chore(flag-removal): [Auth/PM20439] Remove Flagging Logic for BrowserExtensionLoginApproval (#6368)

src/Api/Auth/Controllers/AuthRequestsController.cs

@@ -3,7 +3,6 @@
 
 using Bit.Api.Auth.Models.Response;
 using Bit.Api.Models.Response;
-using Bit.Core;
 using Bit.Core.Auth.Enums;
 using Bit.Core.Auth.Identity;
 using Bit.Core.Auth.Models.Api.Request.AuthRequest;
@@ -12,7 +11,6 @@ using Bit.Core.Exceptions;
 using Bit.Core.Repositories;
 using Bit.Core.Services;
 using Bit.Core.Settings;
-using Bit.Core.Utilities;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
 
@@ -55,7 +53,6 @@ public class AuthRequestsController(
     }
 
     [HttpGet("pending")]
-    [RequireFeature(FeatureFlagKeys.BrowserExtensionLoginApproval)]
     public async Task<ListResponseModel<PendingAuthRequestResponseModel>> GetPendingAuthRequestsAsync()
     {
         var userId = _userService.GetProperUserId(User).Value;

src/Identity/Utilities/LoginApprovingClientTypes.cs

@@ -1,6 +1,4 @@
-using Bit.Core;
-using Bit.Core.Enums;
-using Bit.Core.Services;
+using Bit.Core.Enums;
 
 namespace Bit.Identity.Utilities;
 
@@ -11,28 +9,15 @@ public interface ILoginApprovingClientTypes
 
 public class LoginApprovingClientTypes : ILoginApprovingClientTypes
 {
-    public LoginApprovingClientTypes(
-        IFeatureService featureService)
+    public LoginApprovingClientTypes()
     {
-        if (featureService.IsEnabled(FeatureFlagKeys.BrowserExtensionLoginApproval))
+        TypesThatCanApprove = new List<ClientType>
         {
-            TypesThatCanApprove = new List<ClientType>
-            {
-                ClientType.Desktop,
-                ClientType.Mobile,
-                ClientType.Web,
-                ClientType.Browser,
-            };
-        }
-        else
-        {
-            TypesThatCanApprove = new List<ClientType>
-            {
-                ClientType.Desktop,
-                ClientType.Mobile,
-                ClientType.Web,
-            };
-        }
+            ClientType.Desktop,
+            ClientType.Mobile,
+            ClientType.Web,
+            ClientType.Browser,
+        };
     }
 
     public IReadOnlyCollection<ClientType> TypesThatCanApprove { get; }