bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-02-12 22:44:00 +00:00
Code Issues Releases Wiki Activity

[PM-32007] Use kebab instead of snake case for cookie vendor (#6977)

Browse Source
This commit is contained in:
Derek Nance
2026-02-10 15:26:19 -06:00
committed by GitHub
parent c1ee27f42c
commit de330e987d
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Api/Controllers/SsoCookieVendorController.cs → src/Api/Platform/SsoCookieVendor/Controllers/SsoCookieVendorController.cs
View File

@@ -3,7 +3,7 @@ using Bit.Core.Utilities;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
namespace Bit.Api.Controllers;
namespace Bit.Api.Platform.SsoCookieVendor;
/// <summary>
/// Provides an endpoint to read an SSO cookie and redirect to a custom URI
@@ -114,6 +114,6 @@ public class SsoCookieVendorController(IGlobalSettings globalSettings) : Control
// event a user agent decides the URI is too long.
queryParams.Add("d=1");
return $"bitwarden://sso_cookie_vendor?{string.Join("&", queryParams)}";
return $"bitwarden://sso-cookie-vendor?{string.Join("&", queryParams)}";
}
}

12
test/Api.Test/Controllers/SsoCookieVendorControllerTests.cs → test/Api.Test/Platform/SsoCookieVendor/Controllers/SsoCookieVendorControllerTests.cs
View File

@@ -1,13 +1,13 @@
#nullable enable
using Bit.Api.Controllers;
using Bit.Api.Platform.SsoCookieVendor;
using Bit.Core.Settings;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using NSubstitute;
using Xunit;
namespace Bit.Api.Test.Controllers;
namespace Bit.Api.Test.Platform.SsoCookieVendor.Controllers;
public class SsoCookieVendorControllerTests : IDisposable
{
@@ -129,7 +129,7 @@ public class SsoCookieVendorControllerTests : IDisposable
// Assert
var redirectResult = Assert.IsType<RedirectResult>(result);
Assert.Equal("bitwarden://sso_cookie_vendor?test-cookie=my-token-value-123&d=1", redirectResult.Url);
Assert.Equal("bitwarden://sso-cookie-vendor?test-cookie=my-token-value-123&d=1", redirectResult.Url);
}
[Fact]
@@ -170,7 +170,7 @@ public class SsoCookieVendorControllerTests : IDisposable
// Assert
var redirectResult = Assert.IsType<RedirectResult>(result);
Assert.StartsWith("bitwarden://sso_cookie_vendor?", redirectResult.Url);
Assert.StartsWith("bitwarden://sso-cookie-vendor?", redirectResult.Url);
Assert.Contains("test-cookie-0=part1", redirectResult.Url);
Assert.Contains("test-cookie-1=part2", redirectResult.Url);
Assert.Contains("test-cookie-2=part3", redirectResult.Url);
@@ -256,7 +256,7 @@ public class SsoCookieVendorControllerTests : IDisposable
public void Get_WhenUriExceedsMaxLength_Returns400()
{
// Arrange - create a very long cookie value that will exceed 8192 characters
// URI format: "bitwarden://sso_cookie_vendor?test-cookie={value}"
// URI format: "bitwarden://sso-cookie-vendor?test-cookie={value}"
// Base URI length is about 43 characters, so we need value > 8149
var longValue = new string('a', 8200);
var cookies = new Dictionary<string, string>
@@ -289,7 +289,7 @@ public class SsoCookieVendorControllerTests : IDisposable
// Assert
var redirectResult = Assert.IsType<RedirectResult>(result);
Assert.Equal("bitwarden://sso_cookie_vendor?test-cookie=single-value&d=1", redirectResult.Url);
Assert.Equal("bitwarden://sso-cookie-vendor?test-cookie=single-value&d=1", redirectResult.Url);
}
[Fact]