WIP https://github.com/dfinke/ImportExcel/issues/1587

ImportExcel.psd1

@@ -6,7 +6,7 @@
     RootModule         = 'ImportExcel.psm1'
 
     # Version number of this module.
-    ModuleVersion      = '7.8.9'
+    ModuleVersion      = '7.8.6'
 
     # ID used to uniquely identify this module
     GUID               = '60dd4136-feff-401a-ba27-a84458c57ede'

Private/ArgumentCompletion.ps1

@@ -67,8 +67,9 @@ function WorksheetArgumentCompleter {
     param($commandName, $parameterName, $wordToComplete, $commandAst, $fakeBoundParameter)
     $xlPath = $fakeBoundParameter['Path']
     if (Test-Path -Path $xlPath) {
-        $xlSheet = Get-ExcelSheetInfo -Path $xlPath
-        $WorksheetNames = $xlSheet.Name
+        $xlpkg = Open-ExcelPackage -ReadOnly -Path $xlPath
+        $WorksheetNames = $xlPkg.Workbook.Worksheets.Name
+        Close-ExcelPackage -nosave -ExcelPackage $xlpkg
         $WorksheetNames.where( { $_ -like "*$wordToComplete*" }) | foreach-object {
             New-Object -TypeName System.Management.Automation.CompletionResult -ArgumentList "'$_'",
             $_ , ([System.Management.Automation.CompletionResultType]::ParameterValue) , $_

Public/ConvertTo-ExcelXlsx.ps1

@@ -3,121 +3,53 @@ function ConvertTo-ExcelXlsx {
     param
     (
         [parameter(Mandatory = $true, ValueFromPipeline)]
-        [string[]]$Path,
+        [string]$Path,
         [parameter(Mandatory = $false)]
-        [switch]$Force,
-        [parameter(Mandatory = $false)]
-        [switch]$CacheToTemp,
-        [parameter(Mandatory = $false)]
-        [string]$CacheToDirectory
+        [switch]$Force
     )
     process {
-        try {
+        if (-Not ($Path | Test-Path) ) {
+            throw "File not found"
+        }
+        if (-Not ($Path | Test-Path -PathType Leaf) ) {
+            throw "Folder paths are not allowed"
+        }
 
-            if ($CacheToTemp -and $CacheToDirectory) {
-                throw "Cannot specify both -CacheToTemp and -CacheToDirectory. Please choose one or the other."
-            }
+        $xlFixedFormat = 51 #Constant for XLSX Workbook
+        $xlsFile = Get-Item -Path $Path
+        $xlsxPath = "{0}x" -f $xlsFile.FullName
 
-            if ($CacheToTemp) {
-                $CacheToDirectory = [System.IO.Path]::GetTempPath()
-            }
+        if ($xlsFile.Extension -ne ".xls") {
+            throw "Expected .xls extension"
+        }
 
-            if ($CacheToDirectory) {
-                if (-not (Test-Path -Path $CacheToDirectory -PathType Container)) {
-                    throw "CacheToDirectory path does not exist or is not writeable"
-                }
-            }
-
-            foreach ($singlePath in $Path) {
-                if (-Not ($singlePath | Test-Path) ) {
-                    throw "File not found"
-                }
-                if (-Not ($singlePath | Test-Path -PathType Leaf) ) {
-                    throw "Folder paths are not allowed"
-                }
-
-                $xlFixedFormat = 51 #Constant for XLSX Workbook
-                $xlsFile = Get-Item -Path $singlePath
-                $destinationXlsxPath = [System.IO.Path]::ChangeExtension($xlsFile.FullName, ".xlsx")
-
-                if ($xlsFile.Extension -ne ".xls") {
-                    throw "Expected .xls extension"
-                }
-
-                if (Test-Path -Path $destinationXlsxPath) {
-                    if ($Force) {
-                        try {
-                            Remove-Item $destinationXlsxPath -Force
-                        }
-                        catch {
-                            throw "{0} already exists and cannot be removed. The file may be locked by another application." -f $destinationXlsxPath
-                        }
-                        Write-Verbose $("Removed {0}" -f $destinationXlsxPath)
-                    }
-                    else {
-                        throw "{0} already exists!" -f $destinationXlsxPath
-                    }
-                }
-
-                if ($null -eq $Excel)
-                {
-                    try {
-                        $Excel = New-Object -ComObject "Excel.Application"
-                    }
-                    catch {
-                        throw "Could not create Excel.Application ComObject. Please verify that Excel is installed."
-                    }
-                }
-
-                if ($CacheToDirectory) {
-                    $tempPath = [System.IO.Path]::Combine($CacheToDirectory, [System.IO.Path]::GetFileName($xlsFile.FullName))
-                    Write-Host ("Using Temp path: {0}" -f $tempPath)
-                    Copy-Item -Path $xlsFile.FullName -Destination $tempPath -Force
-                    $fileToProcess = $tempPath
-                }
-                else {
-                    $fileToProcess = $xlsFile.FullName
-                }
-
-                $xlsxPath = [System.IO.Path]::ChangeExtension($fileToProcess, ".xlsx")
-
-                try {  
-                    $Excel.Visible = $false
-                    $workbook = $Excel.Workbooks.Open($fileToProcess, $null, $true)
-                    if ($null -eq $workbook) {
-                        Write-Host "Failed to open workbook"
-                    } else {
-                        $workbook.SaveAs($xlsxPath, $xlFixedFormat)
-                        
-                        if ($CacheToDirectory) {
-                            Copy-Item -Path $xlsxPath -Destination $destinationXlsxPath -Force
-                        }
-                    }
+        if (Test-Path -Path $xlsxPath) {
+            if ($Force) {
+                try {
+                    Remove-Item $xlsxPath -Force
                 }
                 catch {
-                    Write-Error ("Failed to convert {0} to XLSX. To avoid network issues or locking issues, you could try the -CacheToTemp or -CacheToDirectory parameter." -f $xlsFile.FullName)
-                    throw
+                    throw "{0} already exists and cannot be removed. The file may be locked by another application." -f $xlsxPath
                 }
-                finally {
-                    if ($null -ne $workbook) {
-                        $workbook.Close()
-                        [System.Runtime.InteropServices.Marshal]::ReleaseComObject($workbook) | Out-Null
-                        $workbook = $null
-                    }
+                Write-Verbose $("Removed {0}" -f $xlsxPath)
+            }
+            else {
+                throw "{0} already exists!" -f $xlsxPath
+            }
+        }
 
-                    if ($CacheToDirectory) {
-                        Remove-Item -Path $tempPath -Force
-                        Remove-Item -Path $xlsxPath -Force
-                    }
-                }
-            }
+        try {
+            $Excel = New-Object -ComObject "Excel.Application"
         }
-        finally {
-            if ($null -ne $Excel) {
-                $Excel.Quit()
-                [System.Runtime.InteropServices.Marshal]::ReleaseComObject($Excel) | Out-Null
-                $Excel = $null
-            }
+        catch {
+            throw "Could not create Excel.Application ComObject. Please verify that Excel is installed."
         }
+
+        $Excel.Visible = $false
+        $null = $Excel.Workbooks.Open($xlsFile.FullName)
+        $Excel.ActiveWorkbook.SaveAs($xlsxPath, $xlFixedFormat)
+        $Excel.ActiveWorkbook.Close()
+        $Excel.Quit()
     }
 }
+

changelog.md

@@ -1,18 +1,6 @@
-# 7.8.9
-
-- Thanks to (Edward Miller)[https://github.com/edwardmiller-mesirow] for improving `ConvertTo-ExcelXlsx`and making it more robust
-
-# 7.8.8
-
-- Fix the release
-
 # 7.8.7
 
-- Thanks to [Phil Bossman](https://github.com/pbossman) for the PR and fixing this.
-    
-    Now, back again, you can type `Import-Excel .\yearlySales.xlsx`, press <ctrl+space> and get a list of the worksheets in the Excel file
-
-    ![alt text](images/AutoCompleteSheetNames.png)    
+-
 
 # Infrastructure change