jgaunt/pykmip
2
0
Fork 0
mirror of https://github.com/openkmip/pykmip synced 2026-01-03 09:03:16 +00:00
Code Issues Releases Wiki Activity

Merge pull request #457 from tipabu/secure-logging

Browse Source 
Secure logging by default
This commit is contained in:
Peter Hamilton
2018-10-10 08:51:07 -04:00
committed by GitHub
parent 9fc9c62887 f60bae83d0
commit 1365047dcb
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kmip/core/config_helper.py
View File

@@ -47,6 +47,10 @@ class ConfigHelper(object):
def __init__(self, path=None):
self.logger = logging.getLogger(__name__)
# DEBUG logging here may expose passwords, so log at INFO by default.
# However, if consumers know the risks, let them go ahead and override.
if self.logger.level == logging.NOTSET:
self.logger.setLevel(logging.INFO)
self.conf = SafeConfigParser()

4
kmip/services/server/kmip_protocol.py
View File

@@ -27,6 +27,10 @@ class KMIPProtocol(object):
def __init__(self, socket, buffer_size=1024):
self.socket = socket
self.logger = logging.getLogger(__name__)
# DEBUG logging here may expose secrets, so log at INFO by default.
# However, if consumers know the risks, let them go ahead and override.
if self.logger.level == logging.NOTSET:
self.logger.setLevel(logging.INFO)
def write(self, data):
if len(data) > 0: