1
0
mirror of https://github.com/rclone/rclone.git synced 2025-12-28 22:23:41 +00:00
Commit Graph

8574 Commits

Author SHA1 Message Date
Nick Craig-Wood
07bb122d47 drive: metadata: fix error when setting copy-requires-writer-permission on a folder
This appears not to be allowed, so this fixes the problem by ignoring
that metadata for a folder.

Fixes #8517
2025-04-30 16:09:30 +01:00
Ed Craig-Wood
aedcd56531 Update README.md
removed warp as project sponsor
2025-04-30 16:09:30 +01:00
Andrew Kreimer
4a10491c2a docs: fix typos via codespell
There are some types in the changelog.

Fix them via codespell.
2025-04-30 16:09:30 +01:00
Nick Craig-Wood
bbceb84cad onedrive: fix metadata ordering in permissions
Before this change, due to a quirk in Graph, User permissions could be
lost when applying permissions.

Fixes #8465
2025-04-30 16:09:30 +01:00
Ben Alex
4c3737014a iclouddrive: fix so created files are writable
At present any created file (eg through the touch command, copy, mount
etc) is read-only in iCloud.

This has been reported by users at
https://forum.rclone.org/t/icloud-and-file-editing-permissions/50659.
2025-04-30 16:09:30 +01:00
simwai
a49ccddb81 cmd/authorize: show required arguments in help text 2025-04-30 16:09:30 +01:00
Markus Gerstel
7fd3d0d1ab s3: documentation regression - fixes #8438
We lost a previous documentation fix (#7077) detailing how to restore
single objects from AWS S3 Glacier.

Also make clearer that rclone provides restore functionality natively.

Co-authored-by: danielkrajnik <dan94kra@gmail.com>
2025-04-30 16:09:30 +01:00
huanghaojun
77c1031dcd vfs: fix inefficient directory caching when directory reads are slow
Before this change, when querying directories with large datasets, if
the query duration exceeded the directory cache expiration time, the
cache became invalid by the time results were retrieved. This means
every execution of `_readDir` triggers `_readDirFromEntries`,
resulting in prolonged processing times.

After this change we update the directory time with the time at the
end of the query.
2025-04-30 16:09:30 +01:00
simonmcnair
d8c7031dc3 docs: update fuse version in docker docs 2025-04-30 16:09:30 +01:00
Samantha Bowen
ab5844df77 fs/config: Read configuration passwords from stdin even when terminated with EOF - fixes #8480 2025-04-30 16:09:30 +01:00
Nick Craig-Wood
a3c4e2fd20 lib/http: fix race between Serve() and Shutdown()
This was discovered by the race detector.
2025-04-30 16:09:30 +01:00
Danny Garside
b12d2f32db docs: fix minor typo in box docs 2025-04-30 16:09:30 +01:00
Nick Craig-Wood
85c1563701 docs: Add rcloneui.com as Silver Sponsor 2025-04-30 16:09:30 +01:00
eccoisle
f52d753363 docs: replace option --auto-filename-header with --header-filename 2025-04-30 16:09:30 +01:00
alingse
f76c72b5cc operations: fix call fmt.Errorf with wrong err 2025-04-30 16:09:30 +01:00
Nick Craig-Wood
46dcc0eaf6 rc: fix debug/* commands not being available over unix sockets
This was caused by an incorrect handler URL which was passing the
debug/* commands to the debug/pprof handler by accident. This only
happened when using unix sockets.
2025-04-30 16:09:30 +01:00
nielash
f46787dcc3 http: correct root if definitely pointing to a file - fixes #8428
This was formalized in
c69eb84573
But it appears that we forgot to update `http`, and the `FsRoot` test didn't
catch it because we don't currently have an http integration test.
2025-04-30 16:09:30 +01:00
Nick Craig-Wood
e7c46912a3 fs: fix corruption of SizeSuffix with "B" suffix in config (eg --min-size)
Before this change, the config system round tripped fs.SizeSuffix
values through strings like this, corrupting them in the process.

    "2B" -> 2 -> "2" -> 2048

This caused `--min-size 2B` to be interpreted as `--min-size 2k`.

This fix makes sure SizeSuffix values have a "B" suffix when turned
into a string where necessary, so it becomes

    "2B" -> 2 -> "2B" -> 2

In rclone v2 we should probably declare unsuffixed SizeSuffix values
are in bytes not kBytes (done for rsync compatibility) but this would
be a backwards incompatible change which we don't want for v1.

Fixes #8437
Fixes #8212
Fixes #5169
2025-04-30 16:09:30 +01:00
jack
296c26b671 docs: fix incorrect mentions of vfs-cache-min-free-size 2025-04-30 16:09:30 +01:00
Nick Craig-Wood
ef99b9ad18 fs/object: fix memory object out of bounds Seek 2025-04-30 16:09:30 +01:00
Nick Craig-Wood
2e853b6e75 serve nfs: fix unlikely crash 2025-04-30 16:09:30 +01:00
Zachary Vorhies
d725f4f4de docs: add note for using rclone cat for slicing out a byte range from a file 2025-04-30 16:09:30 +01:00
Dave Vasilevsky
6a9c2350de dropbox: Retry link without expiry
Dropbox only allows public links with expiry for certain account types.
Rather than erroring for other accounts, retry without expiry.
2025-04-30 16:09:30 +01:00
emyarod
659aca8711 chore: update contributor email 2025-04-30 16:09:30 +01:00
Nick Craig-Wood
1ac7e32302 docs: correct stable release workflow 2025-04-30 16:09:30 +01:00
Lorenz Brun
286ae6a1b4 vfs: fix directory cache serving stale data
The VFS directory cache layer didn't update directory entry properties
if they are reused after cache invalidation.

Update them unconditionally as newDir sets them to the same value and
setting a pointer is cheaper in both LoC as well as CPU cycles than a
branch.

Also add a test exercising this behavior.

Fixes #6335
2025-04-30 16:09:30 +01:00
Anagh Kumar Baranwal
861456d970 build: fix docker plugin build - fixes #8394
Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
2025-04-30 16:09:30 +01:00
Michael Kebe
5fa9c0209e docs: improved sftp limitations
Added a link to `--sftp-path-override` for a better solution with working hash calculation.
2025-04-30 16:09:30 +01:00
Anagh Kumar Baranwal
b00dcc37bd accounting: fix percentDiff calculation -- fixes #8345
Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
2025-04-30 16:09:30 +01:00
Janne Hellsten
92efc5ff43 cmd: fix crash if rclone is invoked without any arguments - Fixes #8378 2025-04-30 16:09:30 +01:00
ll3006
57bbb4be9f sync: copy dir modtimes even when copyEmptySrcDirs is false - fixes #8317
Before, after a sync, only file modtimes were updated when not using
--copy-empty-src-dirs. This ensures modtimes are updated to match the source
folder, regardless of copyEmptySrcDir. The flag --no-update-dir-modtime
(which previously did nothing) will disable this.
2025-04-30 16:09:30 +01:00
Anagh Kumar Baranwal
c62fbc5269 stats: fix the speed not getting updated after a pause in the processing
This shifts the behavior of the average loop to be a persistent loop
that gets resumed/paused when transfers & checks are started/completed.

Previously, the averageLoop was stopped on completion of
transfers & checks but failed to start again due to the protection of
the sync.Once

Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
2025-04-30 16:09:30 +01:00
Nick Craig-Wood
6eb8919719 sync: fix cpu spinning when empty directory finding with leading slashes
Before this change the logic which makes sure we create all
directories could get confused with directories which started with
slashes and get into an infinite loop consuming 100% of the CPU.
2025-04-30 16:09:30 +01:00
hiddenmarten
ff4d7c8dd0 rc: disable the metrics server when running rclone rc
Fixes #8248
2025-04-30 16:09:29 +01:00
Nick Craig-Wood
4f8dfd14fc Start v1.69.2-DEV development 2025-02-14 17:14:31 +00:00
Nick Craig-Wood
4e77a4ff73 Version v1.69.1 v1.69.1 2025-02-14 15:17:21 +00:00
Anagh Kumar Baranwal
b63c42f39b build: disable docker builds on PRs & add missing dockerfile changes
Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
2025-02-14 13:03:33 +00:00
Anagh Kumar Baranwal
30c9bab35d Added parallel docker builds and caching for go build in the container
Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
2025-02-14 13:03:33 +00:00
Nick Craig-Wood
68bbd8017d docs: add FileLu as sponsors and tidy sponsor logos 2025-02-14 13:03:33 +00:00
Nick Craig-Wood
259dbbab55 vfs: fix the cache failing to upload symlinks when --links was specified
Before this change, if --vfs-cache-mode writes or above was set and
--links was in use, when a symlink was saved then the VFS failed to
upload it. This meant when the VFS was restarted the link wasn't there
any more.

This was caused by the local backend, which we use to manage the VFS
cache, picking up the global --links flag.

This patch makes sure that the internal instantations of the local
backend in the VFS cache don't ever use the --links flag or the
--local-links flag even if specified on the command line.

Fixes #8367
2025-02-14 13:03:33 +00:00
Zachary Vorhies
5fa85f66fe doc: add note on concurrency of rclone purge 2025-02-14 13:03:33 +00:00
jbagwell-akamai
fb648e4774 s3: add latest Linode Object Storage endpoints
Added missing Linode Object Storage endpoints AMS, MAA, CGK, LON, LAX, MAD, MEL, MIA, OSA, GRU, SIN
2025-02-14 13:03:33 +00:00
nielash
9978750a8c fix golangci-lint errors 2025-02-14 13:03:33 +00:00
nielash
d953c0c51b bisync: fix listings missing concurrent modifications - fixes #8359
Before this change, there was a bug affecting listing files when:

- a given bisync run had changes in the 2to1 direction
AND
- the run had NO changes in the 1to2 direction
AND
- at least one of the changed files changed AGAIN during the run
(specifically, after the initial march and before the transfers.)

In this situation, the listings on one side would still retain the prior version
of the changed file, potentially causing conflicts or errors.

This change fixes the issue by making sure that if we're updating the listings
on one side, we must also update the other. (We previously tried to skip it for
efficiency, but this failed to account for the possibility that a changed file
could change again during the run.)
2025-02-14 13:03:33 +00:00
Nick Craig-Wood
9dfce11c9b lib/oauthutil: fix redirect URL mismatch errors - fixes #8351
In this commit we introduced support for client credentials flow:

65012beea4 lib/oauthutil: add support for OAuth client credential flow

This involved re-organising the oauth credentials.

Unfortunately a small error was made which used a fixed redirect URL
rather than the one configured for the backend.

This caused the box backend oauth flow not to work properly with
redirect_uri_mismatch errors.

These backends were using the wrong redirect URL and will likely be
affected, though it is possible the backends have workarounds.

- box
- drive
- googlecloudstorage
- googlephotos
- hidrive
- pikpak
- premiumizeme
- sharefile
- yandex
2025-02-14 13:03:33 +00:00
Nick Craig-Wood
504f2fb571 b2: fix "fatal error: concurrent map writes" - fixes #8355
This was caused by the embryonic metadata support. Since this isn't
actually visible externally, this patch removes it for the time being.
2025-02-14 13:03:33 +00:00
Zachary Vorhies
f79f929e57 serve nfs: update docs to note Windows is not supported - fixes #8352 2025-02-14 13:03:33 +00:00
jkpe
83e04ead37 s3: add DigitalOcean regions SFO2, LON1, TOR1, BLR1 2025-02-14 13:03:33 +00:00
Nick Craig-Wood
1a95a23fdc onedrive: mark German (de) region as deprecated
See: https://learn.microsoft.com/en-us/previous-versions/azure/germany/
2025-02-14 13:03:33 +00:00
Bruno Fernandes
c4b592e549 s3: Added new storage class to magalu provider 2025-02-14 13:03:33 +00:00