Version v1.64.2

This was caused by a change to the upstream library
ProtonMail/go-crypto checking the flags on the keys more strictly.

However the signing key for rclone is very old and does not have those
flags. Adding those flags using `gpg --edit-key` and then the
`change-usage` subcommand to remove, save, quite then re-add, save
quit the signing capabilities caused the key to work.

This also adds tests for the verification and adds the selfupdate
tests into the integration test harness as they had been disabled on
CI because they rely on external sources and are sometimes unreliable.

Fixes #7373

.github/workflows/build.yml

@@ -104,7 +104,7 @@ jobs:
           fetch-depth: 0
 
       - name: Install Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v4
         with:
           go-version: ${{ matrix.go }}
           check-latest: true
@@ -216,6 +216,7 @@ jobs:
         shell: bash
         run: |
           if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then make release_dep_linux ; fi
+          if [[ "${{ matrix.os }}" == "windows-latest" ]]; then make release_dep_windows ; fi
           make ci_beta
         env:
           RCLONE_CONFIG_PASS: ${{ secrets.RCLONE_CONFIG_PASS }}
@@ -241,7 +242,7 @@ jobs:
 
       # Run govulncheck on the latest go version, the one we build binaries with
       - name: Install Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v4
         with:
           go-version: '1.21'
           check-latest: true
@@ -266,7 +267,7 @@ jobs:
 
       # Upgrade together with NDK version
       - name: Set up Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v4
         with:
           go-version: '1.21'
 

.gitignore

@@ -14,7 +14,4 @@ fuzz-build.zip
 *.rej
 Thumbs.db
 __pycache__
-.DS_Store
-/docs/static/img/logos/
-resource_windows_*.syso
-.devcontainer
+.DS_Store

CONTRIBUTING.md

@@ -1,8 +1,8 @@
-# Contributing to rclone
+# Contributing to rclone #
 
 This is a short guide on how to contribute things to rclone.
 
-## Reporting a bug
+## Reporting a bug ##
 
 If you've just got a question or aren't sure if you've found a bug
 then please use the [rclone forum](https://forum.rclone.org/) instead
@@ -12,13 +12,13 @@ When filing an issue, please include the following information if
 possible as well as a description of the problem.  Make sure you test
 with the [latest beta of rclone](https://beta.rclone.org/):
 
-- Rclone version (e.g. output from `rclone version`)
-- Which OS you are using and how many bits (e.g. Windows 10, 64 bit)
-- The command you were trying to run (e.g. `rclone copy /tmp remote:tmp`)
-- A log of the command with the `-vv` flag (e.g. output from `rclone -vv copy /tmp remote:tmp`)
-    - if the log contains secrets then edit the file with a text editor first to obscure them
+  * Rclone version (e.g. output from `rclone version`)
+  * Which OS you are using and how many bits (e.g. Windows 10, 64 bit)
+  * The command you were trying to run (e.g. `rclone copy /tmp remote:tmp`)
+  * A log of the command with the `-vv` flag (e.g. output from `rclone -vv copy /tmp remote:tmp`)
+    * if the log contains secrets then edit the file with a text editor first to obscure them
 
-## Submitting a new feature or bug fix
+## Submitting a new feature or bug fix ##
 
 If you find a bug that you'd like to fix, or a new feature that you'd
 like to implement then please submit a pull request via GitHub.
@@ -73,9 +73,9 @@ This is typically enough if you made a simple bug fix, otherwise please read the
 
 Make sure you
 
-- Add [unit tests](#testing) for a new feature.
-- Add [documentation](#writing-documentation) for a new feature.
-- [Commit your changes](#committing-your-changes) using the [commit message guidelines](#commit-messages).
+  * Add [unit tests](#testing) for a new feature.
+  * Add [documentation](#writing-documentation) for a new feature.
+  * [Commit your changes](#committing-your-changes) using the [message guideline](#commit-messages).
 
 When you are done with that push your changes to GitHub:
 
@@ -88,9 +88,9 @@ Your changes will then get reviewed and you might get asked to fix some stuff. I
 
 You may sometimes be asked to [base your changes on the latest master](#basing-your-changes-on-the-latest-master) or [squash your commits](#squashing-your-commits).
 
-## Using Git and GitHub
+## Using Git and GitHub ##
 
-### Committing your changes
+### Committing your changes ###
 
 Follow the guideline for [commit messages](#commit-messages) and then:
 
@@ -107,7 +107,7 @@ You can modify the message or changes in the latest commit using:
 
 If you amend to commits that have been pushed to GitHub, then you will have to [replace your previously pushed commits](#replacing-your-previously-pushed-commits).
 
-### Replacing your previously pushed commits
+### Replacing your previously pushed commits ###
 
 Note that you are about to rewrite the GitHub history of your branch. It is good practice to involve your collaborators before modifying commits that have been pushed to GitHub.
 
@@ -115,7 +115,7 @@ Your previously pushed commits are replaced by:
 
     git push --force origin my-new-feature 
 
-### Basing your changes on the latest master
+### Basing your changes on the latest master ###
 
 To base your changes on the latest version of the [rclone master](https://github.com/rclone/rclone/tree/master) (upstream):
 
@@ -149,21 +149,13 @@ If you squash commits that have been pushed to GitHub, then you will have to [re
 
 Tip: You may like to use `git rebase -i master` if you are experienced or have a more complex situation.
 
-### GitHub Continuous Integration
+### GitHub Continuous Integration ###
 
 rclone currently uses [GitHub Actions](https://github.com/rclone/rclone/actions) to build and test the project, which should be automatically available for your fork too from the `Actions` tab in your repository.
 
-## Testing
+## Testing ##
 
-### Code quality tests
-
-If you install [golangci-lint](https://github.com/golangci/golangci-lint) then you can run the same tests as get run in the CI which can be very helpful.
-
-You can run them with `make check` or with `golangci-lint run ./...`.
-
-Using these tests ensures that the rclone codebase all uses the same coding standards. These tests also check for easy mistakes to make (like forgetting to check an error return).
-
-### Quick testing
+### Quick testing ###
 
 rclone's tests are run from the go testing framework, so at the top
 level you can run this to run all the tests.
@@ -176,7 +168,7 @@ You can also use `make`, if supported by your platform
 
 The quicktest is [automatically run by GitHub](#github-continuous-integration) when you push your branch to GitHub.
 
-### Backend testing
+### Backend testing ###
 
 rclone contains a mixture of unit tests and integration tests.
 Because it is difficult (and in some respects pointless) to test cloud
@@ -211,7 +203,7 @@ project root:
     go install github.com/rclone/rclone/fstest/test_all
     test_all -backend drive
 
-### Full integration testing
+### Full integration testing ###
 
 If you want to run all the integration tests against all the remotes,
 then change into the project root and run
@@ -226,56 +218,55 @@ The commands may require some extra go packages which you can install with
 The full integration tests are run daily on the integration test server. You can
 find the results at https://pub.rclone.org/integration-tests/
 
-## Code Organisation
+## Code Organisation ##
 
 Rclone code is organised into a small number of top level directories
 with modules beneath.
 
-- backend - the rclone backends for interfacing to cloud providers -
-    - all - import this to load all the cloud providers
-    - ...providers
-- bin - scripts for use while building or maintaining rclone
-- cmd - the rclone commands
-    - all - import this to load all the commands
-    - ...commands
-- cmdtest - end-to-end tests of commands, flags, environment variables,...
-- docs - the documentation and website
-    - content - adjust these docs only - everything else is autogenerated
-    - command - these are auto-generated - edit the corresponding .go file
-- fs - main rclone definitions - minimal amount of code
-    - accounting - bandwidth limiting and statistics
-    - asyncreader - an io.Reader which reads ahead
-    - config - manage the config file and flags
-    - driveletter - detect if a name is a drive letter
-    - filter - implements include/exclude filtering
-    - fserrors - rclone specific error handling
-    - fshttp - http handling for rclone
-    - fspath - path handling for rclone
-    - hash - defines rclone's hash types and functions
-    - list - list a remote
-    - log - logging facilities
-    - march - iterates directories in lock step
-    - object - in memory Fs objects
-    - operations - primitives for sync, e.g. Copy, Move
-    - sync - sync directories
-    - walk - walk a directory
-- fstest - provides integration test framework
-    - fstests - integration tests for the backends
-    - mockdir - mocks an fs.Directory
-    - mockobject - mocks an fs.Object
-    - test_all - Runs integration tests for everything
-- graphics - the images used in the website, etc.
-- lib - libraries used by the backend
-    - atexit - register functions to run when rclone exits
-    - dircache - directory ID to name caching
-    - oauthutil - helpers for using oauth
-    - pacer - retries with backoff and paces operations
-    - readers - a selection of useful io.Readers
-    - rest - a thin abstraction over net/http for REST
-- librclone - in memory interface to rclone's API for embedding rclone
-- vfs - Virtual FileSystem layer for implementing rclone mount and similar
+  * backend - the rclone backends for interfacing to cloud providers -
+    * all - import this to load all the cloud providers
+    * ...providers
+  * bin - scripts for use while building or maintaining rclone
+  * cmd - the rclone commands
+    * all - import this to load all the commands
+    * ...commands
+  * cmdtest - end-to-end tests of commands, flags, environment variables,...
+  * docs - the documentation and website
+    * content - adjust these docs only - everything else is autogenerated
+      * command - these are auto-generated - edit the corresponding .go file
+  * fs - main rclone definitions - minimal amount of code
+    * accounting - bandwidth limiting and statistics
+    * asyncreader - an io.Reader which reads ahead
+    * config - manage the config file and flags
+    * driveletter - detect if a name is a drive letter
+    * filter - implements include/exclude filtering
+    * fserrors - rclone specific error handling
+    * fshttp - http handling for rclone
+    * fspath - path handling for rclone
+    * hash - defines rclone's hash types and functions
+    * list - list a remote
+    * log - logging facilities
+    * march - iterates directories in lock step
+    * object - in memory Fs objects
+    * operations - primitives for sync, e.g. Copy, Move
+    * sync - sync directories
+    * walk - walk a directory
+  * fstest - provides integration test framework
+    * fstests - integration tests for the backends
+    * mockdir - mocks an fs.Directory
+    * mockobject - mocks an fs.Object
+    * test_all - Runs integration tests for everything
+  * graphics - the images used in the website, etc.
+  * lib - libraries used by the backend
+    * atexit - register functions to run when rclone exits
+    * dircache - directory ID to name caching
+    * oauthutil - helpers for using oauth
+    * pacer - retries with backoff and paces operations
+    * readers - a selection of useful io.Readers
+    * rest - a thin abstraction over net/http for REST
+  * vfs - Virtual FileSystem layer for implementing rclone mount and similar
 
-## Writing Documentation
+## Writing Documentation ##
 
 If you are adding a new feature then please update the documentation.
 
@@ -286,22 +277,22 @@ alphabetical order.
 If you add a new backend option/flag, then it should be documented in
 the source file in the `Help:` field.
 
-- Start with the most important information about the option,
+  * Start with the most important information about the option,
     as a single sentence on a single line.
-    - This text will be used for the command-line flag help.
-    - It will be combined with other information, such as any default value,
+    * This text will be used for the command-line flag help.
+    * It will be combined with other information, such as any default value,
       and the result will look odd if not written as a single sentence.
-    - It should end with a period/full stop character, which will be shown
+    * It should end with a period/full stop character, which will be shown
       in docs but automatically removed when producing the flag help.
-    - Try to keep it below 80 characters, to reduce text wrapping in the terminal.
-- More details can be added in a new paragraph, after an empty line (`"\n\n"`).
-    - Like with docs generated from Markdown, a single line break is ignored
+    * Try to keep it below 80 characters, to reduce text wrapping in the terminal.
+  * More details can be added in a new paragraph, after an empty line (`"\n\n"`).
+    * Like with docs generated from Markdown, a single line break is ignored
       and two line breaks creates a new paragraph.
-    - This text will be shown to the user in `rclone config`
+    * This text will be shown to the user in `rclone config`
       and in the docs (where it will be added by `make backenddocs`,
       normally run some time before next release).
-- To create options of enumeration type use the `Examples:` field.
-    - Each example value have their own `Help:` field, but they are treated
+  * To create options of enumeration type use the `Examples:` field.
+    * Each example value have their own `Help:` field, but they are treated
       a bit different than the main option help text. They will be shown
       as an unordered list, therefore a single line break is enough to
       create a new list item. Also, for enumeration texts like name of
@@ -321,12 +312,12 @@ combined unmodified with other information (such as any default value).
 Note that you can use [GitHub's online editor](https://help.github.com/en/github/managing-files-in-a-repository/editing-files-in-another-users-repository)
 for small changes in the docs which makes it very easy.
 
-## Making a release
+## Making a release ##
 
 There are separate instructions for making a release in the RELEASE.md
 file.
 
-## Commit messages
+## Commit messages ##
 
 Please make the first line of your commit message a summary of the
 change that a user (not a developer) of rclone would like to read, and
@@ -367,7 +358,7 @@ error fixing the hang.
 Fixes #1498
 ```
 
-## Adding a dependency
+## Adding a dependency ##
 
 rclone uses the [go
 modules](https://tip.golang.org/cmd/go/#hdr-Modules__module_versions__and_more)
@@ -379,7 +370,7 @@ To add a dependency `github.com/ncw/new_dependency` see the
 instructions below.  These will fetch the dependency and add it to
 `go.mod` and `go.sum`.
 
-    go get github.com/ncw/new_dependency
+    GO111MODULE=on go get github.com/ncw/new_dependency
 
 You can add constraints on that package when doing `go get` (see the
 go docs linked above), but don't unless you really need to.
@@ -387,15 +378,15 @@ go docs linked above), but don't unless you really need to.
 Please check in the changes generated by `go mod` including `go.mod`
 and `go.sum` in the same commit as your other changes.
 
-## Updating a dependency
+## Updating a dependency ##
 
 If you need to update a dependency then run
 
-    go get golang.org/x/crypto
+    GO111MODULE=on go get -u golang.org/x/crypto
 
 Check in a single commit as above.
 
-## Updating all the dependencies
+## Updating all the dependencies ##
 
 In order to update all the dependencies then run `make update`.  This
 just uses the go modules to update all the modules to their latest
@@ -404,7 +395,7 @@ stable release. Check in the changes in a single commit as above.
 This should be done early in the release cycle to pick up new versions
 of packages in time for them to get some testing.
 
-## Updating a backend
+## Updating a backend ##
 
 If you update a backend then please run the unit tests and the
 integration tests for that backend.
@@ -419,133 +410,87 @@ integration tests.
 
 The next section goes into more detail about the tests.
 
-## Writing a new backend
+## Writing a new backend ##
 
 Choose a name.  The docs here will use `remote` as an example.
 
 Note that in rclone terminology a file system backend is called a
 remote or an fs.
 
-### Research
+Research
 
-- Look at the interfaces defined in `fs/types.go`
-- Study one or more of the existing remotes
+  * Look at the interfaces defined in `fs/types.go`
+  * Study one or more of the existing remotes
 
-### Getting going
+Getting going
 
-- Create `backend/remote/remote.go` (copy this from a similar remote)
-    - box is a good one to start from if you have a directory-based remote (and shows how to use the directory cache)
-    - b2 is a good one to start from if you have a bucket-based remote
-- Add your remote to the imports in `backend/all/all.go`
-- HTTP based remotes are easiest to maintain if they use rclone's [lib/rest](https://pkg.go.dev/github.com/rclone/rclone/lib/rest) module, but if there is a really good Go SDK from the provider then use that instead.
-- Try to implement as many optional methods as possible as it makes the remote more usable.
-- Use [lib/encoder](https://pkg.go.dev/github.com/rclone/rclone/lib/encoder) to make sure we can encode any path name and `rclone info` to help determine the encodings needed
-    - `rclone purge -v TestRemote:rclone-info`
-    - `rclone test info --all --remote-encoding None -vv --write-json remote.json TestRemote:rclone-info`
-    - `go run cmd/test/info/internal/build_csv/main.go -o remote.csv remote.json`
-    - open `remote.csv` in a spreadsheet and examine
+  * Create `backend/remote/remote.go` (copy this from a similar remote)
+    * box is a good one to start from if you have a directory-based remote
+    * b2 is a good one to start from if you have a bucket-based remote
+  * Add your remote to the imports in `backend/all/all.go`
+  * HTTP based remotes are easiest to maintain if they use rclone's [lib/rest](https://pkg.go.dev/github.com/rclone/rclone/lib/rest) module, but if there is a really good go SDK then use that instead.
+  * Try to implement as many optional methods as possible as it makes the remote more usable.
+  * Use [lib/encoder](https://pkg.go.dev/github.com/rclone/rclone/lib/encoder) to make sure we can encode any path name and `rclone info` to help determine the encodings needed
+    * `rclone purge -v TestRemote:rclone-info`
+    * `rclone test info --all --remote-encoding None -vv --write-json remote.json TestRemote:rclone-info`
+    * `go run cmd/test/info/internal/build_csv/main.go -o remote.csv remote.json`
+    * open `remote.csv` in a spreadsheet and examine
 
-### Guidelines for a speedy merge
+Important:
 
-- **Do** use [lib/rest](https://pkg.go.dev/github.com/rclone/rclone/lib/rest) if you are implementing a REST like backend and parsing XML/JSON in the backend.
-- **Do** use rclone's Client or Transport from [fs/fshttp](https://pkg.go.dev/github.com/rclone/rclone/fs/fshttp) if your backend is HTTP based - this adds features like `--dump bodies`, `--tpslimit`, `--user-agent` without you having to code anything!
-- **Do** follow your example backend exactly - use the same code order, function names, layout, structure. **Don't** move stuff around and **Don't** delete the comments.
-- **Do not** split your backend up into `fs.go` and `object.go` (there are a few backends like that - don't follow them!)
-- **Do** put your API type definitions in a separate file - by preference `api/types.go`
-- **Remember** we have >50 backends to maintain so keeping them as similar as possible to each other is a high priority!
+  * Please use [lib/rest](https://pkg.go.dev/github.com/rclone/rclone/lib/rest) if you are implementing a REST like backend and parsing XML/JSON in the backend. It makes maintenance much easier.
+  * If your backend is HTTP based then please use rclone's Client or Transport from [fs/fshttp](https://pkg.go.dev/github.com/rclone/rclone/fs/fshttp) - this adds features like `--dump bodies`, `--tpslimit`, `--user-agent` without you having to code anything!
 
-### Unit tests
+Unit tests
 
-- Create a config entry called `TestRemote` for the unit tests to use
-- Create a `backend/remote/remote_test.go` - copy and adjust your example remote
-- Make sure all tests pass with `go test -v`
+  * Create a config entry called `TestRemote` for the unit tests to use
+  * Create a `backend/remote/remote_test.go` - copy and adjust your example remote
+  * Make sure all tests pass with `go test -v`
 
-### Integration tests
+Integration tests
 
-- Add your backend to `fstest/test_all/config.yaml`
-    - Once you've done that then you can use the integration test framework from the project root:
-    - go install ./...
-    - test_all -backends remote
+  * Add your backend to `fstest/test_all/config.yaml`
+      * Once you've done that then you can use the integration test framework from the project root:
+      * go install ./...
+      * test_all -backends remote
 
 Or if you want to run the integration tests manually:
 
-- Make sure integration tests pass with
-    - `cd fs/operations`
-    - `go test -v -remote TestRemote:`
-    - `cd fs/sync`
-    - `go test -v -remote TestRemote:`
-- If your remote defines `ListR` check with this also
-    - `go test -v -remote TestRemote: -fast-list`
+  * Make sure integration tests pass with
+      * `cd fs/operations`
+      * `go test -v -remote TestRemote:`
+      * `cd fs/sync`
+      * `go test -v -remote TestRemote:`
+  * If your remote defines `ListR` check with this also
+      * `go test -v -remote TestRemote: -fast-list`
 
 See the [testing](#testing) section for more information on integration tests.
 
-### Backend documentation
-
-Add your backend to the docs - you'll need to pick an icon for it from
+Add your fs to the docs - you'll need to pick an icon for it from
 [fontawesome](http://fontawesome.io/icons/).  Keep lists of remotes in
 alphabetical order of full name of remote (e.g. `drive` is ordered as
 `Google Drive`) but with the local file system last.
 
-- `README.md` - main GitHub page
-- `docs/content/remote.md` - main docs page (note the backend options are automatically added to this file with `make backenddocs`)
-    - make sure this has the `autogenerated options` comments in (see your reference backend docs)
-    - update them in your backend with `bin/make_backend_docs.py remote`
-- `docs/content/overview.md` - overview docs
-- `docs/content/docs.md` - list of remotes in config section
-- `docs/content/_index.md` - front page of rclone.org
-- `docs/layouts/chrome/navbar.html` - add it to the website navigation
-- `bin/make_manual.py` - add the page to the `docs` constant
+  * `README.md` - main GitHub page
+  * `docs/content/remote.md` - main docs page (note the backend options are automatically added to this file with `make backenddocs`)
+    * make sure this has the `autogenerated options` comments in (see your reference backend docs)
+    * update them in your backend with `bin/make_backend_docs.py remote`
+  * `docs/content/overview.md` - overview docs
+  * `docs/content/docs.md` - list of remotes in config section
+  * `docs/content/_index.md` - front page of rclone.org
+  * `docs/layouts/chrome/navbar.html` - add it to the website navigation
+  * `bin/make_manual.py` - add the page to the `docs` constant
 
 Once you've written the docs, run `make serve` and check they look OK
 in the web browser and the links (internal and external) all work.
 
-## Adding a new s3 provider
-
-It is quite easy to add a new S3 provider to rclone.
-
-You'll need to modify the following files
-
-- `backend/s3/s3.go`
-    - Add the provider to `providerOption` at the top of the file
-    - Add endpoints and other config for your provider gated on the provider in `fs.RegInfo`.
-    - Exclude your provider from genric config questions (eg `region` and `endpoint).
-    - Add the provider to the `setQuirks` function - see the documentation there.
-- `docs/content/s3.md`
-    - Add the provider at the top of the page.
-    - Add a section about the provider linked from there.
-    - Add a transcript of a trial `rclone config` session
-        - Edit the transcript to remove things which might change in subsequent versions
-    - **Do not** alter or add to the autogenerated parts of `s3.md`
-    - **Do not** run `make backenddocs` or `bin/make_backend_docs.py s3`
-- `README.md` - this is the home page in github
-    - Add the provider and a link to the section you wrote in `docs/contents/s3.md`
-- `docs/content/_index.md` - this is the home page of rclone.org
-    - Add the provider and a link to the section you wrote in `docs/contents/s3.md`
-
-When adding the provider, endpoints, quirks, docs etc keep them in
-alphabetical order by `Provider` name, but with `AWS` first and
-`Other` last.
-
-Once you've written the docs, run `make serve` and check they look OK
-in the web browser and the links (internal and external) all work.
-
-Once you've written the code, test `rclone config` works to your
-satisfaction, and check the integration tests work `go test -v -remote
-NewS3Provider:`. You may need to adjust the quirks to get them to
-pass. Some providers just can't pass the tests with control characters
-in the names so if these fail and the provider doesn't support
-`urlEncodeListings` in the quirks then ignore them. Note that the
-`SetTier` test may also fail on non AWS providers.
-
-For an example of adding an s3 provider see [eb3082a1](https://github.com/rclone/rclone/commit/eb3082a1ebdb76d5625f14cedec3f5154a5e7b10).
-
-## Writing a plugin
+## Writing a plugin ##
 
 New features (backends, commands) can also be added "out-of-tree", through Go plugins.
 Changes will be kept in a dynamically loaded file instead of being compiled into the main binary.
 This is useful if you can't merge your changes upstream or don't want to maintain a fork of rclone.
 
-### Usage
+Usage
 
  - Naming
    - Plugins names must have the pattern `librcloneplugin_KIND_NAME.so`.
@@ -560,7 +505,7 @@ This is useful if you can't merge your changes upstream or don't want to maintai
    - Plugins must be compiled against the exact version of rclone to work.
      (The rclone used during building the plugin must be the same as the source of rclone)
 
-### Building
+Building
 
 To turn your existing additions into a Go plugin, move them to an external repository
 and change the top-level package name to `main`.

Dockerfile

@@ -1,9 +1,8 @@
-FROM golang:alpine AS builder
+FROM golang AS builder
 
 COPY . /go/src/github.com/rclone/rclone/
 WORKDIR /go/src/github.com/rclone/rclone/
 
-RUN apk add --no-cache make bash gawk git
 RUN \
   CGO_ENABLED=0 \
   make

Makefile

@@ -30,7 +30,6 @@ ifdef RELEASE_TAG
 	TAG := $(RELEASE_TAG)
 endif
 GO_VERSION := $(shell go version)
-GO_OS := $(shell go env GOOS)
 ifdef BETA_SUBDIR
 	BETA_SUBDIR := /$(BETA_SUBDIR)
 endif
@@ -47,13 +46,7 @@ endif
 .PHONY: rclone test_all vars version
 
 rclone:
-ifeq ($(GO_OS),windows)
-	go run bin/resource_windows.go -version $(TAG) -syso resource_windows_`go env GOARCH`.syso
-endif
 	go build -v --ldflags "-s -X github.com/rclone/rclone/fs.Version=$(TAG)" $(BUILDTAGS) $(BUILD_ARGS)
-ifeq ($(GO_OS),windows)
-	rm resource_windows_`go env GOARCH`.syso
-endif
 	mkdir -p `go env GOPATH`/bin/
 	cp -av rclone`go env GOEXE` `go env GOPATH`/bin/rclone`go env GOEXE`.new
 	mv -v `go env GOPATH`/bin/rclone`go env GOEXE`.new `go env GOPATH`/bin/rclone`go env GOEXE`
@@ -73,10 +66,6 @@ btest:
 	@echo "[$(TAG)]($(BETA_URL)) on branch [$(BRANCH)](https://github.com/rclone/rclone/tree/$(BRANCH)) (uploaded in 15-30 mins)" | xclip -r -sel clip
 	@echo "Copied markdown of beta release to clip board"
 
-btesth:
-	@echo "<a href="$(BETA_URL)">$(TAG)</a> on branch <a href="https://github.com/rclone/rclone/tree/$(BRANCH)">$(BRANCH)</a> (uploaded in 15-30 mins)" | xclip -r -sel clip -t text/html
-	@echo "Copied beta release in HTML to clip board"
-
 version:
 	@echo '$(TAG)'
 
@@ -109,6 +98,10 @@ build_dep:
 release_dep_linux:
 	go install github.com/goreleaser/nfpm/v2/cmd/nfpm@latest
 
+# Get the release dependencies we only install on Windows
+release_dep_windows:
+	GOOS="" GOARCH="" go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@latest
+
 # Update dependencies
 showupdates:
 	@echo "*** Direct dependencies that could be updated ***"
@@ -153,7 +146,7 @@ rcdocs: rclone
 
 install: rclone
 	install -d ${DESTDIR}/usr/bin
-	install ${GOPATH}/bin/rclone ${DESTDIR}/usr/bin
+	install -t ${DESTDIR}/usr/bin ${GOPATH}/bin/rclone
 
 clean:
 	go clean ./...

README.md

@@ -53,14 +53,11 @@ Rclone *("rsync for cloud storage")* is a command-line program to sync files and
   * Koofr [:page_facing_up:](https://rclone.org/koofr/)
   * Leviia Object Storage [:page_facing_up:](https://rclone.org/s3/#leviia)
   * Liara Object Storage [:page_facing_up:](https://rclone.org/s3/#liara-object-storage)
-  * Linkbox [:page_facing_up:](https://rclone.org/linkbox)
-  * Linode Object Storage [:page_facing_up:](https://rclone.org/s3/#linode)
   * Mail.ru Cloud [:page_facing_up:](https://rclone.org/mailru/)
   * Memset Memstore [:page_facing_up:](https://rclone.org/swift/)
   * Mega [:page_facing_up:](https://rclone.org/mega/)
   * Memory [:page_facing_up:](https://rclone.org/memory/)
   * Microsoft Azure Blob Storage [:page_facing_up:](https://rclone.org/azureblob/)
-  * Microsoft Azure Files Storage [:page_facing_up:](https://rclone.org/azurefiles/)
   * Microsoft OneDrive [:page_facing_up:](https://rclone.org/onedrive/)
   * Minio [:page_facing_up:](https://rclone.org/s3/#minio)
   * Nextcloud [:page_facing_up:](https://rclone.org/webdav/#nextcloud)

RELEASE.md

@@ -41,15 +41,12 @@ Early in the next release cycle update the dependencies
 
   * Review any pinned packages in go.mod and remove if possible
   * make updatedirect
-  * make GOTAGS=cmount
-  * make compiletest
+  * make
   * git commit -a -v
   * make update
-  * make GOTAGS=cmount
-  * make compiletest
+  * make
   * roll back any updates which didn't compile
   * git commit -a -v --amend
-  * **NB** watch out for this changing the default go version in `go.mod`
 
 Note that `make update` updates all direct and indirect dependencies
 and there can occasionally be forwards compatibility problems with
@@ -93,13 +90,6 @@ Now
   * git commit -a -v -m "Changelog updates from Version ${NEW_TAG}"
   * git push
 
-## Sponsor logos
-
-If updating the website note that the sponsor logos have been moved out of the main repository.
-
-You will need to checkout `/docs/static/img/logos` from https://github.com/rclone/third-party-logos
-which is a private repo containing artwork from sponsors.
-
 ## Update the website between releases
 
 Create an update website branch based off the last release
@@ -124,21 +114,32 @@ Cherry pick any changes back to master and the stable branch if it is active.
 
 ## Making a manual build of docker
 
-To do a basic build of rclone's docker image to debug builds locally:
-
-```
-docker buildx build --load -t rclone/rclone:testing --progress=plain .
-docker run --rm rclone/rclone:testing version
-```
-
-To test the multipatform build
-
-```
-docker buildx build -t rclone/rclone:testing --progress=plain --platform linux/amd64,linux/386,linux/arm64,linux/arm/v7,linux/arm/v6 .
-```
-
-To make a full build then set the tags correctly and add `--push`
+The rclone docker image should autobuild on via GitHub actions.  If it doesn't
+or needs to be updated then rebuild like this.
+
+See: https://github.com/ilteoood/docker_buildx/issues/19
+See: https://github.com/ilteoood/docker_buildx/blob/master/scripts/install_buildx.sh
 
 ```
+git co v1.54.1
+docker pull golang
+export DOCKER_CLI_EXPERIMENTAL=enabled
+docker buildx create --name actions_builder --use
+docker run --rm --privileged docker/binfmt:820fdd95a9972a5308930a2bdfb8573dd4447ad3
+docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
+SUPPORTED_PLATFORMS=$(docker buildx inspect --bootstrap | grep 'Platforms:*.*' | cut -d : -f2,3)
+echo "Supported platforms: $SUPPORTED_PLATFORMS"
 docker buildx build --platform linux/amd64,linux/386,linux/arm64,linux/arm/v7 -t rclone/rclone:1.54.1 -t rclone/rclone:1.54 -t rclone/rclone:1 -t rclone/rclone:latest --push .
+docker buildx stop actions_builder
+```
+
+### Old build for linux/amd64 only
+
+```
+docker pull golang
+docker build --rm --ulimit memlock=67108864  -t rclone/rclone:1.52.0 -t rclone/rclone:1.52 -t rclone/rclone:1 -t rclone/rclone:latest .
+docker push rclone/rclone:1.52.0
+docker push rclone/rclone:1.52
+docker push rclone/rclone:1
+docker push rclone/rclone:latest
 ```

VERSION

@@ -1 +1 @@
-v1.65.1
+v1.64.2

backend/all/all.go

@@ -6,7 +6,6 @@ import (
 	_ "github.com/rclone/rclone/backend/alias"
 	_ "github.com/rclone/rclone/backend/amazonclouddrive"
 	_ "github.com/rclone/rclone/backend/azureblob"
-	_ "github.com/rclone/rclone/backend/azurefiles"
 	_ "github.com/rclone/rclone/backend/b2"
 	_ "github.com/rclone/rclone/backend/box"
 	_ "github.com/rclone/rclone/backend/cache"
@@ -25,11 +24,9 @@ import (
 	_ "github.com/rclone/rclone/backend/hdfs"
 	_ "github.com/rclone/rclone/backend/hidrive"
 	_ "github.com/rclone/rclone/backend/http"
-	_ "github.com/rclone/rclone/backend/imagekit"
 	_ "github.com/rclone/rclone/backend/internetarchive"
 	_ "github.com/rclone/rclone/backend/jottacloud"
 	_ "github.com/rclone/rclone/backend/koofr"
-	_ "github.com/rclone/rclone/backend/linkbox"
 	_ "github.com/rclone/rclone/backend/local"
 	_ "github.com/rclone/rclone/backend/mailru"
 	_ "github.com/rclone/rclone/backend/mega"

backend/azureblob/azureblob.go

@@ -295,10 +295,10 @@ avoid the time out.`,
 			Advanced: true,
 		}, {
 			Name: "access_tier",
-			Help: `Access tier of blob: hot, cool, cold or archive.
+			Help: `Access tier of blob: hot, cool or archive.
 
-Archived blobs can be restored by setting access tier to hot, cool or
-cold. Leave blank if you intend to use default access tier, which is
+Archived blobs can be restored by setting access tier to hot or
+cool. Leave blank if you intend to use default access tier, which is
 set at account level
 
 If there is no "access tier" specified, rclone doesn't apply any tier.
@@ -306,7 +306,7 @@ rclone performs "Set Tier" operation on blobs while uploading, if objects
 are not modified, specifying "access tier" to new one will have no effect.
 If blobs are in "archive tier" at remote, trying to perform data transfer
 operations from remote will not be allowed. User should first restore by
-tiering blob to "Hot", "Cool" or "Cold".`,
+tiering blob to "Hot" or "Cool".`,
 			Advanced: true,
 		}, {
 			Name:    "archive_tier_delete",
@@ -520,7 +520,6 @@ func (o *Object) split() (container, containerPath string) {
 func validateAccessTier(tier string) bool {
 	return strings.EqualFold(tier, string(blob.AccessTierHot)) ||
 		strings.EqualFold(tier, string(blob.AccessTierCool)) ||
-		strings.EqualFold(tier, string(blob.AccessTierCold)) ||
 		strings.EqualFold(tier, string(blob.AccessTierArchive))
 }
 
@@ -650,8 +649,8 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 	if opt.AccessTier == "" {
 		opt.AccessTier = string(defaultAccessTier)
 	} else if !validateAccessTier(opt.AccessTier) {
-		return nil, fmt.Errorf("supported access tiers are %s, %s, %s and %s",
-			string(blob.AccessTierHot), string(blob.AccessTierCool), string(blob.AccessTierCold), string(blob.AccessTierArchive))
+		return nil, fmt.Errorf("supported access tiers are %s, %s and %s",
+			string(blob.AccessTierHot), string(blob.AccessTierCool), string(blob.AccessTierArchive))
 	}
 
 	if !validatePublicAccess((opt.PublicAccess)) {
@@ -1900,7 +1899,7 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Read
 	var offset int64
 	var count int64
 	if o.AccessTier() == blob.AccessTierArchive {
-		return nil, fmt.Errorf("blob in archive tier, you need to set tier to hot, cool, cold first")
+		return nil, fmt.Errorf("blob in archive tier, you need to set tier to hot or cool first")
 	}
 	fs.FixRangeOption(options, o.size)
 	for _, option := range options {

backend/azureblob/azureblob_test.go

@@ -19,7 +19,7 @@ func TestIntegration(t *testing.T) {
 	fstests.Run(t, &fstests.Opt{
 		RemoteName:  "TestAzureBlob:",
 		NilObject:   (*Object)(nil),
-		TiersToTest: []string{"Hot", "Cool", "Cold"},
+		TiersToTest: []string{"Hot", "Cool"},
 		ChunkedUpload: fstests.ChunkedUploadConfig{
 			MinChunkSize: defaultChunkSize,
 		},
@@ -35,7 +35,7 @@ func TestIntegration2(t *testing.T) {
 	fstests.Run(t, &fstests.Opt{
 		RemoteName:  name + ":",
 		NilObject:   (*Object)(nil),
-		TiersToTest: []string{"Hot", "Cool", "Cold"},
+		TiersToTest: []string{"Hot", "Cool"},
 		ChunkedUpload: fstests.ChunkedUploadConfig{
 			MinChunkSize: defaultChunkSize,
 		},
@@ -62,7 +62,6 @@ func TestValidateAccessTier(t *testing.T) {
 		"HOT":     {"HOT", true},
 		"Hot":     {"Hot", true},
 		"cool":    {"cool", true},
-		"cold":    {"cold", true},
 		"archive": {"archive", true},
 		"empty":   {"", false},
 		"unknown": {"unknown", false},

backend/azurefiles/azurefiles_internal_test.go

@@ -1,70 +0,0 @@
-//go:build !plan9 && !js
-// +build !plan9,!js
-
-package azurefiles
-
-import (
-	"context"
-	"math/rand"
-	"strings"
-	"testing"
-
-	"github.com/rclone/rclone/fstest/fstests"
-	"github.com/stretchr/testify/assert"
-)
-
-func (f *Fs) InternalTest(t *testing.T) {
-	t.Run("Authentication", f.InternalTestAuth)
-}
-
-var _ fstests.InternalTester = (*Fs)(nil)
-
-func (f *Fs) InternalTestAuth(t *testing.T) {
-	t.Skip("skipping since this requires authentication credentials which are not part of repo")
-	shareName := "test-rclone-oct-2023"
-	testCases := []struct {
-		name    string
-		options *Options
-	}{
-		{
-			name: "ConnectionString",
-			options: &Options{
-				ShareName:        shareName,
-				ConnectionString: "",
-			},
-		},
-		{
-			name: "AccountAndKey",
-			options: &Options{
-				ShareName: shareName,
-				Account:   "",
-				Key:       "",
-			}},
-		{
-			name: "SASUrl",
-			options: &Options{
-				ShareName: shareName,
-				SASURL:    "",
-			}},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			fs, err := newFsFromOptions(context.TODO(), "TestAzureFiles", "", tc.options)
-			assert.NoError(t, err)
-			dirName := randomString(10)
-			assert.NoError(t, fs.Mkdir(context.TODO(), dirName))
-		})
-	}
-}
-
-const chars = "abcdefghijklmnopqrstuvwzyxABCDEFGHIJKLMNOPQRSTUVWZYX"
-
-func randomString(charCount int) string {
-	strBldr := strings.Builder{}
-	for i := 0; i < charCount; i++ {
-		randPos := rand.Int63n(52)
-		strBldr.WriteByte(chars[randPos])
-	}
-	return strBldr.String()
-}

backend/azurefiles/azurefiles_test.go

@@ -1,18 +0,0 @@
-//go:build !plan9 && !js
-// +build !plan9,!js
-
-package azurefiles
-
-import (
-	"testing"
-
-	"github.com/rclone/rclone/fstest/fstests"
-)
-
-func TestIntegration(t *testing.T) {
-	var objPtr *Object
-	fstests.Run(t, &fstests.Opt{
-		RemoteName: "TestAzureFiles:",
-		NilObject:  objPtr,
-	})
-}

backend/azurefiles/azurefiles_unsupported.go

@@ -1,7 +0,0 @@
-// Build for azurefiles for unsupported platforms to stop go complaining
-// about "no buildable Go source files "
-
-//go:build plan9 || js
-// +build plan9 js
-
-package azurefiles

backend/b2/api/types.go

@@ -33,18 +33,10 @@ var _ fserrors.Fataler = (*Error)(nil)
 
 // Bucket describes a B2 bucket
 type Bucket struct {
-	ID             string          `json:"bucketId"`
-	AccountID      string          `json:"accountId"`
-	Name           string          `json:"bucketName"`
-	Type           string          `json:"bucketType"`
-	LifecycleRules []LifecycleRule `json:"lifecycleRules,omitempty"`
-}
-
-// LifecycleRule is a single lifecycle rule
-type LifecycleRule struct {
-	DaysFromHidingToDeleting  *int   `json:"daysFromHidingToDeleting"`
-	DaysFromUploadingToHiding *int   `json:"daysFromUploadingToHiding"`
-	FileNamePrefix            string `json:"fileNamePrefix"`
+	ID        string `json:"bucketId"`
+	AccountID string `json:"accountId"`
+	Name      string `json:"bucketName"`
+	Type      string `json:"bucketType"`
 }
 
 // Timestamp is a UTC time when this file was uploaded. It is a base
@@ -214,10 +206,9 @@ type FileInfo struct {
 
 // CreateBucketRequest is used to create a bucket
 type CreateBucketRequest struct {
-	AccountID      string          `json:"accountId"`
-	Name           string          `json:"bucketName"`
-	Type           string          `json:"bucketType"`
-	LifecycleRules []LifecycleRule `json:"lifecycleRules,omitempty"`
+	AccountID string `json:"accountId"`
+	Name      string `json:"bucketName"`
+	Type      string `json:"bucketType"`
 }
 
 // DeleteBucketRequest is used to create a bucket
@@ -340,11 +331,3 @@ type CopyPartRequest struct {
 	PartNumber  int64  `json:"partNumber"`      // Which part this is (starting from 1)
 	Range       string `json:"range,omitempty"` // The range of bytes to copy. If not provided, the whole source file will be copied.
 }
-
-// UpdateBucketRequest describes a request to modify a B2 bucket
-type UpdateBucketRequest struct {
-	ID             string          `json:"bucketId"`
-	AccountID      string          `json:"accountId"`
-	Type           string          `json:"bucketType,omitempty"`
-	LifecycleRules []LifecycleRule `json:"lifecycleRules,omitempty"`
-}

backend/b2/b2.go

@@ -9,7 +9,6 @@ import (
 	"bytes"
 	"context"
 	"crypto/sha1"
-	"encoding/json"
 	"errors"
 	"fmt"
 	gohash "hash"
@@ -74,7 +73,6 @@ func init() {
 		Name:        "b2",
 		Description: "Backblaze B2",
 		NewFs:       NewFs,
-		CommandHelp: commandHelp,
 		Options: []fs.Option{{
 			Name:      "account",
 			Help:      "Account ID or Application Key ID.",
@@ -211,31 +209,6 @@ The minimum value is 1 second. The maximum value is one week.`,
 			Advanced: true,
 			Hide:     fs.OptionHideBoth,
 			Help:     `Whether to use mmap buffers in internal memory pool. (no longer used)`,
-		}, {
-			Name: "lifecycle",
-			Help: `Set the number of days deleted files should be kept when creating a bucket.
-
-On bucket creation, this parameter is used to create a lifecycle rule
-for the entire bucket.
-
-If lifecycle is 0 (the default) it does not create a lifecycle rule so
-the default B2 behaviour applies. This is to create versions of files
-on delete and overwrite and to keep them indefinitely.
-
-If lifecycle is >0 then it creates a single rule setting the number of
-days before a file that is deleted or overwritten is deleted
-permanently. This is known as daysFromHidingToDeleting in the b2 docs.
-
-The minimum value for this parameter is 1 day.
-
-You can also enable hard_delete in the config also which will mean
-deletions won't cause versions but overwrites will still cause
-versions to be made.
-
-See: [rclone backend lifecycle](#lifecycle) for setting lifecycles after bucket creation.
-`,
-			Default:  0,
-			Advanced: true,
 		}, {
 			Name:     config.ConfigEncoding,
 			Help:     config.ConfigEncodingHelp,
@@ -266,7 +239,6 @@ type Options struct {
 	DisableCheckSum               bool                 `config:"disable_checksum"`
 	DownloadURL                   string               `config:"download_url"`
 	DownloadAuthorizationDuration fs.Duration          `config:"download_auth_duration"`
-	Lifecycle                     int                  `config:"lifecycle"`
 	Enc                           encoder.MultiEncoder `config:"encoding"`
 }
 
@@ -400,18 +372,11 @@ func (f *Fs) shouldRetry(ctx context.Context, resp *http.Response, err error) (b
 
 // errorHandler parses a non 2xx error response into an error
 func errorHandler(resp *http.Response) error {
-	body, err := rest.ReadBody(resp)
-	if err != nil {
-		fs.Errorf(nil, "Couldn't read error out of body: %v", err)
-		body = nil
-	}
-	// Decode error response if there was one - they can be blank
+	// Decode error response
 	errResponse := new(api.Error)
-	if len(body) > 0 {
-		err = json.Unmarshal(body, errResponse)
-		if err != nil {
-			fs.Errorf(nil, "Couldn't decode error response: %v", err)
-		}
+	err := rest.DecodeJSON(resp, &errResponse)
+	if err != nil {
+		fs.Debugf(nil, "Couldn't decode error response: %v", err)
 	}
 	if errResponse.Code == "" {
 		errResponse.Code = "unknown"
@@ -455,14 +420,6 @@ func (f *Fs) setUploadCutoff(cs fs.SizeSuffix) (old fs.SizeSuffix, err error) {
 	return
 }
 
-func (f *Fs) setCopyCutoff(cs fs.SizeSuffix) (old fs.SizeSuffix, err error) {
-	err = checkUploadChunkSize(cs)
-	if err == nil {
-		old, f.opt.CopyCutoff = f.opt.CopyCutoff, cs
-	}
-	return
-}
-
 // setRoot changes the root of the Fs
 func (f *Fs) setRoot(root string) {
 	f.root = parsePath(root)
@@ -513,11 +470,10 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 	}
 	f.setRoot(root)
 	f.features = (&fs.Features{
-		ReadMimeType:          true,
-		WriteMimeType:         true,
-		BucketBased:           true,
-		BucketBasedRootOK:     true,
-		ChunkWriterDoesntSeek: true,
+		ReadMimeType:      true,
+		WriteMimeType:     true,
+		BucketBased:       true,
+		BucketBasedRootOK: true,
 	}).Fill(ctx, f)
 	// Set the test flag if required
 	if opt.TestMode != "" {
@@ -868,7 +824,7 @@ func (f *Fs) listDir(ctx context.Context, bucket, directory, prefix string, addB
 
 // listBuckets returns all the buckets to out
 func (f *Fs) listBuckets(ctx context.Context) (entries fs.DirEntries, err error) {
-	err = f.listBucketsToFn(ctx, "", func(bucket *api.Bucket) error {
+	err = f.listBucketsToFn(ctx, func(bucket *api.Bucket) error {
 		d := fs.NewDir(bucket.Name, time.Time{})
 		entries = append(entries, d)
 		return nil
@@ -961,14 +917,11 @@ func (f *Fs) ListR(ctx context.Context, dir string, callback fs.ListRCallback) (
 type listBucketFn func(*api.Bucket) error
 
 // listBucketsToFn lists the buckets to the function supplied
-func (f *Fs) listBucketsToFn(ctx context.Context, bucketName string, fn listBucketFn) error {
+func (f *Fs) listBucketsToFn(ctx context.Context, fn listBucketFn) error {
 	var account = api.ListBucketsRequest{
 		AccountID: f.info.AccountID,
 		BucketID:  f.info.Allowed.BucketID,
 	}
-	if bucketName != "" && account.BucketID == "" {
-		account.BucketName = f.opt.Enc.FromStandardName(bucketName)
-	}
 
 	var response api.ListBucketsResponse
 	opts := rest.Opts{
@@ -1014,7 +967,7 @@ func (f *Fs) getbucketType(ctx context.Context, bucket string) (bucketType strin
 	if bucketType != "" {
 		return bucketType, nil
 	}
-	err = f.listBucketsToFn(ctx, bucket, func(bucket *api.Bucket) error {
+	err = f.listBucketsToFn(ctx, func(bucket *api.Bucket) error {
 		// listBucketsToFn reads bucket Types
 		return nil
 	})
@@ -1049,7 +1002,7 @@ func (f *Fs) getBucketID(ctx context.Context, bucket string) (bucketID string, e
 	if bucketID != "" {
 		return bucketID, nil
 	}
-	err = f.listBucketsToFn(ctx, bucket, func(bucket *api.Bucket) error {
+	err = f.listBucketsToFn(ctx, func(bucket *api.Bucket) error {
 		// listBucketsToFn sets IDs
 		return nil
 	})
@@ -1113,11 +1066,6 @@ func (f *Fs) makeBucket(ctx context.Context, bucket string) error {
 			Name:      f.opt.Enc.FromStandardName(bucket),
 			Type:      "allPrivate",
 		}
-		if f.opt.Lifecycle > 0 {
-			request.LifecycleRules = []api.LifecycleRule{{
-				DaysFromHidingToDeleting: &f.opt.Lifecycle,
-			}}
-		}
 		var response api.Bucket
 		err := f.pacer.Call(func() (bool, error) {
 			resp, err := f.srv.CallJSON(ctx, &opts, &request, &response)
@@ -1338,7 +1286,7 @@ func (f *Fs) CleanUp(ctx context.Context) error {
 // If newInfo is nil then the metadata will be copied otherwise it
 // will be replaced with newInfo
 func (f *Fs) copy(ctx context.Context, dstObj *Object, srcObj *Object, newInfo *api.File) (err error) {
-	if srcObj.size > int64(f.opt.CopyCutoff) {
+	if srcObj.size >= int64(f.opt.CopyCutoff) {
 		if newInfo == nil {
 			newInfo, err = srcObj.getMetaData(ctx)
 			if err != nil {
@@ -2088,7 +2036,7 @@ func (f *Fs) OpenChunkWriter(ctx context.Context, remote string, src fs.ObjectIn
 	// Temporary Object under construction
 	o := &Object{
 		fs:     f,
-		remote: remote,
+		remote: src.Remote(),
 	}
 
 	bucket, _ := o.split()
@@ -2131,137 +2079,6 @@ func (o *Object) ID() string {
 	return o.id
 }
 
-var lifecycleHelp = fs.CommandHelp{
-	Name:  "lifecycle",
-	Short: "Read or set the lifecycle for a bucket",
-	Long: `This command can be used to read or set the lifecycle for a bucket.
-
-Usage Examples:
-
-To show the current lifecycle rules:
-
-    rclone backend lifecycle b2:bucket
-
-This will dump something like this showing the lifecycle rules.
-
-    [
-        {
-            "daysFromHidingToDeleting": 1,
-            "daysFromUploadingToHiding": null,
-            "fileNamePrefix": ""
-        }
-    ]
-
-If there are no lifecycle rules (the default) then it will just return [].
-
-To reset the current lifecycle rules:
-
-    rclone backend lifecycle b2:bucket -o daysFromHidingToDeleting=30
-    rclone backend lifecycle b2:bucket -o daysFromUploadingToHiding=5 -o daysFromHidingToDeleting=1
-
-This will run and then print the new lifecycle rules as above.
-
-Rclone only lets you set lifecycles for the whole bucket with the
-fileNamePrefix = "".
-
-You can't disable versioning with B2. The best you can do is to set
-the daysFromHidingToDeleting to 1 day. You can enable hard_delete in
-the config also which will mean deletions won't cause versions but
-overwrites will still cause versions to be made.
-
-    rclone backend lifecycle b2:bucket -o daysFromHidingToDeleting=1
-
-See: https://www.backblaze.com/docs/cloud-storage-lifecycle-rules
-`,
-	Opts: map[string]string{
-		"daysFromHidingToDeleting":  "After a file has been hidden for this many days it is deleted. 0 is off.",
-		"daysFromUploadingToHiding": "This many days after uploading a file is hidden",
-	},
-}
-
-func (f *Fs) lifecycleCommand(ctx context.Context, name string, arg []string, opt map[string]string) (out interface{}, err error) {
-	var newRule api.LifecycleRule
-	if daysStr := opt["daysFromHidingToDeleting"]; daysStr != "" {
-		days, err := strconv.Atoi(daysStr)
-		if err != nil {
-			return nil, fmt.Errorf("bad daysFromHidingToDeleting: %w", err)
-		}
-		newRule.DaysFromHidingToDeleting = &days
-	}
-	if daysStr := opt["daysFromUploadingToHiding"]; daysStr != "" {
-		days, err := strconv.Atoi(daysStr)
-		if err != nil {
-			return nil, fmt.Errorf("bad daysFromUploadingToHiding: %w", err)
-		}
-		newRule.DaysFromUploadingToHiding = &days
-	}
-	bucketName, _ := f.split("")
-	if bucketName == "" {
-		return nil, errors.New("bucket required")
-
-	}
-
-	var bucket *api.Bucket
-	if newRule.DaysFromHidingToDeleting != nil || newRule.DaysFromUploadingToHiding != nil {
-		bucketID, err := f.getBucketID(ctx, bucketName)
-		if err != nil {
-			return nil, err
-		}
-		opts := rest.Opts{
-			Method: "POST",
-			Path:   "/b2_update_bucket",
-		}
-		var request = api.UpdateBucketRequest{
-			ID:             bucketID,
-			AccountID:      f.info.AccountID,
-			LifecycleRules: []api.LifecycleRule{newRule},
-		}
-		var response api.Bucket
-		err = f.pacer.Call(func() (bool, error) {
-			resp, err := f.srv.CallJSON(ctx, &opts, &request, &response)
-			return f.shouldRetry(ctx, resp, err)
-		})
-		if err != nil {
-			return nil, err
-		}
-		bucket = &response
-	} else {
-		err = f.listBucketsToFn(ctx, bucketName, func(b *api.Bucket) error {
-			bucket = b
-			return nil
-		})
-		if err != nil {
-			return nil, err
-		}
-	}
-	if bucket == nil {
-		return nil, fs.ErrorDirNotFound
-	}
-	return bucket.LifecycleRules, nil
-}
-
-var commandHelp = []fs.CommandHelp{
-	lifecycleHelp,
-}
-
-// Command the backend to run a named command
-//
-// The command run is name
-// args may be used to read arguments from
-// opts may be used to read optional arguments from
-//
-// The result should be capable of being JSON encoded
-// If it is a string or a []string it will be shown to the user
-// otherwise it will be JSON encoded and shown to the user like that
-func (f *Fs) Command(ctx context.Context, name string, arg []string, opt map[string]string) (out interface{}, err error) {
-	switch name {
-	case "lifecycle":
-		return f.lifecycleCommand(ctx, name, arg, opt)
-	default:
-		return nil, fs.ErrorCommandNotFound
-	}
-}
-
 // Check the interfaces are satisfied
 var (
 	_ fs.Fs              = &Fs{}
@@ -2272,7 +2089,6 @@ var (
 	_ fs.ListRer         = &Fs{}
 	_ fs.PublicLinker    = &Fs{}
 	_ fs.OpenChunkWriter = &Fs{}
-	_ fs.Commander       = &Fs{}
 	_ fs.Object          = &Object{}
 	_ fs.MimeTyper       = &Object{}
 	_ fs.IDer            = &Object{}

backend/b2/b2_internal_test.go

@@ -1,11 +1,19 @@
 package b2
 
 import (
+	"bytes"
+	"context"
+	"fmt"
 	"testing"
 	"time"
 
+	"github.com/rclone/rclone/fs"
+	"github.com/rclone/rclone/fs/object"
 	"github.com/rclone/rclone/fstest"
 	"github.com/rclone/rclone/fstest/fstests"
+	"github.com/rclone/rclone/lib/random"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 // Test b2 string encoding
@@ -170,9 +178,99 @@ func TestParseTimeString(t *testing.T) {
 
 }
 
+// The integration tests do a reasonable job of testing the normal
+// copy but don't test the chunked copy.
+func (f *Fs) InternalTestChunkedCopy(t *testing.T) {
+	ctx := context.Background()
+
+	contents := random.String(8 * 1024 * 1024)
+	item := fstest.NewItem("chunked-copy", contents, fstest.Time("2001-05-06T04:05:06.499999999Z"))
+	src := fstests.PutTestContents(ctx, t, f, &item, contents, true)
+	defer func() {
+		assert.NoError(t, src.Remove(ctx))
+	}()
+
+	var itemCopy = item
+	itemCopy.Path += ".copy"
+
+	// Set copy cutoff to mininum value so we make chunks
+	origCutoff := f.opt.CopyCutoff
+	f.opt.CopyCutoff = minChunkSize
+	defer func() {
+		f.opt.CopyCutoff = origCutoff
+	}()
+
+	// Do the copy
+	dst, err := f.Copy(ctx, src, itemCopy.Path)
+	require.NoError(t, err)
+	defer func() {
+		assert.NoError(t, dst.Remove(ctx))
+	}()
+
+	// Check size
+	assert.Equal(t, src.Size(), dst.Size())
+
+	// Check modtime
+	srcModTime := src.ModTime(ctx)
+	dstModTime := dst.ModTime(ctx)
+	assert.True(t, srcModTime.Equal(dstModTime))
+
+	// Make sure contents are correct
+	gotContents := fstests.ReadObject(ctx, t, dst, -1)
+	assert.Equal(t, contents, gotContents)
+}
+
+// The integration tests do a reasonable job of testing the normal
+// streaming upload but don't test the chunked streaming upload.
+func (f *Fs) InternalTestChunkedStreamingUpload(t *testing.T, size int) {
+	ctx := context.Background()
+	contents := random.String(size)
+	item := fstest.NewItem(fmt.Sprintf("chunked-streaming-upload-%d", size), contents, fstest.Time("2001-05-06T04:05:06.499Z"))
+
+	// Set chunk size to mininum value so we make chunks
+	origOpt := f.opt
+	f.opt.ChunkSize = minChunkSize
+	f.opt.UploadCutoff = 0
+	defer func() {
+		f.opt = origOpt
+	}()
+
+	// Do the streaming upload
+	src := object.NewStaticObjectInfo(item.Path, item.ModTime, -1, true, item.Hashes, f)
+	in := bytes.NewBufferString(contents)
+	dst, err := f.PutStream(ctx, in, src)
+	require.NoError(t, err)
+	defer func() {
+		assert.NoError(t, dst.Remove(ctx))
+	}()
+
+	// Check size
+	assert.Equal(t, int64(size), dst.Size())
+
+	// Check modtime
+	srcModTime := src.ModTime(ctx)
+	dstModTime := dst.ModTime(ctx)
+	assert.Equal(t, srcModTime, dstModTime)
+
+	// Make sure contents are correct
+	gotContents := fstests.ReadObject(ctx, t, dst, -1)
+	assert.Equal(t, contents, gotContents, "Contents incorrect")
+}
+
 // -run TestIntegration/FsMkdir/FsPutFiles/Internal
 func (f *Fs) InternalTest(t *testing.T) {
-	// Internal tests go here
+	t.Run("ChunkedCopy", f.InternalTestChunkedCopy)
+	for _, size := range []fs.SizeSuffix{
+		minChunkSize - 1,
+		minChunkSize,
+		minChunkSize + 1,
+		(3 * minChunkSize) / 2,
+		(5 * minChunkSize) / 2,
+	} {
+		t.Run(fmt.Sprintf("ChunkedStreamingUpload/%d", size), func(t *testing.T) {
+			f.InternalTestChunkedStreamingUpload(t, int(size))
+		})
+	}
 }
 
 var _ fstests.InternalTester = (*Fs)(nil)

backend/b2/b2_test.go

@@ -28,12 +28,7 @@ func (f *Fs) SetUploadCutoff(cs fs.SizeSuffix) (fs.SizeSuffix, error) {
 	return f.setUploadCutoff(cs)
 }
 
-func (f *Fs) SetCopyCutoff(cs fs.SizeSuffix) (fs.SizeSuffix, error) {
-	return f.setCopyCutoff(cs)
-}
-
 var (
 	_ fstests.SetUploadChunkSizer = (*Fs)(nil)
 	_ fstests.SetUploadCutoffer   = (*Fs)(nil)
-	_ fstests.SetCopyCutoffer     = (*Fs)(nil)
 )

backend/b2/upload.go

@@ -417,13 +417,7 @@ func (up *largeUpload) Stream(ctx context.Context, initialUploadBlock *pool.RW)
 		} else {
 			n, err = io.CopyN(rw, up.in, up.chunkSize)
 			if err == io.EOF {
-				if n == 0 {
-					fs.Debugf(up.o, "Not sending empty chunk after EOF - ending.")
-					up.f.putRW(rw)
-					break
-				} else {
-					fs.Debugf(up.o, "Read less than a full chunk %d, making this the last one.", n)
-				}
+				fs.Debugf(up.o, "Read less than a full chunk, making this the last one.")
 				hasMoreParts = false
 			} else if err != nil {
 				// other kinds of errors indicate failure

backend/box/api/types.go

@@ -167,7 +167,19 @@ type PreUploadCheckResponse struct {
 // PreUploadCheckConflict is returned in the ContextInfo error field
 // from PreUploadCheck when the error code is "item_name_in_use"
 type PreUploadCheckConflict struct {
-	Conflicts ItemMini `json:"conflicts"`
+	Conflicts struct {
+		Type        string `json:"type"`
+		ID          string `json:"id"`
+		FileVersion struct {
+			Type string `json:"type"`
+			ID   string `json:"id"`
+			Sha1 string `json:"sha1"`
+		} `json:"file_version"`
+		SequenceID string `json:"sequence_id"`
+		Etag       string `json:"etag"`
+		Sha1       string `json:"sha1"`
+		Name       string `json:"name"`
+	} `json:"conflicts"`
 }
 
 // UpdateFileModTime is used in Update File Info

backend/box/box.go

@@ -380,7 +380,7 @@ func shouldRetry(ctx context.Context, resp *http.Response, err error) (bool, err
 
 // readMetaDataForPath reads the metadata from the path
 func (f *Fs) readMetaDataForPath(ctx context.Context, path string) (info *api.Item, err error) {
-	// defer log.Trace(f, "path=%q", path)("info=%+v, err=%v", &info, &err)
+	// defer fs.Trace(f, "path=%q", path)("info=%+v, err=%v", &info, &err)
 	leaf, directoryID, err := f.dirCache.FindPath(ctx, path, false)
 	if err != nil {
 		if err == fs.ErrorDirNotFound {
@@ -389,30 +389,20 @@ func (f *Fs) readMetaDataForPath(ctx context.Context, path string) (info *api.It
 		return nil, err
 	}
 
-	// Use preupload to find the ID
-	itemMini, err := f.preUploadCheck(ctx, leaf, directoryID, -1)
-	if err != nil {
-		return nil, err
-	}
-	if itemMini == nil {
-		return nil, fs.ErrorObjectNotFound
-	}
-
-	// Now we have the ID we can look up the object proper
-	opts := rest.Opts{
-		Method:     "GET",
-		Path:       "/files/" + itemMini.ID,
-		Parameters: fieldsValue(),
-	}
-	var item api.Item
-	err = f.pacer.Call(func() (bool, error) {
-		resp, err := f.srv.CallJSON(ctx, &opts, nil, &item)
-		return shouldRetry(ctx, resp, err)
+	found, err := f.listAll(ctx, directoryID, false, true, true, func(item *api.Item) bool {
+		if strings.EqualFold(item.Name, leaf) {
+			info = item
+			return true
+		}
+		return false
 	})
 	if err != nil {
 		return nil, err
 	}
-	return &item, nil
+	if !found {
+		return nil, fs.ErrorObjectNotFound
+	}
+	return info, nil
 }
 
 // errorHandler parses a non 2xx error response into an error
@@ -772,7 +762,7 @@ func (f *Fs) createObject(ctx context.Context, remote string, modTime time.Time,
 //
 // It returns "", nil if the file is good to go
 // It returns "ID", nil if the file must be updated
-func (f *Fs) preUploadCheck(ctx context.Context, leaf, directoryID string, size int64) (item *api.ItemMini, err error) {
+func (f *Fs) preUploadCheck(ctx context.Context, leaf, directoryID string, size int64) (ID string, err error) {
 	check := api.PreUploadCheck{
 		Name: f.opt.Enc.FromStandardName(leaf),
 		Parent: api.Parent{
@@ -797,16 +787,16 @@ func (f *Fs) preUploadCheck(ctx context.Context, leaf, directoryID string, size
 			var conflict api.PreUploadCheckConflict
 			err = json.Unmarshal(apiErr.ContextInfo, &conflict)
 			if err != nil {
-				return nil, fmt.Errorf("pre-upload check: JSON decode failed: %w", err)
+				return "", fmt.Errorf("pre-upload check: JSON decode failed: %w", err)
 			}
 			if conflict.Conflicts.Type != api.ItemTypeFile {
-				return nil, fs.ErrorIsDir
+				return "", fmt.Errorf("pre-upload check: can't overwrite non file with file: %w", err)
 			}
-			return &conflict.Conflicts, nil
+			return conflict.Conflicts.ID, nil
 		}
-		return nil, fmt.Errorf("pre-upload check: %w", err)
+		return "", fmt.Errorf("pre-upload check: %w", err)
 	}
-	return nil, nil
+	return "", nil
 }
 
 // Put the object
@@ -827,11 +817,11 @@ func (f *Fs) Put(ctx context.Context, in io.Reader, src fs.ObjectInfo, options .
 
 	// Preflight check the upload, which returns the ID if the
 	// object already exists
-	item, err := f.preUploadCheck(ctx, leaf, directoryID, src.Size())
+	ID, err := f.preUploadCheck(ctx, leaf, directoryID, src.Size())
 	if err != nil {
 		return nil, err
 	}
-	if item == nil {
+	if ID == "" {
 		return f.PutUnchecked(ctx, in, src, options...)
 	}
 
@@ -839,7 +829,7 @@ func (f *Fs) Put(ctx context.Context, in io.Reader, src fs.ObjectInfo, options .
 	o := &Object{
 		fs:     f,
 		remote: remote,
-		id:     item.ID,
+		id:     ID,
 	}
 	return o, o.Update(ctx, in, src, options...)
 }
@@ -1221,10 +1211,6 @@ func (f *Fs) ChangeNotify(ctx context.Context, notifyFunc func(string, fs.EntryT
 			fs.Infof(f, "Failed to get StreamPosition: %s", err)
 		}
 
-		// box can send duplicate Event IDs. Use this map to track and filter
-		// the ones we've already processed.
-		processedEventIDs := make(map[string]time.Time)
-
 		var ticker *time.Ticker
 		var tickerC <-chan time.Time
 		for {
@@ -1252,15 +1238,7 @@ func (f *Fs) ChangeNotify(ctx context.Context, notifyFunc func(string, fs.EntryT
 						continue
 					}
 				}
-
-				// Garbage collect EventIDs older than 1 minute
-				for eventID, timestamp := range processedEventIDs {
-					if time.Since(timestamp) > time.Minute {
-						delete(processedEventIDs, eventID)
-					}
-				}
-
-				streamPosition, err = f.changeNotifyRunner(ctx, notifyFunc, streamPosition, processedEventIDs)
+				streamPosition, err = f.changeNotifyRunner(ctx, notifyFunc, streamPosition)
 				if err != nil {
 					fs.Infof(f, "Change notify listener failure: %s", err)
 				}
@@ -1313,9 +1291,12 @@ func (f *Fs) getFullPath(parentID string, childName string) (fullPath string) {
 	return fullPath
 }
 
-func (f *Fs) changeNotifyRunner(ctx context.Context, notifyFunc func(string, fs.EntryType), streamPosition string, processedEventIDs map[string]time.Time) (nextStreamPosition string, err error) {
+func (f *Fs) changeNotifyRunner(ctx context.Context, notifyFunc func(string, fs.EntryType), streamPosition string) (nextStreamPosition string, err error) {
 	nextStreamPosition = streamPosition
 
+	// box can send duplicate Event IDs; filter any in a single notify run
+	processedEventIDs := make(map[string]bool)
+
 	for {
 		limit := f.opt.ListChunk
 
@@ -1360,32 +1341,21 @@ func (f *Fs) changeNotifyRunner(ctx context.Context, notifyFunc func(string, fs.
 		var pathsToClear []pathToClear
 		newEventIDs := 0
 		for _, entry := range result.Entries {
-			eventDetails := fmt.Sprintf("[%q(%d)|%s|%s|%s|%s]", entry.Source.Name, entry.Source.SequenceID,
-				entry.Source.Type, entry.EventType, entry.Source.ID, entry.EventID)
-
-			if entry.EventID == "" {
-				fs.Debugf(f, "%s ignored due to missing EventID", eventDetails)
+			if entry.EventID == "" || processedEventIDs[entry.EventID] { // missing Event ID, or already saw this one
 				continue
 			}
-			if _, ok := processedEventIDs[entry.EventID]; ok {
-				fs.Debugf(f, "%s ignored due to duplicate EventID", eventDetails)
-				continue
-			}
-			processedEventIDs[entry.EventID] = time.Now()
+			processedEventIDs[entry.EventID] = true
 			newEventIDs++
 
 			if entry.Source.ID == "" { // missing File or Folder ID
-				fs.Debugf(f, "%s ignored due to missing SourceID", eventDetails)
 				continue
 			}
 			if entry.Source.Type != api.ItemTypeFile && entry.Source.Type != api.ItemTypeFolder { // event is not for a file or folder
-				fs.Debugf(f, "%s ignored due to unsupported SourceType", eventDetails)
 				continue
 			}
 
 			// Only interested in event types that result in a file tree change
 			if _, found := api.FileTreeChangeEventTypes[entry.EventType]; !found {
-				fs.Debugf(f, "%s ignored due to unsupported EventType", eventDetails)
 				continue
 			}
 
@@ -1396,7 +1366,6 @@ func (f *Fs) changeNotifyRunner(ctx context.Context, notifyFunc func(string, fs.
 					// Item in the cache has the same or newer SequenceID than
 					// this event. Ignore this event, it must be old.
 					f.itemMetaCacheMu.Unlock()
-					fs.Debugf(f, "%s ignored due to old SequenceID (%q)", eventDetails, itemMeta.SequenceID)
 					continue
 				}
 
@@ -1418,10 +1387,7 @@ func (f *Fs) changeNotifyRunner(ctx context.Context, notifyFunc func(string, fs.
 			if cachedItemMetaFound {
 				path := f.getFullPath(itemMeta.ParentID, itemMeta.Name)
 				if path != "" {
-					fs.Debugf(f, "%s added old path (%q) for notify", eventDetails, path)
 					pathsToClear = append(pathsToClear, pathToClear{path: path, entryType: entryType})
-				} else {
-					fs.Debugf(f, "%s old parent not cached", eventDetails)
 				}
 
 				// If this is a directory, also delete it from the dir cache.
@@ -1445,10 +1411,7 @@ func (f *Fs) changeNotifyRunner(ctx context.Context, notifyFunc func(string, fs.
 			if entry.Source.ItemStatus == api.ItemStatusActive {
 				path := f.getFullPath(entry.Source.Parent.ID, entry.Source.Name)
 				if path != "" {
-					fs.Debugf(f, "%s added new path (%q) for notify", eventDetails, path)
 					pathsToClear = append(pathsToClear, pathToClear{path: path, entryType: entryType})
-				} else {
-					fs.Debugf(f, "%s new parent not found", eventDetails)
 				}
 			}
 		}

backend/chunker/chunker.go

@@ -325,14 +325,6 @@ func NewFs(ctx context.Context, name, rpath string, m configmap.Mapper) (fs.Fs,
 		}
 	}
 
-	// Correct root if definitely pointing to a file
-	if err == fs.ErrorIsFile {
-		f.root = path.Dir(f.root)
-		if f.root == "." || f.root == "/" {
-			f.root = ""
-		}
-	}
-
 	// Note 1: the features here are ones we could support, and they are
 	// ANDed with the ones from wrappedFs.
 	// Note 2: features.Fill() points features.PutStream to our PutStream,

backend/compress/compress.go

@@ -14,7 +14,6 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"path"
 	"regexp"
 	"strings"
 	"time"
@@ -173,13 +172,6 @@ func NewFs(ctx context.Context, name, rpath string, m configmap.Mapper) (fs.Fs,
 		opt:  *opt,
 		mode: compressionModeFromName(opt.CompressionMode),
 	}
-	// Correct root if definitely pointing to a file
-	if err == fs.ErrorIsFile {
-		f.root = path.Dir(f.root)
-		if f.root == "." || f.root == "/" {
-			f.root = ""
-		}
-	}
 	// the features here are ones we could support, and they are
 	// ANDed with the ones from wrappedFs
 	f.features = (&fs.Features{

backend/crypt/crypt.go

@@ -253,13 +253,6 @@ func NewFs(ctx context.Context, name, rpath string, m configmap.Mapper) (fs.Fs,
 		cipher: cipher,
 	}
 	cache.PinUntilFinalized(f.Fs, f)
-	// Correct root if definitely pointing to a file
-	if err == fs.ErrorIsFile {
-		f.root = path.Dir(f.root)
-		if f.root == "." || f.root == "/" {
-			f.root = ""
-		}
-	}
 	// the features here are ones we could support, and they are
 	// ANDed with the ones from wrappedFs
 	f.features = (&fs.Features{

backend/drive/drive.go

@@ -71,7 +71,7 @@ const (
 	// 1<<18 is the minimum size supported by the Google uploader, and there is no maximum.
 	minChunkSize     = fs.SizeSuffix(googleapi.MinUploadChunkSize)
 	defaultChunkSize = 8 * fs.Mebi
-	partialFields    = "id,name,size,md5Checksum,sha1Checksum,sha256Checksum,trashed,explicitlyTrashed,modifiedTime,createdTime,mimeType,parents,webViewLink,shortcutDetails,exportLinks,resourceKey"
+	partialFields    = "id,name,size,md5Checksum,trashed,explicitlyTrashed,modifiedTime,createdTime,mimeType,parents,webViewLink,shortcutDetails,exportLinks,resourceKey"
 	listRGrouping    = 50   // number of IDs to search at once when using ListR
 	listRInputBuffer = 1000 // size of input buffer when using ListR
 	defaultXDGIcon   = "text-html"
@@ -143,41 +143,6 @@ var (
 	_linkTemplates   map[string]*template.Template // available link types
 )
 
-// rwChoices type for fs.Bits
-type rwChoices struct{}
-
-func (rwChoices) Choices() []fs.BitsChoicesInfo {
-	return []fs.BitsChoicesInfo{
-		{Bit: uint64(rwOff), Name: "off"},
-		{Bit: uint64(rwRead), Name: "read"},
-		{Bit: uint64(rwWrite), Name: "write"},
-	}
-}
-
-// rwChoice type alias
-type rwChoice = fs.Bits[rwChoices]
-
-const (
-	rwRead rwChoice = 1 << iota
-	rwWrite
-	rwOff rwChoice = 0
-)
-
-// Examples for the options
-var rwExamples = fs.OptionExamples{{
-	Value: rwOff.String(),
-	Help:  "Do not read or write the value",
-}, {
-	Value: rwRead.String(),
-	Help:  "Read the value only",
-}, {
-	Value: rwWrite.String(),
-	Help:  "Write the value only",
-}, {
-	Value: (rwRead | rwWrite).String(),
-	Help:  "Read and Write the value.",
-}}
-
 // Parse the scopes option returning a slice of scopes
 func driveScopes(scopesString string) (scopes []string) {
 	if scopesString == "" {
@@ -285,13 +250,9 @@ func init() {
 			}
 			return nil, fmt.Errorf("unknown state %q", config.State)
 		},
-		MetadataInfo: &fs.MetadataInfo{
-			System: systemMetadataInfo,
-			Help:   `User metadata is stored in the properties field of the drive object.`,
-		},
 		Options: append(driveOAuthOptions(), []fs.Option{{
 			Name: "scope",
-			Help: "Comma separated list of scopes that rclone should use when requesting access from drive.",
+			Help: "Scope that rclone should use when requesting access from drive.",
 			Examples: []fs.OptionExample{{
 				Value: "drive",
 				Help:  "Full access all files, excluding Application Data Folder.",
@@ -359,35 +320,16 @@ rather than shortcuts themselves when doing server side copies.`,
 			Default:  false,
 			Help:     "Skip google documents in all listings.\n\nIf given, gdocs practically become invisible to rclone.",
 			Advanced: true,
-		}, {
-			Name:    "show_all_gdocs",
-			Default: false,
-			Help: `Show all Google Docs including non-exportable ones in listings.
-
-If you try a server side copy on a Google Form without this flag, you
-will get this error:
-
-    No export formats found for "application/vnd.google-apps.form"
-
-However adding this flag will allow the form to be server side copied.
-
-Note that rclone doesn't add extensions to the Google Docs file names
-in this mode.
-
-Do **not** use this flag when trying to download Google Docs - rclone
-will fail to download them.
-`,
-			Advanced: true,
 		}, {
 			Name:    "skip_checksum_gphotos",
 			Default: false,
-			Help: `Skip checksums on Google photos and videos only.
+			Help: `Skip MD5 checksum on Google photos and videos only.
 
 Use this if you get checksum errors when transferring Google photos or
 videos.
 
 Setting this flag will cause Google photos and videos to return a
-blank checksums.
+blank MD5 checksum.
 
 Google photos are identified by being in the "photos" space.
 
@@ -678,56 +620,6 @@ having trouble with like many empty directories.
 `,
 			Advanced: true,
 			Default:  true,
-		}, {
-			Name: "metadata_owner",
-			Help: `Control whether owner should be read or written in metadata.
-
-Owner is a standard part of the file metadata so is easy to read. But it
-isn't always desirable to set the owner from the metadata.
-
-Note that you can't set the owner on Shared Drives, and that setting
-ownership will generate an email to the new owner (this can't be
-disabled), and you can't transfer ownership to someone outside your
-organization.
-`,
-			Advanced: true,
-			Default:  rwRead,
-			Examples: rwExamples,
-		}, {
-			Name: "metadata_permissions",
-			Help: `Control whether permissions should be read or written in metadata.
-
-Reading permissions metadata from files can be done quickly, but it
-isn't always desirable to set the permissions from the metadata.
-
-Note that rclone drops any inherited permissions on Shared Drives and
-any owner permission on My Drives as these are duplicated in the owner
-metadata.
-`,
-			Advanced: true,
-			Default:  rwOff,
-			Examples: rwExamples,
-		}, {
-			Name: "metadata_labels",
-			Help: `Control whether labels should be read or written in metadata.
-
-Reading labels metadata from files takes an extra API transaction and
-will slow down listings. It isn't always desirable to set the labels
-from the metadata.
-
-The format of labels is documented in the drive API documentation at
-https://developers.google.com/drive/api/reference/rest/v3/Label -
-rclone just provides a JSON dump of this format.
-
-When setting labels, the label and fields must already exist - rclone
-will not create them. This means that if you are transferring labels
-from two different accounts you will have to create the labels in
-advance and use the metadata mapper to translate the IDs between the
-two accounts.
-`,
-			Advanced: true,
-			Default:  rwOff,
-			Examples: rwExamples,
 		}, {
 			Name:     config.ConfigEncoding,
 			Help:     config.ConfigEncodingHelp,
@@ -775,7 +667,6 @@ type Options struct {
 	UseTrash                  bool                 `config:"use_trash"`
 	CopyShortcutContent       bool                 `config:"copy_shortcut_content"`
 	SkipGdocs                 bool                 `config:"skip_gdocs"`
-	ShowAllGdocs              bool                 `config:"show_all_gdocs"`
 	SkipChecksumGphotos       bool                 `config:"skip_checksum_gphotos"`
 	SharedWithMe              bool                 `config:"shared_with_me"`
 	TrashedOnly               bool                 `config:"trashed_only"`
@@ -804,9 +695,6 @@ type Options struct {
 	SkipDanglingShortcuts     bool                 `config:"skip_dangling_shortcuts"`
 	ResourceKey               string               `config:"resource_key"`
 	FastListBugFix            bool                 `config:"fast_list_bug_fix"`
-	MetadataOwner             rwChoice             `config:"metadata_owner"`
-	MetadataPermissions       rwChoice             `config:"metadata_permissions"`
-	MetadataLabels            rwChoice             `config:"metadata_labels"`
 	Enc                       encoder.MultiEncoder `config:"encoding"`
 	EnvAuth                   bool                 `config:"env_auth"`
 }
@@ -828,25 +716,23 @@ type Fs struct {
 	exportExtensions []string           // preferred extensions to download docs
 	importMimeTypes  []string           // MIME types to convert to docs
 	isTeamDrive      bool               // true if this is a team drive
+	fileFields       googleapi.Field    // fields to fetch file info with
 	m                configmap.Mapper
-	grouping         int32                        // number of IDs to search at once in ListR - read with atomic
-	listRmu          *sync.Mutex                  // protects listRempties
-	listRempties     map[string]struct{}          // IDs of supposedly empty directories which triggered grouping disable
-	dirResourceKeys  *sync.Map                    // map directory ID to resource key
-	permissionsMu    *sync.Mutex                  // protect the below
-	permissions      map[string]*drive.Permission // map permission IDs to Permissions
+	grouping         int32               // number of IDs to search at once in ListR - read with atomic
+	listRmu          *sync.Mutex         // protects listRempties
+	listRempties     map[string]struct{} // IDs of supposedly empty directories which triggered grouping disable
+	dirResourceKeys  *sync.Map           // map directory ID to resource key
 }
 
 type baseObject struct {
-	fs           *Fs          // what this object is part of
-	remote       string       // The remote path
-	id           string       // Drive Id of this object
-	modifiedDate string       // RFC3339 time it was last modified
-	mimeType     string       // The object MIME type
-	bytes        int64        // size of the object
-	parents      []string     // IDs of the parent directories
-	resourceKey  *string      // resourceKey is needed for link shared objects
-	metadata     *fs.Metadata // metadata if known
+	fs           *Fs      // what this object is part of
+	remote       string   // The remote path
+	id           string   // Drive Id of this object
+	modifiedDate string   // RFC3339 time it was last modified
+	mimeType     string   // The object MIME type
+	bytes        int64    // size of the object
+	parents      []string // IDs of the parent directories
+	resourceKey  *string  // resourceKey is needed for link shared objects
 }
 type documentObject struct {
 	baseObject
@@ -865,8 +751,6 @@ type Object struct {
 	baseObject
 	url        string // Download URL of this object
 	md5sum     string // md5sum of the object
-	sha1sum    string // sha1sum of the object
-	sha256sum  string // sha256sum of the object
 	v2Download bool   // generate v2 download link ondemand
 }
 
@@ -1095,7 +979,7 @@ func (f *Fs) list(ctx context.Context, dirIDs []string, title string, directorie
 		list.Header().Add("X-Goog-Drive-Resource-Keys", resourceKeysHeader)
 	}
 
-	fields := fmt.Sprintf("files(%s),nextPageToken,incompleteSearch", f.getFileFields(ctx))
+	fields := fmt.Sprintf("files(%s),nextPageToken,incompleteSearch", f.fileFields)
 
 OUTER:
 	for {
@@ -1369,10 +1253,9 @@ func newFs(ctx context.Context, name, path string, m configmap.Mapper) (*Fs, err
 		listRmu:         new(sync.Mutex),
 		listRempties:    make(map[string]struct{}),
 		dirResourceKeys: new(sync.Map),
-		permissionsMu:   new(sync.Mutex),
-		permissions:     make(map[string]*drive.Permission),
 	}
 	f.isTeamDrive = opt.TeamDriveID != ""
+	f.fileFields = f.getFileFields()
 	f.features = (&fs.Features{
 		DuplicateFiles:          true,
 		ReadMimeType:            true,
@@ -1380,9 +1263,6 @@ func newFs(ctx context.Context, name, path string, m configmap.Mapper) (*Fs, err
 		CanHaveEmptyDirectories: true,
 		ServerSideAcrossConfigs: opt.ServerSideAcrossConfigs,
 		FilterAware:             true,
-		ReadMetadata:            true,
-		WriteMetadata:           true,
-		UserMetadata:            true,
 	}).Fill(ctx, f)
 
 	// Create a new authorized Drive client.
@@ -1487,7 +1367,7 @@ func NewFs(ctx context.Context, name, path string, m configmap.Mapper) (fs.Fs, e
 	return f, nil
 }
 
-func (f *Fs) newBaseObject(ctx context.Context, remote string, info *drive.File) (o baseObject, err error) {
+func (f *Fs) newBaseObject(remote string, info *drive.File) baseObject {
 	modifiedDate := info.ModifiedTime
 	if f.opt.UseCreatedDate {
 		modifiedDate = info.CreatedTime
@@ -1498,7 +1378,7 @@ func (f *Fs) newBaseObject(ctx context.Context, remote string, info *drive.File)
 	if f.opt.SizeAsQuota {
 		size = info.QuotaBytesUsed
 	}
-	o = baseObject{
+	return baseObject{
 		fs:           f,
 		remote:       remote,
 		id:           info.Id,
@@ -1507,15 +1387,10 @@ func (f *Fs) newBaseObject(ctx context.Context, remote string, info *drive.File)
 		bytes:        size,
 		parents:      info.Parents,
 	}
-	err = nil
-	if fs.GetConfig(ctx).Metadata {
-		err = o.parseMetadata(ctx, info)
-	}
-	return o, err
 }
 
 // getFileFields gets the fields for a normal file Get or List
-func (f *Fs) getFileFields(ctx context.Context) (fields googleapi.Field) {
+func (f *Fs) getFileFields() (fields googleapi.Field) {
 	fields = partialFields
 	if f.opt.AuthOwnerOnly {
 		fields += ",owners"
@@ -1529,53 +1404,40 @@ func (f *Fs) getFileFields(ctx context.Context) (fields googleapi.Field) {
 	if f.opt.SizeAsQuota {
 		fields += ",quotaBytesUsed"
 	}
-	if fs.GetConfig(ctx).Metadata {
-		fields += "," + metadataFields
-	}
 	return fields
 }
 
 // newRegularObject creates an fs.Object for a normal drive.File
-func (f *Fs) newRegularObject(ctx context.Context, remote string, info *drive.File) (obj fs.Object, err error) {
+func (f *Fs) newRegularObject(remote string, info *drive.File) fs.Object {
 	// wipe checksum if SkipChecksumGphotos and file is type Photo or Video
 	if f.opt.SkipChecksumGphotos {
 		for _, space := range info.Spaces {
 			if space == "photos" {
 				info.Md5Checksum = ""
-				info.Sha1Checksum = ""
-				info.Sha256Checksum = ""
 				break
 			}
 		}
 	}
 	o := &Object{
+		baseObject: f.newBaseObject(remote, info),
 		url:        fmt.Sprintf("%sfiles/%s?alt=media", f.svc.BasePath, actualID(info.Id)),
 		md5sum:     strings.ToLower(info.Md5Checksum),
-		sha1sum:    strings.ToLower(info.Sha1Checksum),
-		sha256sum:  strings.ToLower(info.Sha256Checksum),
 		v2Download: f.opt.V2DownloadMinSize != -1 && info.Size >= int64(f.opt.V2DownloadMinSize),
 	}
-	o.baseObject, err = f.newBaseObject(ctx, remote, info)
-	if err != nil {
-		return nil, err
-	}
 	if info.ResourceKey != "" {
 		o.resourceKey = &info.ResourceKey
 	}
-	return o, nil
+	return o
 }
 
 // newDocumentObject creates an fs.Object for a google docs drive.File
-func (f *Fs) newDocumentObject(ctx context.Context, remote string, info *drive.File, extension, exportMimeType string) (fs.Object, error) {
+func (f *Fs) newDocumentObject(remote string, info *drive.File, extension, exportMimeType string) (fs.Object, error) {
 	mediaType, _, err := mime.ParseMediaType(exportMimeType)
 	if err != nil {
 		return nil, err
 	}
 	url := info.ExportLinks[mediaType]
-	baseObject, err := f.newBaseObject(ctx, remote+extension, info)
-	if err != nil {
-		return nil, err
-	}
+	baseObject := f.newBaseObject(remote+extension, info)
 	baseObject.bytes = -1
 	baseObject.mimeType = exportMimeType
 	return &documentObject{
@@ -1587,7 +1449,7 @@ func (f *Fs) newDocumentObject(ctx context.Context, remote string, info *drive.F
 }
 
 // newLinkObject creates an fs.Object that represents a link a google docs drive.File
-func (f *Fs) newLinkObject(ctx context.Context, remote string, info *drive.File, extension, exportMimeType string) (fs.Object, error) {
+func (f *Fs) newLinkObject(remote string, info *drive.File, extension, exportMimeType string) (fs.Object, error) {
 	t := linkTemplate(exportMimeType)
 	if t == nil {
 		return nil, fmt.Errorf("unsupported link type %s", exportMimeType)
@@ -1606,10 +1468,7 @@ func (f *Fs) newLinkObject(ctx context.Context, remote string, info *drive.File,
 		return nil, fmt.Errorf("executing template failed: %w", err)
 	}
 
-	baseObject, err := f.newBaseObject(ctx, remote+extension, info)
-	if err != nil {
-		return nil, err
-	}
+	baseObject := f.newBaseObject(remote+extension, info)
 	baseObject.bytes = int64(buf.Len())
 	baseObject.mimeType = exportMimeType
 	return &linkObject{
@@ -1625,7 +1484,7 @@ func (f *Fs) newLinkObject(ctx context.Context, remote string, info *drive.File,
 func (f *Fs) newObjectWithInfo(ctx context.Context, remote string, info *drive.File) (fs.Object, error) {
 	// If item has MD5 sum it is a file stored on drive
 	if info.Md5Checksum != "" {
-		return f.newRegularObject(ctx, remote, info)
+		return f.newRegularObject(remote, info), nil
 	}
 
 	extension, exportName, exportMimeType, isDocument := f.findExportFormat(ctx, info)
@@ -1656,15 +1515,13 @@ func (f *Fs) newObjectWithExportInfo(
 	case info.MimeType == shortcutMimeTypeDangling:
 		// Pretend a dangling shortcut is a regular object
 		// It will error if used, but appear in listings so it can be deleted
-		return f.newRegularObject(ctx, remote, info)
+		return f.newRegularObject(remote, info), nil
 	case info.Md5Checksum != "":
 		// If item has MD5 sum it is a file stored on drive
-		return f.newRegularObject(ctx, remote, info)
+		return f.newRegularObject(remote, info), nil
 	case f.opt.SkipGdocs:
 		fs.Debugf(remote, "Skipping google document type %q", info.MimeType)
 		return nil, fs.ErrorObjectNotFound
-	case f.opt.ShowAllGdocs:
-		return f.newDocumentObject(ctx, remote, info, "", info.MimeType)
 	default:
 		// If item MimeType is in the ExportFormats then it is a google doc
 		if !isDocument {
@@ -1676,9 +1533,9 @@ func (f *Fs) newObjectWithExportInfo(
 			return nil, fs.ErrorObjectNotFound
 		}
 		if isLinkMimeType(exportMimeType) {
-			return f.newLinkObject(ctx, remote, info, extension, exportMimeType)
+			return f.newLinkObject(remote, info, extension, exportMimeType)
 		}
-		return f.newDocumentObject(ctx, remote, info, extension, exportMimeType)
+		return f.newDocumentObject(remote, info, extension, exportMimeType)
 	}
 }
 
@@ -2306,7 +2163,7 @@ func (f *Fs) resolveShortcut(ctx context.Context, item *drive.File) (newItem *dr
 		fs.Errorf(nil, "Expecting shortcutDetails in %v", item)
 		return item, nil
 	}
-	newItem, err = f.getFile(ctx, item.ShortcutDetails.TargetId, f.getFileFields(ctx))
+	newItem, err = f.getFile(ctx, item.ShortcutDetails.TargetId, f.fileFields)
 	if err != nil {
 		var gerr *googleapi.Error
 		if errors.As(err, &gerr) && gerr.Code == 404 {
@@ -2438,10 +2295,6 @@ func (f *Fs) PutUnchecked(ctx context.Context, in io.Reader, src fs.ObjectInfo,
 	} else {
 		createInfo.MimeType = fs.MimeTypeFromName(remote)
 	}
-	updateMetadata, err := f.fetchAndUpdateMetadata(ctx, src, options, createInfo, false)
-	if err != nil {
-		return nil, err
-	}
 
 	var info *drive.File
 	if size >= 0 && size < int64(f.opt.UploadCutoff) {
@@ -2466,10 +2319,6 @@ func (f *Fs) PutUnchecked(ctx context.Context, in io.Reader, src fs.ObjectInfo,
 			return nil, err
 		}
 	}
-	err = updateMetadata(ctx, info)
-	if err != nil {
-		return nil, err
-	}
 	return f.newObjectWithInfo(ctx, remote, info)
 }
 
@@ -3158,7 +3007,7 @@ func (f *Fs) DirCacheFlush() {
 
 // Hashes returns the supported hash sets.
 func (f *Fs) Hashes() hash.Set {
-	return hash.NewHashSet(hash.MD5, hash.SHA1, hash.SHA256)
+	return hash.Set(hash.MD5)
 }
 
 func (f *Fs) changeChunkSize(chunkSizeString string) (err error) {
@@ -3387,7 +3236,7 @@ func (f *Fs) unTrashDir(ctx context.Context, dir string, recurse bool) (r unTras
 
 // copy file with id to dest
 func (f *Fs) copyID(ctx context.Context, id, dest string) (err error) {
-	info, err := f.getFile(ctx, id, f.getFileFields(ctx))
+	info, err := f.getFile(ctx, id, f.fileFields)
 	if err != nil {
 		return fmt.Errorf("couldn't find id: %w", err)
 	}
@@ -3719,16 +3568,10 @@ func (o *baseObject) Remote() string {
 
 // Hash returns the Md5sum of an object returning a lowercase hex string
 func (o *Object) Hash(ctx context.Context, t hash.Type) (string, error) {
-	if t == hash.MD5 {
-		return o.md5sum, nil
+	if t != hash.MD5 {
+		return "", hash.ErrUnsupported
 	}
-	if t == hash.SHA1 {
-		return o.sha1sum, nil
-	}
-	if t == hash.SHA256 {
-		return o.sha256sum, nil
-	}
-	return "", hash.ErrUnsupported
+	return o.md5sum, nil
 }
 func (o *baseObject) Hash(ctx context.Context, t hash.Type) (string, error) {
 	if t != hash.MD5 {
@@ -4067,20 +3910,10 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		MimeType:     srcMimeType,
 		ModifiedTime: src.ModTime(ctx).Format(timeFormatOut),
 	}
-
-	updateMetadata, err := o.fs.fetchAndUpdateMetadata(ctx, src, options, updateInfo, true)
-	if err != nil {
-		return err
-	}
-
 	info, err := o.baseObject.update(ctx, updateInfo, srcMimeType, in, src)
 	if err != nil {
 		return err
 	}
-	err = updateMetadata(ctx, info)
-	if err != nil {
-		return err
-	}
 	newO, err := o.fs.newObjectWithInfo(ctx, o.remote, info)
 	if err != nil {
 		return err
@@ -4166,26 +3999,6 @@ func (o *baseObject) ParentID() string {
 	return ""
 }
 
-// Metadata returns metadata for an object
-//
-// It should return nil if there is no Metadata
-func (o *baseObject) Metadata(ctx context.Context) (metadata fs.Metadata, err error) {
-	if o.metadata != nil {
-		return *o.metadata, nil
-	}
-	fs.Debugf(o, "Fetching metadata")
-	id := actualID(o.id)
-	info, err := o.fs.getFile(ctx, id, o.fs.getFileFields(ctx))
-	if err != nil {
-		return nil, err
-	}
-	err = o.parseMetadata(ctx, info)
-	if err != nil {
-		return nil, err
-	}
-	return *o.metadata, nil
-}
-
 func (o *documentObject) ext() string {
 	return o.baseObject.remote[len(o.baseObject.remote)-o.extLen:]
 }
@@ -4247,7 +4060,6 @@ var (
 	_ fs.MimeTyper       = (*Object)(nil)
 	_ fs.IDer            = (*Object)(nil)
 	_ fs.ParentIDer      = (*Object)(nil)
-	_ fs.Metadataer      = (*Object)(nil)
 	_ fs.Object          = (*documentObject)(nil)
 	_ fs.MimeTyper       = (*documentObject)(nil)
 	_ fs.IDer            = (*documentObject)(nil)

backend/drive/metadata.go

@@ -1,608 +0,0 @@
-package drive
-
-import (
-	"context"
-	"encoding/json"
-	"fmt"
-	"strconv"
-	"strings"
-	"sync"
-
-	"github.com/rclone/rclone/fs"
-	"golang.org/x/sync/errgroup"
-	drive "google.golang.org/api/drive/v3"
-	"google.golang.org/api/googleapi"
-)
-
-// system metadata keys which this backend owns
-var systemMetadataInfo = map[string]fs.MetadataHelp{
-	"content-type": {
-		Help:    "The MIME type of the file.",
-		Type:    "string",
-		Example: "text/plain",
-	},
-	"mtime": {
-		Help:    "Time of last modification with mS accuracy.",
-		Type:    "RFC 3339",
-		Example: "2006-01-02T15:04:05.999Z07:00",
-	},
-	"btime": {
-		Help:    "Time of file birth (creation) with mS accuracy. Note that this is only writable on fresh uploads - it can't be written for updates.",
-		Type:    "RFC 3339",
-		Example: "2006-01-02T15:04:05.999Z07:00",
-	},
-	"copy-requires-writer-permission": {
-		Help:    "Whether the options to copy, print, or download this file, should be disabled for readers and commenters.",
-		Type:    "boolean",
-		Example: "true",
-	},
-	"writers-can-share": {
-		Help:    "Whether users with only writer permission can modify the file's permissions. Not populated for items in shared drives.",
-		Type:    "boolean",
-		Example: "false",
-	},
-	"viewed-by-me": {
-		Help:     "Whether the file has been viewed by this user.",
-		Type:     "boolean",
-		Example:  "true",
-		ReadOnly: true,
-	},
-	"owner": {
-		Help:    "The owner of the file. Usually an email address. Enable with --drive-metadata-owner.",
-		Type:    "string",
-		Example: "user@example.com",
-	},
-	"permissions": {
-		Help:    "Permissions in a JSON dump of Google drive format. On shared drives these will only be present if they aren't inherited. Enable with --drive-metadata-permissions.",
-		Type:    "JSON",
-		Example: "{}",
-	},
-	"folder-color-rgb": {
-		Help:    "The color for a folder or a shortcut to a folder as an RGB hex string.",
-		Type:    "string",
-		Example: "881133",
-	},
-	"description": {
-		Help:    "A short description of the file.",
-		Type:    "string",
-		Example: "Contract for signing",
-	},
-	"starred": {
-		Help:    "Whether the user has starred the file.",
-		Type:    "boolean",
-		Example: "false",
-	},
-	"labels": {
-		Help:    "Labels attached to this file in a JSON dump of Googled drive format. Enable with --drive-metadata-labels.",
-		Type:    "JSON",
-		Example: "[]",
-	},
-}
-
-// Extra fields we need to fetch to implement the system metadata above
-var metadataFields = googleapi.Field(strings.Join([]string{
-	"copyRequiresWriterPermission",
-	"description",
-	"folderColorRgb",
-	"hasAugmentedPermissions",
-	"owners",
-	"permissionIds",
-	"permissions",
-	"properties",
-	"starred",
-	"viewedByMe",
-	"viewedByMeTime",
-	"writersCanShare",
-}, ","))
-
-// Fields we need to read from permissions
-var permissionsFields = googleapi.Field(strings.Join([]string{
-	"*",
-	"permissionDetails/*",
-}, ","))
-
-// getPermission returns permissions for the fileID and permissionID passed in
-func (f *Fs) getPermission(ctx context.Context, fileID, permissionID string, useCache bool) (perm *drive.Permission, inherited bool, err error) {
-	f.permissionsMu.Lock()
-	defer f.permissionsMu.Unlock()
-	if useCache {
-		perm = f.permissions[permissionID]
-		if perm != nil {
-			return perm, false, nil
-		}
-	}
-	fs.Debugf(f, "Fetching permission %q", permissionID)
-	err = f.pacer.Call(func() (bool, error) {
-		perm, err = f.svc.Permissions.Get(fileID, permissionID).
-			Fields(permissionsFields).
-			SupportsAllDrives(true).
-			Context(ctx).Do()
-		return f.shouldRetry(ctx, err)
-	})
-	if err != nil {
-		return nil, false, err
-	}
-
-	inherited = len(perm.PermissionDetails) > 0 && perm.PermissionDetails[0].Inherited
-
-	cleanPermission(perm)
-
-	// cache the permission
-	f.permissions[permissionID] = perm
-
-	return perm, inherited, err
-}
-
-// Set the permissions on the info
-func (f *Fs) setPermissions(ctx context.Context, info *drive.File, permissions []*drive.Permission) (err error) {
-	for _, perm := range permissions {
-		if perm.Role == "owner" {
-			// ignore owner permissions - these are set with owner
-			continue
-		}
-		cleanPermissionForWrite(perm)
-		err = f.pacer.Call(func() (bool, error) {
-			_, err = f.svc.Permissions.Create(info.Id, perm).
-				SupportsAllDrives(true).
-				Context(ctx).Do()
-			return f.shouldRetry(ctx, err)
-		})
-		if err != nil {
-			return fmt.Errorf("failed to set permission: %w", err)
-		}
-	}
-	return nil
-}
-
-// Clean attributes from permissions which we can't write
-func cleanPermissionForWrite(perm *drive.Permission) {
-	perm.Deleted = false
-	perm.DisplayName = ""
-	perm.Id = ""
-	perm.Kind = ""
-	perm.PermissionDetails = nil
-	perm.TeamDrivePermissionDetails = nil
-}
-
-// Clean and cache the permission if not already cached
-func (f *Fs) cleanAndCachePermission(perm *drive.Permission) {
-	f.permissionsMu.Lock()
-	defer f.permissionsMu.Unlock()
-	cleanPermission(perm)
-	if _, found := f.permissions[perm.Id]; !found {
-		f.permissions[perm.Id] = perm
-	}
-}
-
-// Clean fields we don't need to keep from the permission
-func cleanPermission(perm *drive.Permission) {
-	// DisplayName: Output only. The "pretty" name of the value of the
-	// permission. The following is a list of examples for each type of
-	// permission: * `user` - User's full name, as defined for their Google
-	// account, such as "Joe Smith." * `group` - Name of the Google Group,
-	// such as "The Company Administrators." * `domain` - String domain
-	// name, such as "thecompany.com." * `anyone` - No `displayName` is
-	// present.
-	perm.DisplayName = ""
-
-	// Kind: Output only. Identifies what kind of resource this is. Value:
-	// the fixed string "drive#permission".
-	perm.Kind = ""
-
-	// PermissionDetails: Output only. Details of whether the permissions on
-	// this shared drive item are inherited or directly on this item. This
-	// is an output-only field which is present only for shared drive items.
-	perm.PermissionDetails = nil
-
-	// PhotoLink: Output only. A link to the user's profile photo, if
-	// available.
-	perm.PhotoLink = ""
-
-	// TeamDrivePermissionDetails: Output only. Deprecated: Output only. Use
-	// `permissionDetails` instead.
-	perm.TeamDrivePermissionDetails = nil
-}
-
-// Fields we need to read from labels
-var labelsFields = googleapi.Field(strings.Join([]string{
-	"*",
-}, ","))
-
-// getLabels returns labels for the fileID passed in
-func (f *Fs) getLabels(ctx context.Context, fileID string) (labels []*drive.Label, err error) {
-	fs.Debugf(f, "Fetching labels for %q", fileID)
-	listLabels := f.svc.Files.ListLabels(fileID).
-		Fields(labelsFields).
-		Context(ctx)
-	for {
-		var info *drive.LabelList
-		err = f.pacer.Call(func() (bool, error) {
-			info, err = listLabels.Do()
-			return f.shouldRetry(ctx, err)
-		})
-		if err != nil {
-			return nil, err
-		}
-		labels = append(labels, info.Labels...)
-		if info.NextPageToken == "" {
-			break
-		}
-		listLabels.PageToken(info.NextPageToken)
-	}
-	for _, label := range labels {
-		cleanLabel(label)
-	}
-	return labels, nil
-}
-
-// Set the labels on the info
-func (f *Fs) setLabels(ctx context.Context, info *drive.File, labels []*drive.Label) (err error) {
-	if len(labels) == 0 {
-		return nil
-	}
-	req := drive.ModifyLabelsRequest{}
-	for _, label := range labels {
-		req.LabelModifications = append(req.LabelModifications, &drive.LabelModification{
-			FieldModifications: labelFieldsToFieldModifications(label.Fields),
-			LabelId:            label.Id,
-		})
-	}
-	err = f.pacer.Call(func() (bool, error) {
-		_, err = f.svc.Files.ModifyLabels(info.Id, &req).
-			Context(ctx).Do()
-		return f.shouldRetry(ctx, err)
-	})
-	if err != nil {
-		return fmt.Errorf("failed to set owner: %w", err)
-	}
-	return nil
-}
-
-// Convert label fields into something which can set the fields
-func labelFieldsToFieldModifications(fields map[string]drive.LabelField) (out []*drive.LabelFieldModification) {
-	for id, field := range fields {
-		var emails []string
-		for _, user := range field.User {
-			emails = append(emails, user.EmailAddress)
-		}
-		out = append(out, &drive.LabelFieldModification{
-			// FieldId: The ID of the field to be modified.
-			FieldId: id,
-
-			// SetDateValues: Replaces the value of a dateString Field with these
-			// new values. The string must be in the RFC 3339 full-date format:
-			// YYYY-MM-DD.
-			SetDateValues: field.DateString,
-
-			// SetIntegerValues: Replaces the value of an `integer` field with these
-			// new values.
-			SetIntegerValues: field.Integer,
-
-			// SetSelectionValues: Replaces a `selection` field with these new
-			// values.
-			SetSelectionValues: field.Selection,
-
-			// SetTextValues: Sets the value of a `text` field.
-			SetTextValues: field.Text,
-
-			// SetUserValues: Replaces a `user` field with these new values. The
-			// values must be valid email addresses.
-			SetUserValues: emails,
-		})
-	}
-	return out
-}
-
-// Clean fields we don't need to keep from the label
-func cleanLabel(label *drive.Label) {
-	// Kind: This is always drive#label
-	label.Kind = ""
-
-	for name, field := range label.Fields {
-		// Kind: This is always drive#labelField.
-		field.Kind = ""
-
-		// Note the fields are copies so we need to write them
-		// back to the map
-		label.Fields[name] = field
-	}
-}
-
-// Parse the metadata from drive item
-//
-// It should return nil if there is no Metadata
-func (o *baseObject) parseMetadata(ctx context.Context, info *drive.File) (err error) {
-	metadata := make(fs.Metadata, 16)
-
-	// Dump user metadata first as it overrides system metadata
-	for k, v := range info.Properties {
-		metadata[k] = v
-	}
-
-	// System metadata
-	metadata["copy-requires-writer-permission"] = fmt.Sprint(info.CopyRequiresWriterPermission)
-	metadata["writers-can-share"] = fmt.Sprint(info.WritersCanShare)
-	metadata["viewed-by-me"] = fmt.Sprint(info.ViewedByMe)
-	metadata["content-type"] = info.MimeType
-
-	// Owners: Output only. The owner of this file. Only certain legacy
-	// files may have more than one owner. This field isn't populated for
-	// items in shared drives.
-	if o.fs.opt.MetadataOwner.IsSet(rwRead) && len(info.Owners) > 0 {
-		user := info.Owners[0]
-		if len(info.Owners) > 1 {
-			fs.Logf(o, "Ignoring more than 1 owner")
-		}
-		if user != nil {
-			id := user.EmailAddress
-			if id == "" {
-				id = user.DisplayName
-			}
-			metadata["owner"] = id
-		}
-	}
-
-	if o.fs.opt.MetadataPermissions.IsSet(rwRead) {
-		// We only write permissions out if they are not inherited.
-		//
-		// On My Drives permissions seem to be attached to every item
-		// so they will always be written out.
-		//
-		// On Shared Drives only non-inherited permissions will be
-		// written out.
-
-		// To read the inherited permissions flag will mean we need to
-		// read the permissions for each object and the cache will be
-		// useless. However shared drives don't return permissions
-		// only permissionIds so will need to fetch them for each
-		// object. We use HasAugmentedPermissions to see if there are
-		// special permissions before fetching them to save transactions.
-
-		// HasAugmentedPermissions: Output only. Whether there are permissions
-		// directly on this file. This field is only populated for items in
-		// shared drives.
-		if o.fs.isTeamDrive && !info.HasAugmentedPermissions {
-			// Don't process permissions if there aren't any specifically set
-			info.Permissions = nil
-			info.PermissionIds = nil
-		}
-
-		// PermissionIds: Output only. List of permission IDs for users with
-		// access to this file.
-		//
-		// Only process these if we have no Permissions
-		if len(info.PermissionIds) > 0 && len(info.Permissions) == 0 {
-			info.Permissions = make([]*drive.Permission, 0, len(info.PermissionIds))
-			g, gCtx := errgroup.WithContext(ctx)
-			g.SetLimit(o.fs.ci.Checkers)
-			var mu sync.Mutex // protect the info.Permissions from concurrent writes
-			for _, permissionID := range info.PermissionIds {
-				permissionID := permissionID
-				g.Go(func() error {
-					// must fetch the team drive ones individually to check the inherited flag
-					perm, inherited, err := o.fs.getPermission(gCtx, actualID(info.Id), permissionID, !o.fs.isTeamDrive)
-					if err != nil {
-						return fmt.Errorf("failed to read permission: %w", err)
-					}
-					// Don't write inherited permissions out
-					if inherited {
-						return nil
-					}
-					// Don't write owner role out - these are covered by the owner metadata
-					if perm.Role == "owner" {
-						return nil
-					}
-					mu.Lock()
-					info.Permissions = append(info.Permissions, perm)
-					mu.Unlock()
-					return nil
-				})
-			}
-			err = g.Wait()
-			if err != nil {
-				return err
-			}
-		} else {
-			// Clean the fetched permissions
-			for _, perm := range info.Permissions {
-				o.fs.cleanAndCachePermission(perm)
-			}
-		}
-
-		// Permissions: Output only. The full list of permissions for the file.
-		// This is only available if the requesting user can share the file. Not
-		// populated for items in shared drives.
-		if len(info.Permissions) > 0 {
-			buf, err := json.Marshal(info.Permissions)
-			if err != nil {
-				return fmt.Errorf("failed to marshal permissions: %w", err)
-			}
-			metadata["permissions"] = string(buf)
-		}
-
-		// Permission propagation
-		// https://developers.google.com/drive/api/guides/manage-sharing#permission-propagation
-		// Leads me to believe that in non shared drives, permissions
-		// are added to each item when you set permissions for a
-		// folder whereas in shared drives they are inherited and
-		// placed on the item directly.
-	}
-
-	if info.FolderColorRgb != "" {
-		metadata["folder-color-rgb"] = info.FolderColorRgb
-	}
-	if info.Description != "" {
-		metadata["description"] = info.Description
-	}
-	metadata["starred"] = fmt.Sprint(info.Starred)
-	metadata["btime"] = info.CreatedTime
-	metadata["mtime"] = info.ModifiedTime
-
-	if o.fs.opt.MetadataLabels.IsSet(rwRead) {
-		// FIXME would be really nice if we knew if files had labels
-		// before listing but we need to know all possible label IDs
-		// to get it in the listing.
-
-		labels, err := o.fs.getLabels(ctx, actualID(info.Id))
-		if err != nil {
-			return fmt.Errorf("failed to fetch labels: %w", err)
-		}
-		buf, err := json.Marshal(labels)
-		if err != nil {
-			return fmt.Errorf("failed to marshal labels: %w", err)
-		}
-		metadata["labels"] = string(buf)
-	}
-
-	o.metadata = &metadata
-	return nil
-}
-
-// Set the owner on the info
-func (f *Fs) setOwner(ctx context.Context, info *drive.File, owner string) (err error) {
-	perm := drive.Permission{
-		Role:         "owner",
-		EmailAddress: owner,
-		// Type: The type of the grantee. Valid values are: * `user` * `group` *
-		// `domain` * `anyone` When creating a permission, if `type` is `user`
-		// or `group`, you must provide an `emailAddress` for the user or group.
-		// When `type` is `domain`, you must provide a `domain`. There isn't
-		// extra information required for an `anyone` type.
-		Type: "user",
-	}
-	err = f.pacer.Call(func() (bool, error) {
-		_, err = f.svc.Permissions.Create(info.Id, &perm).
-			SupportsAllDrives(true).
-			TransferOwnership(true).
-			// SendNotificationEmail(false). - required apparently!
-			Context(ctx).Do()
-		return f.shouldRetry(ctx, err)
-	})
-	if err != nil {
-		return fmt.Errorf("failed to set owner: %w", err)
-	}
-	return nil
-}
-
-// Call back to set metadata that can't be set on the upload/update
-//
-// The *drive.File passed in holds the current state of the drive.File
-// and this should update it with any modifications.
-type updateMetadataFn func(context.Context, *drive.File) error
-
-// read the metadata from meta and write it into updateInfo
-//
-// update should be true if this is being used to create metadata for
-// an update/PATCH call as the rules on what can be updated are
-// slightly different there.
-//
-// It returns a callback which should be called to finish the updates
-// after the data is uploaded.
-func (f *Fs) updateMetadata(ctx context.Context, updateInfo *drive.File, meta fs.Metadata, update bool) (callback updateMetadataFn, err error) {
-	callbackFns := []updateMetadataFn{}
-	callback = func(ctx context.Context, info *drive.File) error {
-		for _, fn := range callbackFns {
-			err := fn(ctx, info)
-			if err != nil {
-				return err
-			}
-		}
-		return nil
-	}
-	// merge metadata into request and user metadata
-	for k, v := range meta {
-		k, v := k, v
-		// parse a boolean from v and write into out
-		parseBool := func(out *bool) error {
-			b, err := strconv.ParseBool(v)
-			if err != nil {
-				return fmt.Errorf("can't parse metadata %q = %q: %w", k, v, err)
-			}
-			*out = b
-			return nil
-		}
-		switch k {
-		case "copy-requires-writer-permission":
-			if err := parseBool(&updateInfo.CopyRequiresWriterPermission); err != nil {
-				return nil, err
-			}
-		case "writers-can-share":
-			if err := parseBool(&updateInfo.WritersCanShare); err != nil {
-				return nil, err
-			}
-		case "viewed-by-me":
-			// Can't write this
-		case "content-type":
-			updateInfo.MimeType = v
-		case "owner":
-			if !f.opt.MetadataOwner.IsSet(rwWrite) {
-				continue
-			}
-			// Can't set Owner on upload so need to set afterwards
-			callbackFns = append(callbackFns, func(ctx context.Context, info *drive.File) error {
-				return f.setOwner(ctx, info, v)
-			})
-		case "permissions":
-			if !f.opt.MetadataPermissions.IsSet(rwWrite) {
-				continue
-			}
-			var perms []*drive.Permission
-			err := json.Unmarshal([]byte(v), &perms)
-			if err != nil {
-				return nil, fmt.Errorf("failed to unmarshal permissions: %w", err)
-			}
-			// Can't set Permissions on upload so need to set afterwards
-			callbackFns = append(callbackFns, func(ctx context.Context, info *drive.File) error {
-				return f.setPermissions(ctx, info, perms)
-			})
-		case "labels":
-			if !f.opt.MetadataLabels.IsSet(rwWrite) {
-				continue
-			}
-			var labels []*drive.Label
-			err := json.Unmarshal([]byte(v), &labels)
-			if err != nil {
-				return nil, fmt.Errorf("failed to unmarshal labels: %w", err)
-			}
-			// Can't set Labels on upload so need to set afterwards
-			callbackFns = append(callbackFns, func(ctx context.Context, info *drive.File) error {
-				return f.setLabels(ctx, info, labels)
-			})
-		case "folder-color-rgb":
-			updateInfo.FolderColorRgb = v
-		case "description":
-			updateInfo.Description = v
-		case "starred":
-			if err := parseBool(&updateInfo.Starred); err != nil {
-				return nil, err
-			}
-		case "btime":
-			if update {
-				fs.Debugf(f, "Skipping btime metadata as can't update it on an existing file: %v", v)
-			} else {
-				updateInfo.CreatedTime = v
-			}
-		case "mtime":
-			updateInfo.ModifiedTime = v
-		default:
-			if updateInfo.Properties == nil {
-				updateInfo.Properties = make(map[string]string, 1)
-			}
-			updateInfo.Properties[k] = v
-		}
-	}
-	return callback, nil
-}
-
-// Fetch metadata and update updateInfo if --metadata is in use
-func (f *Fs) fetchAndUpdateMetadata(ctx context.Context, src fs.ObjectInfo, options []fs.OpenOption, updateInfo *drive.File, update bool) (callback updateMetadataFn, err error) {
-	meta, err := fs.GetMetadataOptions(ctx, f, src, options)
-	if err != nil {
-		return nil, fmt.Errorf("failed to read metadata from source object: %w", err)
-	}
-	callback, err = f.updateMetadata(ctx, updateInfo, meta, update)
-	if err != nil {
-		return nil, fmt.Errorf("failed to update metadata from source object: %w", err)
-	}
-	return callback, nil
-}

backend/dropbox/batcher.go

@@ -8,19 +8,121 @@ package dropbox
 
 import (
 	"context"
+	"errors"
 	"fmt"
+	"sync"
+	"time"
 
 	"github.com/dropbox/dropbox-sdk-go-unofficial/v6/dropbox/files"
+	"github.com/rclone/rclone/fs"
 	"github.com/rclone/rclone/fs/fserrors"
+	"github.com/rclone/rclone/lib/atexit"
 )
 
+const (
+	maxBatchSize          = 1000                   // max size the batch can be
+	defaultTimeoutSync    = 500 * time.Millisecond // kick off the batch if nothing added for this long (sync)
+	defaultTimeoutAsync   = 10 * time.Second       // kick off the batch if nothing added for this long (ssync)
+	defaultBatchSizeAsync = 100                    // default batch size if async
+)
+
+// batcher holds info about the current items waiting for upload
+type batcher struct {
+	f        *Fs                 // Fs this batch is part of
+	mode     string              // configured batch mode
+	size     int                 // maximum size for batch
+	timeout  time.Duration       // idle timeout for batch
+	async    bool                // whether we are using async batching
+	in       chan batcherRequest // incoming items to batch
+	closed   chan struct{}       // close to indicate batcher shut down
+	atexit   atexit.FnHandle     // atexit handle
+	shutOnce sync.Once           // make sure we shutdown once only
+	wg       sync.WaitGroup      // wait for shutdown
+}
+
+// batcherRequest holds an incoming request with a place for a reply
+type batcherRequest struct {
+	commitInfo *files.UploadSessionFinishArg
+	result     chan<- batcherResponse
+}
+
+// Return true if batcherRequest is the quit request
+func (br *batcherRequest) isQuit() bool {
+	return br.commitInfo == nil
+}
+
+// Send this to get the engine to quit
+var quitRequest = batcherRequest{}
+
+// batcherResponse holds a response to be delivered to clients waiting
+// for a batch to complete.
+type batcherResponse struct {
+	err   error
+	entry *files.FileMetadata
+}
+
+// newBatcher creates a new batcher structure
+func newBatcher(ctx context.Context, f *Fs, mode string, size int, timeout time.Duration) (*batcher, error) {
+	// fs.Debugf(f, "Creating batcher with mode %q, size %d, timeout %v", mode, size, timeout)
+	if size > maxBatchSize || size < 0 {
+		return nil, fmt.Errorf("dropbox: batch size must be < %d and >= 0 - it is currently %d", maxBatchSize, size)
+	}
+
+	async := false
+
+	switch mode {
+	case "sync":
+		if size <= 0 {
+			ci := fs.GetConfig(ctx)
+			size = ci.Transfers
+		}
+		if timeout <= 0 {
+			timeout = defaultTimeoutSync
+		}
+	case "async":
+		if size <= 0 {
+			size = defaultBatchSizeAsync
+		}
+		if timeout <= 0 {
+			timeout = defaultTimeoutAsync
+		}
+		async = true
+	case "off":
+		size = 0
+	default:
+		return nil, fmt.Errorf("dropbox: batch mode must be sync|async|off not %q", mode)
+	}
+
+	b := &batcher{
+		f:       f,
+		mode:    mode,
+		size:    size,
+		timeout: timeout,
+		async:   async,
+		in:      make(chan batcherRequest, size),
+		closed:  make(chan struct{}),
+	}
+	if b.Batching() {
+		b.atexit = atexit.Register(b.Shutdown)
+		b.wg.Add(1)
+		go b.commitLoop(context.Background())
+	}
+	return b, nil
+
+}
+
+// Batching returns true if batching is active
+func (b *batcher) Batching() bool {
+	return b.size > 0
+}
+
 // finishBatch commits the batch, returning a batch status to poll or maybe complete
-func (f *Fs) finishBatch(ctx context.Context, items []*files.UploadSessionFinishArg) (complete *files.UploadSessionFinishBatchResult, err error) {
+func (b *batcher) finishBatch(ctx context.Context, items []*files.UploadSessionFinishArg) (complete *files.UploadSessionFinishBatchResult, err error) {
 	var arg = &files.UploadSessionFinishBatchArg{
 		Entries: items,
 	}
-	err = f.pacer.Call(func() (bool, error) {
-		complete, err = f.srv.UploadSessionFinishBatchV2(arg)
+	err = b.f.pacer.Call(func() (bool, error) {
+		complete, err = b.f.srv.UploadSessionFinishBatchV2(arg)
 		// If error is insufficient space then don't retry
 		if e, ok := err.(files.UploadSessionFinishAPIError); ok {
 			if e.EndpointError != nil && e.EndpointError.Path != nil && e.EndpointError.Path.Tag == files.WriteErrorInsufficientSpace {
@@ -37,10 +139,23 @@ func (f *Fs) finishBatch(ctx context.Context, items []*files.UploadSessionFinish
 	return complete, nil
 }
 
-// Called by the batcher to commit a batch
-func (f *Fs) commitBatch(ctx context.Context, items []*files.UploadSessionFinishArg, results []*files.FileMetadata, errors []error) (err error) {
+// commit a batch
+func (b *batcher) commitBatch(ctx context.Context, items []*files.UploadSessionFinishArg, results []chan<- batcherResponse) (err error) {
+	// If commit fails then signal clients if sync
+	var signalled = b.async
+	defer func() {
+		if err != nil && !signalled {
+			// Signal to clients that there was an error
+			for _, result := range results {
+				result <- batcherResponse{err: err}
+			}
+		}
+	}()
+	desc := fmt.Sprintf("%s batch length %d starting with: %s", b.mode, len(items), items[0].Commit.Path)
+	fs.Debugf(b.f, "Committing %s", desc)
+
 	// finalise the batch getting either a result or a job id to poll
-	complete, err := f.finishBatch(ctx, items)
+	complete, err := b.finishBatch(ctx, items)
 	if err != nil {
 		return err
 	}
@@ -51,13 +166,19 @@ func (f *Fs) commitBatch(ctx context.Context, items []*files.UploadSessionFinish
 		return fmt.Errorf("expecting %d items in batch but got %d", len(results), len(entries))
 	}
 
-	// Format results for return
+	// Report results to clients
+	var (
+		errorTag   = ""
+		errorCount = 0
+	)
 	for i := range results {
 		item := entries[i]
+		resp := batcherResponse{}
 		if item.Tag == "success" {
-			results[i] = item.Success
+			resp.entry = item.Success
 		} else {
-			errorTag := item.Tag
+			errorCount++
+			errorTag = item.Tag
 			if item.Failure != nil {
 				errorTag = item.Failure.Tag
 				if item.Failure.LookupFailed != nil {
@@ -70,9 +191,112 @@ func (f *Fs) commitBatch(ctx context.Context, items []*files.UploadSessionFinish
 					errorTag += "/" + item.Failure.PropertiesError.Tag
 				}
 			}
-			errors[i] = fmt.Errorf("upload failed: %s", errorTag)
+			resp.err = fmt.Errorf("batch upload failed: %s", errorTag)
+		}
+		if !b.async {
+			results[i] <- resp
 		}
 	}
+	// Show signalled so no need to report error to clients from now on
+	signalled = true
 
+	// Report an error if any failed in the batch
+	if errorTag != "" {
+		return fmt.Errorf("batch had %d errors: last error: %s", errorCount, errorTag)
+	}
+
+	fs.Debugf(b.f, "Committed %s", desc)
 	return nil
 }
+
+// commitLoop runs the commit engine in the background
+func (b *batcher) commitLoop(ctx context.Context) {
+	var (
+		items     []*files.UploadSessionFinishArg // current batch of uncommitted files
+		results   []chan<- batcherResponse        // current batch of clients awaiting results
+		idleTimer = time.NewTimer(b.timeout)
+		commit    = func() {
+			err := b.commitBatch(ctx, items, results)
+			if err != nil {
+				fs.Errorf(b.f, "%s batch commit: failed to commit batch length %d: %v", b.mode, len(items), err)
+			}
+			items, results = nil, nil
+		}
+	)
+	defer b.wg.Done()
+	defer idleTimer.Stop()
+	idleTimer.Stop()
+
+outer:
+	for {
+		select {
+		case req := <-b.in:
+			if req.isQuit() {
+				break outer
+			}
+			items = append(items, req.commitInfo)
+			results = append(results, req.result)
+			idleTimer.Stop()
+			if len(items) >= b.size {
+				commit()
+			} else {
+				idleTimer.Reset(b.timeout)
+			}
+		case <-idleTimer.C:
+			if len(items) > 0 {
+				fs.Debugf(b.f, "Batch idle for %v so committing", b.timeout)
+				commit()
+			}
+		}
+
+	}
+	// commit any remaining items
+	if len(items) > 0 {
+		commit()
+	}
+}
+
+// Shutdown finishes any pending batches then shuts everything down
+//
+// Can be called from atexit handler
+func (b *batcher) Shutdown() {
+	if !b.Batching() {
+		return
+	}
+	b.shutOnce.Do(func() {
+		atexit.Unregister(b.atexit)
+		fs.Infof(b.f, "Committing uploads - please wait...")
+		// show that batcher is shutting down
+		close(b.closed)
+		// quit the commitLoop by sending a quitRequest message
+		//
+		// Note that we don't close b.in because that will
+		// cause write to closed channel in Commit when we are
+		// exiting due to a signal.
+		b.in <- quitRequest
+		b.wg.Wait()
+	})
+}
+
+// Commit commits the file using a batch call, first adding it to the
+// batch and then waiting for the batch to complete in a synchronous
+// way if async is not set.
+func (b *batcher) Commit(ctx context.Context, commitInfo *files.UploadSessionFinishArg) (entry *files.FileMetadata, err error) {
+	select {
+	case <-b.closed:
+		return nil, fserrors.FatalError(errors.New("batcher is shutting down"))
+	default:
+	}
+	fs.Debugf(b.f, "Adding %q to batch", commitInfo.Commit.Path)
+	resp := make(chan batcherResponse, 1)
+	b.in <- batcherRequest{
+		commitInfo: commitInfo,
+		result:     resp,
+	}
+	// If running async then don't wait for the result
+	if b.async {
+		return nil, nil
+	}
+	result := <-resp
+	return result.entry, result.err
+}

backend/dropbox/dropbox.go

@@ -47,7 +47,6 @@ import (
 	"github.com/rclone/rclone/fs/config/obscure"
 	"github.com/rclone/rclone/fs/fserrors"
 	"github.com/rclone/rclone/fs/hash"
-	"github.com/rclone/rclone/lib/batcher"
 	"github.com/rclone/rclone/lib/encoder"
 	"github.com/rclone/rclone/lib/oauthutil"
 	"github.com/rclone/rclone/lib/pacer"
@@ -122,14 +121,6 @@ var (
 
 	// Errors
 	errNotSupportedInSharedMode = fserrors.NoRetryError(errors.New("not supported in shared files mode"))
-
-	// Configure the batcher
-	defaultBatcherOptions = batcher.Options{
-		MaxBatchSize:          1000,
-		DefaultTimeoutSync:    500 * time.Millisecond,
-		DefaultTimeoutAsync:   10 * time.Second,
-		DefaultBatchSizeAsync: 100,
-	}
 )
 
 // Gets an oauth config with the right scopes
@@ -161,7 +152,7 @@ func init() {
 				},
 			})
 		},
-		Options: append(append(oauthutil.SharedOptions, []fs.Option{{
+		Options: append(oauthutil.SharedOptions, []fs.Option{{
 			Name: "chunk_size",
 			Help: fmt.Sprintf(`Upload chunk size (< %v).
 
@@ -219,6 +210,68 @@ Note that we don't unmount the shared folder afterwards so the
 shared folder.`,
 			Default:  false,
 			Advanced: true,
+		}, {
+			Name: "batch_mode",
+			Help: `Upload file batching sync|async|off.
+
+This sets the batch mode used by rclone.
+
+For full info see [the main docs](https://rclone.org/dropbox/#batch-mode)
+
+This has 3 possible values
+
+- off - no batching
+- sync - batch uploads and check completion (default)
+- async - batch upload and don't check completion
+
+Rclone will close any outstanding batches when it exits which may make
+a delay on quit.
+`,
+			Default:  "sync",
+			Advanced: true,
+		}, {
+			Name: "batch_size",
+			Help: `Max number of files in upload batch.
+
+This sets the batch size of files to upload. It has to be less than 1000.
+
+By default this is 0 which means rclone which calculate the batch size
+depending on the setting of batch_mode.
+
+- batch_mode: async - default batch_size is 100
+- batch_mode: sync - default batch_size is the same as --transfers
+- batch_mode: off - not in use
+
+Rclone will close any outstanding batches when it exits which may make
+a delay on quit.
+
+Setting this is a great idea if you are uploading lots of small files
+as it will make them a lot quicker. You can use --transfers 32 to
+maximise throughput.
+`,
+			Default:  0,
+			Advanced: true,
+		}, {
+			Name: "batch_timeout",
+			Help: `Max time to allow an idle upload batch before uploading.
+
+If an upload batch is idle for more than this long then it will be
+uploaded.
+
+The default for this is 0 which means rclone will choose a sensible
+default based on the batch_mode in use.
+
+- batch_mode: async - default batch_timeout is 10s
+- batch_mode: sync - default batch_timeout is 500ms
+- batch_mode: off - not in use
+`,
+			Default:  fs.Duration(0),
+			Advanced: true,
+		}, {
+			Name:     "batch_commit_timeout",
+			Help:     `Max time to wait for a batch to finish committing`,
+			Default:  fs.Duration(10 * time.Minute),
+			Advanced: true,
 		}, {
 			Name:     "pacer_min_sleep",
 			Default:  defaultMinSleep,
@@ -237,22 +290,23 @@ shared folder.`,
 				encoder.EncodeDel |
 				encoder.EncodeRightSpace |
 				encoder.EncodeInvalidUtf8,
-		}}...), defaultBatcherOptions.FsOptions("For full info see [the main docs](https://rclone.org/dropbox/#batch-mode)\n\n")...),
+		}}...),
 	})
 }
 
 // Options defines the configuration for this backend
 type Options struct {
-	ChunkSize     fs.SizeSuffix        `config:"chunk_size"`
-	Impersonate   string               `config:"impersonate"`
-	SharedFiles   bool                 `config:"shared_files"`
-	SharedFolders bool                 `config:"shared_folders"`
-	BatchMode     string               `config:"batch_mode"`
-	BatchSize     int                  `config:"batch_size"`
-	BatchTimeout  fs.Duration          `config:"batch_timeout"`
-	AsyncBatch    bool                 `config:"async_batch"`
-	PacerMinSleep fs.Duration          `config:"pacer_min_sleep"`
-	Enc           encoder.MultiEncoder `config:"encoding"`
+	ChunkSize          fs.SizeSuffix        `config:"chunk_size"`
+	Impersonate        string               `config:"impersonate"`
+	SharedFiles        bool                 `config:"shared_files"`
+	SharedFolders      bool                 `config:"shared_folders"`
+	BatchMode          string               `config:"batch_mode"`
+	BatchSize          int                  `config:"batch_size"`
+	BatchTimeout       fs.Duration          `config:"batch_timeout"`
+	BatchCommitTimeout fs.Duration          `config:"batch_commit_timeout"`
+	AsyncBatch         bool                 `config:"async_batch"`
+	PacerMinSleep      fs.Duration          `config:"pacer_min_sleep"`
+	Enc                encoder.MultiEncoder `config:"encoding"`
 }
 
 // Fs represents a remote dropbox server
@@ -271,7 +325,7 @@ type Fs struct {
 	slashRootSlash string         // root with "/" prefix and postfix, lowercase
 	pacer          *fs.Pacer      // To pace the API calls
 	ns             string         // The namespace we are using or "" for none
-	batcher        *batcher.Batcher[*files.UploadSessionFinishArg, *files.FileMetadata]
+	batcher        *batcher       // batch builder
 }
 
 // Object describes a dropbox object
@@ -397,11 +451,7 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		ci:    ci,
 		pacer: fs.NewPacer(ctx, pacer.NewDefault(pacer.MinSleep(opt.PacerMinSleep), pacer.MaxSleep(maxSleep), pacer.DecayConstant(decayConstant))),
 	}
-	batcherOptions := defaultBatcherOptions
-	batcherOptions.Mode = f.opt.BatchMode
-	batcherOptions.Size = f.opt.BatchSize
-	batcherOptions.Timeout = time.Duration(f.opt.BatchTimeout)
-	f.batcher, err = batcher.New(ctx, f, f.commitBatch, batcherOptions)
+	f.batcher, err = newBatcher(ctx, f, f.opt.BatchMode, f.opt.BatchSize, time.Duration(f.opt.BatchTimeout))
 	if err != nil {
 		return nil, err
 	}
@@ -946,7 +996,6 @@ func (f *Fs) purgeCheck(ctx context.Context, dir string, check bool) (err error)
 	if root == "/" {
 		return errors.New("can't remove root directory")
 	}
-	encRoot := f.opt.Enc.FromStandardPath(root)
 
 	if check {
 		// check directory exists
@@ -955,9 +1004,10 @@ func (f *Fs) purgeCheck(ctx context.Context, dir string, check bool) (err error)
 			return fmt.Errorf("Rmdir: %w", err)
 		}
 
+		root = f.opt.Enc.FromStandardPath(root)
 		// check directory empty
 		arg := files.ListFolderArg{
-			Path:      encRoot,
+			Path:      root,
 			Recursive: false,
 		}
 		if root == "/" {
@@ -978,7 +1028,7 @@ func (f *Fs) purgeCheck(ctx context.Context, dir string, check bool) (err error)
 
 	// remove it
 	err = f.pacer.Call(func() (bool, error) {
-		_, err = f.srv.DeleteV2(&files.DeleteArg{Path: encRoot})
+		_, err = f.srv.DeleteV2(&files.DeleteArg{Path: root})
 		return shouldRetry(ctx, err)
 	})
 	return err
@@ -1231,21 +1281,18 @@ func (f *Fs) About(ctx context.Context) (usage *fs.Usage, err error) {
 		return nil, err
 	}
 	var total uint64
-	var used = q.Used
 	if q.Allocation != nil {
 		if q.Allocation.Individual != nil {
 			total += q.Allocation.Individual.Allocated
 		}
 		if q.Allocation.Team != nil {
 			total += q.Allocation.Team.Allocated
-			// Override used with Team.Used as this includes q.Used already
-			used = q.Allocation.Team.Used
 		}
 	}
 	usage = &fs.Usage{
-		Total: fs.NewUsageValue(int64(total)),        // quota of bytes that can be used
-		Used:  fs.NewUsageValue(int64(used)),         // bytes in use
-		Free:  fs.NewUsageValue(int64(total - used)), // bytes which can be uploaded before reaching the quota
+		Total: fs.NewUsageValue(int64(total)),          // quota of bytes that can be used
+		Used:  fs.NewUsageValue(int64(q.Used)),         // bytes in use
+		Free:  fs.NewUsageValue(int64(total - q.Used)), // bytes which can be uploaded before reaching the quota
 	}
 	return usage, nil
 }
@@ -1675,7 +1722,7 @@ func (o *Object) uploadChunked(ctx context.Context, in0 io.Reader, commitInfo *f
 	// If we are batching then we should have written all the data now
 	// store the commit info now for a batch commit
 	if o.fs.batcher.Batching() {
-		return o.fs.batcher.Commit(ctx, o.remote, args)
+		return o.fs.batcher.Commit(ctx, args)
 	}
 
 	err = o.fs.pacer.Call(func() (bool, error) {

backend/googlecloudstorage/googlecloudstorage.go

@@ -1310,11 +1310,10 @@ func (o *Object) Storable() bool {
 
 // Open an object for read
 func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.ReadCloser, err error) {
-	url := o.url
 	if o.fs.opt.UserProject != "" {
-		url += "&userProject=" + o.fs.opt.UserProject
+		o.url = o.url + "&userProject=" + o.fs.opt.UserProject
 	}
-	req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
+	req, err := http.NewRequestWithContext(ctx, "GET", o.url, nil)
 	if err != nil {
 		return nil, err
 	}

backend/googlephotos/googlephotos.go

@@ -29,7 +29,6 @@ import (
 	"github.com/rclone/rclone/fs/fshttp"
 	"github.com/rclone/rclone/fs/hash"
 	"github.com/rclone/rclone/fs/log"
-	"github.com/rclone/rclone/lib/batcher"
 	"github.com/rclone/rclone/lib/encoder"
 	"github.com/rclone/rclone/lib/oauthutil"
 	"github.com/rclone/rclone/lib/pacer"
@@ -72,14 +71,6 @@ var (
 		ClientSecret: obscure.MustReveal(rcloneEncryptedClientSecret),
 		RedirectURL:  oauthutil.RedirectURL,
 	}
-
-	// Configure the batcher
-	defaultBatcherOptions = batcher.Options{
-		MaxBatchSize:          50,
-		DefaultTimeoutSync:    1000 * time.Millisecond,
-		DefaultTimeoutAsync:   10 * time.Second,
-		DefaultBatchSizeAsync: 50,
-	}
 )
 
 // Register with Fs
@@ -120,7 +111,7 @@ will count towards storage in your Google Account.`)
 			}
 			return nil, fmt.Errorf("unknown state %q", config.State)
 		},
-		Options: append(append(oauthutil.SharedOptions, []fs.Option{{
+		Options: append(oauthutil.SharedOptions, []fs.Option{{
 			Name:    "read_only",
 			Default: false,
 			Help: `Set to make the Google Photos backend read only.
@@ -167,7 +158,7 @@ listings and won't be transferred.`,
 			Default: (encoder.Base |
 				encoder.EncodeCrLf |
 				encoder.EncodeInvalidUtf8),
-		}}...), defaultBatcherOptions.FsOptions("")...),
+		}}...),
 	})
 }
 
@@ -178,9 +169,6 @@ type Options struct {
 	StartYear       int                  `config:"start_year"`
 	IncludeArchived bool                 `config:"include_archived"`
 	Enc             encoder.MultiEncoder `config:"encoding"`
-	BatchMode       string               `config:"batch_mode"`
-	BatchSize       int                  `config:"batch_size"`
-	BatchTimeout    fs.Duration          `config:"batch_timeout"`
 }
 
 // Fs represents a remote storage server
@@ -199,7 +187,6 @@ type Fs struct {
 	uploadedMu sync.Mutex             // to protect the below
 	uploaded   dirtree.DirTree        // record of uploaded items
 	createMu   sync.Mutex             // held when creating albums to prevent dupes
-	batcher    *batcher.Batcher[uploadedItem, *api.MediaItem]
 }
 
 // Object describes a storage object
@@ -325,14 +312,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		albums:    map[bool]*albums{},
 		uploaded:  dirtree.New(),
 	}
-	batcherOptions := defaultBatcherOptions
-	batcherOptions.Mode = f.opt.BatchMode
-	batcherOptions.Size = f.opt.BatchSize
-	batcherOptions.Timeout = time.Duration(f.opt.BatchTimeout)
-	f.batcher, err = batcher.New(ctx, f, f.commitBatch, batcherOptions)
-	if err != nil {
-		return nil, err
-	}
 	f.features = (&fs.Features{
 		ReadMimeType: true,
 	}).Fill(ctx, f)
@@ -802,13 +781,6 @@ func (f *Fs) Hashes() hash.Set {
 	return hash.Set(hash.None)
 }
 
-// Shutdown the backend, closing any background tasks and any
-// cached connections.
-func (f *Fs) Shutdown(ctx context.Context) error {
-	f.batcher.Shutdown()
-	return nil
-}
-
 // ------------------------------------------------------------
 
 // Fs returns the parent Fs
@@ -989,82 +961,6 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Read
 	return resp.Body, err
 }
 
-// input to the batcher
-type uploadedItem struct {
-	AlbumID     string // desired album
-	UploadToken string // upload ID
-}
-
-// Commit a batch of items to albumID returning the errors in errors
-func (f *Fs) commitBatchAlbumID(ctx context.Context, items []uploadedItem, results []*api.MediaItem, errors []error, albumID string) {
-	// Create the media item from an UploadToken, optionally adding to an album
-	opts := rest.Opts{
-		Method: "POST",
-		Path:   "/mediaItems:batchCreate",
-	}
-	var request = api.BatchCreateRequest{
-		AlbumID: albumID,
-	}
-	itemsInBatch := 0
-	for i := range items {
-		if items[i].AlbumID == albumID {
-			request.NewMediaItems = append(request.NewMediaItems, api.NewMediaItem{
-				SimpleMediaItem: api.SimpleMediaItem{
-					UploadToken: items[i].UploadToken,
-				},
-			})
-			itemsInBatch++
-		}
-	}
-	var result api.BatchCreateResponse
-	var resp *http.Response
-	var err error
-	err = f.pacer.Call(func() (bool, error) {
-		resp, err = f.srv.CallJSON(ctx, &opts, request, &result)
-		return shouldRetry(ctx, resp, err)
-	})
-	if err != nil {
-		err = fmt.Errorf("failed to create media item: %w", err)
-	}
-	if err == nil && len(result.NewMediaItemResults) != itemsInBatch {
-		err = fmt.Errorf("bad response to BatchCreate expecting %d items but got %d", itemsInBatch, len(result.NewMediaItemResults))
-	}
-	j := 0
-	for i := range items {
-		if items[i].AlbumID == albumID {
-			if err == nil {
-				media := &result.NewMediaItemResults[j]
-				if media.Status.Code != 0 {
-					errors[i] = fmt.Errorf("upload failed: %s (%d)", media.Status.Message, media.Status.Code)
-				} else {
-					results[i] = &media.MediaItem
-				}
-			} else {
-				errors[i] = err
-			}
-			j++
-		}
-	}
-}
-
-// Called by the batcher to commit a batch
-func (f *Fs) commitBatch(ctx context.Context, items []uploadedItem, results []*api.MediaItem, errors []error) (err error) {
-	// Discover all the AlbumIDs as we have to upload these separately
-	//
-	// Should maybe have one batcher per AlbumID
-	albumIDs := map[string]struct{}{}
-	for i := range items {
-		albumIDs[items[i].AlbumID] = struct{}{}
-	}
-
-	// batch the albums
-	for albumID := range albumIDs {
-		// errors returned in errors
-		f.commitBatchAlbumID(ctx, items, results, errors, albumID)
-	}
-	return nil
-}
-
 // Update the object with the contents of the io.Reader, modTime and size
 //
 // The new object may have been created if an error is returned
@@ -1125,29 +1021,37 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		return errors.New("empty upload token")
 	}
 
-	uploaded := uploadedItem{
-		AlbumID:     albumID,
-		UploadToken: uploadToken,
+	// Create the media item from an UploadToken, optionally adding to an album
+	opts = rest.Opts{
+		Method: "POST",
+		Path:   "/mediaItems:batchCreate",
 	}
-
-	// Save the upload into an album
-	var info *api.MediaItem
-	if o.fs.batcher.Batching() {
-		info, err = o.fs.batcher.Commit(ctx, o.remote, uploaded)
-	} else {
-		errors := make([]error, 1)
-		results := make([]*api.MediaItem, 1)
-		err = o.fs.commitBatch(ctx, []uploadedItem{uploaded}, results, errors)
-		if err != nil {
-			err = errors[0]
-			info = results[0]
-		}
+	var request = api.BatchCreateRequest{
+		AlbumID: albumID,
+		NewMediaItems: []api.NewMediaItem{
+			{
+				SimpleMediaItem: api.SimpleMediaItem{
+					UploadToken: uploadToken,
+				},
+			},
+		},
 	}
+	var result api.BatchCreateResponse
+	err = o.fs.pacer.Call(func() (bool, error) {
+		resp, err = o.fs.srv.CallJSON(ctx, &opts, request, &result)
+		return shouldRetry(ctx, resp, err)
+	})
 	if err != nil {
-		return fmt.Errorf("failed to commit batch: %w", err)
+		return fmt.Errorf("failed to create media item: %w", err)
 	}
-
-	o.setMetaData(info)
+	if len(result.NewMediaItemResults) != 1 {
+		return errors.New("bad response to BatchCreate wrong number of items")
+	}
+	mediaItemResult := result.NewMediaItemResults[0]
+	if mediaItemResult.Status.Code != 0 {
+		return fmt.Errorf("upload failed: %s (%d)", mediaItemResult.Status.Message, mediaItemResult.Status.Code)
+	}
+	o.setMetaData(&mediaItemResult.MediaItem)
 
 	// Add upload to internal storage
 	if pattern.isUpload {

backend/hasher/commands.go

@@ -80,14 +80,6 @@ func (f *Fs) dbDump(ctx context.Context, full bool, root string) error {
 		}
 		root = fspath.JoinRootPath(remoteFs.Root(), f.Root())
 	}
-	if f.db == nil {
-		if f.opt.MaxAge == 0 {
-			fs.Errorf(f, "db not found. (disabled with max_age = 0)")
-		} else {
-			fs.Errorf(f, "db not found.")
-		}
-		return kv.ErrInactive
-	}
 	op := &kvDump{
 		full: full,
 		root: root,

backend/hasher/hasher.go

@@ -114,13 +114,6 @@ func NewFs(ctx context.Context, fsname, rpath string, cmap configmap.Mapper) (fs
 		root: rpath,
 		opt:  opt,
 	}
-	// Correct root if definitely pointing to a file
-	if err == fs.ErrorIsFile {
-		f.root = path.Dir(f.root)
-		if f.root == "." || f.root == "/" {
-			f.root = ""
-		}
-	}
 	baseFeatures := baseFs.Features()
 	f.fpTime = baseFs.Precision() != fs.ModTimeNotSupported
 
@@ -418,9 +411,7 @@ func (f *Fs) DirMove(ctx context.Context, src fs.Fs, srcRemote, dstRemote string
 
 // Shutdown the backend, closing any background tasks and any cached connections.
 func (f *Fs) Shutdown(ctx context.Context) (err error) {
-	if f.db != nil {
-		err = f.db.Stop(false)
-	}
+	err = f.db.Stop(false)
 	if do := f.Fs.Features().Shutdown; do != nil {
 		if err2 := do(ctx); err2 != nil {
 			err = err2

backend/hasher/hasher_internal_test.go

@@ -60,11 +60,9 @@ func (f *Fs) testUploadFromCrypt(t *testing.T) {
 	assert.NotNil(t, dst)
 
 	// check that hash was created
-	if f.opt.MaxAge > 0 {
-		hash, err = f.getRawHash(ctx, hashType, fileName, anyFingerprint, longTime)
-		assert.NoError(t, err)
-		assert.NotEmpty(t, hash)
-	}
+	hash, err = f.getRawHash(ctx, hashType, fileName, anyFingerprint, longTime)
+	assert.NoError(t, err)
+	assert.NotEmpty(t, hash)
 	//t.Logf("hash is %q", hash)
 	_ = operations.Purge(ctx, f, dirName)
 }

backend/hasher/hasher_test.go

@@ -37,9 +37,4 @@ func TestIntegration(t *testing.T) {
 		opt.QuickTestOK = true
 	}
 	fstests.Run(t, &opt)
-	// test again with MaxAge = 0
-	if *fstest.RemoteName == "" {
-		opt.ExtraConfig = append(opt.ExtraConfig, fstests.ExtraConfigItem{Name: "TestHasher", Key: "max_age", Value: "0"})
-		fstests.Run(t, &opt)
-	}
 }

backend/hdfs/fs.go

@@ -93,7 +93,7 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 	}
 
 	options := hdfs.ClientOptions{
-		Addresses:           opt.Namenode,
+		Addresses:           []string{opt.Namenode},
 		UseDatanodeHostname: false,
 	}
 

backend/hdfs/hdfs.go

@@ -20,10 +20,9 @@ func init() {
 		NewFs:       NewFs,
 		Options: []fs.Option{{
 			Name:      "namenode",
-			Help:      "Hadoop name nodes and ports.\n\nE.g. \"namenode-1:8020,namenode-2:8020,...\" to connect to host namenodes at port 8020.",
+			Help:      "Hadoop name node and port.\n\nE.g. \"namenode:8020\" to connect to host namenode at port 8020.",
 			Required:  true,
 			Sensitive: true,
-			Default:   fs.CommaSepList{},
 		}, {
 			Name: "username",
 			Help: "Hadoop user name.",
@@ -66,7 +65,7 @@ and 'privacy'. Used only with KERBEROS enabled.`,
 
 // Options for this backend
 type Options struct {
-	Namenode               fs.CommaSepList      `config:"namenode"`
+	Namenode               string               `config:"namenode"`
 	Username               string               `config:"username"`
 	ServicePrincipalName   string               `config:"service_principal_name"`
 	DataTransferProtection string               `config:"data_transfer_protection"`

backend/http/http.go

@@ -36,7 +36,6 @@ func init() {
 		Name:        "http",
 		Description: "HTTP",
 		NewFs:       NewFs,
-		CommandHelp: commandHelp,
 		Options: []fs.Option{{
 			Name:     "url",
 			Help:     "URL of HTTP host to connect to.\n\nE.g. \"https://example.com\", or \"https://user:pass@example.com\" to use a username and password.",
@@ -211,42 +210,6 @@ func getFsEndpoint(ctx context.Context, client *http.Client, url string, opt *Op
 	return createFileResult()
 }
 
-// Make the http connection with opt
-func (f *Fs) httpConnection(ctx context.Context, opt *Options) (isFile bool, err error) {
-	if len(opt.Headers)%2 != 0 {
-		return false, errors.New("odd number of headers supplied")
-	}
-
-	if !strings.HasSuffix(opt.Endpoint, "/") {
-		opt.Endpoint += "/"
-	}
-
-	// Parse the endpoint and stick the root onto it
-	base, err := url.Parse(opt.Endpoint)
-	if err != nil {
-		return false, err
-	}
-	u, err := rest.URLJoin(base, rest.URLPathEscape(f.root))
-	if err != nil {
-		return false, err
-	}
-
-	client := fshttp.NewClient(ctx)
-
-	endpoint, isFile := getFsEndpoint(ctx, client, u.String(), opt)
-	fs.Debugf(nil, "Root: %s", endpoint)
-	u, err = url.Parse(endpoint)
-	if err != nil {
-		return false, err
-	}
-
-	// Update f with the new parameters
-	f.httpClient = client
-	f.endpoint = u
-	f.endpointURL = u.String()
-	return isFile, nil
-}
-
 // NewFs creates a new Fs object from the name and root. It connects to
 // the host specified in the config file.
 func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, error) {
@@ -257,23 +220,47 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		return nil, err
 	}
 
+	if len(opt.Headers)%2 != 0 {
+		return nil, errors.New("odd number of headers supplied")
+	}
+
+	if !strings.HasSuffix(opt.Endpoint, "/") {
+		opt.Endpoint += "/"
+	}
+
+	// Parse the endpoint and stick the root onto it
+	base, err := url.Parse(opt.Endpoint)
+	if err != nil {
+		return nil, err
+	}
+	u, err := rest.URLJoin(base, rest.URLPathEscape(root))
+	if err != nil {
+		return nil, err
+	}
+
+	client := fshttp.NewClient(ctx)
+
+	endpoint, isFile := getFsEndpoint(ctx, client, u.String(), opt)
+	fs.Debugf(nil, "Root: %s", endpoint)
+	u, err = url.Parse(endpoint)
+	if err != nil {
+		return nil, err
+	}
+
 	ci := fs.GetConfig(ctx)
 	f := &Fs{
-		name: name,
-		root: root,
-		opt:  *opt,
-		ci:   ci,
+		name:        name,
+		root:        root,
+		opt:         *opt,
+		ci:          ci,
+		httpClient:  client,
+		endpoint:    u,
+		endpointURL: u.String(),
 	}
 	f.features = (&fs.Features{
 		CanHaveEmptyDirectories: true,
 	}).Fill(ctx, f)
 
-	// Make the http connection
-	isFile, err := f.httpConnection(ctx, opt)
-	if err != nil {
-		return nil, err
-	}
-
 	if isFile {
 		// return an error with an fs which points to the parent
 		return f, fs.ErrorIsFile
@@ -698,66 +685,10 @@ func (o *Object) MimeType(ctx context.Context) string {
 	return o.contentType
 }
 
-var commandHelp = []fs.CommandHelp{{
-	Name:  "set",
-	Short: "Set command for updating the config parameters.",
-	Long: `This set command can be used to update the config parameters
-for a running http backend.
-
-Usage Examples:
-
-    rclone backend set remote: [-o opt_name=opt_value] [-o opt_name2=opt_value2]
-    rclone rc backend/command command=set fs=remote: [-o opt_name=opt_value] [-o opt_name2=opt_value2]
-    rclone rc backend/command command=set fs=remote: -o url=https://example.com
-
-The option keys are named as they are in the config file.
-
-This rebuilds the connection to the http backend when it is called with
-the new parameters. Only new parameters need be passed as the values
-will default to those currently in use.
-
-It doesn't return anything.
-`,
-}}
-
-// Command the backend to run a named command
-//
-// The command run is name
-// args may be used to read arguments from
-// opts may be used to read optional arguments from
-//
-// The result should be capable of being JSON encoded
-// If it is a string or a []string it will be shown to the user
-// otherwise it will be JSON encoded and shown to the user like that
-func (f *Fs) Command(ctx context.Context, name string, arg []string, opt map[string]string) (out interface{}, err error) {
-	switch name {
-	case "set":
-		newOpt := f.opt
-		err := configstruct.Set(configmap.Simple(opt), &newOpt)
-		if err != nil {
-			return nil, fmt.Errorf("reading config: %w", err)
-		}
-		_, err = f.httpConnection(ctx, &newOpt)
-		if err != nil {
-			return nil, fmt.Errorf("updating session: %w", err)
-		}
-		f.opt = newOpt
-		keys := []string{}
-		for k := range opt {
-			keys = append(keys, k)
-		}
-		fs.Logf(f, "Updated config values: %s", strings.Join(keys, ", "))
-		return nil, nil
-	default:
-		return nil, fs.ErrorCommandNotFound
-	}
-}
-
 // Check the interfaces are satisfied
 var (
 	_ fs.Fs          = &Fs{}
 	_ fs.PutStreamer = &Fs{}
 	_ fs.Object      = &Object{}
 	_ fs.MimeTyper   = &Object{}
-	_ fs.Commander   = &Fs{}
 )

backend/imagekit/client/client.go

@@ -1,66 +0,0 @@
-// Package client provides a client for interacting with the ImageKit API.
-package client
-
-import (
-	"context"
-	"fmt"
-
-	"github.com/rclone/rclone/fs"
-	"github.com/rclone/rclone/fs/fshttp"
-	"github.com/rclone/rclone/lib/rest"
-)
-
-// ImageKit main struct
-type ImageKit struct {
-	Prefix        string
-	UploadPrefix  string
-	Timeout       int64
-	UploadTimeout int64
-	PrivateKey    string
-	PublicKey     string
-	URLEndpoint   string
-	HTTPClient    *rest.Client
-}
-
-// NewParams is a struct to define parameters to imagekit
-type NewParams struct {
-	PrivateKey  string
-	PublicKey   string
-	URLEndpoint string
-}
-
-// New returns ImageKit object from environment variables
-func New(ctx context.Context, params NewParams) (*ImageKit, error) {
-
-	privateKey := params.PrivateKey
-	publicKey := params.PublicKey
-	endpointURL := params.URLEndpoint
-
-	switch {
-	case privateKey == "":
-		return nil, fmt.Errorf("ImageKit.io URL endpoint is required")
-	case publicKey == "":
-		return nil, fmt.Errorf("ImageKit.io public key is required")
-	case endpointURL == "":
-		return nil, fmt.Errorf("ImageKit.io private key is required")
-	}
-
-	cliCtx, cliCfg := fs.AddConfig(ctx)
-
-	cliCfg.UserAgent = "rclone/imagekit"
-	client := rest.NewClient(fshttp.NewClient(cliCtx))
-
-	client.SetUserPass(privateKey, "")
-	client.SetHeader("Accept", "application/json")
-
-	return &ImageKit{
-		Prefix:        "https://api.imagekit.io/v2",
-		UploadPrefix:  "https://upload.imagekit.io/api/v2",
-		Timeout:       60,
-		UploadTimeout: 3600,
-		PrivateKey:    params.PrivateKey,
-		PublicKey:     params.PublicKey,
-		URLEndpoint:   params.URLEndpoint,
-		HTTPClient:    client,
-	}, nil
-}

backend/imagekit/client/media.go

@@ -1,252 +0,0 @@
-package client
-
-import (
-	"context"
-	"errors"
-	"fmt"
-	"net/http"
-	"net/url"
-	"time"
-
-	"github.com/rclone/rclone/lib/rest"
-	"gopkg.in/validator.v2"
-)
-
-// FilesOrFolderParam struct is a parameter type to ListFiles() function to search / list media library files.
-type FilesOrFolderParam struct {
-	Path        string `json:"path,omitempty"`
-	Limit       int    `json:"limit,omitempty"`
-	Skip        int    `json:"skip,omitempty"`
-	SearchQuery string `json:"searchQuery,omitempty"`
-}
-
-// AITag represents an AI tag for a media library file.
-type AITag struct {
-	Name       string  `json:"name"`
-	Confidence float32 `json:"confidence"`
-	Source     string  `json:"source"`
-}
-
-// File represents media library File details.
-type File struct {
-	FileID            string            `json:"fileId"`
-	Name              string            `json:"name"`
-	FilePath          string            `json:"filePath"`
-	Type              string            `json:"type"`
-	VersionInfo       map[string]string `json:"versionInfo"`
-	IsPrivateFile     *bool             `json:"isPrivateFile"`
-	CustomCoordinates *string           `json:"customCoordinates"`
-	URL               string            `json:"url"`
-	Thumbnail         string            `json:"thumbnail"`
-	FileType          string            `json:"fileType"`
-	Mime              string            `json:"mime"`
-	Height            int               `json:"height"`
-	Width             int               `json:"Width"`
-	Size              uint64            `json:"size"`
-	HasAlpha          bool              `json:"hasAlpha"`
-	CustomMetadata    map[string]any    `json:"customMetadata,omitempty"`
-	EmbeddedMetadata  map[string]any    `json:"embeddedMetadata"`
-	CreatedAt         time.Time         `json:"createdAt"`
-	UpdatedAt         time.Time         `json:"updatedAt"`
-	Tags              []string          `json:"tags"`
-	AITags            []AITag           `json:"AITags"`
-}
-
-// Folder represents media library Folder details.
-type Folder struct {
-	*File
-	FolderPath string `json:"folderPath"`
-}
-
-// CreateFolderParam represents parameter to create folder api
-type CreateFolderParam struct {
-	FolderName       string `validate:"nonzero" json:"folderName"`
-	ParentFolderPath string `validate:"nonzero" json:"parentFolderPath"`
-}
-
-// DeleteFolderParam represents parameter to delete folder api
-type DeleteFolderParam struct {
-	FolderPath string `validate:"nonzero" json:"folderPath"`
-}
-
-// MoveFolderParam represents parameter to move folder api
-type MoveFolderParam struct {
-	SourceFolderPath string `validate:"nonzero" json:"sourceFolderPath"`
-	DestinationPath  string `validate:"nonzero" json:"destinationPath"`
-}
-
-// JobIDResponse respresents response struct with JobID for folder operations
-type JobIDResponse struct {
-	JobID string `json:"jobId"`
-}
-
-// JobStatus represents response Data to job status api
-type JobStatus struct {
-	JobID  string `json:"jobId"`
-	Type   string `json:"type"`
-	Status string `json:"status"`
-}
-
-// File represents media library File details.
-func (ik *ImageKit) File(ctx context.Context, fileID string) (*http.Response, *File, error) {
-	data := &File{}
-	response, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:       "GET",
-		Path:         fmt.Sprintf("/files/%s/details", fileID),
-		RootURL:      ik.Prefix,
-		IgnoreStatus: true,
-	}, nil, data)
-
-	return response, data, err
-}
-
-// Files retrieves media library files. Filter options can be supplied as FilesOrFolderParam.
-func (ik *ImageKit) Files(ctx context.Context, params FilesOrFolderParam, includeVersion bool) (*http.Response, *[]File, error) {
-	var SearchQuery = `type = "file"`
-
-	if includeVersion {
-		SearchQuery = `type IN ["file", "file-version"]`
-	}
-	if params.SearchQuery != "" {
-		SearchQuery = params.SearchQuery
-	}
-
-	parameters := url.Values{}
-
-	parameters.Set("skip", fmt.Sprintf("%d", params.Skip))
-	parameters.Set("limit", fmt.Sprintf("%d", params.Limit))
-	parameters.Set("path", params.Path)
-	parameters.Set("searchQuery", SearchQuery)
-
-	data := &[]File{}
-
-	response, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:     "GET",
-		Path:       "/files",
-		RootURL:    ik.Prefix,
-		Parameters: parameters,
-	}, nil, data)
-
-	return response, data, err
-}
-
-// DeleteFile removes file by FileID from media library
-func (ik *ImageKit) DeleteFile(ctx context.Context, fileID string) (*http.Response, error) {
-	var err error
-
-	if fileID == "" {
-		return nil, errors.New("fileID can not be empty")
-	}
-
-	response, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:     "DELETE",
-		Path:       fmt.Sprintf("/files/%s", fileID),
-		RootURL:    ik.Prefix,
-		NoResponse: true,
-	}, nil, nil)
-
-	return response, err
-}
-
-// Folders retrieves media library files. Filter options can be supplied as FilesOrFolderParam.
-func (ik *ImageKit) Folders(ctx context.Context, params FilesOrFolderParam) (*http.Response, *[]Folder, error) {
-	var SearchQuery = `type = "folder"`
-
-	if params.SearchQuery != "" {
-		SearchQuery = params.SearchQuery
-	}
-
-	parameters := url.Values{}
-
-	parameters.Set("skip", fmt.Sprintf("%d", params.Skip))
-	parameters.Set("limit", fmt.Sprintf("%d", params.Limit))
-	parameters.Set("path", params.Path)
-	parameters.Set("searchQuery", SearchQuery)
-
-	data := &[]Folder{}
-
-	resp, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:     "GET",
-		Path:       "/files",
-		RootURL:    ik.Prefix,
-		Parameters: parameters,
-	}, nil, data)
-
-	if err != nil {
-		return resp, data, err
-	}
-
-	return resp, data, err
-}
-
-// CreateFolder creates a new folder in media library
-func (ik *ImageKit) CreateFolder(ctx context.Context, param CreateFolderParam) (*http.Response, error) {
-	var err error
-
-	if err = validator.Validate(&param); err != nil {
-		return nil, err
-	}
-
-	response, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:     "POST",
-		Path:       "/folder",
-		RootURL:    ik.Prefix,
-		NoResponse: true,
-	}, param, nil)
-
-	return response, err
-}
-
-// DeleteFolder removes the folder from media library
-func (ik *ImageKit) DeleteFolder(ctx context.Context, param DeleteFolderParam) (*http.Response, error) {
-	var err error
-
-	if err = validator.Validate(&param); err != nil {
-		return nil, err
-	}
-
-	response, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:     "DELETE",
-		Path:       "/folder",
-		RootURL:    ik.Prefix,
-		NoResponse: true,
-	}, param, nil)
-
-	return response, err
-}
-
-// MoveFolder moves given folder to new path in media library
-func (ik *ImageKit) MoveFolder(ctx context.Context, param MoveFolderParam) (*http.Response, *JobIDResponse, error) {
-	var err error
-	var response = &JobIDResponse{}
-
-	if err = validator.Validate(&param); err != nil {
-		return nil, nil, err
-	}
-
-	resp, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:  "PUT",
-		Path:    "bulkJobs/moveFolder",
-		RootURL: ik.Prefix,
-	}, param, response)
-
-	return resp, response, err
-}
-
-// BulkJobStatus retrieves the status of a bulk job by job ID.
-func (ik *ImageKit) BulkJobStatus(ctx context.Context, jobID string) (*http.Response, *JobStatus, error) {
-	var err error
-	var response = &JobStatus{}
-
-	if jobID == "" {
-		return nil, nil, errors.New("jobId can not be blank")
-	}
-
-	resp, err := ik.HTTPClient.CallJSON(ctx, &rest.Opts{
-		Method:  "GET",
-		Path:    "bulkJobs/" + jobID,
-		RootURL: ik.Prefix,
-	}, nil, response)
-
-	return resp, response, err
-}

backend/imagekit/client/upload.go

@@ -1,96 +0,0 @@
-package client
-
-import (
-	"context"
-	"errors"
-	"fmt"
-	"io"
-	"net/http"
-	"net/url"
-
-	"github.com/rclone/rclone/lib/rest"
-)
-
-// UploadParam defines upload parameters
-type UploadParam struct {
-	FileName      string `json:"fileName"`
-	Folder        string `json:"folder,omitempty"` // default value:  /
-	Tags          string `json:"tags,omitempty"`
-	IsPrivateFile *bool  `json:"isPrivateFile,omitempty"` // default: false
-}
-
-// UploadResult defines the response structure for the upload API
-type UploadResult struct {
-	FileID       string            `json:"fileId"`
-	Name         string            `json:"name"`
-	URL          string            `json:"url"`
-	ThumbnailURL string            `json:"thumbnailUrl"`
-	Height       int               `json:"height"`
-	Width        int               `json:"Width"`
-	Size         uint64            `json:"size"`
-	FilePath     string            `json:"filePath"`
-	AITags       []map[string]any  `json:"AITags"`
-	VersionInfo  map[string]string `json:"versionInfo"`
-}
-
-// Upload uploads an asset to a imagekit account.
-//
-// The asset can be:
-//   - the actual data (io.Reader)
-//   - the Data URI (Base64 encoded), max ~60 MB (62,910,000 chars)
-//   - the remote FTP, HTTP or HTTPS URL address of an existing file
-//
-// https://docs.imagekit.io/api-reference/upload-file-api/server-side-file-upload
-func (ik *ImageKit) Upload(ctx context.Context, file io.Reader, param UploadParam) (*http.Response, *UploadResult, error) {
-	var err error
-
-	if param.FileName == "" {
-		return nil, nil, errors.New("Upload: Filename is required")
-	}
-
-	// Initialize URL values
-	formParams := url.Values{}
-
-	formParams.Add("useUniqueFileName", fmt.Sprint(false))
-
-	// Add individual fields to URL values
-	if param.FileName != "" {
-		formParams.Add("fileName", param.FileName)
-	}
-
-	if param.Tags != "" {
-		formParams.Add("tags", param.Tags)
-	}
-
-	if param.Folder != "" {
-		formParams.Add("folder", param.Folder)
-	}
-
-	if param.IsPrivateFile != nil {
-		formParams.Add("isPrivateFile", fmt.Sprintf("%v", *param.IsPrivateFile))
-	}
-
-	response := &UploadResult{}
-
-	formReader, contentType, _, err := rest.MultipartUpload(ctx, file, formParams, "file", param.FileName)
-
-	if err != nil {
-		return nil, nil, fmt.Errorf("failed to make multipart upload: %w", err)
-	}
-
-	opts := rest.Opts{
-		Method:      "POST",
-		Path:        "/files/upload",
-		RootURL:     ik.UploadPrefix,
-		Body:        formReader,
-		ContentType: contentType,
-	}
-
-	resp, err := ik.HTTPClient.CallJSON(ctx, &opts, nil, response)
-
-	if err != nil {
-		return resp, response, err
-	}
-
-	return resp, response, err
-}

backend/imagekit/client/url.go

@@ -1,72 +0,0 @@
-package client
-
-import (
-	"crypto/hmac"
-	"crypto/sha1"
-	"encoding/hex"
-	"fmt"
-	neturl "net/url"
-	"strconv"
-	"strings"
-	"time"
-)
-
-// URLParam represents parameters for generating url
-type URLParam struct {
-	Path            string
-	Src             string
-	URLEndpoint     string
-	Signed          bool
-	ExpireSeconds   int64
-	QueryParameters map[string]string
-}
-
-// URL generates url from URLParam
-func (ik *ImageKit) URL(params URLParam) (string, error) {
-	var resultURL string
-	var url *neturl.URL
-	var err error
-	var endpoint = params.URLEndpoint
-
-	if endpoint == "" {
-		endpoint = ik.URLEndpoint
-	}
-
-	endpoint = strings.TrimRight(endpoint, "/") + "/"
-
-	if params.QueryParameters == nil {
-		params.QueryParameters = make(map[string]string)
-	}
-
-	if url, err = neturl.Parse(params.Src); err != nil {
-		return "", err
-	}
-
-	query := url.Query()
-
-	for k, v := range params.QueryParameters {
-		query.Set(k, v)
-	}
-	url.RawQuery = query.Encode()
-	resultURL = url.String()
-
-	if params.Signed {
-		now := time.Now().Unix()
-
-		var expires = strconv.FormatInt(now+params.ExpireSeconds, 10)
-		var path = strings.Replace(resultURL, endpoint, "", 1)
-
-		path = path + expires
-		mac := hmac.New(sha1.New, []byte(ik.PrivateKey))
-		mac.Write([]byte(path))
-		signature := hex.EncodeToString(mac.Sum(nil))
-
-		if strings.Contains(resultURL, "?") {
-			resultURL = resultURL + "&" + fmt.Sprintf("ik-t=%s&ik-s=%s", expires, signature)
-		} else {
-			resultURL = resultURL + "?" + fmt.Sprintf("ik-t=%s&ik-s=%s", expires, signature)
-		}
-	}
-
-	return resultURL, nil
-}

backend/imagekit/imagekit.go

@@ -1,828 +0,0 @@
-// Package imagekit provides an interface to the ImageKit.io media library.
-package imagekit
-
-import (
-	"context"
-	"errors"
-	"fmt"
-	"io"
-	"math"
-	"net/http"
-	"path"
-	"strconv"
-	"strings"
-	"time"
-
-	"github.com/rclone/rclone/backend/imagekit/client"
-	"github.com/rclone/rclone/fs"
-	"github.com/rclone/rclone/fs/config"
-	"github.com/rclone/rclone/fs/config/configmap"
-	"github.com/rclone/rclone/fs/config/configstruct"
-	"github.com/rclone/rclone/fs/hash"
-	"github.com/rclone/rclone/lib/encoder"
-	"github.com/rclone/rclone/lib/pacer"
-	"github.com/rclone/rclone/lib/readers"
-	"github.com/rclone/rclone/lib/version"
-)
-
-const (
-	minSleep      = 1 * time.Millisecond
-	maxSleep      = 100 * time.Millisecond
-	decayConstant = 2
-)
-
-var systemMetadataInfo = map[string]fs.MetadataHelp{
-	"btime": {
-		Help:     "Time of file birth (creation) read from Last-Modified header",
-		Type:     "RFC 3339",
-		Example:  "2006-01-02T15:04:05.999999999Z07:00",
-		ReadOnly: true,
-	},
-	"size": {
-		Help:     "Size of the object in bytes",
-		Type:     "int64",
-		ReadOnly: true,
-	},
-	"file-type": {
-		Help:     "Type of the file",
-		Type:     "string",
-		Example:  "image",
-		ReadOnly: true,
-	},
-	"height": {
-		Help:     "Height of the image or video in pixels",
-		Type:     "int",
-		ReadOnly: true,
-	},
-	"width": {
-		Help:     "Width of the image or video in pixels",
-		Type:     "int",
-		ReadOnly: true,
-	},
-	"has-alpha": {
-		Help:     "Whether the image has alpha channel or not",
-		Type:     "bool",
-		ReadOnly: true,
-	},
-	"tags": {
-		Help:     "Tags associated with the file",
-		Type:     "string",
-		Example:  "tag1,tag2",
-		ReadOnly: true,
-	},
-	"google-tags": {
-		Help:     "AI generated tags by Google Cloud Vision associated with the image",
-		Type:     "string",
-		Example:  "tag1,tag2",
-		ReadOnly: true,
-	},
-	"aws-tags": {
-		Help:     "AI generated tags by AWS Rekognition associated with the image",
-		Type:     "string",
-		Example:  "tag1,tag2",
-		ReadOnly: true,
-	},
-	"is-private-file": {
-		Help:     "Whether the file is private or not",
-		Type:     "bool",
-		ReadOnly: true,
-	},
-	"custom-coordinates": {
-		Help:     "Custom coordinates of the file",
-		Type:     "string",
-		Example:  "0,0,100,100",
-		ReadOnly: true,
-	},
-}
-
-// Register with Fs
-func init() {
-	fs.Register(&fs.RegInfo{
-		Name:        "imagekit",
-		Description: "ImageKit.io",
-		NewFs:       NewFs,
-		MetadataInfo: &fs.MetadataInfo{
-			System: systemMetadataInfo,
-			Help:   `Any metadata supported by the underlying remote is read and written.`,
-		},
-		Options: []fs.Option{
-			{
-				Name:     "endpoint",
-				Help:     "You can find your ImageKit.io URL endpoint in your [dashboard](https://imagekit.io/dashboard/developer/api-keys)",
-				Required: true,
-			},
-			{
-				Name:      "public_key",
-				Help:      "You can find your ImageKit.io public key in your [dashboard](https://imagekit.io/dashboard/developer/api-keys)",
-				Required:  true,
-				Sensitive: true,
-			},
-			{
-				Name:      "private_key",
-				Help:      "You can find your ImageKit.io private key in your [dashboard](https://imagekit.io/dashboard/developer/api-keys)",
-				Required:  true,
-				Sensitive: true,
-			},
-			{
-				Name:     "only_signed",
-				Help:     "If you have configured `Restrict unsigned image URLs` in your dashboard settings, set this to true.",
-				Default:  false,
-				Advanced: true,
-			},
-			{
-				Name:     "versions",
-				Help:     "Include old versions in directory listings.",
-				Default:  false,
-				Advanced: true,
-			},
-			{
-				Name:     "upload_tags",
-				Help:     "Tags to add to the uploaded files, e.g. \"tag1,tag2\".",
-				Default:  "",
-				Advanced: true,
-			},
-			{
-				Name:     config.ConfigEncoding,
-				Help:     config.ConfigEncodingHelp,
-				Advanced: true,
-				Default: (encoder.EncodeZero |
-					encoder.EncodeSlash |
-					encoder.EncodeQuestion |
-					encoder.EncodeHashPercent |
-					encoder.EncodeCtl |
-					encoder.EncodeDel |
-					encoder.EncodeDot |
-					encoder.EncodeDoubleQuote |
-					encoder.EncodePercent |
-					encoder.EncodeBackSlash |
-					encoder.EncodeDollar |
-					encoder.EncodeLtGt |
-					encoder.EncodeSquareBracket |
-					encoder.EncodeInvalidUtf8),
-			},
-		},
-	})
-}
-
-// Options defines the configuration for this backend
-type Options struct {
-	Endpoint   string               `config:"endpoint"`
-	PublicKey  string               `config:"public_key"`
-	PrivateKey string               `config:"private_key"`
-	OnlySigned bool                 `config:"only_signed"`
-	Versions   bool                 `config:"versions"`
-	Enc        encoder.MultiEncoder `config:"encoding"`
-}
-
-// Fs represents a remote to ImageKit
-type Fs struct {
-	name     string           // name of remote
-	root     string           // root path
-	opt      Options          // parsed options
-	features *fs.Features     // optional features
-	ik       *client.ImageKit // ImageKit client
-	pacer    *fs.Pacer        // pacer for API calls
-}
-
-// Object describes a ImageKit file
-type Object struct {
-	fs          *Fs         // The Fs this object is part of
-	remote      string      // The remote path
-	filePath    string      // The path to the file
-	contentType string      // The content type of the object if known - may be ""
-	timestamp   time.Time   // The timestamp of the object if known - may be zero
-	file        client.File // The media file if known - may be nil
-	versionID   string      // If present this points to an object version
-}
-
-// NewFs constructs an Fs from the path, container:path
-func NewFs(ctx context.Context, name string, root string, m configmap.Mapper) (fs.Fs, error) {
-	opt := new(Options)
-	err := configstruct.Set(m, opt)
-
-	if err != nil {
-		return nil, err
-	}
-
-	ik, err := client.New(ctx, client.NewParams{
-		URLEndpoint: opt.Endpoint,
-		PublicKey:   opt.PublicKey,
-		PrivateKey:  opt.PrivateKey,
-	})
-
-	if err != nil {
-		return nil, err
-	}
-
-	f := &Fs{
-		name:  name,
-		opt:   *opt,
-		ik:    ik,
-		pacer: fs.NewPacer(ctx, pacer.NewDefault(pacer.MinSleep(minSleep), pacer.MaxSleep(maxSleep), pacer.DecayConstant(decayConstant))),
-	}
-
-	f.root = path.Join("/", root)
-
-	f.features = (&fs.Features{
-		CaseInsensitive:         false,
-		DuplicateFiles:          false,
-		ReadMimeType:            true,
-		WriteMimeType:           false,
-		CanHaveEmptyDirectories: true,
-		BucketBased:             false,
-		ServerSideAcrossConfigs: false,
-		IsLocal:                 false,
-		SlowHash:                true,
-		ReadMetadata:            true,
-		WriteMetadata:           false,
-		UserMetadata:            false,
-		FilterAware:             true,
-		PartialUploads:          false,
-		NoMultiThreading:        false,
-	}).Fill(ctx, f)
-
-	if f.root != "/" {
-
-		r := f.root
-
-		folderPath := f.EncodePath(r[:strings.LastIndex(r, "/")+1])
-		fileName := f.EncodeFileName(r[strings.LastIndex(r, "/")+1:])
-
-		file := f.getFileByName(ctx, folderPath, fileName)
-
-		if file != nil {
-			newRoot := path.Dir(f.root)
-			f.root = newRoot
-			return f, fs.ErrorIsFile
-		}
-
-	}
-	return f, nil
-}
-
-// Name of the remote (as passed into NewFs)
-func (f *Fs) Name() string {
-	return f.name
-}
-
-// Root of the remote (as passed into NewFs)
-func (f *Fs) Root() string {
-	return strings.TrimLeft(f.root, "/")
-}
-
-// String returns a description of the FS
-func (f *Fs) String() string {
-	return fmt.Sprintf("FS imagekit: %s", f.root)
-}
-
-// Precision of the ModTimes in this Fs
-func (f *Fs) Precision() time.Duration {
-	return fs.ModTimeNotSupported
-}
-
-// Hashes returns the supported hash types of the filesystem.
-func (f *Fs) Hashes() hash.Set {
-	return hash.NewHashSet()
-}
-
-// Features returns the optional features of this Fs.
-func (f *Fs) Features() *fs.Features {
-	return f.features
-}
-
-// List the objects and directories in dir into entries.  The
-// entries can be returned in any order but should be for a
-// complete directory.
-//
-// dir should be "" to list the root, and should not have
-// trailing slashes.
-//
-// This should return ErrDirNotFound if the directory isn't
-// found.
-func (f *Fs) List(ctx context.Context, dir string) (entries fs.DirEntries, err error) {
-
-	remote := path.Join(f.root, dir)
-
-	remote = f.EncodePath(remote)
-
-	if remote != "/" {
-		parentFolderPath, folderName := path.Split(remote)
-		folderExists, err := f.getFolderByName(ctx, parentFolderPath, folderName)
-
-		if err != nil {
-			return make(fs.DirEntries, 0), err
-		}
-
-		if folderExists == nil {
-			return make(fs.DirEntries, 0), fs.ErrorDirNotFound
-		}
-	}
-
-	folders, folderError := f.getFolders(ctx, remote)
-
-	if folderError != nil {
-		return make(fs.DirEntries, 0), folderError
-	}
-
-	files, fileError := f.getFiles(ctx, remote, f.opt.Versions)
-
-	if fileError != nil {
-		return make(fs.DirEntries, 0), fileError
-	}
-
-	res := make([]fs.DirEntry, 0, len(folders)+len(files))
-
-	for _, folder := range folders {
-		folderPath := f.DecodePath(strings.TrimLeft(strings.Replace(folder.FolderPath, f.EncodePath(f.root), "", 1), "/"))
-		res = append(res, fs.NewDir(folderPath, folder.UpdatedAt))
-	}
-
-	for _, file := range files {
-		res = append(res, f.newObject(ctx, remote, file))
-	}
-
-	return res, nil
-}
-
-func (f *Fs) newObject(ctx context.Context, remote string, file client.File) *Object {
-	remoteFile := strings.TrimLeft(strings.Replace(file.FilePath, f.EncodePath(f.root), "", 1), "/")
-
-	folderPath, fileName := path.Split(remoteFile)
-
-	folderPath = f.DecodePath(folderPath)
-	fileName = f.DecodeFileName(fileName)
-
-	remoteFile = path.Join(folderPath, fileName)
-
-	if file.Type == "file-version" {
-		remoteFile = version.Add(remoteFile, file.UpdatedAt)
-
-		return &Object{
-			fs:          f,
-			remote:      remoteFile,
-			filePath:    file.FilePath,
-			contentType: file.Mime,
-			timestamp:   file.UpdatedAt,
-			file:        file,
-			versionID:   file.VersionInfo["id"],
-		}
-	}
-
-	return &Object{
-		fs:          f,
-		remote:      remoteFile,
-		filePath:    file.FilePath,
-		contentType: file.Mime,
-		timestamp:   file.UpdatedAt,
-		file:        file,
-	}
-}
-
-// NewObject finds the Object at remote.  If it can't be found
-// it returns the error ErrorObjectNotFound.
-//
-// If remote points to a directory then it should return
-// ErrorIsDir if possible without doing any extra work,
-// otherwise ErrorObjectNotFound.
-func (f *Fs) NewObject(ctx context.Context, remote string) (fs.Object, error) {
-	r := path.Join(f.root, remote)
-
-	folderPath, fileName := path.Split(r)
-
-	folderPath = f.EncodePath(folderPath)
-	fileName = f.EncodeFileName(fileName)
-
-	isFolder, err := f.getFolderByName(ctx, folderPath, fileName)
-
-	if err != nil {
-		return nil, err
-	}
-
-	if isFolder != nil {
-		return nil, fs.ErrorIsDir
-	}
-
-	file := f.getFileByName(ctx, folderPath, fileName)
-
-	if file == nil {
-		return nil, fs.ErrorObjectNotFound
-	}
-
-	return f.newObject(ctx, r, *file), nil
-}
-
-// Put in to the remote path with the modTime given of the given size
-//
-// When called from outside an Fs by rclone, src.Size() will always be >= 0.
-// But for unknown-sized objects (indicated by src.Size() == -1), Put should either
-// return an error or upload it properly (rather than e.g. calling panic).
-//
-// May create the object even if it returns an error - if so
-// will return the object and the error, otherwise will return
-// nil and the error
-func (f *Fs) Put(ctx context.Context, in io.Reader, src fs.ObjectInfo, options ...fs.OpenOption) (fs.Object, error) {
-	return uploadFile(ctx, f, in, src.Remote(), options...)
-}
-
-// Mkdir makes the directory (container, bucket)
-//
-// Shouldn't return an error if it already exists
-func (f *Fs) Mkdir(ctx context.Context, dir string) (err error) {
-	remote := path.Join(f.root, dir)
-	parentFolderPath, folderName := path.Split(remote)
-
-	parentFolderPath = f.EncodePath(parentFolderPath)
-	folderName = f.EncodeFileName(folderName)
-
-	err = f.pacer.Call(func() (bool, error) {
-		var res *http.Response
-		res, err = f.ik.CreateFolder(ctx, client.CreateFolderParam{
-			ParentFolderPath: parentFolderPath,
-			FolderName:       folderName,
-		})
-
-		return f.shouldRetry(ctx, res, err)
-	})
-
-	return err
-}
-
-// Rmdir removes the directory (container, bucket) if empty
-//
-// Return an error if it doesn't exist or isn't empty
-func (f *Fs) Rmdir(ctx context.Context, dir string) (err error) {
-
-	entries, err := f.List(ctx, dir)
-
-	if err != nil {
-		return err
-	}
-
-	if len(entries) > 0 {
-		return errors.New("directory is not empty")
-	}
-
-	err = f.pacer.Call(func() (bool, error) {
-		var res *http.Response
-		res, err = f.ik.DeleteFolder(ctx, client.DeleteFolderParam{
-			FolderPath: f.EncodePath(path.Join(f.root, dir)),
-		})
-
-		if res.StatusCode == http.StatusNotFound {
-			return false, fs.ErrorDirNotFound
-		}
-
-		return f.shouldRetry(ctx, res, err)
-	})
-
-	return err
-}
-
-// Purge deletes all the files and the container
-//
-// Optional interface: Only implement this if you have a way of
-// deleting all the files quicker than just running Remove() on the
-// result of List()
-func (f *Fs) Purge(ctx context.Context, dir string) (err error) {
-
-	remote := path.Join(f.root, dir)
-
-	err = f.pacer.Call(func() (bool, error) {
-		var res *http.Response
-		res, err = f.ik.DeleteFolder(ctx, client.DeleteFolderParam{
-			FolderPath: f.EncodePath(remote),
-		})
-
-		if res.StatusCode == http.StatusNotFound {
-			return false, fs.ErrorDirNotFound
-		}
-
-		return f.shouldRetry(ctx, res, err)
-	})
-
-	return err
-}
-
-// PublicLink generates a public link to the remote path (usually readable by anyone)
-func (f *Fs) PublicLink(ctx context.Context, remote string, expire fs.Duration, unlink bool) (string, error) {
-
-	duration := time.Duration(math.Abs(float64(expire)))
-
-	expireSeconds := duration.Seconds()
-
-	fileRemote := path.Join(f.root, remote)
-
-	folderPath, fileName := path.Split(fileRemote)
-	folderPath = f.EncodePath(folderPath)
-	fileName = f.EncodeFileName(fileName)
-
-	file := f.getFileByName(ctx, folderPath, fileName)
-
-	if file == nil {
-		return "", fs.ErrorObjectNotFound
-	}
-
-	// Pacer not needed as this doesn't use the API
-	url, err := f.ik.URL(client.URLParam{
-		Src:           file.URL,
-		Signed:        *file.IsPrivateFile || f.opt.OnlySigned,
-		ExpireSeconds: int64(expireSeconds),
-		QueryParameters: map[string]string{
-			"updatedAt": file.UpdatedAt.String(),
-		},
-	})
-
-	if err != nil {
-		return "", err
-	}
-
-	return url, nil
-}
-
-// Fs returns read only access to the Fs that this object is part of
-func (o *Object) Fs() fs.Info {
-	return o.fs
-}
-
-// Hash returns the selected checksum of the file
-// If no checksum is available it returns ""
-func (o *Object) Hash(ctx context.Context, ty hash.Type) (string, error) {
-	return "", hash.ErrUnsupported
-}
-
-// Storable says whether this object can be stored
-func (o *Object) Storable() bool {
-	return true
-}
-
-// String returns a description of the Object
-func (o *Object) String() string {
-	if o == nil {
-		return "<nil>"
-	}
-	return o.file.Name
-}
-
-// Remote returns the remote path
-func (o *Object) Remote() string {
-	return o.remote
-}
-
-// ModTime returns the modification date of the file
-// It should return a best guess if one isn't available
-func (o *Object) ModTime(context.Context) time.Time {
-	return o.file.UpdatedAt
-}
-
-// Size returns the size of the file
-func (o *Object) Size() int64 {
-	return int64(o.file.Size)
-}
-
-// MimeType returns the MIME type of the file
-func (o *Object) MimeType(context.Context) string {
-	return o.contentType
-}
-
-// Open opens the file for read.  Call Close() on the returned io.ReadCloser
-func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (io.ReadCloser, error) {
-	// Offset and Count for range download
-	var offset int64
-	var count int64
-
-	fs.FixRangeOption(options, -1)
-	partialContent := false
-	for _, option := range options {
-		switch x := option.(type) {
-		case *fs.RangeOption:
-			offset, count = x.Decode(-1)
-			partialContent = true
-		case *fs.SeekOption:
-			offset = x.Offset
-			partialContent = true
-		default:
-			if option.Mandatory() {
-				fs.Logf(o, "Unsupported mandatory option: %v", option)
-			}
-		}
-	}
-
-	// Pacer not needed as this doesn't use the API
-	url, err := o.fs.ik.URL(client.URLParam{
-		Src:    o.file.URL,
-		Signed: *o.file.IsPrivateFile || o.fs.opt.OnlySigned,
-		QueryParameters: map[string]string{
-			"tr":        "orig-true",
-			"updatedAt": o.file.UpdatedAt.String(),
-		},
-	})
-
-	if err != nil {
-		return nil, err
-	}
-
-	client := &http.Client{}
-	req, _ := http.NewRequest("GET", url, nil)
-	req.Header.Set("Range", fmt.Sprintf("bytes=%d-%d", offset, offset+count-1))
-	resp, err := client.Do(req)
-
-	if err != nil {
-		return nil, err
-	}
-
-	end := resp.ContentLength
-
-	if partialContent && resp.StatusCode == http.StatusOK {
-		skip := offset
-
-		if offset < 0 {
-			skip = end + offset + 1
-		}
-
-		_, err = io.CopyN(io.Discard, resp.Body, skip)
-		if err != nil {
-			if resp != nil {
-				_ = resp.Body.Close()
-			}
-			return nil, err
-		}
-
-		return readers.NewLimitedReadCloser(resp.Body, end-skip), nil
-	}
-
-	return resp.Body, nil
-}
-
-// Update in to the object with the modTime given of the given size
-//
-// When called from outside an Fs by rclone, src.Size() will always be >= 0.
-// But for unknown-sized objects (indicated by src.Size() == -1), Upload should either
-// return an error or update the object properly (rather than e.g. calling panic).
-func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, options ...fs.OpenOption) (err error) {
-
-	srcRemote := o.Remote()
-
-	remote := path.Join(o.fs.root, srcRemote)
-	folderPath, fileName := path.Split(remote)
-
-	UseUniqueFileName := new(bool)
-	*UseUniqueFileName = false
-
-	var resp *client.UploadResult
-
-	err = o.fs.pacer.Call(func() (bool, error) {
-		var res *http.Response
-		res, resp, err = o.fs.ik.Upload(ctx, in, client.UploadParam{
-			FileName:      fileName,
-			Folder:        folderPath,
-			IsPrivateFile: o.file.IsPrivateFile,
-		})
-
-		return o.fs.shouldRetry(ctx, res, err)
-	})
-
-	if err != nil {
-		return err
-	}
-
-	fileID := resp.FileID
-
-	_, file, err := o.fs.ik.File(ctx, fileID)
-
-	if err != nil {
-		return err
-	}
-
-	o.file = *file
-
-	return nil
-}
-
-// Remove this object
-func (o *Object) Remove(ctx context.Context) (err error) {
-	err = o.fs.pacer.Call(func() (bool, error) {
-		var res *http.Response
-		res, err = o.fs.ik.DeleteFile(ctx, o.file.FileID)
-
-		return o.fs.shouldRetry(ctx, res, err)
-	})
-
-	return err
-}
-
-// SetModTime sets the metadata on the object to set the modification date
-func (o *Object) SetModTime(ctx context.Context, t time.Time) error {
-	return fs.ErrorCantSetModTime
-}
-
-func uploadFile(ctx context.Context, f *Fs, in io.Reader, srcRemote string, options ...fs.OpenOption) (fs.Object, error) {
-	remote := path.Join(f.root, srcRemote)
-	folderPath, fileName := path.Split(remote)
-
-	folderPath = f.EncodePath(folderPath)
-	fileName = f.EncodeFileName(fileName)
-
-	UseUniqueFileName := new(bool)
-	*UseUniqueFileName = false
-
-	err := f.pacer.Call(func() (bool, error) {
-		var res *http.Response
-		var err error
-		res, _, err = f.ik.Upload(ctx, in, client.UploadParam{
-			FileName:      fileName,
-			Folder:        folderPath,
-			IsPrivateFile: &f.opt.OnlySigned,
-		})
-
-		return f.shouldRetry(ctx, res, err)
-	})
-
-	if err != nil {
-		return nil, err
-	}
-
-	return f.NewObject(ctx, srcRemote)
-}
-
-// Metadata returns the metadata for the object
-func (o *Object) Metadata(ctx context.Context) (metadata fs.Metadata, err error) {
-
-	metadata.Set("btime", o.file.CreatedAt.Format(time.RFC3339))
-	metadata.Set("size", strconv.FormatUint(o.file.Size, 10))
-	metadata.Set("file-type", o.file.FileType)
-	metadata.Set("height", strconv.Itoa(o.file.Height))
-	metadata.Set("width", strconv.Itoa(o.file.Width))
-	metadata.Set("has-alpha", strconv.FormatBool(o.file.HasAlpha))
-
-	for k, v := range o.file.EmbeddedMetadata {
-		metadata.Set(k, fmt.Sprint(v))
-	}
-
-	if o.file.Tags != nil {
-		metadata.Set("tags", strings.Join(o.file.Tags, ","))
-	}
-
-	if o.file.CustomCoordinates != nil {
-		metadata.Set("custom-coordinates", *o.file.CustomCoordinates)
-	}
-
-	if o.file.IsPrivateFile != nil {
-		metadata.Set("is-private-file", strconv.FormatBool(*o.file.IsPrivateFile))
-	}
-
-	if o.file.AITags != nil {
-		googleTags := []string{}
-		awsTags := []string{}
-
-		for _, tag := range o.file.AITags {
-			if tag.Source == "google-auto-tagging" {
-				googleTags = append(googleTags, tag.Name)
-			} else if tag.Source == "aws-auto-tagging" {
-				awsTags = append(awsTags, tag.Name)
-			}
-		}
-
-		if len(googleTags) > 0 {
-			metadata.Set("google-tags", strings.Join(googleTags, ","))
-		}
-
-		if len(awsTags) > 0 {
-			metadata.Set("aws-tags", strings.Join(awsTags, ","))
-		}
-	}
-
-	return metadata, nil
-}
-
-// Copy src to this remote using server-side move operations.
-//
-// This is stored with the remote path given.
-//
-// It returns the destination Object and a possible error.
-//
-// Will only be called if src.Fs().Name() == f.Name()
-//
-// If it isn't possible then return fs.ErrorCantMove
-func (f *Fs) Copy(ctx context.Context, src fs.Object, remote string) (fs.Object, error) {
-	srcObj, ok := src.(*Object)
-	if !ok {
-		return nil, fs.ErrorCantMove
-	}
-
-	file, err := srcObj.Open(ctx)
-
-	if err != nil {
-		return nil, err
-	}
-
-	return uploadFile(ctx, f, file, remote)
-}
-
-// Check the interfaces are satisfied.
-var (
-	_ fs.Fs           = &Fs{}
-	_ fs.Purger       = &Fs{}
-	_ fs.PublicLinker = &Fs{}
-	_ fs.Object       = &Object{}
-	_ fs.Copier       = &Fs{}
-)

backend/imagekit/imagekit_test.go

@@ -1,18 +0,0 @@
-package imagekit
-
-import (
-	"testing"
-
-	"github.com/rclone/rclone/fstest"
-	"github.com/rclone/rclone/fstest/fstests"
-)
-
-func TestIntegration(t *testing.T) {
-	debug := true
-	fstest.Verbose = &debug
-	fstests.Run(t, &fstests.Opt{
-		RemoteName:      "TestImageKit:",
-		NilObject:       (*Object)(nil),
-		SkipFsCheckWrap: true,
-	})
-}

backend/imagekit/util.go

@@ -1,193 +0,0 @@
-package imagekit
-
-import (
-	"context"
-	"fmt"
-	"net/http"
-	"strconv"
-	"time"
-
-	"github.com/rclone/rclone/backend/imagekit/client"
-	"github.com/rclone/rclone/fs"
-	"github.com/rclone/rclone/fs/fserrors"
-	"github.com/rclone/rclone/lib/pacer"
-)
-
-func (f *Fs) getFiles(ctx context.Context, path string, includeVersions bool) (files []client.File, err error) {
-
-	files = make([]client.File, 0)
-
-	var hasMore = true
-
-	for hasMore {
-		err = f.pacer.Call(func() (bool, error) {
-			var data *[]client.File
-			var res *http.Response
-			res, data, err = f.ik.Files(ctx, client.FilesOrFolderParam{
-				Skip:  len(files),
-				Limit: 100,
-				Path:  path,
-			}, includeVersions)
-
-			hasMore = !(len(*data) == 0 || len(*data) < 100)
-
-			if len(*data) > 0 {
-				files = append(files, *data...)
-			}
-
-			return f.shouldRetry(ctx, res, err)
-		})
-	}
-
-	if err != nil {
-		return make([]client.File, 0), err
-	}
-
-	return files, nil
-}
-
-func (f *Fs) getFolders(ctx context.Context, path string) (folders []client.Folder, err error) {
-
-	folders = make([]client.Folder, 0)
-
-	var hasMore = true
-
-	for hasMore {
-		err = f.pacer.Call(func() (bool, error) {
-			var data *[]client.Folder
-			var res *http.Response
-			res, data, err = f.ik.Folders(ctx, client.FilesOrFolderParam{
-				Skip:  len(folders),
-				Limit: 100,
-				Path:  path,
-			})
-
-			hasMore = !(len(*data) == 0 || len(*data) < 100)
-
-			if len(*data) > 0 {
-				folders = append(folders, *data...)
-			}
-
-			return f.shouldRetry(ctx, res, err)
-		})
-	}
-
-	if err != nil {
-		return make([]client.Folder, 0), err
-	}
-
-	return folders, nil
-}
-
-func (f *Fs) getFileByName(ctx context.Context, path string, name string) (file *client.File) {
-
-	err := f.pacer.Call(func() (bool, error) {
-		res, data, err := f.ik.Files(ctx, client.FilesOrFolderParam{
-			Limit:       1,
-			Path:        path,
-			SearchQuery: fmt.Sprintf(`type = "file" AND name = %s`, strconv.Quote(name)),
-		}, false)
-
-		if len(*data) == 0 {
-			file = nil
-		} else {
-			file = &(*data)[0]
-		}
-
-		return f.shouldRetry(ctx, res, err)
-	})
-
-	if err != nil {
-		return nil
-	}
-
-	return file
-}
-
-func (f *Fs) getFolderByName(ctx context.Context, path string, name string) (folder *client.Folder, err error) {
-	err = f.pacer.Call(func() (bool, error) {
-		res, data, err := f.ik.Folders(ctx, client.FilesOrFolderParam{
-			Limit:       1,
-			Path:        path,
-			SearchQuery: fmt.Sprintf(`type = "folder" AND name = %s`, strconv.Quote(name)),
-		})
-
-		if len(*data) == 0 {
-			folder = nil
-		} else {
-			folder = &(*data)[0]
-		}
-
-		return f.shouldRetry(ctx, res, err)
-	})
-
-	if err != nil {
-		return nil, err
-	}
-
-	return folder, nil
-}
-
-// retryErrorCodes is a slice of error codes that we will retry
-var retryErrorCodes = []int{
-	401, // Unauthorized (e.g. "Token has expired")
-	408, // Request Timeout
-	429, // Rate exceeded.
-	500, // Get occasional 500 Internal Server Error
-	503, // Service Unavailable
-	504, // Gateway Time-out
-}
-
-func shouldRetryHTTP(resp *http.Response, retryErrorCodes []int) bool {
-	if resp == nil {
-		return false
-	}
-	for _, e := range retryErrorCodes {
-		if resp.StatusCode == e {
-			return true
-		}
-	}
-	return false
-}
-
-func (f *Fs) shouldRetry(ctx context.Context, resp *http.Response, err error) (bool, error) {
-	if fserrors.ContextError(ctx, &err) {
-		return false, err
-	}
-
-	if resp != nil && (resp.StatusCode == 429 || resp.StatusCode == 503) {
-		var retryAfter = 1
-		retryAfterString := resp.Header.Get("X-RateLimit-Reset")
-		if retryAfterString != "" {
-			var err error
-			retryAfter, err = strconv.Atoi(retryAfterString)
-			if err != nil {
-				fs.Errorf(f, "Malformed %s header %q: %v", "X-RateLimit-Reset", retryAfterString, err)
-			}
-		}
-
-		return true, pacer.RetryAfterError(err, time.Duration(retryAfter)*time.Millisecond)
-	}
-
-	return fserrors.ShouldRetry(err) || shouldRetryHTTP(resp, retryErrorCodes), err
-}
-
-// EncodePath encapsulates the logic for encoding a path
-func (f *Fs) EncodePath(str string) string {
-	return f.opt.Enc.FromStandardPath(str)
-}
-
-// DecodePath encapsulates the logic for decoding a path
-func (f *Fs) DecodePath(str string) string {
-	return f.opt.Enc.ToStandardPath(str)
-}
-
-// EncodeFileName encapsulates the logic for encoding a file name
-func (f *Fs) EncodeFileName(str string) string {
-	return f.opt.Enc.FromStandardName(str)
-}
-
-// DecodeFileName encapsulates the logic for decoding a file name
-func (f *Fs) DecodeFileName(str string) string {
-	return f.opt.Enc.ToStandardName(str)
-}

backend/internetarchive/internetarchive.go

@@ -802,7 +802,7 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		headers["x-archive-size-hint"] = fmt.Sprintf("%d", size)
 	}
 	var mdata fs.Metadata
-	mdata, err = fs.GetMetadataOptions(ctx, o.fs, src, options)
+	mdata, err = fs.GetMetadataOptions(ctx, src, options)
 	if err == nil && mdata != nil {
 		for mk, mv := range mdata {
 			mk = strings.ToLower(mk)

backend/jottacloud/api/types.go

@@ -395,7 +395,7 @@ type JottaFile struct {
 	State           string    `xml:"currentRevision>state"`
 	CreatedAt       JottaTime `xml:"currentRevision>created"`
 	ModifiedAt      JottaTime `xml:"currentRevision>modified"`
-	UpdatedAt       JottaTime `xml:"currentRevision>updated"`
+	Updated         JottaTime `xml:"currentRevision>updated"`
 	Size            int64     `xml:"currentRevision>size"`
 	MimeType        string    `xml:"currentRevision>mime"`
 	MD5             string    `xml:"currentRevision>md5"`

backend/jottacloud/jottacloud.go

@@ -92,33 +92,6 @@ func init() {
 		Description: "Jottacloud",
 		NewFs:       NewFs,
 		Config:      Config,
-		MetadataInfo: &fs.MetadataInfo{
-			Help: `Jottacloud has limited support for metadata, currently an extended set of timestamps.`,
-			System: map[string]fs.MetadataHelp{
-				"btime": {
-					Help:    "Time of file birth (creation), read from rclone metadata",
-					Type:    "RFC 3339",
-					Example: "2006-01-02T15:04:05.999999999Z07:00",
-				},
-				"mtime": {
-					Help:    "Time of last modification, read from rclone metadata",
-					Type:    "RFC 3339",
-					Example: "2006-01-02T15:04:05.999999999Z07:00",
-				},
-				"utime": {
-					Help:     "Time of last upload, when current revision was created, generated by backend",
-					Type:     "RFC 3339",
-					Example:  "2006-01-02T15:04:05.999999999Z07:00",
-					ReadOnly: true,
-				},
-				"content-type": {
-					Help:     "MIME type, also known as media type",
-					Type:     "string",
-					Example:  "text/plain",
-					ReadOnly: true,
-				},
-			},
-		},
 		Options: append(oauthutil.SharedOptions, []fs.Option{{
 			Name:     "md5_memory_limit",
 			Help:     "Files bigger than this will be cached on disk to calculate the MD5 if required.",
@@ -524,9 +497,7 @@ type Object struct {
 	remote      string
 	hasMetaData bool
 	size        int64
-	createTime  time.Time
 	modTime     time.Time
-	updateTime  time.Time
 	md5         string
 	mimeType    string
 }
@@ -1001,9 +972,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		CanHaveEmptyDirectories: true,
 		ReadMimeType:            true,
 		WriteMimeType:           false,
-		ReadMetadata:            true,
-		WriteMetadata:           true,
-		UserMetadata:            false,
 	}).Fill(ctx, f)
 	f.jfsSrv.SetErrorHandler(errorHandler)
 	if opt.TrashedOnly { // we cannot support showing Trashed Files when using ListR right now
@@ -1190,7 +1158,6 @@ func parseListRStream(ctx context.Context, r io.Reader, filesystem *Fs, callback
 			remote:      filesystem.opt.Enc.ToStandardPath(path.Join(f.Path, f.Name)),
 			size:        f.Size,
 			md5:         f.Checksum,
-			createTime:  time.Time(f.Created),
 			modTime:     time.Time(f.Modified),
 		})
 	}
@@ -1420,7 +1387,7 @@ func (f *Fs) Purge(ctx context.Context, dir string) error {
 // is currently in trash, but can be made to match, it will be
 // restored. Returns ErrorObjectNotFound if upload will be necessary
 // to get a matching remote file.
-func (f *Fs) createOrUpdate(ctx context.Context, file string, createTime time.Time, modTime time.Time, size int64, md5 string) (info *api.JottaFile, err error) {
+func (f *Fs) createOrUpdate(ctx context.Context, file string, modTime time.Time, size int64, md5 string) (info *api.JottaFile, err error) {
 	opts := rest.Opts{
 		Method:       "POST",
 		Path:         f.filePath(file),
@@ -1430,10 +1397,11 @@ func (f *Fs) createOrUpdate(ctx context.Context, file string, createTime time.Ti
 
 	opts.Parameters.Set("cphash", "true")
 
+	fileDate := api.JottaTime(modTime).String()
 	opts.ExtraHeaders["JSize"] = strconv.FormatInt(size, 10)
 	opts.ExtraHeaders["JMd5"] = md5
-	opts.ExtraHeaders["JCreated"] = api.JottaTime(createTime).String()
-	opts.ExtraHeaders["JModified"] = api.JottaTime(modTime).String()
+	opts.ExtraHeaders["JCreated"] = fileDate
+	opts.ExtraHeaders["JModified"] = fileDate
 
 	var resp *http.Response
 	err = f.pacer.Call(func() (bool, error) {
@@ -1496,7 +1464,7 @@ func (f *Fs) Copy(ctx context.Context, src fs.Object, remote string) (fs.Object,
 	// if destination was a trashed file then after a successful copy the copied file is still in trash (bug in api?)
 	if err == nil && bool(info.Deleted) && !f.opt.TrashedOnly && info.State == "COMPLETED" {
 		fs.Debugf(src, "Server-side copied to trashed destination, restoring")
-		info, err = f.createOrUpdate(ctx, remote, srcObj.createTime, srcObj.modTime, srcObj.size, srcObj.md5)
+		info, err = f.createOrUpdate(ctx, remote, srcObj.modTime, srcObj.size, srcObj.md5)
 	}
 
 	if err != nil {
@@ -1759,9 +1727,7 @@ func (o *Object) setMetaData(info *api.JottaFile) (err error) {
 	o.size = info.Size
 	o.md5 = info.MD5
 	o.mimeType = info.MimeType
-	o.createTime = time.Time(info.CreatedAt)
 	o.modTime = time.Time(info.ModifiedAt)
-	o.updateTime = time.Time(info.UpdatedAt)
 	return nil
 }
 
@@ -1806,7 +1772,7 @@ func (o *Object) SetModTime(ctx context.Context, modTime time.Time) error {
 	// (note that if size/md5 does not match, the file content will
 	// also be modified if deduplication is possible, i.e. it is
 	// important to use correct/latest values)
-	_, err = o.fs.createOrUpdate(ctx, o.remote, o.createTime, modTime, o.size, o.md5)
+	_, err = o.fs.createOrUpdate(ctx, o.remote, modTime, o.size, o.md5)
 	if err != nil {
 		if err == fs.ErrorObjectNotFound {
 			// file was modified (size/md5 changed) between readMetaData and createOrUpdate?
@@ -1943,37 +1909,6 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		// Wrap the accounting back onto the stream
 		in = wrap(in)
 	}
-	// Fetch metadata if --metadata is in use
-	meta, err := fs.GetMetadataOptions(ctx, o.fs, src, options)
-	if err != nil {
-		return fmt.Errorf("failed to read metadata from source object: %w", err)
-	}
-	var createdTime string
-	var modTime string
-	if meta != nil {
-		if v, ok := meta["btime"]; ok {
-			t, err := time.Parse(time.RFC3339Nano, v) // metadata stores RFC3339Nano timestamps
-			if err != nil {
-				fs.Debugf(o, "failed to parse metadata btime: %q: %v", v, err)
-			} else {
-				createdTime = api.Rfc3339Time(t).String() // jottacloud api wants RFC3339 timestamps
-			}
-		}
-		if v, ok := meta["mtime"]; ok {
-			t, err := time.Parse(time.RFC3339Nano, v)
-			if err != nil {
-				fs.Debugf(o, "failed to parse metadata mtime: %q: %v", v, err)
-			} else {
-				modTime = api.Rfc3339Time(t).String()
-			}
-		}
-	}
-	if modTime == "" { // prefer mtime in meta as Modified time, fallback to source ModTime
-		modTime = api.Rfc3339Time(src.ModTime(ctx)).String()
-	}
-	if createdTime == "" { // if no Created time set same as Modified
-		createdTime = modTime
-	}
 
 	// use the api to allocate the file first and get resume / deduplication info
 	var resp *http.Response
@@ -1983,12 +1918,13 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		Options:      options,
 		ExtraHeaders: make(map[string]string),
 	}
+	fileDate := api.Rfc3339Time(src.ModTime(ctx)).String()
 
 	// the allocate request
 	var request = api.AllocateFileRequest{
 		Bytes:    size,
-		Created:  createdTime,
-		Modified: modTime,
+		Created:  fileDate,
+		Modified: fileDate,
 		Md5:      md5String,
 		Path:     o.fs.allocatePathRaw(o.remote, true),
 	}
@@ -2003,10 +1939,7 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		return err
 	}
 
-	// If the file state is INCOMPLETE and CORRUPT, we must upload it.
-	// Else, if the file state is COMPLETE, we don't need to upload it because
-	// the content is already there, possibly it was created with deduplication,
-	// and also any metadata changes are already performed by the allocate request.
+	// If the file state is INCOMPLETE and CORRUPT, try to upload a then
 	if response.State != "COMPLETED" {
 		// how much do we still have to upload?
 		remainingBytes := size - response.ResumePos
@@ -2030,18 +1963,22 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 		}
 
 		// send the remaining bytes
-		_, err = o.fs.apiSrv.CallJSON(ctx, &opts, nil, &result)
+		resp, err = o.fs.apiSrv.CallJSON(ctx, &opts, nil, &result)
 		if err != nil {
 			return err
 		}
 
-		// Upload response contains main metadata properties (size, md5 and modTime)
-		// which could be set back to the object, but it does not contain the
-		// necessary information to set the createTime and updateTime properties,
-		// so must therefore perform a read instead.
+		// finally update the meta data
+		o.hasMetaData = true
+		o.size = result.Bytes
+		o.md5 = result.Md5
+		o.modTime = time.Unix(result.Modified/1000, 0)
+	} else {
+		// If the file state is COMPLETE we don't need to upload it because the file was already found but we still need to update our metadata
+		return o.readMetaData(ctx, true)
 	}
-	// in any case we must update the object meta data
-	return o.readMetaData(ctx, true)
+
+	return nil
 }
 
 func (o *Object) remove(ctx context.Context, hard bool) error {
@@ -2076,22 +2013,6 @@ func (o *Object) Remove(ctx context.Context) error {
 	return o.remove(ctx, o.fs.opt.HardDelete)
 }
 
-// Metadata returns metadata for an object
-//
-// It should return nil if there is no Metadata
-func (o *Object) Metadata(ctx context.Context) (metadata fs.Metadata, err error) {
-	err = o.readMetaData(ctx, false)
-	if err != nil {
-		fs.Logf(o, "Failed to read metadata: %v", err)
-		return nil, err
-	}
-	metadata.Set("btime", o.createTime.Format(time.RFC3339Nano)) // metadata timestamps should be RFC3339Nano
-	metadata.Set("mtime", o.modTime.Format(time.RFC3339Nano))
-	metadata.Set("utime", o.updateTime.Format(time.RFC3339Nano))
-	metadata.Set("content-type", o.mimeType)
-	return metadata, nil
-}
-
 // Check the interfaces are satisfied
 var (
 	_ fs.Fs           = (*Fs)(nil)
@@ -2106,5 +2027,4 @@ var (
 	_ fs.CleanUpper   = (*Fs)(nil)
 	_ fs.Object       = (*Object)(nil)
 	_ fs.MimeTyper    = (*Object)(nil)
-	_ fs.Metadataer   = (*Object)(nil)
 )

backend/jottacloud/jottacloud_internal_test.go

@@ -1,17 +1,11 @@
 package jottacloud
 
 import (
-	"context"
 	"crypto/md5"
 	"fmt"
 	"io"
 	"testing"
-	"time"
 
-	"github.com/rclone/rclone/fs"
-	"github.com/rclone/rclone/fstest"
-	"github.com/rclone/rclone/fstest/fstests"
-	"github.com/rclone/rclone/lib/random"
 	"github.com/rclone/rclone/lib/readers"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -46,48 +40,3 @@ func TestReadMD5(t *testing.T) {
 		})
 	}
 }
-
-func (f *Fs) InternalTestMetadata(t *testing.T) {
-	ctx := context.Background()
-	contents := random.String(1000)
-
-	item := fstest.NewItem("test-metadata", contents, fstest.Time("2001-05-06T04:05:06.499999999Z"))
-	utime := time.Now()
-	metadata := fs.Metadata{
-		"btime": "2009-05-06T04:05:06.499999999Z",
-		"mtime": "2010-06-07T08:09:07.599999999Z",
-		//"utime" - read-only
-		//"content-type" - read-only
-	}
-	obj := fstests.PutTestContentsMetadata(ctx, t, f, &item, contents, true, "text/html", metadata)
-	defer func() {
-		assert.NoError(t, obj.Remove(ctx))
-	}()
-	o := obj.(*Object)
-	gotMetadata, err := o.Metadata(ctx)
-	require.NoError(t, err)
-	for k, v := range metadata {
-		got := gotMetadata[k]
-		switch k {
-		case "btime":
-			assert.True(t, fstest.Time(v).Truncate(f.Precision()).Equal(fstest.Time(got)), fmt.Sprintf("btime not equal want %v got %v", v, got))
-		case "mtime":
-			assert.True(t, fstest.Time(v).Truncate(f.Precision()).Equal(fstest.Time(got)), fmt.Sprintf("btime not equal want %v got %v", v, got))
-		case "utime":
-			gotUtime := fstest.Time(got)
-			dt := gotUtime.Sub(utime)
-			assert.True(t, dt < time.Minute && dt > -time.Minute, fmt.Sprintf("utime more than 1 minute out want %v got %v delta %v", utime, gotUtime, dt))
-			assert.True(t, fstest.Time(v).Equal(fstest.Time(got)))
-		case "content-type":
-			assert.True(t, o.MimeType(ctx) == got)
-		default:
-			assert.Equal(t, v, got, k)
-		}
-	}
-}
-
-func (f *Fs) InternalTest(t *testing.T) {
-	t.Run("Metadata", f.InternalTestMetadata)
-}
-
-var _ fstests.InternalTester = (*Fs)(nil)

backend/linkbox/linkbox.go

@@ -1,897 +0,0 @@
-// Package linkbox provides an interface to the linkbox.to Cloud storage system.
-//
-// API docs: https://www.linkbox.to/api-docs
-package linkbox
-
-/*
-   Extras
-   - PublicLink - NO - sharing doesn't share the actual file, only a page with it on
-   - Move - YES - have Move and Rename file APIs so is possible
-   - MoveDir - NO - probably not possible - have Move but no Rename
-*/
-
-import (
-	"bytes"
-	"context"
-	"crypto/md5"
-	"fmt"
-	"io"
-	"net/http"
-	"net/url"
-	"path"
-	"regexp"
-	"strconv"
-	"strings"
-	"time"
-
-	"github.com/rclone/rclone/fs"
-	"github.com/rclone/rclone/fs/config/configmap"
-	"github.com/rclone/rclone/fs/config/configstruct"
-	"github.com/rclone/rclone/fs/fserrors"
-	"github.com/rclone/rclone/fs/fshttp"
-	"github.com/rclone/rclone/fs/hash"
-	"github.com/rclone/rclone/lib/dircache"
-	"github.com/rclone/rclone/lib/pacer"
-	"github.com/rclone/rclone/lib/rest"
-)
-
-const (
-	maxEntitiesPerPage = 1024
-	minSleep           = 200 * time.Millisecond
-	maxSleep           = 2 * time.Second
-	pacerBurst         = 1
-	linkboxAPIURL      = "https://www.linkbox.to/api/open/"
-	rootID             = "0" // ID of root directory
-)
-
-func init() {
-	fsi := &fs.RegInfo{
-		Name:        "linkbox",
-		Description: "Linkbox",
-		NewFs:       NewFs,
-		Options: []fs.Option{{
-			Name:      "token",
-			Help:      "Token from https://www.linkbox.to/admin/account",
-			Sensitive: true,
-			Required:  true,
-		}},
-	}
-	fs.Register(fsi)
-}
-
-// Options defines the configuration for this backend
-type Options struct {
-	Token string `config:"token"`
-}
-
-// Fs stores the interface to the remote Linkbox files
-type Fs struct {
-	name     string
-	root     string
-	opt      Options            // options for this backend
-	features *fs.Features       // optional features
-	ci       *fs.ConfigInfo     // global config
-	srv      *rest.Client       // the connection to the server
-	dirCache *dircache.DirCache // Map of directory path to directory id
-	pacer    *fs.Pacer
-}
-
-// Object is a remote object that has been stat'd (so it exists, but is not necessarily open for reading)
-type Object struct {
-	fs          *Fs
-	remote      string
-	size        int64
-	modTime     time.Time
-	contentType string
-	fullURL     string
-	dirID       int64
-	itemID      string // and these IDs are for files
-	id          int64  // these IDs appear to apply to directories
-	isDir       bool
-}
-
-// NewFs creates a new Fs object from the name and root. It connects to
-// the host specified in the config file.
-func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, error) {
-	root = strings.Trim(root, "/")
-	// Parse config into Options struct
-
-	opt := new(Options)
-	err := configstruct.Set(m, opt)
-	if err != nil {
-		return nil, err
-	}
-
-	ci := fs.GetConfig(ctx)
-
-	f := &Fs{
-		name: name,
-		opt:  *opt,
-		root: root,
-		ci:   ci,
-		srv:  rest.NewClient(fshttp.NewClient(ctx)),
-
-		pacer: fs.NewPacer(ctx, pacer.NewDefault(pacer.MinSleep(minSleep), pacer.MaxSleep(maxSleep))),
-	}
-	f.dirCache = dircache.New(root, rootID, f)
-
-	f.features = (&fs.Features{
-		CanHaveEmptyDirectories: true,
-		CaseInsensitive:         true,
-	}).Fill(ctx, f)
-
-	// Find the current root
-	err = f.dirCache.FindRoot(ctx, false)
-	if err != nil {
-		// Assume it is a file
-		newRoot, remote := dircache.SplitPath(root)
-		tempF := *f
-		tempF.dirCache = dircache.New(newRoot, rootID, &tempF)
-		tempF.root = newRoot
-		// Make new Fs which is the parent
-		err = tempF.dirCache.FindRoot(ctx, false)
-		if err != nil {
-			// No root so return old f
-			return f, nil
-		}
-		_, err := tempF.NewObject(ctx, remote)
-		if err != nil {
-			if err == fs.ErrorObjectNotFound {
-				// File doesn't exist so return old f
-				return f, nil
-			}
-			return nil, err
-		}
-		f.features.Fill(ctx, &tempF)
-		// XXX: update the old f here instead of returning tempF, since
-		// `features` were already filled with functions having *f as a receiver.
-		// See https://github.com/rclone/rclone/issues/2182
-		f.dirCache = tempF.dirCache
-		f.root = tempF.root
-		// return an error with an fs which points to the parent
-		return f, fs.ErrorIsFile
-	}
-	return f, nil
-}
-
-type entity struct {
-	Type   string `json:"type"`
-	Name   string `json:"name"`
-	URL    string `json:"url"`
-	Ctime  int64  `json:"ctime"`
-	Size   int64  `json:"size"`
-	ID     int64  `json:"id"`
-	Pid    int64  `json:"pid"`
-	ItemID string `json:"item_id"`
-}
-
-// Return true if the entity is a directory
-func (e *entity) isDir() bool {
-	return e.Type == "dir" || e.Type == "sdir"
-}
-
-type data struct {
-	Entities []entity `json:"list"`
-}
-type fileSearchRes struct {
-	response
-	SearchData data `json:"data"`
-}
-
-// Set an object info from an entity
-func (o *Object) set(e *entity) {
-	o.modTime = time.Unix(e.Ctime, 0)
-	o.contentType = e.Type
-	o.size = e.Size
-	o.fullURL = e.URL
-	o.isDir = e.isDir()
-	o.id = e.ID
-	o.itemID = e.ItemID
-	o.dirID = e.Pid
-}
-
-// Call linkbox with the query in opts and return result
-//
-// This will be checked for error and an error will be returned if Status != 1
-func getUnmarshaledResponse(ctx context.Context, f *Fs, opts *rest.Opts, result interface{}) error {
-	err := f.pacer.Call(func() (bool, error) {
-		resp, err := f.srv.CallJSON(ctx, opts, nil, &result)
-		return f.shouldRetry(ctx, resp, err)
-	})
-	if err != nil {
-		return err
-	}
-	responser := result.(responser)
-	if responser.IsError() {
-		return responser
-	}
-	return nil
-}
-
-// list the objects into the function supplied
-//
-// If directories is set it only sends directories
-// User function to process a File item from listAll
-//
-// Should return true to finish processing
-type listAllFn func(*entity) bool
-
-// Search is a bit fussy about which characters match
-//
-// If the name doesn't match this then do an dir list instead
-var searchOK = regexp.MustCompile(`^[a-zA-Z0-9_ .]+$`)
-
-// Lists the directory required calling the user function on each item found
-//
-// If the user fn ever returns true then it early exits with found = true
-//
-// If you set name then search ignores dirID. name is a substring
-// search also so name="dir" matches "sub dir" also. This filters it
-// down so it only returns items in dirID
-func (f *Fs) listAll(ctx context.Context, dirID string, name string, fn listAllFn) (found bool, err error) {
-	var (
-		pageNumber       = 0
-		numberOfEntities = maxEntitiesPerPage
-	)
-	name = strings.TrimSpace(name) // search doesn't like spaces
-	if !searchOK.MatchString(name) {
-		// If name isn't good then do an unbounded search
-		name = ""
-	}
-OUTER:
-	for numberOfEntities == maxEntitiesPerPage {
-		pageNumber++
-		opts := &rest.Opts{
-			Method:  "GET",
-			RootURL: linkboxAPIURL,
-			Path:    "file_search",
-			Parameters: url.Values{
-				"token":    {f.opt.Token},
-				"name":     {name},
-				"pid":      {dirID},
-				"pageNo":   {itoa(pageNumber)},
-				"pageSize": {itoa64(maxEntitiesPerPage)},
-			},
-		}
-
-		var responseResult fileSearchRes
-		err = getUnmarshaledResponse(ctx, f, opts, &responseResult)
-		if err != nil {
-			return false, fmt.Errorf("getting files failed: %w", err)
-
-		}
-
-		numberOfEntities = len(responseResult.SearchData.Entities)
-
-		for _, entity := range responseResult.SearchData.Entities {
-			if itoa64(entity.Pid) != dirID {
-				// when name != "" this returns from all directories, so ignore not this one
-				continue
-			}
-			if fn(&entity) {
-				found = true
-				break OUTER
-			}
-		}
-		if pageNumber > 100000 {
-			return false, fmt.Errorf("too many results")
-		}
-	}
-	return found, nil
-}
-
-// Turn 64 bit int to string
-func itoa64(i int64) string {
-	return strconv.FormatInt(i, 10)
-}
-
-// Turn int to string
-func itoa(i int) string {
-	return itoa64(int64(i))
-}
-
-func splitDirAndName(remote string) (dir string, name string) {
-	lastSlashPosition := strings.LastIndex(remote, "/")
-	if lastSlashPosition == -1 {
-		dir = ""
-		name = remote
-	} else {
-		dir = remote[:lastSlashPosition]
-		name = remote[lastSlashPosition+1:]
-	}
-
-	// fs.Debugf(nil, "splitDirAndName remote = {%s}, dir = {%s}, name = {%s}", remote, dir, name)
-
-	return dir, name
-}
-
-// FindLeaf finds a directory of name leaf in the folder with ID directoryID
-func (f *Fs) FindLeaf(ctx context.Context, directoryID, leaf string) (directoryIDOut string, found bool, err error) {
-	// Find the leaf in directoryID
-	found, err = f.listAll(ctx, directoryID, leaf, func(entity *entity) bool {
-		if entity.isDir() && strings.EqualFold(entity.Name, leaf) {
-			directoryIDOut = itoa64(entity.ID)
-			return true
-		}
-		return false
-	})
-	return directoryIDOut, found, err
-}
-
-// Returned from "folder_create"
-type folderCreateRes struct {
-	response
-	Data struct {
-		DirID int64 `json:"dirId"`
-	} `json:"data"`
-}
-
-// CreateDir makes a directory with dirID as parent and name leaf
-func (f *Fs) CreateDir(ctx context.Context, dirID, leaf string) (newID string, err error) {
-	// fs.Debugf(f, "CreateDir(%q, %q)\n", dirID, leaf)
-	opts := &rest.Opts{
-		Method:  "GET",
-		RootURL: linkboxAPIURL,
-		Path:    "folder_create",
-		Parameters: url.Values{
-			"token":       {f.opt.Token},
-			"name":        {leaf},
-			"pid":         {dirID},
-			"isShare":     {"0"},
-			"canInvite":   {"1"},
-			"canShare":    {"1"},
-			"withBodyImg": {"1"},
-			"desc":        {""},
-		},
-	}
-
-	response := folderCreateRes{}
-	err = getUnmarshaledResponse(ctx, f, opts, &response)
-	if err != nil {
-		// response status 1501 means that directory already exists
-		if response.Status == 1501 {
-			return newID, fmt.Errorf("couldn't find already created directory: %w", fs.ErrorDirNotFound)
-		}
-		return newID, fmt.Errorf("CreateDir failed: %w", err)
-
-	}
-	if response.Data.DirID == 0 {
-		return newID, fmt.Errorf("API returned 0 for ID of newly created directory")
-	}
-	return itoa64(response.Data.DirID), nil
-}
-
-// List the objects and directories in dir into entries.  The
-// entries can be returned in any order but should be for a
-// complete directory.
-//
-// dir should be "" to list the root, and should not have
-// trailing slashes.
-//
-// This should return ErrDirNotFound if the directory isn't
-// found.
-func (f *Fs) List(ctx context.Context, dir string) (entries fs.DirEntries, err error) {
-	// fs.Debugf(f, "List method dir = {%s}", dir)
-	directoryID, err := f.dirCache.FindDir(ctx, dir, false)
-	if err != nil {
-		return nil, err
-	}
-	_, err = f.listAll(ctx, directoryID, "", func(entity *entity) bool {
-		remote := path.Join(dir, entity.Name)
-		if entity.isDir() {
-			id := itoa64(entity.ID)
-			modTime := time.Unix(entity.Ctime, 0)
-			d := fs.NewDir(remote, modTime).SetID(id).SetParentID(itoa64(entity.Pid))
-			entries = append(entries, d)
-			// cache the directory ID for later lookups
-			f.dirCache.Put(remote, id)
-		} else {
-			o := &Object{
-				fs:     f,
-				remote: remote,
-			}
-			o.set(entity)
-			entries = append(entries, o)
-		}
-		return false
-	})
-	if err != nil {
-		return nil, err
-	}
-	return entries, nil
-}
-
-// get an entity with leaf from dirID
-func getEntity(ctx context.Context, f *Fs, leaf string, directoryID string, token string) (*entity, error) {
-	var result *entity
-	var resultErr = fs.ErrorObjectNotFound
-	_, err := f.listAll(ctx, directoryID, leaf, func(entity *entity) bool {
-		if strings.EqualFold(entity.Name, leaf) {
-			// fs.Debugf(f, "getObject found entity.Name {%s} name {%s}", entity.Name, name)
-			if entity.isDir() {
-				result = nil
-				resultErr = fs.ErrorIsDir
-			} else {
-				result = entity
-				resultErr = nil
-			}
-			return true
-		}
-		return false
-	})
-	if err != nil {
-		return nil, err
-	}
-	return result, resultErr
-}
-
-// NewObject finds the Object at remote.  If it can't be found
-// it returns the error ErrorObjectNotFound.
-//
-// If remote points to a directory then it should return
-// ErrorIsDir if possible without doing any extra work,
-// otherwise ErrorObjectNotFound.
-func (f *Fs) NewObject(ctx context.Context, remote string) (fs.Object, error) {
-	leaf, dirID, err := f.dirCache.FindPath(ctx, remote, false)
-	if err != nil {
-		if err == fs.ErrorDirNotFound {
-			return nil, fs.ErrorObjectNotFound
-		}
-		return nil, err
-	}
-
-	entity, err := getEntity(ctx, f, leaf, dirID, f.opt.Token)
-	if err != nil {
-		return nil, err
-	}
-	o := &Object{
-		fs:     f,
-		remote: remote,
-	}
-	o.set(entity)
-	return o, nil
-}
-
-// Mkdir makes the directory (container, bucket)
-//
-// Shouldn't return an error if it already exists
-func (f *Fs) Mkdir(ctx context.Context, dir string) error {
-	_, err := f.dirCache.FindDir(ctx, dir, true)
-	return err
-}
-
-func (f *Fs) purgeCheck(ctx context.Context, dir string, check bool) error {
-	if check {
-		entries, err := f.List(ctx, dir)
-		if err != nil {
-			return err
-		}
-		if len(entries) != 0 {
-			return fs.ErrorDirectoryNotEmpty
-		}
-	}
-
-	directoryID, err := f.dirCache.FindDir(ctx, dir, false)
-	if err != nil {
-		return err
-	}
-	opts := &rest.Opts{
-		Method:  "GET",
-		RootURL: linkboxAPIURL,
-		Path:    "folder_del",
-		Parameters: url.Values{
-			"token":  {f.opt.Token},
-			"dirIds": {directoryID},
-		},
-	}
-
-	response := response{}
-	err = getUnmarshaledResponse(ctx, f, opts, &response)
-	if err != nil {
-		// Linkbox has some odd error returns here
-		if response.Status == 403 || response.Status == 500 {
-			return fs.ErrorDirNotFound
-		}
-		return fmt.Errorf("purge error: %w", err)
-	}
-
-	f.dirCache.FlushDir(dir)
-	if err != nil {
-		return err
-	}
-	return nil
-}
-
-// Rmdir removes the directory (container, bucket) if empty
-//
-// Return an error if it doesn't exist or isn't empty
-func (f *Fs) Rmdir(ctx context.Context, dir string) error {
-	return f.purgeCheck(ctx, dir, true)
-}
-
-// SetModTime sets modTime on a particular file
-func (o *Object) SetModTime(ctx context.Context, modTime time.Time) error {
-	return fs.ErrorCantSetModTime
-}
-
-// Open opens the file for read.  Call Close() on the returned io.ReadCloser
-func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (io.ReadCloser, error) {
-	var res *http.Response
-	downloadURL := o.fullURL
-	if downloadURL == "" {
-		_, name := splitDirAndName(o.Remote())
-		newObject, err := getEntity(ctx, o.fs, name, itoa64(o.dirID), o.fs.opt.Token)
-		if err != nil {
-			return nil, err
-		}
-		if newObject == nil {
-			// fs.Debugf(o.fs, "Open entity is empty: name = {%s}", name)
-			return nil, fs.ErrorObjectNotFound
-		}
-
-		downloadURL = newObject.URL
-	}
-
-	opts := &rest.Opts{
-		Method:  "GET",
-		RootURL: downloadURL,
-		Options: options,
-	}
-
-	err := o.fs.pacer.Call(func() (bool, error) {
-		var err error
-		res, err = o.fs.srv.Call(ctx, opts)
-		return o.fs.shouldRetry(ctx, res, err)
-	})
-
-	if err != nil {
-		return nil, fmt.Errorf("Open failed: %w", err)
-	}
-
-	return res.Body, nil
-}
-
-// Update in to the object with the modTime given of the given size
-//
-// When called from outside an Fs by rclone, src.Size() will always be >= 0.
-// But for unknown-sized objects (indicated by src.Size() == -1), Upload should either
-// return an error or update the object properly (rather than e.g. calling panic).
-func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, options ...fs.OpenOption) (err error) {
-	size := src.Size()
-	if size == 0 {
-		return fs.ErrorCantUploadEmptyFiles
-	} else if size < 0 {
-		return fmt.Errorf("can't upload files of unknown length")
-	}
-
-	remote := o.Remote()
-
-	// remove the file if it exists
-	if o.itemID != "" {
-		fs.Debugf(o, "Update: removing old file")
-		err = o.Remove(ctx)
-		if err != nil {
-			fs.Errorf(o, "Update: failed to remove existing file: %v", err)
-		}
-		o.itemID = ""
-	} else {
-		tmpObject, err := o.fs.NewObject(ctx, remote)
-		if err == nil {
-			fs.Debugf(o, "Update: removing old file")
-			err = tmpObject.Remove(ctx)
-			if err != nil {
-				fs.Errorf(o, "Update: failed to remove existing file: %v", err)
-			}
-		}
-	}
-
-	first10m := io.LimitReader(in, 10_485_760)
-	first10mBytes, err := io.ReadAll(first10m)
-	if err != nil {
-		return fmt.Errorf("Update err in reading file: %w", err)
-	}
-
-	// get upload authorization (step 1)
-	opts := &rest.Opts{
-		Method:  "GET",
-		RootURL: linkboxAPIURL,
-		Path:    "get_upload_url",
-		Options: options,
-		Parameters: url.Values{
-			"token":           {o.fs.opt.Token},
-			"fileMd5ofPre10m": {fmt.Sprintf("%x", md5.Sum(first10mBytes))},
-			"fileSize":        {itoa64(size)},
-		},
-	}
-
-	getFirstStepResult := getUploadURLResponse{}
-	err = getUnmarshaledResponse(ctx, o.fs, opts, &getFirstStepResult)
-	if err != nil {
-		if getFirstStepResult.Status != 600 {
-			return fmt.Errorf("Update err in unmarshaling response: %w", err)
-		}
-	}
-
-	switch getFirstStepResult.Status {
-	case 1:
-		// upload file using link from first step
-		var res *http.Response
-
-		file := io.MultiReader(bytes.NewReader(first10mBytes), in)
-
-		opts := &rest.Opts{
-			Method:        "PUT",
-			RootURL:       getFirstStepResult.Data.SignURL,
-			Options:       options,
-			Body:          file,
-			ContentLength: &size,
-		}
-
-		err = o.fs.pacer.CallNoRetry(func() (bool, error) {
-			res, err = o.fs.srv.Call(ctx, opts)
-			return o.fs.shouldRetry(ctx, res, err)
-		})
-
-		if err != nil {
-			return fmt.Errorf("update err in uploading file: %w", err)
-		}
-
-		_, err = io.ReadAll(res.Body)
-		if err != nil {
-			return fmt.Errorf("update err in reading response: %w", err)
-		}
-
-	case 600:
-		// Status means that we don't need to upload file
-		// We need only to make second step
-	default:
-		return fmt.Errorf("got unexpected message from Linkbox: %s", getFirstStepResult.Message)
-	}
-
-	leaf, dirID, err := o.fs.dirCache.FindPath(ctx, remote, false)
-	if err != nil {
-		return err
-	}
-
-	// create file item at Linkbox (second step)
-	opts = &rest.Opts{
-		Method:  "GET",
-		RootURL: linkboxAPIURL,
-		Path:    "folder_upload_file",
-		Options: options,
-		Parameters: url.Values{
-			"token":           {o.fs.opt.Token},
-			"fileMd5ofPre10m": {fmt.Sprintf("%x", md5.Sum(first10mBytes))},
-			"fileSize":        {itoa64(size)},
-			"pid":             {dirID},
-			"diyName":         {leaf},
-		},
-	}
-
-	getSecondStepResult := getUploadURLResponse{}
-	err = getUnmarshaledResponse(ctx, o.fs, opts, &getSecondStepResult)
-	if err != nil {
-		return fmt.Errorf("Update second step failed: %w", err)
-	}
-
-	// Try a few times to read the object after upload for eventual consistency
-	const maxTries = 10
-	var sleepTime = 100 * time.Millisecond
-	var entity *entity
-	for try := 1; try <= maxTries; try++ {
-		entity, err = getEntity(ctx, o.fs, leaf, dirID, o.fs.opt.Token)
-		if err == nil {
-			break
-		}
-		if err != fs.ErrorObjectNotFound {
-			return fmt.Errorf("Update failed to read object: %w", err)
-		}
-		fs.Debugf(o, "Trying to read object after upload: try again in %v (%d/%d)", sleepTime, try, maxTries)
-		time.Sleep(sleepTime)
-		sleepTime *= 2
-	}
-	if err != nil {
-		return err
-	}
-	o.set(entity)
-	return nil
-}
-
-// Remove this object
-func (o *Object) Remove(ctx context.Context) error {
-	opts := &rest.Opts{
-		Method:  "GET",
-		RootURL: linkboxAPIURL,
-		Path:    "file_del",
-		Parameters: url.Values{
-			"token":   {o.fs.opt.Token},
-			"itemIds": {o.itemID},
-		},
-	}
-	requestResult := getUploadURLResponse{}
-	err := getUnmarshaledResponse(ctx, o.fs, opts, &requestResult)
-	if err != nil {
-		return fmt.Errorf("could not Remove: %w", err)
-
-	}
-	return nil
-}
-
-// ModTime returns the modification time of the remote http file
-func (o *Object) ModTime(ctx context.Context) time.Time {
-	return o.modTime
-}
-
-// Remote the name of the remote HTTP file, relative to the fs root
-func (o *Object) Remote() string {
-	return o.remote
-}
-
-// Size returns the size in bytes of the remote http file
-func (o *Object) Size() int64 {
-	return o.size
-}
-
-// String returns the URL to the remote HTTP file
-func (o *Object) String() string {
-	if o == nil {
-		return "<nil>"
-	}
-	return o.remote
-}
-
-// Fs is the filesystem this remote http file object is located within
-func (o *Object) Fs() fs.Info {
-	return o.fs
-}
-
-// Hash returns "" since HTTP (in Go or OpenSSH) doesn't support remote calculation of hashes
-func (o *Object) Hash(ctx context.Context, r hash.Type) (string, error) {
-	return "", hash.ErrUnsupported
-}
-
-// Storable returns whether the remote http file is a regular file
-// (not a directory, symbolic link, block device, character device, named pipe, etc.)
-func (o *Object) Storable() bool {
-	return true
-}
-
-// Features returns the optional features of this Fs
-// Info provides a read only interface to information about a filesystem.
-func (f *Fs) Features() *fs.Features {
-	return f.features
-}
-
-// Name of the remote (as passed into NewFs)
-// Name returns the configured name of the file system
-func (f *Fs) Name() string {
-	return f.name
-}
-
-// Root of the remote (as passed into NewFs)
-func (f *Fs) Root() string {
-	return f.root
-}
-
-// String returns a description of the FS
-func (f *Fs) String() string {
-	return fmt.Sprintf("Linkbox root '%s'", f.root)
-}
-
-// Precision of the ModTimes in this Fs
-func (f *Fs) Precision() time.Duration {
-	return fs.ModTimeNotSupported
-}
-
-// Hashes returns hash.HashNone to indicate remote hashing is unavailable
-// Returns the supported hash types of the filesystem
-func (f *Fs) Hashes() hash.Set {
-	return hash.Set(hash.None)
-}
-
-/*
-	{
-	  "data": {
-	    "signUrl": "http://xx -- Then CURL PUT your file with sign url "
-	  },
-	  "msg": "please use this url to upload (PUT method)",
-	  "status": 1
-	}
-*/
-
-// All messages have these items
-type response struct {
-	Message string `json:"msg"`
-	Status  int    `json:"status"`
-}
-
-// IsError returns whether response represents an error
-func (r *response) IsError() bool {
-	return r.Status != 1
-}
-
-// Error returns the error state of this response
-func (r *response) Error() string {
-	return fmt.Sprintf("Linkbox error %d: %s", r.Status, r.Message)
-}
-
-// responser is interface covering the response so we can use it when it is embedded.
-type responser interface {
-	IsError() bool
-	Error() string
-}
-
-type getUploadURLData struct {
-	SignURL string `json:"signUrl"`
-}
-
-type getUploadURLResponse struct {
-	response
-	Data getUploadURLData `json:"data"`
-}
-
-// Put in to the remote path with the modTime given of the given size
-//
-// When called from outside an Fs by rclone, src.Size() will always be >= 0.
-// But for unknown-sized objects (indicated by src.Size() == -1), Put should either
-// return an error or upload it properly (rather than e.g. calling panic).
-//
-// May create the object even if it returns an error - if so
-// will return the object and the error, otherwise will return
-// nil and the error
-func (f *Fs) Put(ctx context.Context, in io.Reader, src fs.ObjectInfo, options ...fs.OpenOption) (fs.Object, error) {
-	o := &Object{
-		fs:     f,
-		remote: src.Remote(),
-		size:   src.Size(),
-	}
-	dir, _ := splitDirAndName(src.Remote())
-	err := f.Mkdir(ctx, dir)
-	if err != nil {
-		return nil, err
-	}
-	err = o.Update(ctx, in, src, options...)
-	return o, err
-}
-
-// Purge all files in the directory specified
-//
-// Implement this if you have a way of deleting all the files
-// quicker than just running Remove() on the result of List()
-//
-// Return an error if it doesn't exist
-func (f *Fs) Purge(ctx context.Context, dir string) error {
-	return f.purgeCheck(ctx, dir, false)
-}
-
-// retryErrorCodes is a slice of error codes that we will retry
-var retryErrorCodes = []int{
-	429, // Too Many Requests.
-	500, // Internal Server Error
-	502, // Bad Gateway
-	503, // Service Unavailable
-	504, // Gateway Timeout
-	509, // Bandwidth Limit Exceeded
-}
-
-// shouldRetry determines whether a given err rates being retried
-func (f *Fs) shouldRetry(ctx context.Context, resp *http.Response, err error) (bool, error) {
-	if fserrors.ContextError(ctx, &err) {
-		return false, err
-	}
-	return fserrors.ShouldRetry(err) || fserrors.ShouldRetryHTTP(resp, retryErrorCodes), err
-}
-
-// DirCacheFlush resets the directory cache - used in testing as an
-// optional interface
-func (f *Fs) DirCacheFlush() {
-	f.dirCache.ResetRoot()
-}
-
-// Check the interfaces are satisfied
-var (
-	_ fs.Fs              = &Fs{}
-	_ fs.Purger          = &Fs{}
-	_ fs.DirCacheFlusher = &Fs{}
-	_ fs.Object          = &Object{}
-)

backend/linkbox/linkbox_test.go

@@ -1,17 +0,0 @@
-// Test Linkbox filesystem interface
-package linkbox_test
-
-import (
-	"testing"
-
-	"github.com/rclone/rclone/backend/linkbox"
-	"github.com/rclone/rclone/fstest/fstests"
-)
-
-// TestIntegration runs integration tests against the remote
-func TestIntegration(t *testing.T) {
-	fstests.Run(t, &fstests.Opt{
-		RemoteName: "TestLinkbox:",
-		NilObject:  (*linkbox.Object)(nil),
-	})
-}

backend/local/local.go

@@ -146,11 +146,6 @@ time we:
 - Only checksum the size that stat gave
 - Don't update the stat info for the file
 
-**NB** do not use this flag on a Windows Volume Shadow (VSS). For some
-unknown reason, files in a VSS sometimes show different sizes from the
-directory listing (where the initial stat value comes from on Windows)
-and when stat is called on them directly. Other copy tools always use
-the direct stat value and setting this flag will disable that.
 `,
 			Default:  false,
 			Advanced: true,
@@ -1128,12 +1123,6 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Read
 		}
 	}
 
-	// Update the file info before we start reading
-	err = o.lstat()
-	if err != nil {
-		return nil, err
-	}
-
 	// If not checking updated then limit to current size.  This means if
 	// file is being extended, readers will read a o.Size() bytes rather
 	// than the new size making for a consistent upload.
@@ -1298,7 +1287,7 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 	}
 
 	// Fetch and set metadata if --metadata is in use
-	meta, err := fs.GetMetadataOptions(ctx, o.fs, src, options)
+	meta, err := fs.GetMetadataOptions(ctx, src, options)
 	if err != nil {
 		return fmt.Errorf("failed to read metadata from source object: %w", err)
 	}

backend/onedrive/api/types.go

@@ -99,16 +99,6 @@ type ItemReference struct {
 	DriveType string `json:"driveType"` // Type of the drive,	Read-Only
 }
 
-// GetID returns a normalized ID of the item
-// If DriveID is known it will be prefixed to the ID with # separator
-// Can be parsed using onedrive.parseNormalizedID(normalizedID)
-func (i *ItemReference) GetID() string {
-	if !strings.Contains(i.ID, "#") {
-		return i.DriveID + "#" + i.ID
-	}
-	return i.ID
-}
-
 // RemoteItemFacet groups data needed to reference a OneDrive remote item
 type RemoteItemFacet struct {
 	ID                   string               `json:"id"`                   // The unique identifier of the item within the remote Drive. Read-only.
@@ -195,8 +185,8 @@ type Item struct {
 	Deleted *DeletedFacet `json:"deleted"` // Information about the deleted state of the item. Read-only.
 }
 
-// DeltaResponse is the response to the view delta method
-type DeltaResponse struct {
+// ViewDeltaResponse is the response to the view delta method
+type ViewDeltaResponse struct {
 	Value      []Item `json:"value"`            // An array of Item objects which have been created, modified, or deleted.
 	NextLink   string `json:"@odata.nextLink"`  // A URL to retrieve the next available page of changes.
 	DeltaLink  string `json:"@odata.deltaLink"` // A URL returned instead of @odata.nextLink after all current changes have been returned. Used to read the next set of changes in the future.
@@ -448,27 +438,3 @@ type Version struct {
 type VersionsResponse struct {
 	Versions []Version `json:"value"`
 }
-
-// DriveResource is returned from /me/drive
-type DriveResource struct {
-	DriveID   string `json:"id"`
-	DriveName string `json:"name"`
-	DriveType string `json:"driveType"`
-}
-
-// DrivesResponse is returned from /sites/{siteID}/drives",
-type DrivesResponse struct {
-	Drives []DriveResource `json:"value"`
-}
-
-// SiteResource is part of the response from from "/sites/root:"
-type SiteResource struct {
-	SiteID   string `json:"id"`
-	SiteName string `json:"displayName"`
-	SiteURL  string `json:"webUrl"`
-}
-
-// SiteResponse is returned from "/sites/root:"
-type SiteResponse struct {
-	Sites []SiteResource `json:"value"`
-}

backend/onedrive/onedrive.go

@@ -27,7 +27,6 @@ import (
 	"github.com/rclone/rclone/fs/config/configstruct"
 	"github.com/rclone/rclone/fs/config/obscure"
 	"github.com/rclone/rclone/fs/fserrors"
-	"github.com/rclone/rclone/fs/fshttp"
 	"github.com/rclone/rclone/fs/hash"
 	"github.com/rclone/rclone/fs/operations"
 	"github.com/rclone/rclone/fs/walk"
@@ -325,37 +324,6 @@ the --onedrive-av-override flag, or av_override = true in the config
 file.
 `,
 			Advanced: true,
-		}, {
-			Name:    "delta",
-			Default: false,
-			Help: strings.ReplaceAll(`If set rclone will use delta listing to implement recursive listings.
-
-If this flag is set the the onedrive backend will advertise |ListR|
-support for recursive listings.
-
-Setting this flag speeds up these things greatly:
-
-    rclone lsf -R onedrive:
-    rclone size onedrive:
-    rclone rc vfs/refresh recursive=true
-
-**However** the delta listing API **only** works at the root of the
-drive. If you use it not at the root then it recurses from the root
-and discards all the data that is not under the directory you asked
-for. So it will be correct but may not be very efficient.
-
-This is why this flag is not set as the default.
-
-As a rule of thumb if nearly all of your data is under rclone's root
-directory (the |root/directory| in |onedrive:root/directory|) then
-using this flag will be be a big performance win. If your data is
-mostly not under the root then using this flag will be a big
-performance loss.
-
-It is recommended if you are mounting your onedrive at the root
-(or near the root when using crypt) and using rclone |rc vfs/refresh|.
-`, "|", "`"),
-			Advanced: true,
 		}, {
 			Name:     config.ConfigEncoding,
 			Help:     config.ConfigEncodingHelp,
@@ -403,6 +371,28 @@ It is recommended if you are mounting your onedrive at the root
 	})
 }
 
+type driveResource struct {
+	DriveID   string `json:"id"`
+	DriveName string `json:"name"`
+	DriveType string `json:"driveType"`
+}
+type drivesResponse struct {
+	Drives []driveResource `json:"value"`
+}
+
+type siteResource struct {
+	SiteID   string `json:"id"`
+	SiteName string `json:"displayName"`
+	SiteURL  string `json:"webUrl"`
+}
+type siteResponse struct {
+	Sites []siteResource `json:"value"`
+}
+type deltaResponse struct {
+	DeltaLink string     `json:"@odata.deltaLink"`
+	Value     []api.Item `json:"value"`
+}
+
 // Get the region and graphURL from the config
 func getRegionURL(m configmap.Mapper) (region, graphURL string) {
 	region, _ = m.Get("region")
@@ -429,7 +419,7 @@ func chooseDrive(ctx context.Context, name string, m configmap.Mapper, srv *rest
 			RootURL: graphURL,
 			Path:    "/sites/root:" + opt.relativePath,
 		}
-		site := api.SiteResource{}
+		site := siteResource{}
 		_, err := srv.CallJSON(ctx, &opt.opts, nil, &site)
 		if err != nil {
 			return fs.ConfigError("choose_type", fmt.Sprintf("Failed to query available site by relative path: %v", err))
@@ -446,7 +436,7 @@ func chooseDrive(ctx context.Context, name string, m configmap.Mapper, srv *rest
 		}
 	}
 
-	drives := api.DrivesResponse{}
+	drives := drivesResponse{}
 
 	// We don't have the final ID yet?
 	// query Microsoft Graph
@@ -459,7 +449,7 @@ func chooseDrive(ctx context.Context, name string, m configmap.Mapper, srv *rest
 		// Also call /me/drive as sometimes /me/drives doesn't return it #4068
 		if opt.opts.Path == "/me/drives" {
 			opt.opts.Path = "/me/drive"
-			meDrive := api.DriveResource{}
+			meDrive := driveResource{}
 			_, err := srv.CallJSON(ctx, &opt.opts, nil, &meDrive)
 			if err != nil {
 				return fs.ConfigError("choose_type", fmt.Sprintf("Failed to query available drives: %v", err))
@@ -478,7 +468,7 @@ func chooseDrive(ctx context.Context, name string, m configmap.Mapper, srv *rest
 			}
 		}
 	} else {
-		drives.Drives = append(drives.Drives, api.DriveResource{
+		drives.Drives = append(drives.Drives, driveResource{
 			DriveID:   opt.finalDriveID,
 			DriveName: "Chosen Drive ID",
 			DriveType: "drive",
@@ -615,7 +605,7 @@ Examples:
 			Path:    "/sites?search=" + searchTerm,
 		}
 
-		sites := api.SiteResponse{}
+		sites := siteResponse{}
 		_, err := srv.CallJSON(ctx, &opts, nil, &sites)
 		if err != nil {
 			return fs.ConfigError("choose_type", fmt.Sprintf("Failed to query available sites: %v", err))
@@ -677,7 +667,6 @@ type Options struct {
 	LinkPassword            string               `config:"link_password"`
 	HashType                string               `config:"hash_type"`
 	AVOverride              bool                 `config:"av_override"`
-	Delta                   bool                 `config:"delta"`
 	Enc                     encoder.MultiEncoder `config:"encoding"`
 }
 
@@ -689,7 +678,6 @@ type Fs struct {
 	ci           *fs.ConfigInfo     // global config
 	features     *fs.Features       // optional features
 	srv          *rest.Client       // the connection to the OneDrive server
-	unAuth       *rest.Client       // no authentication connection to the OneDrive server
 	dirCache     *dircache.DirCache // Map of directory path to directory id
 	pacer        *fs.Pacer          // pacer for API calls
 	tokenRenewer *oauthutil.Renew   // renew the token on expiry
@@ -948,9 +936,8 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		TokenURL: authEndpoint[opt.Region] + tokenPath,
 	}
 
-	client := fshttp.NewClient(ctx)
 	root = parsePath(root)
-	oAuthClient, ts, err := oauthutil.NewClientWithBaseClient(ctx, name, m, oauthConfig, client)
+	oAuthClient, ts, err := oauthutil.NewClient(ctx, name, m, oauthConfig)
 	if err != nil {
 		return nil, fmt.Errorf("failed to configure OneDrive: %w", err)
 	}
@@ -964,7 +951,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		driveID:   opt.DriveID,
 		driveType: opt.DriveType,
 		srv:       rest.NewClient(oAuthClient).SetRoot(rootURL),
-		unAuth:    rest.NewClient(client).SetRoot(rootURL),
 		pacer:     fs.NewPacer(ctx, pacer.NewDefault(pacer.MinSleep(minSleep), pacer.MaxSleep(maxSleep), pacer.DecayConstant(decayConstant))),
 		hashType:  QuickXorHashType,
 	}
@@ -1012,11 +998,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 
 	f.dirCache = dircache.New(root, rootID, f)
 
-	// ListR only supported if delta set
-	if !f.opt.Delta {
-		f.features.ListR = nil
-	}
-
 	// Find the current root
 	err = f.dirCache.FindRoot(ctx, false)
 	if err != nil {
@@ -1136,29 +1117,32 @@ func (f *Fs) CreateDir(ctx context.Context, dirID, leaf string) (newID string, e
 // If directories is set it only sends directories
 // User function to process a File item from listAll
 //
-// If an error is returned then processing stops
-type listAllFn func(*api.Item) error
+// Should return true to finish processing
+type listAllFn func(*api.Item) bool
 
 // Lists the directory required calling the user function on each item found
 //
 // If the user fn ever returns true then it early exits with found = true
-//
-// This listing function works on both normal listings and delta listings
-func (f *Fs) _listAll(ctx context.Context, dirID string, directoriesOnly bool, filesOnly bool, fn listAllFn, opts *rest.Opts, result any, pValue *[]api.Item, pNextLink *string) (err error) {
+func (f *Fs) listAll(ctx context.Context, dirID string, directoriesOnly bool, filesOnly bool, fn listAllFn) (found bool, err error) {
+	// Top parameter asks for bigger pages of data
+	// https://dev.onedrive.com/odata/optional-query-parameters.htm
+	opts := f.newOptsCall(dirID, "GET", fmt.Sprintf("/children?$top=%d", f.opt.ListChunk))
+OUTER:
 	for {
+		var result api.ListChildrenResponse
 		var resp *http.Response
 		err = f.pacer.Call(func() (bool, error) {
-			resp, err = f.srv.CallJSON(ctx, opts, nil, result)
+			resp, err = f.srv.CallJSON(ctx, &opts, nil, &result)
 			return shouldRetry(ctx, resp, err)
 		})
 		if err != nil {
-			return fmt.Errorf("couldn't list files: %w", err)
+			return found, fmt.Errorf("couldn't list files: %w", err)
 		}
-		if len(*pValue) == 0 {
+		if len(result.Value) == 0 {
 			break
 		}
-		for i := range *pValue {
-			item := &(*pValue)[i]
+		for i := range result.Value {
+			item := &result.Value[i]
 			isFolder := item.GetFolder() != nil
 			if isFolder {
 				if filesOnly {
@@ -1173,60 +1157,18 @@ func (f *Fs) _listAll(ctx context.Context, dirID string, directoriesOnly bool, f
 				continue
 			}
 			item.Name = f.opt.Enc.ToStandardName(item.GetName())
-			err = fn(item)
-			if err != nil {
-				return err
+			if fn(item) {
+				found = true
+				break OUTER
 			}
 		}
-		if *pNextLink == "" {
+		if result.NextLink == "" {
 			break
 		}
 		opts.Path = ""
-		opts.Parameters = nil
-		opts.RootURL = *pNextLink
-		// reset results
-		*pNextLink = ""
-		*pValue = nil
+		opts.RootURL = result.NextLink
 	}
-	return nil
-}
-
-// Lists the directory required calling the user function on each item found
-//
-// If the user fn ever returns true then it early exits with found = true
-func (f *Fs) listAll(ctx context.Context, dirID string, directoriesOnly bool, filesOnly bool, fn listAllFn) (err error) {
-	// Top parameter asks for bigger pages of data
-	// https://dev.onedrive.com/odata/optional-query-parameters.htm
-	opts := f.newOptsCall(dirID, "GET", fmt.Sprintf("/children?$top=%d", f.opt.ListChunk))
-	var result api.ListChildrenResponse
-	return f._listAll(ctx, dirID, directoriesOnly, filesOnly, fn, &opts, &result, &result.Value, &result.NextLink)
-}
-
-// Convert a list item into a DirEntry
-//
-// Can return nil for an item which should be skipped
-func (f *Fs) itemToDirEntry(ctx context.Context, dir string, info *api.Item) (entry fs.DirEntry, err error) {
-	if !f.opt.ExposeOneNoteFiles && info.GetPackageType() == api.PackageTypeOneNote {
-		fs.Debugf(info.Name, "OneNote file not shown in directory listing")
-		return nil, nil
-	}
-	remote := path.Join(dir, info.GetName())
-	folder := info.GetFolder()
-	if folder != nil {
-		// cache the directory ID for later lookups
-		id := info.GetID()
-		f.dirCache.Put(remote, id)
-		d := fs.NewDir(remote, time.Time(info.GetLastModifiedDateTime())).SetID(id)
-		d.SetItems(folder.ChildCount)
-		entry = d
-	} else {
-		o, err := f.newObjectWithInfo(ctx, remote, info)
-		if err != nil {
-			return nil, err
-		}
-		entry = o
-	}
-	return entry, nil
+	return
 }
 
 // List the objects and directories in dir into entries.  The
@@ -1243,144 +1185,41 @@ func (f *Fs) List(ctx context.Context, dir string) (entries fs.DirEntries, err e
 	if err != nil {
 		return nil, err
 	}
-	err = f.listAll(ctx, directoryID, false, false, func(info *api.Item) error {
-		entry, err := f.itemToDirEntry(ctx, dir, info)
-		if err != nil {
-			return err
+	var iErr error
+	_, err = f.listAll(ctx, directoryID, false, false, func(info *api.Item) bool {
+		if !f.opt.ExposeOneNoteFiles && info.GetPackageType() == api.PackageTypeOneNote {
+			fs.Debugf(info.Name, "OneNote file not shown in directory listing")
+			return false
 		}
-		if entry == nil {
-			return nil
+
+		remote := path.Join(dir, info.GetName())
+		folder := info.GetFolder()
+		if folder != nil {
+			// cache the directory ID for later lookups
+			id := info.GetID()
+			f.dirCache.Put(remote, id)
+			d := fs.NewDir(remote, time.Time(info.GetLastModifiedDateTime())).SetID(id)
+			d.SetItems(folder.ChildCount)
+			entries = append(entries, d)
+		} else {
+			o, err := f.newObjectWithInfo(ctx, remote, info)
+			if err != nil {
+				iErr = err
+				return true
+			}
+			entries = append(entries, o)
 		}
-		entries = append(entries, entry)
-		return nil
+		return false
 	})
 	if err != nil {
 		return nil, err
 	}
+	if iErr != nil {
+		return nil, iErr
+	}
 	return entries, nil
 }
 
-// ListR lists the objects and directories of the Fs starting
-// from dir recursively into out.
-//
-// dir should be "" to start from the root, and should not
-// have trailing slashes.
-//
-// This should return ErrDirNotFound if the directory isn't
-// found.
-//
-// It should call callback for each tranche of entries read.
-// These need not be returned in any particular order.  If
-// callback returns an error then the listing will stop
-// immediately.
-//
-// Don't implement this unless you have a more efficient way
-// of listing recursively than doing a directory traversal.
-func (f *Fs) ListR(ctx context.Context, dir string, callback fs.ListRCallback) (err error) {
-	// Make sure this ID is in the directory cache
-	directoryID, err := f.dirCache.FindDir(ctx, dir, false)
-	if err != nil {
-		return err
-	}
-
-	// ListR only works at the root of a onedrive, not on a folder
-	// So we have to filter things outside of the root which is
-	// inefficient.
-
-	list := walk.NewListRHelper(callback)
-
-	// list a folder conventionally - used for shared folders
-	var listFolder func(dir string) error
-	listFolder = func(dir string) error {
-		entries, err := f.List(ctx, dir)
-		if err != nil {
-			return err
-		}
-		for _, entry := range entries {
-			err = list.Add(entry)
-			if err != nil {
-				return err
-			}
-			if _, isDir := entry.(fs.Directory); isDir {
-				err = listFolder(entry.Remote())
-				if err != nil {
-					return err
-				}
-			}
-		}
-		return nil
-	}
-
-	// This code relies on the fact that directories are sent before their children. This isn't
-	// mentioned in the docs though, so maybe it shouldn't be relied on.
-	seen := map[string]struct{}{}
-	fn := func(info *api.Item) error {
-		var parentPath string
-		var ok bool
-		id := info.GetID()
-		// The API can produce duplicates, so skip them
-		if _, found := seen[id]; found {
-			return nil
-		}
-		seen[id] = struct{}{}
-		// Skip the root directory
-		if id == directoryID {
-			return nil
-		}
-		// Skip deleted items
-		if info.Deleted != nil {
-			return nil
-		}
-		dirID := info.GetParentReference().GetID()
-		// Skip files that don't have their parent directory
-		// cached as they are outside the root.
-		parentPath, ok = f.dirCache.GetInv(dirID)
-		if !ok {
-			return nil
-		}
-		// Skip files not under the root directory
-		remote := path.Join(parentPath, info.GetName())
-		if dir != "" && !strings.HasPrefix(remote, dir+"/") {
-			return nil
-		}
-		entry, err := f.itemToDirEntry(ctx, parentPath, info)
-		if err != nil {
-			return err
-		}
-		if entry == nil {
-			return nil
-		}
-		err = list.Add(entry)
-		if err != nil {
-			return err
-		}
-		// If this is a shared folder, we'll need list it too
-		if info.RemoteItem != nil && info.RemoteItem.Folder != nil {
-			fs.Debugf(remote, "Listing shared directory")
-			return listFolder(remote)
-		}
-		return nil
-	}
-
-	opts := rest.Opts{
-		Method: "GET",
-		Path:   "/root/delta",
-		Parameters: map[string][]string{
-			// "token": {token},
-			"$top": {fmt.Sprintf("%d", f.opt.ListChunk)},
-		},
-	}
-
-	var result api.DeltaResponse
-	err = f._listAll(ctx, "", false, false, fn, &opts, &result, &result.Value, &result.NextLink)
-	if err != nil {
-		return err
-	}
-
-	return list.Flush()
-
-}
-
 // Creates from the parameters passed in a half finished Object which
 // must have setMetaData called on it
 //
@@ -1449,12 +1288,15 @@ func (f *Fs) purgeCheck(ctx context.Context, dir string, check bool) error {
 	}
 	if check {
 		// check to see if there are any items
-		err := f.listAll(ctx, rootID, false, false, func(item *api.Item) error {
-			return fs.ErrorDirectoryNotEmpty
+		found, err := f.listAll(ctx, rootID, false, false, func(item *api.Item) bool {
+			return true
 		})
 		if err != nil {
 			return err
 		}
+		if found {
+			return fs.ErrorDirectoryNotEmpty
+		}
 	}
 	err = f.deleteObject(ctx, rootID)
 	if err != nil {
@@ -2243,7 +2085,7 @@ func (o *Object) uploadFragment(ctx context.Context, url string, start int64, to
 			Options:       options,
 		}
 		_, _ = chunk.Seek(skip, io.SeekStart)
-		resp, err = o.fs.unAuth.Call(ctx, &opts)
+		resp, err = o.fs.srv.Call(ctx, &opts)
 		if err != nil && resp != nil && resp.StatusCode == http.StatusRequestedRangeNotSatisfiable {
 			fs.Debugf(o, "Received 416 error - reading current position from server: %v", err)
 			pos, posErr := o.getPosition(ctx, url)
@@ -2639,7 +2481,7 @@ func (f *Fs) changeNotifyStartPageToken(ctx context.Context) (nextDeltaToken str
 	return
 }
 
-func (f *Fs) changeNotifyNextChange(ctx context.Context, token string) (delta api.DeltaResponse, err error) {
+func (f *Fs) changeNotifyNextChange(ctx context.Context, token string) (delta deltaResponse, err error) {
 	opts := f.buildDriveDeltaOpts(token)
 
 	_, err = f.srv.CallJSON(ctx, &opts, nil, &delta)
@@ -2758,7 +2600,6 @@ var (
 	_ fs.Abouter         = (*Fs)(nil)
 	_ fs.PublicLinker    = (*Fs)(nil)
 	_ fs.CleanUpper      = (*Fs)(nil)
-	_ fs.ListRer         = (*Fs)(nil)
 	_ fs.Object          = (*Object)(nil)
 	_ fs.MimeTyper       = &Object{}
 	_ fs.IDer            = &Object{}

backend/oracleobjectstorage/client.go

@@ -70,9 +70,6 @@ func newObjectStorageClient(ctx context.Context, opt *Options) (*objectstorage.O
 	if opt.Region != "" {
 		client.SetRegion(opt.Region)
 	}
-	if opt.Endpoint != "" {
-		client.Host = opt.Endpoint
-	}
 	modifyClient(ctx, opt, &client.BaseClient)
 	return &client, err
 }

backend/oracleobjectstorage/multipart.go

@@ -295,7 +295,7 @@ func (o *Object) prepareUpload(ctx context.Context, src fs.ObjectInfo, options [
 	// Set the mtime in the metadata
 	modTime := src.ModTime(ctx)
 	// Fetch metadata if --metadata is in use
-	meta, err := fs.GetMetadataOptions(ctx, o.fs, src, options)
+	meta, err := fs.GetMetadataOptions(ctx, src, options)
 	if err != nil {
 		return ui, fmt.Errorf("failed to read metadata from source object: %w", err)
 	}
@@ -399,17 +399,13 @@ func (o *Object) prepareUpload(ctx context.Context, src fs.ObjectInfo, options [
 func (o *Object) createMultipartUpload(ctx context.Context, putReq *objectstorage.PutObjectRequest) (
 	uploadID string, existingParts map[int]objectstorage.MultipartUploadPartSummary, err error) {
 	bucketName, bucketPath := o.split()
-	err = o.fs.makeBucket(ctx, bucketName)
-	if err != nil {
-		fs.Errorf(o, "failed to create bucket: %v, err: %v", bucketName, err)
-		return uploadID, existingParts, err
-	}
-	if o.fs.opt.AttemptResumeUpload {
+	f := o.fs
+	if f.opt.AttemptResumeUpload {
 		fs.Debugf(o, "attempting to resume upload for %v (if any)", o.remote)
 		resumeUploads, err := o.fs.findLatestMultipartUpload(ctx, bucketName, bucketPath)
 		if err == nil && len(resumeUploads) > 0 {
 			uploadID = *resumeUploads[0].UploadId
-			existingParts, err = o.fs.listMultipartUploadParts(ctx, bucketName, bucketPath, uploadID)
+			existingParts, err = f.listMultipartUploadParts(ctx, bucketName, bucketPath, uploadID)
 			if err == nil {
 				fs.Debugf(o, "resuming with existing upload id: %v", uploadID)
 				return uploadID, existingParts, err

backend/oracleobjectstorage/oracleobjectstorage.go

@@ -138,14 +138,6 @@ func (f *Fs) setUploadCutoff(cs fs.SizeSuffix) (old fs.SizeSuffix, err error) {
 	return
 }
 
-func (f *Fs) setCopyCutoff(cs fs.SizeSuffix) (old fs.SizeSuffix, err error) {
-	err = checkUploadChunkSize(cs)
-	if err == nil {
-		old, f.opt.CopyCutoff = f.opt.CopyCutoff, cs
-	}
-	return
-}
-
 // ------------------------------------------------------------
 // Implement backed that represents a remote object storage server
 // Fs is the interface a cloud storage system must provide

backend/oracleobjectstorage/oracleobjectstorage_test.go

@@ -30,12 +30,4 @@ func (f *Fs) SetUploadCutoff(cs fs.SizeSuffix) (fs.SizeSuffix, error) {
 	return f.setUploadCutoff(cs)
 }
 
-func (f *Fs) SetCopyCutoff(cs fs.SizeSuffix) (fs.SizeSuffix, error) {
-	return f.setCopyCutoff(cs)
-}
-
-var (
-	_ fstests.SetUploadChunkSizer = (*Fs)(nil)
-	_ fstests.SetUploadCutoffer   = (*Fs)(nil)
-	_ fstests.SetCopyCutoffer     = (*Fs)(nil)
-)
+var _ fstests.SetUploadChunkSizer = (*Fs)(nil)

backend/quatrix/api/types.go

@@ -6,8 +6,8 @@ import (
 	"time"
 )
 
-// OverwriteMode is a conflict resolve mode during copy or move. Files with conflicting names will be overwritten
-const OverwriteMode = "overwrite"
+// OverwriteOnCopyMode is a conflict resolve mode during copy. Files with conflicting names will be overwritten
+const OverwriteOnCopyMode = "overwrite"
 
 // ProfileInfo is a profile info about quota
 type ProfileInfo struct {

backend/quatrix/quatrix.go

@@ -193,7 +193,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 	f.features = (&fs.Features{
 		CaseInsensitive:         false,
 		CanHaveEmptyDirectories: true,
-		PartialUploads:          true,
 	}).Fill(ctx, f)
 
 	if f.opt.APIKey != "" {
@@ -729,7 +728,7 @@ func (f *Fs) Copy(ctx context.Context, src fs.Object, remote string) (fs.Object,
 		Resolve:     true,
 		MTime:       api.JSONTime(srcObj.ModTime(ctx)),
 		Name:        dstLeaf,
-		ResolveMode: api.OverwriteMode,
+		ResolveMode: api.OverwriteOnCopyMode,
 	}
 
 	result := &api.File{}
@@ -789,12 +788,11 @@ func (f *Fs) Move(ctx context.Context, src fs.Object, remote string) (fs.Object,
 	}
 
 	params := &api.FileCopyMoveOneParams{
-		ID:          srcObj.id,
-		Target:      directoryID,
-		Resolve:     true,
-		MTime:       api.JSONTime(srcObj.ModTime(ctx)),
-		Name:        dstLeaf,
-		ResolveMode: api.OverwriteMode,
+		ID:      srcObj.id,
+		Target:  directoryID,
+		Resolve: false,
+		MTime:   api.JSONTime(srcObj.ModTime(ctx)),
+		Name:    dstLeaf,
 	}
 
 	var resp *http.Response

backend/s3/s3.go

@@ -15,7 +15,6 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"math"
 	"net/http"
 	"net/url"
 	"path"
@@ -63,135 +62,11 @@ import (
 	"golang.org/x/net/http/httpguts"
 )
 
-// The S3 providers
-//
-// Please keep these in alphabetical order, but with AWS first and
-// Other last.
-//
-// NB if you add a new provider here, then add it in the setQuirks
-// function and set the correct quirks. Test the quirks are correct by
-// running the integration tests "go test -v -remote NewS3Provider:".
-//
-// See https://github.com/rclone/rclone/blob/master/CONTRIBUTING.md#adding-a-new-s3-provider
-// for full information about how to add a new s3 provider.
-var providerOption = fs.Option{
-	Name: fs.ConfigProvider,
-	Help: "Choose your S3 provider.",
-	Examples: []fs.OptionExample{{
-		Value: "AWS",
-		Help:  "Amazon Web Services (AWS) S3",
-	}, {
-		Value: "Alibaba",
-		Help:  "Alibaba Cloud Object Storage System (OSS) formerly Aliyun",
-	}, {
-		Value: "ArvanCloud",
-		Help:  "Arvan Cloud Object Storage (AOS)",
-	}, {
-		Value: "Ceph",
-		Help:  "Ceph Object Storage",
-	}, {
-		Value: "ChinaMobile",
-		Help:  "China Mobile Ecloud Elastic Object Storage (EOS)",
-	}, {
-		Value: "Cloudflare",
-		Help:  "Cloudflare R2 Storage",
-	}, {
-		Value: "DigitalOcean",
-		Help:  "DigitalOcean Spaces",
-	}, {
-		Value: "Dreamhost",
-		Help:  "Dreamhost DreamObjects",
-	}, {
-		Value: "GCS",
-		Help:  "Google Cloud Storage",
-	}, {
-		Value: "HuaweiOBS",
-		Help:  "Huawei Object Storage Service",
-	}, {
-		Value: "IBMCOS",
-		Help:  "IBM COS S3",
-	}, {
-		Value: "IDrive",
-		Help:  "IDrive e2",
-	}, {
-		Value: "IONOS",
-		Help:  "IONOS Cloud",
-	}, {
-		Value: "LyveCloud",
-		Help:  "Seagate Lyve Cloud",
-	}, {
-		Value: "Leviia",
-		Help:  "Leviia Object Storage",
-	}, {
-		Value: "Liara",
-		Help:  "Liara Object Storage",
-	}, {
-		Value: "Linode",
-		Help:  "Linode Object Storage",
-	}, {
-		Value: "Minio",
-		Help:  "Minio Object Storage",
-	}, {
-		Value: "Netease",
-		Help:  "Netease Object Storage (NOS)",
-	}, {
-		Value: "Petabox",
-		Help:  "Petabox Object Storage",
-	}, {
-		Value: "RackCorp",
-		Help:  "RackCorp Object Storage",
-	}, {
-		Value: "Rclone",
-		Help:  "Rclone S3 Server",
-	}, {
-		Value: "Scaleway",
-		Help:  "Scaleway Object Storage",
-	}, {
-		Value: "SeaweedFS",
-		Help:  "SeaweedFS S3",
-	}, {
-		Value: "StackPath",
-		Help:  "StackPath Object Storage",
-	}, {
-		Value: "Storj",
-		Help:  "Storj (S3 Compatible Gateway)",
-	}, {
-		Value: "Synology",
-		Help:  "Synology C2 Object Storage",
-	}, {
-		Value: "TencentCOS",
-		Help:  "Tencent Cloud Object Storage (COS)",
-	}, {
-		Value: "Wasabi",
-		Help:  "Wasabi Object Storage",
-	}, {
-		Value: "Qiniu",
-		Help:  "Qiniu Object Storage (Kodo)",
-	}, {
-		Value: "Other",
-		Help:  "Any other S3 compatible provider",
-	}},
-}
-
-var providersList string
-
 // Register with Fs
 func init() {
-	var s strings.Builder
-	for i, provider := range providerOption.Examples {
-		if provider.Value == "Other" {
-			_, _ = s.WriteString(" and others")
-		} else {
-			if i != 0 {
-				_, _ = s.WriteString(", ")
-			}
-			_, _ = s.WriteString(provider.Value)
-		}
-	}
-	providersList = s.String()
 	fs.Register(&fs.RegInfo{
 		Name:        "s3",
-		Description: "Amazon S3 Compliant Storage Providers including " + providersList,
+		Description: "Amazon S3 Compliant Storage Providers including AWS, Alibaba, ArvanCloud, Ceph, China Mobile, Cloudflare, GCS, DigitalOcean, Dreamhost, Huawei OBS, IBM COS, IDrive e2, IONOS Cloud, Leviia, Liara, Lyve Cloud, Minio, Netease, Petabox, RackCorp, Scaleway, SeaweedFS, StackPath, Storj, Synology, Tencent COS, Qiniu and Wasabi",
 		NewFs:       NewFs,
 		CommandHelp: commandHelp,
 		Config: func(ctx context.Context, name string, m configmap.Mapper, config fs.ConfigIn) (*fs.ConfigOut, error) {
@@ -205,7 +80,100 @@ func init() {
 			System: systemMetadataInfo,
 			Help:   `User metadata is stored as x-amz-meta- keys. S3 metadata keys are case insensitive and are always returned in lower case.`,
 		},
-		Options: []fs.Option{providerOption, {
+		Options: []fs.Option{{
+			Name: fs.ConfigProvider,
+			Help: "Choose your S3 provider.",
+			// NB if you add a new provider here, then add it in the
+			// setQuirks function and set the correct quirks
+			Examples: []fs.OptionExample{{
+				Value: "AWS",
+				Help:  "Amazon Web Services (AWS) S3",
+			}, {
+				Value: "Alibaba",
+				Help:  "Alibaba Cloud Object Storage System (OSS) formerly Aliyun",
+			}, {
+				Value: "ArvanCloud",
+				Help:  "Arvan Cloud Object Storage (AOS)",
+			}, {
+				Value: "Ceph",
+				Help:  "Ceph Object Storage",
+			}, {
+				Value: "ChinaMobile",
+				Help:  "China Mobile Ecloud Elastic Object Storage (EOS)",
+			}, {
+				Value: "Cloudflare",
+				Help:  "Cloudflare R2 Storage",
+			}, {
+				Value: "DigitalOcean",
+				Help:  "DigitalOcean Spaces",
+			}, {
+				Value: "Dreamhost",
+				Help:  "Dreamhost DreamObjects",
+			}, {
+				Value: "GCS",
+				Help:  "Google Cloud Storage",
+			}, {
+				Value: "HuaweiOBS",
+				Help:  "Huawei Object Storage Service",
+			}, {
+				Value: "IBMCOS",
+				Help:  "IBM COS S3",
+			}, {
+				Value: "IDrive",
+				Help:  "IDrive e2",
+			}, {
+				Value: "IONOS",
+				Help:  "IONOS Cloud",
+			}, {
+				Value: "LyveCloud",
+				Help:  "Seagate Lyve Cloud",
+			}, {
+				Value: "Leviia",
+				Help:  "Leviia Object Storage",
+			}, {
+				Value: "Liara",
+				Help:  "Liara Object Storage",
+			}, {
+				Value: "Minio",
+				Help:  "Minio Object Storage",
+			}, {
+				Value: "Netease",
+				Help:  "Netease Object Storage (NOS)",
+			}, {
+				Value: "Petabox",
+				Help:  "Petabox Object Storage",
+			}, {
+				Value: "RackCorp",
+				Help:  "RackCorp Object Storage",
+			}, {
+				Value: "Scaleway",
+				Help:  "Scaleway Object Storage",
+			}, {
+				Value: "SeaweedFS",
+				Help:  "SeaweedFS S3",
+			}, {
+				Value: "StackPath",
+				Help:  "StackPath Object Storage",
+			}, {
+				Value: "Storj",
+				Help:  "Storj (S3 Compatible Gateway)",
+			}, {
+				Value: "Synology",
+				Help:  "Synology C2 Object Storage",
+			}, {
+				Value: "TencentCOS",
+				Help:  "Tencent Cloud Object Storage (COS)",
+			}, {
+				Value: "Wasabi",
+				Help:  "Wasabi Object Storage",
+			}, {
+				Value: "Qiniu",
+				Help:  "Qiniu Object Storage (Kodo)",
+			}, {
+				Value: "Other",
+				Help:  "Any other S3 compatible provider",
+			}},
+		}, {
 			Name:    "env_auth",
 			Help:    "Get AWS credentials from runtime (environment variables or EC2/ECS meta data if no env vars).\n\nOnly applies if access_key_id and secret_access_key is blank.",
 			Default: false,
@@ -526,7 +494,7 @@ func init() {
 		}, {
 			Name:     "region",
 			Help:     "Region to connect to.\n\nLeave blank if you are using an S3 clone and you don't have a region.",
-			Provider: "!AWS,Alibaba,ArvanCloud,ChinaMobile,Cloudflare,IONOS,Petabox,Liara,Linode,Qiniu,RackCorp,Scaleway,Storj,Synology,TencentCOS,HuaweiOBS,IDrive",
+			Provider: "!AWS,Alibaba,ArvanCloud,ChinaMobile,Cloudflare,IONOS,Petabox,Liara,Qiniu,RackCorp,Scaleway,Storj,Synology,TencentCOS,HuaweiOBS,IDrive",
 			Examples: []fs.OptionExample{{
 				Value: "",
 				Help:  "Use this if unsure.\nWill use v4 signatures and an empty region.",
@@ -893,42 +861,6 @@ func init() {
 				Value: "storage.iran.liara.space",
 				Help:  "The default endpoint\nIran",
 			}},
-		}, {
-			// Linode endpoints: https://www.linode.com/docs/products/storage/object-storage/guides/urls/#cluster-url-s3-endpoint
-			Name:     "endpoint",
-			Help:     "Endpoint for Linode Object Storage API.",
-			Provider: "Linode",
-			Examples: []fs.OptionExample{{
-				Value: "us-southeast-1.linodeobjects.com",
-				Help:  "Atlanta, GA (USA), us-southeast-1",
-			}, {
-				Value: "us-ord-1.linodeobjects.com",
-				Help:  "Chicago, IL (USA), us-ord-1",
-			}, {
-				Value: "eu-central-1.linodeobjects.com",
-				Help:  "Frankfurt (Germany), eu-central-1",
-			}, {
-				Value: "it-mil-1.linodeobjects.com",
-				Help:  "Milan (Italy), it-mil-1",
-			}, {
-				Value: "us-east-1.linodeobjects.com",
-				Help:  "Newark, NJ (USA), us-east-1",
-			}, {
-				Value: "fr-par-1.linodeobjects.com",
-				Help:  "Paris (France), fr-par-1",
-			}, {
-				Value: "us-sea-1.linodeobjects.com",
-				Help:  "Seattle, WA (USA), us-sea-1",
-			}, {
-				Value: "ap-south-1.linodeobjects.com",
-				Help:  "Singapore ap-south-1",
-			}, {
-				Value: "se-sto-1.linodeobjects.com",
-				Help:  "Stockholm (Sweden), se-sto-1",
-			}, {
-				Value: "us-iad-1.linodeobjects.com",
-				Help:  "Washington, DC, (USA), us-iad-1",
-			}},
 		}, {
 			// oss endpoints: https://help.aliyun.com/document_detail/31837.html
 			Name:     "endpoint",
@@ -1281,7 +1213,7 @@ func init() {
 		}, {
 			Name:     "endpoint",
 			Help:     "Endpoint for S3 API.\n\nRequired when using an S3 clone.",
-			Provider: "!AWS,ArvanCloud,IBMCOS,IDrive,IONOS,TencentCOS,HuaweiOBS,Alibaba,ChinaMobile,GCS,Liara,Linode,Scaleway,StackPath,Storj,Synology,RackCorp,Qiniu,Petabox",
+			Provider: "!AWS,ArvanCloud,IBMCOS,IDrive,IONOS,TencentCOS,HuaweiOBS,Alibaba,ChinaMobile,GCS,Liara,Scaleway,StackPath,Storj,Synology,RackCorp,Qiniu,Petabox",
 			Examples: []fs.OptionExample{{
 				Value:    "objects-us-east-1.dream.io",
 				Help:     "Dream Objects endpoint",
@@ -1769,7 +1701,7 @@ func init() {
 		}, {
 			Name:     "location_constraint",
 			Help:     "Location constraint - must be set to match the Region.\n\nLeave blank if not sure. Used when creating buckets only.",
-			Provider: "!AWS,Alibaba,ArvanCloud,HuaweiOBS,ChinaMobile,Cloudflare,IBMCOS,IDrive,IONOS,Leviia,Liara,Linode,Qiniu,RackCorp,Scaleway,StackPath,Storj,TencentCOS,Petabox",
+			Provider: "!AWS,Alibaba,ArvanCloud,HuaweiOBS,ChinaMobile,Cloudflare,IBMCOS,IDrive,IONOS,Leviia,Liara,Qiniu,RackCorp,Scaleway,StackPath,Storj,TencentCOS,Petabox",
 		}, {
 			Name: "acl",
 			Help: `Canned ACL used when creating buckets and storing or copying objects.
@@ -2492,45 +2424,6 @@ In this case, you might want to try disabling this option.
 			Help:     "Endpoint for STS.\n\nLeave blank if using AWS to use the default endpoint for the region.",
 			Provider: "AWS",
 			Advanced: true,
-		}, {
-			Name: "use_already_exists",
-			Help: strings.ReplaceAll(`Set if rclone should report BucketAlreadyExists errors on bucket creation.
-
-At some point during the evolution of the s3 protocol, AWS started
-returning an |AlreadyOwnedByYou| error when attempting to create a
-bucket that the user already owned, rather than a
-|BucketAlreadyExists| error.
-
-Unfortunately exactly what has been implemented by s3 clones is a
-little inconsistent, some return |AlreadyOwnedByYou|, some return
-|BucketAlreadyExists| and some return no error at all.
-
-This is important to rclone because it ensures the bucket exists by
-creating it on quite a lot of operations (unless
-|--s3-no-check-bucket| is used).
-
-If rclone knows the provider can return |AlreadyOwnedByYou| or returns
-no error then it can report |BucketAlreadyExists| errors when the user
-attempts to create a bucket not owned by them. Otherwise rclone
-ignores the |BucketAlreadyExists| error which can lead to confusion.
-
-This should be automatically set correctly for all providers rclone
-knows about - please make a bug report if not.
-`, "|", "`"),
-			Default:  fs.Tristate{},
-			Advanced: true,
-		}, {
-			Name: "use_multipart_uploads",
-			Help: `Set if rclone should use multipart uploads.
-
-You can change this if you want to disable the use of multipart uploads.
-This shouldn't be necessary in normal operation.
-
-This should be automatically set correctly for all providers rclone
-knows about - please make a bug report if not.
-`,
-			Default:  fs.Tristate{},
-			Advanced: true,
 		},
 		}})
 }
@@ -2657,8 +2550,6 @@ type Options struct {
 	MightGzip             fs.Tristate          `config:"might_gzip"`
 	UseAcceptEncodingGzip fs.Tristate          `config:"use_accept_encoding_gzip"`
 	NoSystemMetadata      bool                 `config:"no_system_metadata"`
-	UseAlreadyExists      fs.Tristate          `config:"use_already_exists"`
-	UseMultipartUploads   fs.Tristate          `config:"use_multipart_uploads"`
 }
 
 // Fs represents a remote s3 server
@@ -2913,7 +2804,6 @@ func s3Connection(ctx context.Context, opt *Options, client *http.Client) (*s3.S
 	case v.AccessKeyID == "" && v.SecretAccessKey == "":
 		// if no access key/secret and iam is explicitly disabled then fall back to anon interaction
 		cred = credentials.AnonymousCredentials
-		fs.Debugf(nil, "Using anonymous credentials - did you mean to set env_auth=true?")
 	case v.AccessKeyID == "":
 		return nil, nil, errors.New("access_key_id not found")
 	case v.SecretAccessKey == "":
@@ -3004,23 +2894,13 @@ func checkUploadCutoff(cs fs.SizeSuffix) error {
 }
 
 func (f *Fs) setUploadCutoff(cs fs.SizeSuffix) (old fs.SizeSuffix, err error) {
-	if f.opt.Provider != "Rclone" {
-		err = checkUploadCutoff(cs)
-	}
+	err = checkUploadCutoff(cs)
 	if err == nil {
 		old, f.opt.UploadCutoff = f.opt.UploadCutoff, cs
 	}
 	return
 }
 
-func (f *Fs) setCopyCutoff(cs fs.SizeSuffix) (old fs.SizeSuffix, err error) {
-	err = checkUploadChunkSize(cs)
-	if err == nil {
-		old, f.opt.CopyCutoff = f.opt.CopyCutoff, cs
-	}
-	return
-}
-
 // setEndpointValueForIDriveE2 gets user region endpoint against the Access Key details by calling the API
 func setEndpointValueForIDriveE2(m configmap.Mapper) (err error) {
 	value, ok := m.Get(fs.ConfigProvider)
@@ -3057,19 +2937,15 @@ func setEndpointValueForIDriveE2(m configmap.Mapper) (err error) {
 // There should be no testing against opt.Provider anywhere in the
 // code except in here to localise the setting of the quirks.
 //
-// Run the integration tests to check you have the quirks correct.
-//
-//	go test -v -remote NewS3Provider:
+// These should be differences from AWS S3
 func setQuirks(opt *Options) {
 	var (
-		listObjectsV2         = true // Always use ListObjectsV2 instead of ListObjects
-		virtualHostStyle      = true // Use bucket.provider.com instead of putting the bucket in the URL
-		urlEncodeListings     = true // URL encode the listings to help with control characters
-		useMultipartEtag      = true // Set if Etags for multpart uploads are compatible with AWS
-		useAcceptEncodingGzip = true // Set Accept-Encoding: gzip
-		mightGzip             = true // assume all providers might use content encoding gzip until proven otherwise
-		useAlreadyExists      = true // Set if provider returns AlreadyOwnedByYou or no error if you try to remake your own bucket
-		useMultipartUploads   = true // Set if provider supports multipart uploads
+		listObjectsV2         = true
+		virtualHostStyle      = true
+		urlEncodeListings     = true
+		useMultipartEtag      = true
+		useAcceptEncodingGzip = true
+		mightGzip             = true // assume all providers might gzip until proven otherwise
 	)
 	switch opt.Provider {
 	case "AWS":
@@ -3077,22 +2953,18 @@ func setQuirks(opt *Options) {
 		mightGzip = false // Never auto gzips objects
 	case "Alibaba":
 		useMultipartEtag = false // Alibaba seems to calculate multipart Etags differently from AWS
-		useAlreadyExists = true  // returns 200 OK
 	case "HuaweiOBS":
 		// Huawei OBS PFS is not support listObjectV2, and if turn on the urlEncodeListing, marker will not work and keep list same page forever.
 		urlEncodeListings = false
 		listObjectsV2 = false
-		useAlreadyExists = false // untested
 	case "Ceph":
 		listObjectsV2 = false
 		virtualHostStyle = false
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "ChinaMobile":
 		listObjectsV2 = false
 		virtualHostStyle = false
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "Cloudflare":
 		virtualHostStyle = false
 		useMultipartEtag = false // currently multipart Etags are random
@@ -3100,111 +2972,86 @@ func setQuirks(opt *Options) {
 		listObjectsV2 = false
 		virtualHostStyle = false
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "DigitalOcean":
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "Dreamhost":
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "IBMCOS":
 		listObjectsV2 = false // untested
 		virtualHostStyle = false
 		urlEncodeListings = false
 		useMultipartEtag = false // untested
-		useAlreadyExists = false // returns BucketAlreadyExists
 	case "IDrive":
 		virtualHostStyle = false
-		useAlreadyExists = false // untested
 	case "IONOS":
 		// listObjectsV2 supported - https://api.ionos.com/docs/s3/#Basic-Operations-get-Bucket-list-type-2
 		virtualHostStyle = false
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "Petabox":
-		useAlreadyExists = false // untested
+		// No quirks
 	case "Liara":
 		virtualHostStyle = false
 		urlEncodeListings = false
 		useMultipartEtag = false
-		useAlreadyExists = false // untested
-	case "Linode":
-		useAlreadyExists = true // returns 200 OK
 	case "LyveCloud":
 		useMultipartEtag = false // LyveCloud seems to calculate multipart Etags differently from AWS
-		useAlreadyExists = false // untested
 	case "Minio":
 		virtualHostStyle = false
 	case "Netease":
 		listObjectsV2 = false // untested
 		urlEncodeListings = false
 		useMultipartEtag = false // untested
-		useAlreadyExists = false // untested
 	case "RackCorp":
 		// No quirks
 		useMultipartEtag = false // untested
-		useAlreadyExists = false // untested
-	case "Rclone":
-		listObjectsV2 = true
-		urlEncodeListings = true
-		virtualHostStyle = false
-		useMultipartEtag = false
-		useAlreadyExists = false
-		// useMultipartUploads = false - set this manually
 	case "Scaleway":
 		// Scaleway can only have 1000 parts in an upload
 		if opt.MaxUploadParts > 1000 {
 			opt.MaxUploadParts = 1000
 		}
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "SeaweedFS":
 		listObjectsV2 = false // untested
 		virtualHostStyle = false
 		urlEncodeListings = false
 		useMultipartEtag = false // untested
-		useAlreadyExists = false // untested
 	case "StackPath":
 		listObjectsV2 = false // untested
 		virtualHostStyle = false
 		urlEncodeListings = false
-		useAlreadyExists = false // untested
 	case "Storj":
 		// Force chunk size to >= 64 MiB
 		if opt.ChunkSize < 64*fs.Mebi {
 			opt.ChunkSize = 64 * fs.Mebi
 		}
-		useAlreadyExists = false // returns BucketAlreadyExists
 	case "Synology":
 		useMultipartEtag = false
-		useAlreadyExists = false // untested
 	case "TencentCOS":
 		listObjectsV2 = false    // untested
 		useMultipartEtag = false // untested
-		useAlreadyExists = false // untested
 	case "Wasabi":
-		useAlreadyExists = true // returns 200 OK
+		// No quirks
 	case "Leviia":
-		useAlreadyExists = false // untested
+		// No quirks
 	case "Qiniu":
 		useMultipartEtag = false
 		urlEncodeListings = false
 		virtualHostStyle = false
-		useAlreadyExists = false // untested
 	case "GCS":
 		// Google break request Signature by mutating accept-encoding HTTP header
 		// https://github.com/rclone/rclone/issues/6670
 		useAcceptEncodingGzip = false
-		useAlreadyExists = true // returns BucketNameUnavailable instead of BucketAlreadyExists but good enough!
-	default:
-		fs.Logf("s3", "s3 provider %q not known - please set correctly", opt.Provider)
-		fallthrough
 	case "Other":
 		listObjectsV2 = false
 		virtualHostStyle = false
 		urlEncodeListings = false
 		useMultipartEtag = false
-		useAlreadyExists = false
+	default:
+		fs.Logf("s3", "s3 provider %q not known - please set correctly", opt.Provider)
+		listObjectsV2 = false
+		virtualHostStyle = false
+		urlEncodeListings = false
+		useMultipartEtag = false
 	}
 
 	// Path Style vs Virtual Host style
@@ -3244,22 +3091,6 @@ func setQuirks(opt *Options) {
 		opt.UseAcceptEncodingGzip.Valid = true
 		opt.UseAcceptEncodingGzip.Value = useAcceptEncodingGzip
 	}
-
-	// Has the provider got AlreadyOwnedByYou error?
-	if !opt.UseAlreadyExists.Valid {
-		opt.UseAlreadyExists.Valid = true
-		opt.UseAlreadyExists.Value = useAlreadyExists
-	}
-
-	// Set the correct use multipart uploads if not manually set
-	if !opt.UseMultipartUploads.Valid {
-		opt.UseMultipartUploads.Valid = true
-		opt.UseMultipartUploads.Value = useMultipartUploads
-	}
-	if !opt.UseMultipartUploads.Value {
-		opt.UploadCutoff = math.MaxInt64
-	}
-
 }
 
 // setRoot changes the root of the Fs
@@ -3372,10 +3203,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		f.features.CanHaveEmptyDirectories = true
 	}
 	// f.listMultipartUploads()
-	if !opt.UseMultipartUploads.Value {
-		fs.Debugf(f, "Disabling multipart uploads")
-		f.features.OpenChunkWriter = nil
-	}
 
 	if f.rootBucket != "" && f.rootDirectory != "" && !opt.NoHeadObject && !strings.HasSuffix(root, "/") {
 		// Check to see if the (bucket,directory) is actually an existing file
@@ -3731,9 +3558,6 @@ func (ls *versionsList) List(ctx context.Context) (resp *s3.ListObjectsV2Output,
 	// Set up the request for next time
 	ls.req.KeyMarker = respVersions.NextKeyMarker
 	ls.req.VersionIdMarker = respVersions.NextVersionIdMarker
-	if aws.BoolValue(respVersions.IsTruncated) && ls.req.KeyMarker == nil {
-		return nil, nil, errors.New("s3 protocol error: received versions listing with IsTruncated set with no NextKeyMarker")
-	}
 
 	// If we are URL encoding then must decode the marker
 	if ls.req.KeyMarker != nil && ls.req.EncodingType != nil {
@@ -4295,17 +4119,8 @@ func (f *Fs) makeBucket(ctx context.Context, bucket string) error {
 			fs.Infof(f, "Bucket %q created with ACL %q", bucket, f.opt.BucketACL)
 		}
 		if awsErr, ok := err.(awserr.Error); ok {
-			switch awsErr.Code() {
-			case "BucketAlreadyOwnedByYou":
+			if code := awsErr.Code(); code == "BucketAlreadyOwnedByYou" || code == "BucketAlreadyExists" {
 				err = nil
-			case "BucketAlreadyExists", "BucketNameUnavailable":
-				if f.opt.UseAlreadyExists.Value {
-					// We can trust BucketAlreadyExists to mean not owned by us, so make it non retriable
-					err = fserrors.NoRetryError(err)
-				} else {
-					// We can't trust BucketAlreadyExists to mean not owned by us, so ignore it
-					err = nil
-				}
 			}
 		}
 		return err
@@ -5678,13 +5493,6 @@ func (f *Fs) OpenChunkWriter(ctx context.Context, remote string, src fs.ObjectIn
 	var mOut *s3.CreateMultipartUploadOutput
 	err = f.pacer.Call(func() (bool, error) {
 		mOut, err = f.c.CreateMultipartUploadWithContext(ctx, &mReq)
-		if err == nil {
-			if mOut == nil {
-				err = fserrors.RetryErrorf("internal error: no info from multipart upload")
-			} else if mOut.UploadId == nil {
-				err = fserrors.RetryErrorf("internal error: no UploadId in multpart upload: %#v", *mOut)
-			}
-		}
 		return f.shouldRetry(ctx, err)
 	})
 	if err != nil {
@@ -6028,7 +5836,7 @@ func (o *Object) prepareUpload(ctx context.Context, src fs.ObjectInfo, options [
 	}
 
 	// Fetch metadata if --metadata is in use
-	meta, err := fs.GetMetadataOptions(ctx, o.fs, src, options)
+	meta, err := fs.GetMetadataOptions(ctx, src, options)
 	if err != nil {
 		return ui, fmt.Errorf("failed to read metadata from source object: %w", err)
 	}

backend/s3/s3_internal_test.go

@@ -12,7 +12,6 @@ import (
 	"time"
 
 	"github.com/aws/aws-sdk-go/aws"
-	"github.com/aws/aws-sdk-go/aws/awserr"
 	"github.com/aws/aws-sdk-go/service/s3"
 	"github.com/rclone/rclone/fs"
 	"github.com/rclone/rclone/fs/cache"
@@ -394,41 +393,6 @@ func (f *Fs) InternalTestVersions(t *testing.T) {
 		}
 	})
 
-	t.Run("Mkdir", func(t *testing.T) {
-		// Test what happens when we create a bucket we already own and see whether the
-		// quirk is set correctly
-		req := s3.CreateBucketInput{
-			Bucket: &f.rootBucket,
-			ACL:    stringPointerOrNil(f.opt.BucketACL),
-		}
-		if f.opt.LocationConstraint != "" {
-			req.CreateBucketConfiguration = &s3.CreateBucketConfiguration{
-				LocationConstraint: &f.opt.LocationConstraint,
-			}
-		}
-		err := f.pacer.Call(func() (bool, error) {
-			_, err := f.c.CreateBucketWithContext(ctx, &req)
-			return f.shouldRetry(ctx, err)
-		})
-		var errString string
-		if err == nil {
-			errString = "No Error"
-		} else if awsErr, ok := err.(awserr.Error); ok {
-			errString = awsErr.Code()
-		} else {
-			assert.Fail(t, "Unknown error %T %v", err, err)
-		}
-		t.Logf("Creating a bucket we already have created returned code: %s", errString)
-		switch errString {
-		case "BucketAlreadyExists":
-			assert.False(t, f.opt.UseAlreadyExists.Value, "Need to clear UseAlreadyExists quirk")
-		case "No Error", "BucketAlreadyOwnedByYou":
-			assert.True(t, f.opt.UseAlreadyExists.Value, "Need to set UseAlreadyExists quirk")
-		default:
-			assert.Fail(t, "Unknown error string %q", errString)
-		}
-	})
-
 	t.Run("Cleanup", func(t *testing.T) {
 		require.NoError(t, f.CleanUpHidden(ctx))
 		items := append([]fstest.Item{newItem}, fstests.InternalTestFiles...)

backend/s3/s3_test.go

@@ -47,12 +47,4 @@ func (f *Fs) SetUploadCutoff(cs fs.SizeSuffix) (fs.SizeSuffix, error) {
 	return f.setUploadCutoff(cs)
 }
 
-func (f *Fs) SetCopyCutoff(cs fs.SizeSuffix) (fs.SizeSuffix, error) {
-	return f.setCopyCutoff(cs)
-}
-
-var (
-	_ fstests.SetUploadChunkSizer = (*Fs)(nil)
-	_ fstests.SetUploadCutoffer   = (*Fs)(nil)
-	_ fstests.SetCopyCutoffer     = (*Fs)(nil)
-)
+var _ fstests.SetUploadChunkSizer = (*Fs)(nil)

backend/sftp/sftp.go

@@ -449,26 +449,6 @@ Example:
 	myUser:myPass@localhost:9005
 	`,
 			Advanced: true,
-		}, {
-			Name:    "copy_is_hardlink",
-			Default: false,
-			Help: `Set to enable server side copies using hardlinks.
-
-The SFTP protocol does not define a copy command so normally server
-side copies are not allowed with the sftp backend.
-
-However the SFTP protocol does support hardlinking, and if you enable
-this flag then the sftp backend will support server side copies. These
-will be implemented by doing a hardlink from the source to the
-destination.
-
-Not all sftp servers support this.
-
-Note that hardlinking two files together will use no additional space
-as the source and the destination will be the same file.
-
-This feature may be useful backups made with --copy-dest.`,
-			Advanced: true,
 		}},
 	}
 	fs.Register(fsi)
@@ -510,7 +490,6 @@ type Options struct {
 	HostKeyAlgorithms       fs.SpaceSepList `config:"host_key_algorithms"`
 	SSH                     fs.SpaceSepList `config:"ssh"`
 	SocksProxy              string          `config:"socks_proxy"`
-	CopyIsHardlink          bool            `config:"copy_is_hardlink"`
 }
 
 // Fs stores the interface to the remote SFTP files
@@ -1070,10 +1049,6 @@ func NewFsWithConnection(ctx context.Context, f *Fs, name string, root string, m
 		SlowHash:                true,
 		PartialUploads:          true,
 	}).Fill(ctx, f)
-	if !opt.CopyIsHardlink {
-		// Disable server side copy unless --sftp-copy-is-hardlink is set
-		f.features.Copy = nil
-	}
 	// Make a connection and pool it to return errors early
 	c, err := f.getSftpConnection(ctx)
 	if err != nil {
@@ -1426,43 +1401,6 @@ func (f *Fs) Move(ctx context.Context, src fs.Object, remote string) (fs.Object,
 	return dstObj, nil
 }
 
-// Copy server side copies a remote sftp file object using hardlinks
-func (f *Fs) Copy(ctx context.Context, src fs.Object, remote string) (fs.Object, error) {
-	if !f.opt.CopyIsHardlink {
-		return nil, fs.ErrorCantCopy
-	}
-	srcObj, ok := src.(*Object)
-	if !ok {
-		fs.Debugf(src, "Can't copy - not same remote type")
-		return nil, fs.ErrorCantCopy
-	}
-	err := f.mkParentDir(ctx, remote)
-	if err != nil {
-		return nil, fmt.Errorf("Copy mkParentDir failed: %w", err)
-	}
-	c, err := f.getSftpConnection(ctx)
-	if err != nil {
-		return nil, fmt.Errorf("Copy: %w", err)
-	}
-	srcPath, dstPath := srcObj.path(), path.Join(f.absRoot, remote)
-	err = c.sftpClient.Link(srcPath, dstPath)
-	f.putSftpConnection(&c, err)
-	if err != nil {
-		if sftpErr, ok := err.(*sftp.StatusError); ok {
-			if sftpErr.FxCode() == sftp.ErrSSHFxOpUnsupported {
-				// Remote doesn't support Link
-				return nil, fs.ErrorCantCopy
-			}
-		}
-		return nil, fmt.Errorf("Copy failed: %w", err)
-	}
-	dstObj, err := f.NewObject(ctx, remote)
-	if err != nil {
-		return nil, fmt.Errorf("Copy NewObject failed: %w", err)
-	}
-	return dstObj, nil
-}
-
 // DirMove moves src, srcRemote to this remote at dstRemote
 // using server-side move operations.
 //
@@ -2182,7 +2120,6 @@ var (
 	_ fs.Fs          = &Fs{}
 	_ fs.PutStreamer = &Fs{}
 	_ fs.Mover       = &Fs{}
-	_ fs.Copier      = &Fs{}
 	_ fs.DirMover    = &Fs{}
 	_ fs.Abouter     = &Fs{}
 	_ fs.Shutdowner  = &Fs{}

backend/smb/connpool.go

@@ -6,7 +6,7 @@ import (
 	"net"
 	"time"
 
-	smb2 "github.com/cloudsoda/go-smb2"
+	smb2 "github.com/hirochachacha/go-smb2"
 	"github.com/rclone/rclone/fs"
 	"github.com/rclone/rclone/fs/accounting"
 	"github.com/rclone/rclone/fs/config/obscure"
@@ -40,7 +40,7 @@ func (f *Fs) dial(ctx context.Context, network, addr string) (*conn, error) {
 		},
 	}
 
-	session, err := d.DialConn(ctx, tconn, addr)
+	session, err := d.DialContext(ctx, tconn)
 	if err != nil {
 		return nil, err
 	}

backend/smb/smb.go

@@ -177,7 +177,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		CaseInsensitive:         opt.CaseInsensitive,
 		CanHaveEmptyDirectories: true,
 		BucketBased:             true,
-		PartialUploads:          true,
 	}).Fill(ctx, f)
 
 	f.pacer = fs.NewPacer(ctx, pacer.NewDefault(pacer.MinSleep(minSleep), pacer.MaxSleep(maxSleep), pacer.DecayConstant(decayConstant)))

backend/union/union.go

@@ -877,13 +877,6 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e
 		opt:       *opt,
 		upstreams: usedUpstreams,
 	}
-	// Correct root if definitely pointing to a file
-	if fserr == fs.ErrorIsFile {
-		f.root = path.Dir(f.root)
-		if f.root == "." || f.root == "/" {
-			f.root = ""
-		}
-	}
 	err = upstream.Prepare(f.upstreams)
 	if err != nil {
 		return nil, err

backend/webdav/api/types.go

@@ -121,8 +121,9 @@ func (p *Prop) Hashes() (hashes map[hash.Type]string) {
 		hashes = make(map[hash.Type]string)
 		hashes[hash.SHA1] = *p.MESha1Hex
 		return hashes
+	} else {
+		return nil
 	}
-	return nil
 }
 
 // PropValue is a tagged name and value

backend/webdav/webdav.go

@@ -91,9 +91,6 @@ func init() {
 			}, {
 				Value: "sharepoint-ntlm",
 				Help:  "Sharepoint with NTLM authentication, usually self-hosted or on-premises",
-			}, {
-				Value: "rclone",
-				Help:  "rclone WebDAV server to serve a remote over HTTP via the WebDAV protocol",
 			}, {
 				Value: "other",
 				Help:  "Other site/service or software",
@@ -647,10 +644,6 @@ func (f *Fs) setQuirks(ctx context.Context, vendor string) error {
 		// so we must perform an extra check to detect this
 		// condition and return a proper error code.
 		f.checkBeforePurge = true
-	case "rclone":
-		f.canStream = true
-		f.precision = time.Second
-		f.useOCMtime = true
 	case "other":
 	default:
 		fs.Debugf(f, "Unknown vendor %q", vendor)

bin/.ignore-emails

@@ -7,7 +7,3 @@
 <ankur0493@gmail.com>
 <agupta@egnyte.com>
 <ricci@disroot.org>
-<stoesser@yay-digital.de>
-<services+github@simjo.st>
-<seb•ɑƬ•chezwam•ɖɵʈ•org>
-<allllaboutyou@gmail.com>

bin/cross-compile.go

@@ -6,6 +6,7 @@
 package main
 
 import (
+	"encoding/json"
 	"flag"
 	"fmt"
 	"log"
@@ -20,21 +21,23 @@ import (
 	"sync"
 	"text/template"
 	"time"
+
+	"github.com/coreos/go-semver/semver"
 )
 
 var (
 	// Flags
-	debug           = flag.Bool("d", false, "Print commands instead of running them")
-	parallel        = flag.Int("parallel", runtime.NumCPU(), "Number of commands to run in parallel")
+	debug           = flag.Bool("d", false, "Print commands instead of running them.")
+	parallel        = flag.Int("parallel", runtime.NumCPU(), "Number of commands to run in parallel.")
 	copyAs          = flag.String("release", "", "Make copies of the releases with this name")
 	gitLog          = flag.String("git-log", "", "git log to include as well")
 	include         = flag.String("include", "^.*$", "os/arch regexp to include")
 	exclude         = flag.String("exclude", "^$", "os/arch regexp to exclude")
 	cgo             = flag.Bool("cgo", false, "Use cgo for the build")
-	noClean         = flag.Bool("no-clean", false, "Don't clean the build directory before running")
+	noClean         = flag.Bool("no-clean", false, "Don't clean the build directory before running.")
 	tags            = flag.String("tags", "", "Space separated list of build tags")
 	buildmode       = flag.String("buildmode", "", "Passed to go build -buildmode flag")
-	compileOnly     = flag.Bool("compile-only", false, "Just build the binary, not the zip")
+	compileOnly     = flag.Bool("compile-only", false, "Just build the binary, not the zip.")
 	extraEnv        = flag.String("env", "", "comma separated list of VAR=VALUE env vars to set")
 	macOSSDK        = flag.String("macos-sdk", "", "macOS SDK to use")
 	macOSArch       = flag.String("macos-arch", "", "macOS arch to use")
@@ -137,21 +140,21 @@ func chdir(dir string) {
 func substitute(inFile, outFile string, data interface{}) {
 	t, err := template.ParseFiles(inFile)
 	if err != nil {
-		log.Fatalf("Failed to read template file %q: %v", inFile, err)
+		log.Fatalf("Failed to read template file %q: %v %v", inFile, err)
 	}
 	out, err := os.Create(outFile)
 	if err != nil {
-		log.Fatalf("Failed to create output file %q: %v", outFile, err)
+		log.Fatalf("Failed to create output file %q: %v %v", outFile, err)
 	}
 	defer func() {
 		err := out.Close()
 		if err != nil {
-			log.Fatalf("Failed to close output file %q: %v", outFile, err)
+			log.Fatalf("Failed to close output file %q: %v %v", outFile, err)
 		}
 	}()
 	err = t.Execute(out, data)
 	if err != nil {
-		log.Fatalf("Failed to substitute template file %q: %v", inFile, err)
+		log.Fatalf("Failed to substitute template file %q: %v %v", inFile, err)
 	}
 }
 
@@ -199,6 +202,101 @@ func buildDebAndRpm(dir, version, goarch string) []string {
 	return artifacts
 }
 
+// generate system object (syso) file to be picked up by a following go build for embedding icon and version info resources into windows executable
+func buildWindowsResourceSyso(goarch string, versionTag string) string {
+	type M map[string]interface{}
+	version := strings.TrimPrefix(versionTag, "v")
+	semanticVersion := semver.New(version)
+
+	// Build json input to goversioninfo utility
+	bs, err := json.Marshal(M{
+		"FixedFileInfo": M{
+			"FileVersion": M{
+				"Major": semanticVersion.Major,
+				"Minor": semanticVersion.Minor,
+				"Patch": semanticVersion.Patch,
+			},
+			"ProductVersion": M{
+				"Major": semanticVersion.Major,
+				"Minor": semanticVersion.Minor,
+				"Patch": semanticVersion.Patch,
+			},
+		},
+		"StringFileInfo": M{
+			"CompanyName":      "https://rclone.org",
+			"ProductName":      "Rclone",
+			"FileDescription":  "Rclone",
+			"InternalName":     "rclone",
+			"OriginalFilename": "rclone.exe",
+			"LegalCopyright":   "The Rclone Authors",
+			"FileVersion":      version,
+			"ProductVersion":   version,
+		},
+		"IconPath": "../graphics/logo/ico/logo_symbol_color.ico",
+	})
+	if err != nil {
+		log.Printf("Failed to build version info json: %v", err)
+		return ""
+	}
+
+	// Write json to temporary file that will only be used by the goversioninfo command executed below.
+	jsonPath, err := filepath.Abs("versioninfo_windows_" + goarch + ".json") // Appending goos and goarch as suffix to avoid any race conditions
+	if err != nil {
+		log.Printf("Failed to resolve path: %v", err)
+		return ""
+	}
+	err = os.WriteFile(jsonPath, bs, 0644)
+	if err != nil {
+		log.Printf("Failed to write %s: %v", jsonPath, err)
+		return ""
+	}
+	defer func() {
+		if err := os.Remove(jsonPath); err != nil {
+			if !os.IsNotExist(err) {
+				log.Printf("Warning: Couldn't remove generated %s: %v. Please remove it manually.", jsonPath, err)
+			}
+		}
+	}()
+
+	// Execute goversioninfo utility using the json file as input.
+	// It will produce a system object (syso) file that a following go build should pick up.
+	sysoPath, err := filepath.Abs("../resource_windows_" + goarch + ".syso") // Appending goos and goarch as suffix to avoid any race conditions, and also it is recognized by go build and avoids any builds for other systems considering it
+	if err != nil {
+		log.Printf("Failed to resolve path: %v", err)
+		return ""
+	}
+	args := []string{
+		"goversioninfo",
+		"-o",
+		sysoPath,
+	}
+	if strings.Contains(goarch, "64") {
+		args = append(args, "-64") // Make the syso a 64-bit coff file
+	}
+	if strings.Contains(goarch, "arm") {
+		args = append(args, "-arm") // Make the syso an arm binary
+	}
+	args = append(args, jsonPath)
+	err = runEnv(args, nil)
+	if err != nil {
+		return ""
+	}
+
+	return sysoPath
+}
+
+// delete generated system object (syso) resource file
+func cleanupResourceSyso(sysoFilePath string) {
+	if sysoFilePath == "" {
+		return
+	}
+	if err := os.Remove(sysoFilePath); err != nil {
+		if !os.IsNotExist(err) {
+			log.Printf("Warning: Couldn't remove generated %s: %v. Please remove it manually.", sysoFilePath, err)
+		}
+	}
+}
+
 // Trip a version suffix off the arch if present
 func stripVersion(goarch string) string {
 	i := strings.Index(goarch, "-")
@@ -217,41 +315,17 @@ func runOut(command ...string) string {
 	return strings.TrimSpace(string(out))
 }
 
-// Generate Windows resource system object file (.syso), which can be picked
-// up by the following go build for embedding version information and icon
-// resources into the executable.
-func generateResourceWindows(version, arch string) func() {
-	sysoPath := fmt.Sprintf("../resource_windows_%s.syso", arch) // Use explicit destination filename, even though it should be same as default, so that we are sure we have the correct reference to it
-	if err := os.Remove(sysoPath); !os.IsNotExist(err) {
-		// Note: This one we choose to treat as fatal, to avoid any risk of picking up an old .syso file without noticing.
-		log.Fatalf("Failed to remove existing Windows %s resource system object file %s: %v", arch, sysoPath, err)
-	}
-	args := []string{"go", "run", "../bin/resource_windows.go", "-arch", arch, "-version", version, "-syso", sysoPath}
-	if err := runEnv(args, nil); err != nil {
-		log.Printf("Warning: Couldn't generate Windows %s resource system object file, binaries will not have version information or icon embedded", arch)
-		return nil
-	}
-	if _, err := os.Stat(sysoPath); err != nil {
-		log.Printf("Warning: Couldn't find generated Windows %s resource system object file, binaries will not have version information or icon embedded", arch)
-		return nil
-	}
-	return func() {
-		if err := os.Remove(sysoPath); err != nil && !os.IsNotExist(err) {
-			log.Printf("Warning: Couldn't remove generated Windows %s resource system object file %s: %v. Please remove it manually.", arch, sysoPath, err)
-		}
-	}
-}
-
 // build the binary in dir returning success or failure
 func compileArch(version, goos, goarch, dir string) bool {
 	log.Printf("Compiling %s/%s into %s", goos, goarch, dir)
-	goarchBase := stripVersion(goarch)
 	output := filepath.Join(dir, "rclone")
 	if goos == "windows" {
 		output += ".exe"
-		if cleanupFn := generateResourceWindows(version, goarchBase); cleanupFn != nil {
-			defer cleanupFn()
+		sysoPath := buildWindowsResourceSyso(goarch, version)
+		if sysoPath == "" {
+			log.Printf("Warning: Windows binaries will not have file information embedded")
 		}
+		defer cleanupResourceSyso(sysoPath)
 	}
 	err := os.MkdirAll(dir, 0777)
 	if err != nil {
@@ -274,7 +348,7 @@ func compileArch(version, goos, goarch, dir string) bool {
 	)
 	env := []string{
 		"GOOS=" + goos,
-		"GOARCH=" + goarchBase,
+		"GOARCH=" + stripVersion(goarch),
 	}
 	if *extraEnv != "" {
 		env = append(env, strings.Split(*extraEnv, ",")...)

bin/make_manual.py

@@ -50,17 +50,14 @@ docs = [
     "hdfs.md",
     "hidrive.md",
     "http.md",
-    "imagekit.md",
     "internetarchive.md",
     "jottacloud.md",
     "koofr.md",
-    "linkbox.md",
     "mailru.md",
     "mega.md",
     "memory.md",
     "netstorage.md",
     "azureblob.md",
-    "azurefiles.md",
     "onedrive.md",
     "opendrive.md",
     "oracleobjectstorage.md",

bin/resource_windows.go

@@ -1,122 +0,0 @@
-// Utility program to generate Rclone-specific Windows resource system object
-// file (.syso), that can be picked up by a following go build for embedding
-// version information and icon resources into a rclone binary.
-//
-// Run it with "go generate", or "go run" to be able to customize with
-// command-line flags. Note that this program is intended to be run directly
-// from its original location in the source tree: Default paths are absolute
-// within the current source tree, which is convenient because it makes it
-// oblivious to the working directory, and it gives identical result whether
-// run by "go generate" or "go run", but it will not make sense if this
-// program's source is moved out from the source tree.
-//
-// Can be used for rclone.exe (default), and other binaries such as
-// librclone.dll (must be specified with flag -binary).
-//
-
-//go:generate go run resource_windows.go
-//go:build tools
-// +build tools
-
-package main
-
-import (
-	"flag"
-	"fmt"
-	"log"
-	"path"
-	"runtime"
-	"strings"
-
-	"github.com/coreos/go-semver/semver"
-	"github.com/josephspurrier/goversioninfo"
-	"github.com/rclone/rclone/fs"
-)
-
-func main() {
-	// Get path of directory containing the current source file to use for absolute path references within the code tree (as described above)
-	projectDir := ""
-	_, sourceFile, _, ok := runtime.Caller(0)
-	if ok {
-		projectDir = path.Dir(path.Dir(sourceFile)) // Root of the current project working directory
-	}
-
-	// Define flags
-	binary := flag.String("binary", "rclone.exe", `The name of the binary to generate resource for, e.g. "rclone.exe" or "librclone.dll"`)
-	arch := flag.String("arch", runtime.GOARCH, `Architecture of resource file, or the target GOARCH, "386", "amd64", "arm", or "arm64"`)
-	version := flag.String("version", fs.Version, "Version number or tag name")
-	icon := flag.String("icon", path.Join(projectDir, "graphics/logo/ico/logo_symbol_color.ico"), "Path to icon file to embed in an .exe binary")
-	dir := flag.String("dir", projectDir, "Path to output directory where to write the resulting system object file (.syso), with a default name according to -arch (resource_windows_<arch>.syso), only considered if not -syso is specified")
-	syso := flag.String("syso", "", "Path to output resource system object file (.syso) to be created/overwritten, ignores -dir")
-
-	// Parse command-line flags
-	flag.Parse()
-
-	// Handle default value for -file which depends on optional -dir and -arch
-	if *syso == "" {
-		// Use default filename, which includes target GOOS (hardcoded "windows")
-		// and GOARCH (from argument -arch) as suffix, to avoid any race conditions,
-		// and also this will be recognized by go build when it is consuming the
-		// .syso file and will only be used for builds with matching os/arch.
-		*syso = path.Join(*dir, fmt.Sprintf("resource_windows_%s.syso", *arch))
-	}
-
-	// Parse version/tag string argument as a SemVer
-	stringVersion := strings.TrimPrefix(*version, "v")
-	semanticVersion, err := semver.NewVersion(stringVersion)
-	if err != nil {
-		log.Fatalf("Invalid version number: %v", err)
-	}
-
-	// Extract binary extension
-	binaryExt := path.Ext(*binary)
-
-	// Create the version info configuration container
-	vi := &goversioninfo.VersionInfo{}
-
-	// FixedFileInfo
-	vi.FixedFileInfo.FileOS = "040004" // VOS_NT_WINDOWS32
-	if strings.EqualFold(binaryExt, ".exe") {
-		vi.FixedFileInfo.FileType = "01" // VFT_APP
-	} else if strings.EqualFold(binaryExt, ".dll") {
-		vi.FixedFileInfo.FileType = "02" // VFT_DLL
-	} else {
-		log.Fatalf("Specified binary must have extension .exe or .dll")
-	}
-	// FixedFileInfo.FileVersion
-	vi.FixedFileInfo.FileVersion.Major = int(semanticVersion.Major)
-	vi.FixedFileInfo.FileVersion.Minor = int(semanticVersion.Minor)
-	vi.FixedFileInfo.FileVersion.Patch = int(semanticVersion.Patch)
-	vi.FixedFileInfo.FileVersion.Build = 0
-	// FixedFileInfo.ProductVersion
-	vi.FixedFileInfo.ProductVersion.Major = int(semanticVersion.Major)
-	vi.FixedFileInfo.ProductVersion.Minor = int(semanticVersion.Minor)
-	vi.FixedFileInfo.ProductVersion.Patch = int(semanticVersion.Patch)
-	vi.FixedFileInfo.ProductVersion.Build = 0
-
-	// StringFileInfo
-	vi.StringFileInfo.CompanyName = "https://rclone.org"
-	vi.StringFileInfo.ProductName = "Rclone"
-	vi.StringFileInfo.FileDescription = "Rclone"
-	vi.StringFileInfo.InternalName = (*binary)[:len(*binary)-len(binaryExt)]
-	vi.StringFileInfo.OriginalFilename = *binary
-	vi.StringFileInfo.LegalCopyright = "The Rclone Authors"
-	vi.StringFileInfo.FileVersion = stringVersion
-	vi.StringFileInfo.ProductVersion = stringVersion
-
-	// Icon (only relevant for .exe, not .dll)
-	if *icon != "" && strings.EqualFold(binaryExt, ".exe") {
-		vi.IconPath = *icon
-	}
-
-	// Build native structures from the configuration data
-	vi.Build()
-
-	// Write the native structures as binary data to a buffer
-	vi.Walk()
-
-	// Write the binary data buffer to file
-	if err := vi.WriteSyso(*syso, *arch); err != nil {
-		log.Fatalf(`Failed to generate Windows %s resource system object file for %v with path "%v": %v`, *arch, *binary, *syso, err)
-	}
-}

bin/test_metadata_mapper.py

@@ -1,24 +0,0 @@
-#!/usr/bin/env python3
-"""
-A demo metadata mapper
-"""
-
-import sys
-import json
-
-def main():
-    i = json.load(sys.stdin)
-    # Add tag to description
-    metadata = i["Metadata"]
-    if "description" in metadata:
-        metadata["description"] += " [migrated from domain1]"
-    else:
-        metadata["description"] = "[migrated from domain1]"
-    # Modify owner
-    if "owner" in metadata:
-        metadata["owner"] = metadata["owner"].replace("domain1.com", "domain2.com")
-    o = { "Metadata": metadata }
-    json.dump(o, sys.stdout, indent="\t")
-
-if __name__ == "__main__":
-    main()

bin/update-authors.py

@@ -27,7 +27,6 @@ def add_email(name, email):
     subprocess.check_call(["git", "commit", "-m", "Add %s to contributors" % name, AUTHORS])
     
 def main():
-    # Add emails from authors
     out = subprocess.check_output(["git", "log", '--reverse', '--format=%an|%ae', "master"])
     out = out.decode("utf-8")
 
@@ -44,23 +43,5 @@ def main():
         previous.add(email)
         add_email(name, email)
 
-    # Add emails from Co-authored-by: lines
-    out = subprocess.check_output(["git", "log", '-i', '--grep', 'Co-authored-by:', "master"])
-    out = out.decode("utf-8")
-    co_authored_by = re.compile(r"(?i)Co-authored-by:\s+(.*?)\s+<([^>]+)>$")
-
-    for line in out.split("\n"):
-        line = line.strip()
-        m = co_authored_by.search(line)
-        if not m:
-            continue
-        name, email = m.group(1), m.group(2)
-        name = name.strip()
-        email = email.strip()
-        if email in previous:
-            continue
-        previous.add(email)
-        add_email(name, email)
-
 if __name__ == "__main__":
     main()

cmd/all/all.go

@@ -40,7 +40,6 @@ import (
 	_ "github.com/rclone/rclone/cmd/move"
 	_ "github.com/rclone/rclone/cmd/moveto"
 	_ "github.com/rclone/rclone/cmd/ncdu"
-	_ "github.com/rclone/rclone/cmd/nfsmount"
 	_ "github.com/rclone/rclone/cmd/obscure"
 	_ "github.com/rclone/rclone/cmd/purge"
 	_ "github.com/rclone/rclone/cmd/rc"

cmd/checksum/checksum.go

@@ -24,18 +24,15 @@ func init() {
 }
 
 var commandDefinition = &cobra.Command{
-	Use:   "checksum <hash> sumfile dst:path",
-	Short: `Checks the files in the destination against a SUM file.`,
+	Use:   "checksum <hash> sumfile src:path",
+	Short: `Checks the files in the source against a SUM file.`,
 	Long: strings.ReplaceAll(`
-Checks that hashsums of destination files match the SUM file.
+Checks that hashsums of source files match the SUM file.
 It compares hashes (MD5, SHA1, etc) and logs a report of files which
 don't match.  It doesn't alter the file system.
 
-The sumfile is treated as the source and the dst:path is treated as
-the destination for the purposes of the output.
-
-If you supply the |--download| flag, it will download the data from the remote
-and calculate the content hash on the fly.  This can be useful for remotes
+If you supply the |--download| flag, it will download the data from remote
+and calculate the contents hash on the fly.  This can be useful for remotes
 that don't support hashes or if you really want to check all the data.
 
 Note that hash values in the SUM file are treated as case insensitive.

cmd/cmount/mount.go

@@ -25,7 +25,7 @@ import (
 
 func init() {
 	name := "cmount"
-	cmountOnly := runtime.GOOS != "linux" // rclone mount only works for linux
+	cmountOnly := ProvidedBy(runtime.GOOS)
 	if cmountOnly {
 		name = "mount"
 	}

cmd/cmount/mount_test.go

@@ -15,7 +15,6 @@ import (
 	"testing"
 
 	"github.com/rclone/rclone/fstest/testy"
-	"github.com/rclone/rclone/vfs/vfscommon"
 	"github.com/rclone/rclone/vfs/vfstest"
 )
 
@@ -24,5 +23,5 @@ func TestMount(t *testing.T) {
 	if runtime.GOOS == "darwin" {
 		testy.SkipUnreliable(t)
 	}
-	vfstest.RunTests(t, false, vfscommon.CacheModeOff, true, mount)
+	vfstest.RunTests(t, false, mount)
 }

cmd/hashsum/hashsum.go

@@ -82,7 +82,7 @@ func CreateFromStdinArg(ht hash.Type, args []string, startArg int) (bool, error)
 }
 
 var commandDefinition = &cobra.Command{
-	Use:   "hashsum [<hash> remote:path]",
+	Use:   "hashsum <hash> remote:path",
 	Short: `Produces a hashsum file for all the objects in the path.`,
 	Long: `
 Produces a hash file for all the objects in the path using the hash

cmd/mount/dir.go

@@ -1,5 +1,5 @@
-//go:build linux
-// +build linux
+//go:build linux || freebsd
+// +build linux freebsd
 
 package mount
 

cmd/mount/file.go

@@ -1,5 +1,5 @@
-//go:build linux
-// +build linux
+//go:build linux || freebsd
+// +build linux freebsd
 
 package mount
 

cmd/mount/fs.go

@@ -1,7 +1,7 @@
 // FUSE main Fs
 
-//go:build linux
-// +build linux
+//go:build linux || freebsd
+// +build linux freebsd
 
 package mount
 

cmd/mount/handle.go

@@ -1,5 +1,5 @@
-//go:build linux
-// +build linux
+//go:build linux || freebsd
+// +build linux freebsd
 
 package mount
 

cmd/mount/mount.go

@@ -1,5 +1,5 @@
-//go:build linux
-// +build linux
+//go:build linux || freebsd
+// +build linux freebsd
 
 // Package mount implements a FUSE mounting system for rclone remotes.
 package mount

cmd/mount/mount_test.go

@@ -1,15 +1,14 @@
-//go:build linux
-// +build linux
+//go:build linux || freebsd
+// +build linux freebsd
 
 package mount
 
 import (
 	"testing"
 
-	"github.com/rclone/rclone/vfs/vfscommon"
 	"github.com/rclone/rclone/vfs/vfstest"
 )
 
 func TestMount(t *testing.T) {
-	vfstest.RunTests(t, false, vfscommon.CacheModeOff, true, mount)
+	vfstest.RunTests(t, false, mount)
 }

cmd/mount/mount_unsupported.go

@@ -1,8 +1,10 @@
-//go:build !linux
-// +build !linux
+//go:build !linux && !freebsd
+// +build !linux,!freebsd
 
 // Package mount implements a FUSE mounting system for rclone remotes.
 //
 // Build for mount for unsupported platforms to stop go complaining
 // about "no buildable Go source files".
+//
+// Invert the build constraint: linux freebsd
 package mount

cmd/mount2/mount_test.go

@@ -6,10 +6,9 @@ package mount2
 import (
 	"testing"
 
-	"github.com/rclone/rclone/vfs/vfscommon"
 	"github.com/rclone/rclone/vfs/vfstest"
 )
 
 func TestMount(t *testing.T) {
-	vfstest.RunTests(t, false, vfscommon.CacheModeOff, true, mount)
+	vfstest.RunTests(t, false, mount)
 }

cmd/mountlib/help.go

@@ -1,11 +1,15 @@
+package mountlib
+
+// "@" will be replaced by the command name, "|" will be replaced by backticks
+var mountHelp = `
 rclone @ allows Linux, FreeBSD, macOS and Windows to
 mount any of Rclone's cloud storage systems as a file system with
 FUSE.
 
-First set up your remote using `rclone config`.  Check it works with `rclone ls` etc.
+First set up your remote using |rclone config|.  Check it works with |rclone ls| etc.
 
 On Linux and macOS, you can run mount in either foreground or background (aka
-daemon) mode. Mount runs in foreground mode by default. Use the `--daemon` flag
+daemon) mode. Mount runs in foreground mode by default. Use the |--daemon| flag
 to force background mode. On Windows you can run mount in foreground only,
 the flag is ignored.
 
@@ -14,7 +18,7 @@ program starts, spawns background rclone process to setup and maintain the
 mount, waits until success or timeout and exits with appropriate code
 (killing the child process if it fails).
 
-On Linux/macOS/FreeBSD start the mount like this, where `/path/to/local/mount`
+On Linux/macOS/FreeBSD start the mount like this, where |/path/to/local/mount|
 is an **empty** **existing** directory:
 
     rclone @ remote:path/to/files /path/to/local/mount
@@ -25,10 +29,10 @@ rclone will serve the mount and occupy the console so another window should be
 used to work with the mount until rclone is interrupted e.g. by pressing Ctrl-C.
 
 The following examples will mount to an automatically assigned drive,
-to specific drive letter `X:`, to path `C:\path\parent\mount`
+to specific drive letter |X:|, to path |C:\path\parent\mount|
 (where parent directory or drive must exist, and mount must **not** exist,
 and is not supported when [mounting as a network drive](#mounting-modes-on-windows)), and
-the last example will mount as network share `\\cloud\remote` and map it to an
+the last example will mount as network share |\\cloud\remote| and map it to an
 automatically assigned drive:
 
     rclone @ remote:path/to/files *
@@ -85,7 +89,7 @@ as a network drive instead.
 
 When mounting as a fixed disk drive you can either mount to an unused drive letter,
 or to a path representing a **nonexistent** subdirectory of an **existing** parent
-directory or drive. Using the special value `*` will tell rclone to
+directory or drive. Using the special value |*| will tell rclone to
 automatically assign the next available drive letter, starting with Z: and moving backward.
 Examples:
 
@@ -94,45 +98,45 @@ Examples:
     rclone @ remote:path/to/files C:\path\parent\mount
     rclone @ remote:path/to/files X:
 
-Option `--volname` can be used to set a custom volume name for the mounted
+Option |--volname| can be used to set a custom volume name for the mounted
 file system. The default is to use the remote name and path.
 
-To mount as network drive, you can add option `--network-mode`
+To mount as network drive, you can add option |--network-mode|
 to your @ command. Mounting to a directory path is not supported in
 this mode, it is a limitation Windows imposes on junctions, so the remote must always
 be mounted to a drive letter.
 
     rclone @ remote:path/to/files X: --network-mode
 
-A volume name specified with `--volname` will be used to create the network share path.
-A complete UNC path, such as `\\cloud\remote`, optionally with path
-`\\cloud\remote\madeup\path`, will be used as is. Any other
-string will be used as the share part, after a default prefix `\\server\`.
-If no volume name is specified then `\\server\share` will be used.
+A volume name specified with |--volname| will be used to create the network share path.
+A complete UNC path, such as |\\cloud\remote|, optionally with path
+|\\cloud\remote\madeup\path|, will be used as is. Any other
+string will be used as the share part, after a default prefix |\\server\|.
+If no volume name is specified then |\\server\share| will be used.
 You must make sure the volume name is unique when you are mounting more than one drive,
 or else the mount command will fail. The share name will treated as the volume label for
 the mapped drive, shown in Windows Explorer etc, while the complete
-`\\server\share` will be reported as the remote UNC path by
-`net use` etc, just like a normal network drive mapping.
+|\\server\share| will be reported as the remote UNC path by
+|net use| etc, just like a normal network drive mapping.
 
-If you specify a full network share UNC path with `--volname`, this will implicitly
-set the `--network-mode` option, so the following two examples have same result:
+If you specify a full network share UNC path with |--volname|, this will implicitly
+set the |--network-mode| option, so the following two examples have same result:
 
     rclone @ remote:path/to/files X: --network-mode
     rclone @ remote:path/to/files X: --volname \\server\share
 
 You may also specify the network share UNC path as the mountpoint itself. Then rclone
-will automatically assign a drive letter, same as with `*` and use that as
+will automatically assign a drive letter, same as with |*| and use that as
 mountpoint, and instead use the UNC path specified as the volume name, as if it were
-specified with the `--volname` option. This will also implicitly set
-the `--network-mode` option. This means the following two examples have same result:
+specified with the |--volname| option. This will also implicitly set
+the |--network-mode| option. This means the following two examples have same result:
 
     rclone @ remote:path/to/files \\cloud\remote
     rclone @ remote:path/to/files * --volname \\cloud\remote
 
 There is yet another way to enable network mode, and to set the share path,
 and that is to pass the "native" libfuse/WinFsp option directly:
-`--fuse-flag --VolumePrefix=\server\share`. Note that the path
+|--fuse-flag --VolumePrefix=\server\share|. Note that the path
 must be with just a single backslash prefix in this case.
 
 
@@ -153,15 +157,15 @@ representing permissions for the POSIX permission scopes: Owner, group and other
 By default, the owner and group will be taken from the current user, and the built-in
 group "Everyone" will be used to represent others. The user/group can be customized
 with FUSE options "UserName" and "GroupName",
-e.g. `-o UserName=user123 -o GroupName="Authenticated Users"`.
+e.g. |-o UserName=user123 -o GroupName="Authenticated Users"|.
 The permissions on each entry will be set according to [options](#options)
-`--dir-perms` and `--file-perms`, which takes a value in traditional Unix
+|--dir-perms| and |--file-perms|, which takes a value in traditional Unix
 [numeric notation](https://en.wikipedia.org/wiki/File-system_permissions#Numeric_notation).
 
-The default permissions corresponds to `--file-perms 0666 --dir-perms 0777`,
+The default permissions corresponds to |--file-perms 0666 --dir-perms 0777|,
 i.e. read and write permissions to everyone. This means you will not be able
 to start any programs from the mount. To be able to do that you must add
-execute permissions, e.g. `--file-perms 0777 --dir-perms 0777` to add it
+execute permissions, e.g. |--file-perms 0777 --dir-perms 0777| to add it
 to everyone. If the program needs to write files, chances are you will
 have to enable [VFS File Caching](#vfs-file-caching) as well (see also
 [limitations](#limitations)). Note that the default write permission have
@@ -189,12 +193,12 @@ will be added automatically for compatibility with Unix. Some example use
 cases will following.
 
 If you set POSIX permissions for only allowing access to the owner,
-using `--file-perms 0600 --dir-perms 0700`, the user group and the built-in
+using |--file-perms 0600 --dir-perms 0700|, the user group and the built-in
 "Everyone" group will still be given some special permissions, as described
 above. Some programs may then (incorrectly) interpret this as the file being
 accessible by everyone, for example an SSH client may warn about "unprotected
 private key file". You can work around this by specifying
-`-o FileSecurity="D:P(A;;FA;;;OW)"`, which sets file all access (FA) to the
+|-o FileSecurity="D:P(A;;FA;;;OW)"|, which sets file all access (FA) to the
 owner (OW), and nothing else.
 
 When setting write permissions then, except for the owner, this does not
@@ -203,11 +207,11 @@ This may prevent applications from writing to files, giving permission denied
 error instead. To set working write permissions for the built-in "Everyone"
 group, similar to what it gets by default but with the addition of the
 "write extended attributes", you can specify
-`-o FileSecurity="D:P(A;;FRFW;;;WD)"`, which sets file read (FR) and file
+|-o FileSecurity="D:P(A;;FRFW;;;WD)"|, which sets file read (FR) and file
 write (FW) to everyone (WD). If file execute (FX) is also needed, then change
-to `-o FileSecurity="D:P(A;;FRFWFX;;;WD)"`, or set file all access (FA) to
+to |-o FileSecurity="D:P(A;;FRFWFX;;;WD)"|, or set file all access (FA) to
 get full access permissions, including delete, with
-`-o FileSecurity="D:P(A;;FA;;;WD)"`.
+|-o FileSecurity="D:P(A;;FA;;;WD)"|.
 
 #### Windows caveats
 
@@ -231,7 +235,7 @@ It is also possible to make a drive mount available to everyone on the system,
 by running the process creating it as the built-in SYSTEM account.
 There are several ways to do this: One is to use the command-line
 utility [PsExec](https://docs.microsoft.com/en-us/sysinternals/downloads/psexec),
-from Microsoft's Sysinternals suite, which has option `-s` to start
+from Microsoft's Sysinternals suite, which has option |-s| to start
 processes as the SYSTEM account. Another alternative is to run the mount
 command from a Windows Scheduled Task, or a Windows Service, configured
 to run as the SYSTEM account. A third alternative is to use the
@@ -239,7 +243,7 @@ to run as the SYSTEM account. A third alternative is to use the
 Read more in the [install documentation](https://rclone.org/install/).
 Note that when running rclone as another user, it will not use
 the configuration file from your profile unless you tell it to
-with the [`--config`](https://rclone.org/docs/#config-config-file) option.
+with the [|--config|](https://rclone.org/docs/#config-config-file) option.
 Note also that it is now the SYSTEM account that will have the owner
 permissions, and other accounts will have permissions according to the
 group or others scopes. As mentioned above, these will then not get the
@@ -252,17 +256,11 @@ does not suffer from the same limitations.
 
 ### Mounting on macOS
 
-Mounting on macOS can be done either via [built-in NFS server](/commands/rclone_serve_nfs/), [macFUSE](https://osxfuse.github.io/) 
+Mounting on macOS can be done either via [macFUSE](https://osxfuse.github.io/) 
 (also known as osxfuse) or [FUSE-T](https://www.fuse-t.org/). macFUSE is a traditional
 FUSE driver utilizing a macOS kernel extension (kext). FUSE-T is an alternative FUSE system
 which "mounts" via an NFSv4 local server.
 
-## NFS mount
-
-This method spins up an NFS server using [serve nfs](/commands/rclone_serve_nfs/) command and mounts
-it to the specified mountpoint. If you run this in background mode using |--daemon|, you will need to
-send SIGTERM signal to the rclone process using |kill| command to stop the mount.
-
 #### macFUSE Notes
 
 If installing macFUSE using [dmg packages](https://github.com/osxfuse/osxfuse/releases) from
@@ -296,33 +294,31 @@ of the file.
 Rclone includes flags for unicode normalization with macFUSE that should be updated
 for FUSE-T. See [this forum post](https://forum.rclone.org/t/some-unicode-forms-break-mount-on-macos-with-fuse-t/36403)
 and [FUSE-T issue #16](https://github.com/macos-fuse-t/fuse-t/issues/16). The following
-flag should be added to the `rclone mount` command.
+flag should be added to the |rclone mount| command.
 
     -o modules=iconv,from_code=UTF-8,to_code=UTF-8
     
 ##### Read Only mounts
 
-When mounting with `--read-only`, attempts to write to files will fail *silently* as
+When mounting with |--read-only|, attempts to write to files will fail *silently* as
 opposed to with a clear warning as in macFUSE.
 
 ### Limitations
 
-Without the use of `--vfs-cache-mode` this can only write files
+Without the use of |--vfs-cache-mode| this can only write files
 sequentially, it can only seek when reading.  This means that many
 applications won't work with their files on an rclone mount without
-`--vfs-cache-mode writes` or `--vfs-cache-mode full`.
+|--vfs-cache-mode writes| or |--vfs-cache-mode full|.
 See the [VFS File Caching](#vfs-file-caching) section for more info.
-When using NFS mount on macOS, if you don't specify |--vfs-cache-mode|
-the mount point will be read-only.
 
 The bucket-based remotes (e.g. Swift, S3, Google Compute Storage, B2)
 do not support the concept of empty directories, so empty
 directories will have a tendency to disappear once they fall out of
 the directory cache.
 
-When `rclone mount` is invoked on Unix with `--daemon` flag, the main rclone
+When |rclone mount| is invoked on Unix with |--daemon| flag, the main rclone
 program will wait for the background mount to become ready or until the timeout
-specified by the `--daemon-wait` flag. On Linux it can check mount status using
+specified by the |--daemon-wait| flag. On Linux it can check mount status using
 ProcFS so the flag in fact sets **maximum** time to wait, while the real wait
 can be less. On macOS / BSD the time to wait is constant and the check is
 performed only at the end. We advise you to set wait time on macOS reasonably.
@@ -340,10 +336,10 @@ for solutions to make @ more reliable.
 
 ### Attribute caching
 
-You can use the flag `--attr-timeout` to set the time the kernel caches
+You can use the flag |--attr-timeout| to set the time the kernel caches
 the attributes (size, modification time, etc.) for directory entries.
 
-The default is `1s` which caches files just long enough to avoid
+The default is |1s| which caches files just long enough to avoid
 too many callbacks to rclone from the kernel.
 
 In theory 0s should be the correct value for filesystems which can
@@ -354,14 +350,14 @@ few problems such as
 and [excessive time listing directories](https://github.com/rclone/rclone/issues/2095#issuecomment-371141147).
 
 The kernel can cache the info about a file for the time given by
-`--attr-timeout`. You may see corruption if the remote file changes
+|--attr-timeout|. You may see corruption if the remote file changes
 length during this window.  It will show up as either a truncated file
-or a file with garbage on the end.  With `--attr-timeout 1s` this is
-very unlikely but not impossible.  The higher you set `--attr-timeout`
+or a file with garbage on the end.  With |--attr-timeout 1s| this is
+very unlikely but not impossible.  The higher you set |--attr-timeout|
 the more likely it is.  The default setting of "1s" is the lowest
 setting which mitigates the problems above.
 
-If you set it higher (`10s` or `1m` say) then the kernel will call
+If you set it higher (|10s| or |1m| say) then the kernel will call
 back to rclone less often making it more efficient, however there is
 more chance of the corruption issue above.
 
@@ -384,32 +380,32 @@ Units having the rclone @ service specified as a requirement
 will see all files and folders immediately in this mode.
 
 Note that systemd runs mount units without any environment variables including
-`PATH` or `HOME`. This means that tilde (`~`) expansion will not work
-and you should provide `--config` and `--cache-dir` explicitly as absolute
+|PATH| or |HOME|. This means that tilde (|~|) expansion will not work
+and you should provide |--config| and |--cache-dir| explicitly as absolute
 paths via rclone arguments.
-Since mounting requires the `fusermount` program, rclone will use the fallback
-PATH of `/bin:/usr/bin` in this scenario. Please ensure that `fusermount`
+Since mounting requires the |fusermount| program, rclone will use the fallback
+PATH of |/bin:/usr/bin| in this scenario. Please ensure that |fusermount|
 is present on this PATH.
 
 ### Rclone as Unix mount helper
 
-The core Unix program `/bin/mount` normally takes the `-t FSTYPE` argument
-then runs the `/sbin/mount.FSTYPE` helper program passing it mount options
-as `-o key=val,...` or `--opt=...`. Automount (classic or systemd) behaves
+The core Unix program |/bin/mount| normally takes the |-t FSTYPE| argument
+then runs the |/sbin/mount.FSTYPE| helper program passing it mount options
+as |-o key=val,...| or |--opt=...|. Automount (classic or systemd) behaves
 in a similar way.
 
-rclone by default expects GNU-style flags `--key val`. To run it as a mount
-helper you should symlink rclone binary to `/sbin/mount.rclone` and optionally
-`/usr/bin/rclonefs`, e.g. `ln -s /usr/bin/rclone /sbin/mount.rclone`.
+rclone by default expects GNU-style flags |--key val|. To run it as a mount
+helper you should symlink rclone binary to |/sbin/mount.rclone| and optionally
+|/usr/bin/rclonefs|, e.g. |ln -s /usr/bin/rclone /sbin/mount.rclone|.
 rclone will detect it and translate command-line arguments appropriately.
 
 Now you can run classic mounts like this:
-```
+|||
 mount sftp1:subdir /mnt/data -t rclone -o vfs_cache_mode=writes,sftp_key_file=/path/to/pem
-```
+|||
 
 or create systemd mount units:
-```
+|||
 # /etc/systemd/system/mnt-data.mount
 [Unit]
 Description=Mount for /mnt/data
@@ -418,10 +414,10 @@ Type=rclone
 What=sftp1:subdir
 Where=/mnt/data
 Options=rw,_netdev,allow_other,args2env,vfs-cache-mode=writes,config=/etc/rclone.conf,cache-dir=/var/rclone
-```
+|||
 
 optionally accompanied by systemd automount unit
-```
+|||
 # /etc/systemd/system/mnt-data.automount
 [Unit]
 Description=AutoMount for /mnt/data
@@ -430,33 +426,34 @@ Where=/mnt/data
 TimeoutIdleSec=600
 [Install]
 WantedBy=multi-user.target
-```
+|||
 
-or add in `/etc/fstab` a line like
-```
+or add in |/etc/fstab| a line like
+|||
 sftp1:subdir /mnt/data rclone rw,noauto,nofail,_netdev,x-systemd.automount,args2env,vfs_cache_mode=writes,config=/etc/rclone.conf,cache_dir=/var/cache/rclone 0 0
-```
+|||
 
 or use classic Automountd.
-Remember to provide explicit `config=...,cache-dir=...` as a workaround for
-mount units being run without `HOME`.
+Remember to provide explicit |config=...,cache-dir=...| as a workaround for
+mount units being run without |HOME|.
 
-Rclone in the mount helper mode will split `-o` argument(s) by comma, replace `_`
-by `-` and prepend `--` to get the command-line flags. Options containing commas
+Rclone in the mount helper mode will split |-o| argument(s) by comma, replace |_|
+by |-| and prepend |--| to get the command-line flags. Options containing commas
 or spaces can be wrapped in single or double quotes. Any inner quotes inside outer
 quotes of the same type should be doubled.
 
 Mount option syntax includes a few extra options treated specially:
 
-- `env.NAME=VALUE` will set an environment variable for the mount process.
+- |env.NAME=VALUE| will set an environment variable for the mount process.
   This helps with Automountd and Systemd.mount which don't allow setting
   custom environment for mount helpers.
-  Typically you will use `env.HTTPS_PROXY=proxy.host:3128` or `env.HOME=/root`
-- `command=cmount` can be used to run `cmount` or any other rclone command
-  rather than the default `mount`.
-- `args2env` will pass mount options to the mount helper running in background
+  Typically you will use |env.HTTPS_PROXY=proxy.host:3128| or |env.HOME=/root|
+- |command=cmount| can be used to run |cmount| or any other rclone command
+  rather than the default |mount|.
+- |args2env| will pass mount options to the mount helper running in background
   via environment variables instead of command line arguments. This allows to
-  hide secrets from such commands as `ps` or `pgrep`.
-- `vv...` will be transformed into appropriate `--verbose=N`
-- standard mount options like `x-systemd.automount`, `_netdev`, `nosuid` and alike
+  hide secrets from such commands as |ps| or |pgrep|.
+- |vv...| will be transformed into appropriate |--verbose=N|
+- standard mount options like |x-systemd.automount|, |_netdev|, |nosuid| and alike
   are intended only for Automountd and ignored by rclone.
+`

cmd/mountlib/mount.go

@@ -3,7 +3,6 @@ package mountlib
 
 import (
 	"context"
-	_ "embed"
 	"fmt"
 	"log"
 	"os"
@@ -28,9 +27,6 @@ import (
 	"github.com/spf13/pflag"
 )
 
-//go:embed mount.md
-var mountHelp string
-
 // Options for creating the mount
 type Options struct {
 	DebugFUSE          bool
@@ -162,7 +158,7 @@ func NewMountCommand(commandName string, hidden bool, mount MountFn) *cobra.Comm
 		Use:    commandName + " remote:path /path/to/mountpoint",
 		Hidden: hidden,
 		Short:  `Mount the remote as file system on a mountpoint.`,
-		Long:   strings.ReplaceAll(mountHelp, "@", commandName) + vfs.Help,
+		Long:   strings.ReplaceAll(strings.ReplaceAll(mountHelp, "|", "`"), "@", commandName) + vfs.Help,
 		Annotations: map[string]string{
 			"versionIntroduced": "v1.33",
 			"groups":            "Filter",

cmd/ncdu/ncdu.go

@@ -386,12 +386,6 @@ func (u *UI) Draw() {
 		}
 		showEmptyDir := u.hasEmptyDir()
 		dirPos := u.dirPosMap[u.path]
-		// Check to see if a rescan has invalidated the position
-		if dirPos.offset >= len(u.sortPerm) {
-			delete(u.dirPosMap, u.path)
-			dirPos.offset = 0
-			dirPos.entry = 0
-		}
 		for i, j := range u.sortPerm[dirPos.offset:] {
 			entry := u.entries[j]
 			n := i + dirPos.offset

cmd/nfsmount/nfsmount.go

@@ -1,100 +0,0 @@
-//go:build unix
-// +build unix
-
-// Package nfsmount implements mounting functionality using serve nfs command
-//
-// This can potentially work on all unix like systems which can mount NFS.
-package nfsmount
-
-import (
-	"bytes"
-	"context"
-	"fmt"
-	"net"
-	"os/exec"
-	"runtime"
-
-	"github.com/rclone/rclone/cmd/mountlib"
-	"github.com/rclone/rclone/cmd/serve/nfs"
-	"github.com/rclone/rclone/fs"
-	"github.com/rclone/rclone/fs/config/flags"
-	"github.com/rclone/rclone/vfs"
-)
-
-var (
-	sudo = false
-)
-
-func init() {
-	name := "nfsmount"
-	cmd := mountlib.NewMountCommand(name, false, mount)
-	cmd.Annotations["versionIntroduced"] = "v1.65"
-	cmd.Annotations["status"] = "Experimental"
-	mountlib.AddRc(name, mount)
-	cmdFlags := cmd.Flags()
-	flags.BoolVarP(cmdFlags, &sudo, "sudo", "", sudo, "Use sudo to run the mount command as root.", "")
-}
-
-func mount(VFS *vfs.VFS, mountpoint string, opt *mountlib.Options) (asyncerrors <-chan error, unmount func() error, err error) {
-	s, err := nfs.NewServer(context.Background(), VFS, &nfs.Options{})
-	if err != nil {
-		return
-	}
-	errChan := make(chan error, 1)
-	go func() {
-		errChan <- s.Serve()
-	}()
-	// The port is always picked at random after the NFS server has started
-	// we need to query the server for the port number so we can mount it
-	_, port, err := net.SplitHostPort(s.Addr().String())
-	if err != nil {
-		err = fmt.Errorf("cannot find port number in %s", s.Addr().String())
-		return
-	}
-
-	// Options
-	options := []string{
-		"-o", fmt.Sprintf("port=%s", port),
-		"-o", fmt.Sprintf("mountport=%s", port),
-	}
-	for _, option := range opt.ExtraOptions {
-		options = append(options, "-o", option)
-	}
-	options = append(options, opt.ExtraFlags...)
-
-	cmd := []string{}
-	if sudo {
-		cmd = append(cmd, "sudo")
-	}
-	cmd = append(cmd, "mount")
-	cmd = append(cmd, options...)
-	cmd = append(cmd, "localhost:", mountpoint)
-	fs.Debugf(nil, "Running mount command: %q", cmd)
-
-	out, err := exec.Command(cmd[0], cmd[1:]...).CombinedOutput()
-	if err != nil {
-		out = bytes.TrimSpace(out)
-		err = fmt.Errorf("%s: failed to mount NFS volume: %v", out, err)
-		return
-	}
-	asyncerrors = errChan
-	unmount = func() error {
-		var umountErr error
-		var out []byte
-		if runtime.GOOS == "darwin" {
-			out, umountErr = exec.Command("diskutil", "umount", "force", mountpoint).CombinedOutput()
-		} else {
-			out, umountErr = exec.Command("umount", "-f", mountpoint).CombinedOutput()
-		}
-		shutdownErr := s.Shutdown()
-		VFS.Shutdown()
-		if umountErr != nil {
-			out = bytes.TrimSpace(out)
-			return fmt.Errorf("%s: failed to umount the NFS volume %e", out, umountErr)
-		} else if shutdownErr != nil {
-			return fmt.Errorf("failed to shutdown NFS server: %e", shutdownErr)
-		}
-		return nil
-	}
-	return
-}

cmd/nfsmount/nfsmount_test.go

@@ -1,15 +0,0 @@
-//go:build darwin && !cmount
-// +build darwin,!cmount
-
-package nfsmount
-
-import (
-	"testing"
-
-	"github.com/rclone/rclone/vfs/vfscommon"
-	"github.com/rclone/rclone/vfs/vfstest"
-)
-
-func TestMount(t *testing.T) {
-	vfstest.RunTests(t, false, vfscommon.CacheModeMinimal, false, mount)
-}

cmd/nfsmount/nfsmount_unsupported.go

@@ -1,8 +0,0 @@
-// Build for nfsmount for unsupported platforms to stop go complaining
-// about "no buildable Go source files "
-
-//go:build !unix
-// +build !unix
-
-// Package nfsmount implements mount command using NFS.
-package nfsmount

cmd/rc/rc.go

@@ -168,16 +168,6 @@ func setAlternateFlag(flagName string, output *string) {
 	}
 }
 
-// Format an error and create a synthetic server return from it
-func errorf(status int, path string, format string, arg ...any) (out rc.Params, err error) {
-	err = fmt.Errorf(format, arg...)
-	out = make(rc.Params)
-	out["error"] = err.Error()
-	out["path"] = path
-	out["status"] = status
-	return out, err
-}
-
 // do a call from (path, in) to (out, err).
 //
 // if err is set, out may be a valid error return or it may be nil
@@ -186,16 +176,16 @@ func doCall(ctx context.Context, path string, in rc.Params) (out rc.Params, err
 	if loopback {
 		call := rc.Calls.Get(path)
 		if call == nil {
-			return errorf(http.StatusBadRequest, path, "loopback: method %q not found", path)
+			return nil, fmt.Errorf("method %q not found", path)
 		}
 		_, out, err := jobs.NewJob(ctx, call.Fn, in)
 		if err != nil {
-			return errorf(http.StatusInternalServerError, path, "loopback: call failed: %w", err)
+			return nil, fmt.Errorf("loopback call failed: %w", err)
 		}
 		// Reshape (serialize then deserialize) the data so it is in the form expected
 		err = rc.Reshape(&out, out)
 		if err != nil {
-			return errorf(http.StatusInternalServerError, path, "loopback: reshape failed: %w", err)
+			return nil, fmt.Errorf("loopback reshape failed: %w", err)
 		}
 		return out, nil
 	}
@@ -205,12 +195,12 @@ func doCall(ctx context.Context, path string, in rc.Params) (out rc.Params, err
 	url += path
 	data, err := json.Marshal(in)
 	if err != nil {
-		return errorf(http.StatusBadRequest, path, "failed to encode request: %w", err)
+		return nil, fmt.Errorf("failed to encode JSON: %w", err)
 	}
 
 	req, err := http.NewRequestWithContext(ctx, "POST", url, bytes.NewBuffer(data))
 	if err != nil {
-		return errorf(http.StatusInternalServerError, path, "failed to make request: %w", err)
+		return nil, fmt.Errorf("failed to make request: %w", err)
 	}
 
 	req.Header.Set("Content-Type", "application/json")
@@ -220,24 +210,28 @@ func doCall(ctx context.Context, path string, in rc.Params) (out rc.Params, err
 
 	resp, err := client.Do(req)
 	if err != nil {
-		return errorf(http.StatusServiceUnavailable, path, "connection failed: %w", err)
+		return nil, fmt.Errorf("connection failed: %w", err)
 	}
 	defer fs.CheckClose(resp.Body, &err)
 
-	// Read response
-	var body []byte
-	var bodyString string
-	body, err = io.ReadAll(resp.Body)
-	bodyString = strings.TrimSpace(string(body))
-	if err != nil {
-		return errorf(resp.StatusCode, "failed to read rc response: %s: %s", resp.Status, bodyString)
+	if resp.StatusCode != http.StatusOK {
+		var body []byte
+		body, err = io.ReadAll(resp.Body)
+		var bodyString string
+		if err == nil {
+			bodyString = string(body)
+		} else {
+			bodyString = err.Error()
+		}
+		bodyString = strings.TrimSpace(bodyString)
+		return nil, fmt.Errorf("failed to read rc response: %s: %s", resp.Status, bodyString)
 	}
 
 	// Parse output
 	out = make(rc.Params)
-	err = json.NewDecoder(strings.NewReader(bodyString)).Decode(&out)
+	err = json.NewDecoder(resp.Body).Decode(&out)
 	if err != nil {
-		return errorf(resp.StatusCode, path, "failed to decode response: %w: %s", err, bodyString)
+		return nil, fmt.Errorf("failed to decode JSON: %w", err)
 	}
 
 	// Check we got 200 OK

cmd/selfupdate/help.go

@@ -1,47 +1,55 @@
+//go:build !noselfupdate
+// +build !noselfupdate
+
+package selfupdate
+
+// Note: "|" will be replaced by backticks in the help string below
+var selfUpdateHelp = `
 This command downloads the latest release of rclone and replaces the
 currently running binary. The download is verified with a hashsum and
 cryptographically signed signature; see [the release signing
 docs](/release_signing/) for details.
 
-If used without flags (or with implied `--stable` flag), this command
+If used without flags (or with implied |--stable| flag), this command
 will install the latest stable release. However, some issues may be fixed
 (or features added) only in the latest beta release. In such cases you should
-run the command with the `--beta` flag, i.e. `rclone selfupdate --beta`.
+run the command with the |--beta| flag, i.e. |rclone selfupdate --beta|.
 You can check in advance what version would be installed by adding the
-`--check` flag, then repeat the command without it when you are satisfied.
+|--check| flag, then repeat the command without it when you are satisfied.
 
 Sometimes the rclone team may recommend you a concrete beta or stable
 rclone release to troubleshoot your issue or add a bleeding edge feature.
-The `--version VER` flag, if given, will update to the concrete version
-instead of the latest one. If you omit micro version from `VER` (for
-example `1.53`), the latest matching micro version will be used.
+The |--version VER| flag, if given, will update to the concrete version
+instead of the latest one. If you omit micro version from |VER| (for
+example |1.53|), the latest matching micro version will be used.
 
 Upon successful update rclone will print a message that contains a previous
 version number. You will need it if you later decide to revert your update
 for some reason. Then you'll have to note the previous version and run the
-following command: `rclone selfupdate [--beta] OLDVER`.
-If the old version contains only dots and digits (for example `v1.54.0`)
-then it's a stable release so you won't need the `--beta` flag. Beta releases
-have an additional information similar to `v1.54.0-beta.5111.06f1c0c61`.
+following command: |rclone selfupdate [--beta] OLDVER|.
+If the old version contains only dots and digits (for example |v1.54.0|)
+then it's a stable release so you won't need the |--beta| flag. Beta releases
+have an additional information similar to |v1.54.0-beta.5111.06f1c0c61|.
 (if you are a developer and use a locally built rclone, the version number
-will end with `-DEV`, you will have to rebuild it as it obviously can't
+will end with |-DEV|, you will have to rebuild it as it obviously can't
 be distributed).
 
 If you previously installed rclone via a package manager, the package may
 include local documentation or configure services. You may wish to update
-with the flag `--package deb` or `--package rpm` (whichever is correct for
-your OS) to update these too. This command with the default `--package zip`
+with the flag |--package deb| or |--package rpm| (whichever is correct for
+your OS) to update these too. This command with the default |--package zip|
 will update only the rclone executable so the local manual may become
 inaccurate after it.
 
 The [rclone mount](/commands/rclone_mount/) command may
 or may not support extended FUSE options depending on the build and OS.
-`selfupdate` will refuse to update if the capability would be discarded.
+|selfupdate| will refuse to update if the capability would be discarded.
 
 Note: Windows forbids deletion of a currently running executable so this
 command will rename the old executable to 'rclone.old.exe' upon success.
 
 Please note that this command was not available before rclone version 1.55.
-If it fails for you with the message `unknown command "selfupdate"` then
+If it fails for you with the message |unknown command "selfupdate"| then
 you will need to update manually following the install instructions located
 at https://rclone.org/install/
+`

cmd/selfupdate/selfupdate.go

@@ -10,7 +10,6 @@ import (
 	"bytes"
 	"context"
 	"crypto/sha256"
-	_ "embed"
 	"encoding/hex"
 	"errors"
 	"fmt"
@@ -36,9 +35,6 @@ import (
 	versionCmd "github.com/rclone/rclone/cmd/version"
 )
 
-//go:embed selfupdate.md
-var selfUpdateHelp string
-
 // Options contains options for the self-update command
 type Options struct {
 	Check   bool
@@ -67,7 +63,7 @@ var cmdSelfUpdate = &cobra.Command{
 	Use:     "selfupdate",
 	Aliases: []string{"self-update"},
 	Short:   `Update the rclone binary.`,
-	Long:    selfUpdateHelp,
+	Long:    strings.ReplaceAll(selfUpdateHelp, "|", "`"),
 	Annotations: map[string]string{
 		"versionIntroduced": "v1.55",
 	},