bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-05 19:23:19 +00:00
Code Issues Releases Wiki Activity

updated test cases and services using the config service

Browse Source
This commit is contained in:
gbubemismith
2023-09-09 23:22:18 -04:00
parent 88b7511124
commit 520628c99b
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/src/vault/services/fido2/fido2-client.service.spec.ts
View File

@@ -30,7 +30,7 @@ describe("FidoAuthenticatorService", () => {
authenticator = mock<Fido2AuthenticatorService>();
configService = mock<ConfigServiceAbstraction>();
client = new Fido2ClientService(authenticator, configService);
configService.getFeatureFlagBool.mockResolvedValue(true);
configService.getFeatureFlag.mockResolvedValue(true);
});
describe("createCredential", () => {
@@ -197,7 +197,7 @@ describe("FidoAuthenticatorService", () => {
it("should throw FallbackRequestedError if feature flag is not enabled", async () => {
const params = createParams();
configService.getFeatureFlagBool.mockResolvedValue(false);
configService.getFeatureFlag.mockResolvedValue(false);
const result = async () => await client.createCredential(params);
@@ -335,7 +335,7 @@ describe("FidoAuthenticatorService", () => {
it("should throw FallbackRequestedError if feature flag is not enabled", async () => {
const params = createParams();
configService.getFeatureFlagBool.mockResolvedValue(false);
configService.getFeatureFlag.mockResolvedValue(false);
const result = async () => await client.assertCredential(params);

2
libs/common/src/vault/services/fido2/fido2-client.service.ts
View File

@@ -35,7 +35,7 @@ export class Fido2ClientService implements Fido2ClientServiceAbstraction {
) {}
async isFido2FeatureEnabled(): Promise<boolean> {
return await this.configService.getFeatureFlagBool(FeatureFlag.Fido2VaultCredentials);
return await this.configService.getFeatureFlag<boolean>(FeatureFlag.Fido2VaultCredentials);
}
async createCredential(