bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-31 00:33:33 +00:00
Code Issues Releases Wiki Activity

[PM-27086] Update deprecation comments

Browse Source
This commit is contained in:
rr-bw
2026-01-15 13:43:19 -08:00
parent e0967b9b91
commit c27d9897b8
6 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/desktop/src/app/services/set-initial-password/desktop-set-initial-password.service.spec.ts
View File

@@ -82,7 +82,8 @@ describe("DesktopSetInitialPasswordService", () => {
});
/**
* @deprecated To be removed in PM-28143
* @deprecated To be removed in PM-28143. When you remove this, check also if there are any imports/properties
* in the test setup above that are now un-used and can also be removed.
*/
describe("setInitialPassword(...)", () => {
// Mock function parameters

3
apps/web/src/app/auth/core/services/password-management/set-initial-password/web-set-initial-password.service.spec.ts
View File

@@ -86,7 +86,8 @@ describe("WebSetInitialPasswordService", () => {
});
/**
* @deprecated To be removed in PM-28143
* @deprecated To be removed in PM-28143. When you remove this, check also if there are any imports/properties
* in the test setup above that are now un-used and can also be removed.
*/
describe("setInitialPassword(...)", () => {
// Mock function parameters

3
libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.implementation.ts
View File

@@ -50,7 +50,8 @@ export class DefaultSetInitialPasswordService implements SetInitialPasswordServi
) {}
/**
* @deprecated To be removed in PM-28143
* @deprecated To be removed in PM-28143. When you remove this, also check for any objects/methods
* in this default service that are now un-used and can also be removed.
*/
async setInitialPassword(
credentials: SetInitialPasswordCredentials,

3
libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.spec.ts
View File

@@ -102,7 +102,8 @@ describe("DefaultSetInitialPasswordService", () => {
});
/**
* @deprecated To be removed in PM-28143
* @deprecated To be removed in PM-28143. When you remove this, check also if there are any imports/properties
* in the test setup above that are now un-used and can also be removed.
*/
describe("setInitialPassword(...)", () => {
// Mock function parameters

5
libs/auth/src/angular/input-password/input-password.component.ts
View File

@@ -364,6 +364,7 @@ export class InputPasswordComponent implements OnInit {
return;
}
// When you unwind the flag in PM-28143, also remove the ConfigService if it is un-used.
const newApisWithInputPasswordFlagEnabled = await this.configService.getFeatureFlag(
FeatureFlag.PM27086_UpdateAuthenticationApisForInputPassword,
);
@@ -394,6 +395,10 @@ export class InputPasswordComponent implements OnInit {
return passwordInputResult;
}
/*******************************************************************
* The following code (within this `try`) to be removed in PM-28143
*******************************************************************/
// 4. Create cryptographic keys and build a PasswordInputResult object
const newMasterKey = await this.keyService.makeMasterKey(
newPassword,

1
libs/auth/src/angular/input-password/input-password.stories.ts
View File

@@ -60,6 +60,7 @@ export default {
getAllDecrypted: () => Promise.resolve([]),
},
},
// Can remove ConfigService from component and stories in PM-28143 (if it is no longer used)
{
provide: ConfigService,
useValue: {