1
0
mirror of https://github.com/bitwarden/browser synced 2026-01-30 00:03:30 +00:00

[PM-27086] rename flag variable name for clarity

This commit is contained in:
rr-bw
2026-01-13 14:22:22 -08:00
parent e592912711
commit e418a623b5
3 changed files with 11 additions and 8 deletions

View File

@@ -208,11 +208,14 @@ export class SetInitialPasswordComponent implements OnInit {
// }
// KM flag OFF, Auth flag ON
if (passwordInputResult.newApisFlagEnabled && !passwordInputResult.newMasterKey) {
if (
passwordInputResult.newApisWithInputPasswordFlagEnabled &&
!passwordInputResult.newMasterKey
) {
/**
* If the newApisFlag is enabled, it means the InputPasswordComponent will not emit a
* newMasterKey, newServerMasterKeyHash, and newLocalMasterKeyHash. So we must create
* them here and add them late to the PasswordInputResult before calling setInitialPassword().
* If the newApisWithInputPasswordFlagEnabled is enabled, it means the InputPasswordComponent
* will not emit a newMasterKey, newServerMasterKeyHash, and newLocalMasterKeyHash. So we must
* create them here and add them late to the PasswordInputResult before calling setInitialPassword().
*/
const newMasterKey = await this.keyService.makeMasterKey(

View File

@@ -364,18 +364,18 @@ export class InputPasswordComponent implements OnInit {
return;
}
const newApisFlagEnabled = await this.configService.getFeatureFlag(
const newApisWithInputPasswordFlagEnabled = await this.configService.getFeatureFlag(
FeatureFlag.PM27086_UpdateAuthenticationApisForInputPassword,
);
if (newApisFlagEnabled) {
if (newApisWithInputPasswordFlagEnabled) {
// 4. Build a PasswordInputResult object
const passwordInputResult: PasswordInputResult = {
newPassword,
kdfConfig: this.kdfConfig,
salt,
newPasswordHint,
newApisFlagEnabled, // To be removed in PM-28143
newApisWithInputPasswordFlagEnabled, // To be removed in PM-28143
};
if (

View File

@@ -16,7 +16,7 @@ export interface PasswordInputResult {
*
* To be removed in PM-28143
*/
newApisFlagEnabled?: boolean;
newApisWithInputPasswordFlagEnabled?: boolean;
// The deprecated properties below will be removed in PM-28143: https://bitwarden.atlassian.net/browse/PM-28143