bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-28 07:13:29 +00:00
Code Issues Releases Wiki Activity

fix(register): [PM-27085] Account Register Uses New Data Types - Removed unnecessary part of the payload.

Browse Source
This commit is contained in:
Patrick Pimentel
2026-01-22 16:19:53 -05:00
parent 8146473907
commit eadf3ded82
5 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/web/src/app/auth/core/services/registration/web-registration-finish.service.spec.ts
View File

@@ -400,7 +400,6 @@ describe("WebRegistrationFinishService", () => {
expect.objectContaining({
email,
emailVerificationToken: emailVerificationToken,
masterPasswordHash: passwordInputResult.newServerMasterKeyHash,
masterPasswordHint: passwordInputResult.newPasswordHint,
userSymmetricKey: userKeyEncString.encryptedString,
userAsymmetricKeys: {
@@ -420,7 +419,8 @@ describe("WebRegistrationFinishService", () => {
).toBeDefined();
expect((registerCall as RegisterFinishV2Request).masterPasswordUnlock).toBeDefined();
// Verify old API fields are NOT present
// Verify old API fields are NOT present (including masterPasswordHash which is in masterPasswordAuthentication)
expect((registerCall as any).masterPasswordHash).toBeUndefined();
expect((registerCall as any).kdf).toBeUndefined();
expect((registerCall as any).kdfIterations).toBeUndefined();
});

4
libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.spec.ts
View File

@@ -192,7 +192,6 @@ describe("DefaultRegistrationFinishService", () => {
expect.objectContaining({
email,
emailVerificationToken: emailVerificationToken,
masterPasswordHash: passwordInputResult.newServerMasterKeyHash,
masterPasswordHint: passwordInputResult.newPasswordHint,
userSymmetricKey: userKeyEncString.encryptedString,
userAsymmetricKeys: {
@@ -212,7 +211,8 @@ describe("DefaultRegistrationFinishService", () => {
).toBeDefined();
expect((registerCall as RegisterFinishV2Request).masterPasswordUnlock).toBeDefined();
// Verify old API fields are NOT present
// Verify old API fields are NOT present (including masterPasswordHash which is in masterPasswordAuthentication)
expect((registerCall as any).masterPasswordHash).toBeUndefined();
expect((registerCall as any).kdf).toBeUndefined();
expect((registerCall as any).kdfIterations).toBeUndefined();
});

1
libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.ts
View File

@@ -113,7 +113,6 @@ export class DefaultRegistrationFinishService implements RegistrationFinishServi
const registerFinishRequest = new RegisterFinishV2Request(
email,
passwordInputResult.newServerMasterKeyHash,
passwordInputResult.newPasswordHint,
encryptedUserKey,
userAsymmetricKeysRequest,

2
libs/common/src/auth/models/request/registration/register-finish-v2.request.ts
View File

@@ -8,8 +8,6 @@ import { KeysRequest } from "../../../../models/request/keys.request";
export class RegisterFinishV2Request {
constructor(
public email: string,
public masterPasswordHash: string,
public masterPasswordHint: string,
public userSymmetricKey: EncryptedString,

1
libs/common/src/enums/feature-flag.enum.ts
View File

@@ -135,6 +135,7 @@ export const DefaultFeatureFlagValue = {
/* Auth */
[FeatureFlag.PM23801_PrefetchPasswordPrelogin]: FALSE,
[FeatureFlag.PM27044_UpdateRegistrationApis]: FALSE,
/* Billing */
[FeatureFlag.TrialPaymentOptional]: FALSE,