1
0
mirror of https://github.com/bitwarden/browser synced 2026-01-22 04:13:49 +00:00
Commit Graph

20454 Commits

Author SHA1 Message Date
renovate[bot]
5dee97158a [deps] Platform: Lock file maintenance (#14932)
* [deps]: Lock file maintenance

* Pin is-generator-function, downgrade open

* Bump zbus to match zbus_macro

* Attempt to fix rust compile issue by matching zbus and zbus_macro

* Update ashpd ...

* Fix lockfile

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
2026-01-16 15:20:08 +01:00
Tyler
3406a09d6f BRE-1490 fix(build-desktop): validation jobs (#18374)
* BRE-1490 fix(build-desktop): validation jobs

Adds to validation jobs, `run_id: ${{ githut.run_id }}` and/or fixed
checkout ref.
* validate-linux-x64-deb
* validate-linux-x64-appimage
* validate-linux-wayland
* validate-linux-flatpak
* validate-linux-snap
* validate-macos-dmg
* validate-windows-portable

* fix ref spacing
2026-01-16 09:13:12 -05:00
bw-ghapp[bot]
7ee0cfae1a Autosync the updated translations (#18396)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-01-16 15:04:15 +01:00
bw-ghapp[bot]
fc6c386340 Autosync the updated translations (#18397)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-01-16 13:07:29 +01:00
bw-ghapp[bot]
adc3ff9be2 Autosync the updated translations (#18398)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-01-16 12:34:58 +01:00
Bernd Schoolmann
d410706b45 [PM-30846] Fix incorrect log for private key regen in data recovery tool (#18356)
* Fix no log

* Fix prettier
2026-01-16 10:24:57 +01:00
Nick Krantz
7150283d7c [PM-30287] Archive deletion navigation (#18213)
* add `routeAfterDeletion` for edit screen to redirect the user to the correct location after deleting an archived cipher

* use `historyGo` to preserve the back invocations

* fix duplicate import
2026-01-15 21:24:32 +00:00
Mike Amirault
320fe1f1c9 [PM-30382] Make Send search bar full page width (#18386) 2026-01-15 15:12:11 -05:00
Mike Amirault
9f74178928 [PM-21774] Adjust icon and tooltip for protected Sends on the Sends l… (#18293)
* [PM-21774] Adjust icon and tooltip for protected Sends on the Sends list page

* [PM-21774] Update Sent table UI stories

* [PM-21774] Fix Send table UI story
2026-01-15 14:19:43 -05:00
Leslie Tilton
417dfdd305 [PM-30319][PM-30685] Separate and compress phishing data storage (#18337)
* Add logs for debugging in phishing-detection-settings.service

* Update phishing data service to separate web addresses from meta data for performant writes. Store compressed string instead of array

* Cleanup

* Updated test cases

* Cleanup comments

* Fix fallback encoding/decoding mismatch

* Fix type checking
2026-01-15 12:36:03 -06:00
Daniel Riera
21ea969daa [PM-29520] Remove ts strict ignore in background overlay notifications background (#18243)
* initialize timer to null

* default undefined length to 0 using nullish operator

* optional chaining and explicit null check on tab presence

* add optional chainning where relevant for sender tab id

* explicit null checks and data guards set for sender and modifyLoginData

* address feedback and make explicit undefined checks to avoid possible valid tabid rejection

* explicit tab check on setupNotificationInitTrigger
2026-01-15 12:44:23 -05:00
renovate[bot]
8cfd83e426 [deps]: Update actions/checkout action to v6 (#18384)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-15 11:25:32 -06:00
Daniel Riera
535b958f9e [PM-29523] Remove ts strict ignore in browser context menu clicked handler (#18264)
* early return if no cipher before switch case

* explicit null checks within switch cases for early returns

* lower cipher check and add to explicit checks

* add test cases for null values

* format spec file
2026-01-15 12:09:55 -05:00
Nick Krantz
9a22907e27 [PM-30296] Assign to Collections for Archived Ciphers (#18223)
* allow for archived ciphers to be assigned to a collection via the more options menu

* reference `userId$` directly
2026-01-15 11:08:18 -06:00
Jonathan Prusik
2999a57b4a update pull request template (#18385) 2026-01-15 11:32:23 -05:00
Leslie Xiong
44bdaf71b3 Desktop/pm 18769/migrate vault filters (#17919)
Migrated vault filters to new v3 vault's navigation

* Decoupled existing vault filtering from vault component by using routed params with routed-vault-filter-bridge
* Converted vault filters to standalone components
* Removed extending filter Base Components from deprecated /libs/angular library and handled logic directly
* Moved shared 'models' and 'services' directories from web-vault into /libs/vault
2026-01-15 16:17:00 +01:00
neuronull
6ef5241c29 Add Rust pre-commit hooks for desktop native (#17823) 2026-01-15 07:50:47 -07:00
Nick Krantz
d1be3b65f7 show upgrade badge for non-premium users (#18296) 2026-01-15 08:23:52 -06:00
Jordan Aasen
2cec30e533 fix attachment dl icon alignment in web and desktop (#18349) 2026-01-14 17:19:09 -08:00
Jordan Aasen
c91fbb2cad [PM-26515] - Browser - Non Premium User Archived Item Flow (#16908)
* non-premium user flow  archived items

* add archived button

* update archive service

* fix add-edit component

* fix tests

* fix tests

* small fixes

* remove unused service

* fix test

* fix test

* fix test

* fix tests

* only show archived badge when user cannot archive

* update spec

* add test

* revert change to button

* use previouslyCouldArchive

* fix tests

* hide clone button when data ownership policy is enabled

* remove dupe pipe. fix logic

* change from button to span

* fix logic

* fix tests and logic

* fix tests. simplify logic

* updates to archive component

* fix archived pill logic

* fix add missing pop-out

* cleanup

* check if cipher is present in template

* remove enforceDataOwnershipPolicy obs
2026-01-14 14:38:46 -08:00
Mike Amirault
b1b6aa2e75 [PM-30602] Remove unused Send access code from earlier iteration (#18335) 2026-01-14 16:29:34 -05:00
Mike Amirault
952ee02376 [PM-30687] Remove Desktop Send UI refresh feature flag (#18359) 2026-01-14 15:33:07 -05:00
bw-ghapp[bot]
6397b4225a Autosync the updated translations (#18364)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-01-14 18:52:50 +00:00
bw-ghapp[bot]
876c64684b Autosync the updated translations (#18363)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-01-14 19:37:36 +01:00
bw-ghapp[bot]
95bf2a5878 Autosync the updated translations (#18365)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-01-14 18:33:14 +00:00
Bernd Schoolmann
aec049aa84 [PM-30633] Add setLegacyMasterKeyFromUnlockData (#18316)
* Add setMasterKeyFromunlockData

* Rename method

* Add comment

* Add tests

* Fix build

* Fix linting

* Add set local master key hash

* Add tests

* Cleanup

* Move function

* Prettier

* Fix tests

* Eslint

* Fix tests
2026-01-14 12:06:13 -06:00
bw-ghapp[bot]
0a9dc69aa9 Bumped client version(s) (#18362)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
web-v2026.1.0
2026-01-14 17:18:18 +00:00
Isaac Ivins
968260c9f5 [PM-19079] [PM-28168] add edit desktop migration (#18294)
The goal of this PR is to migrate the Desktop Send-v2 component from the AddEditComponent to now use to shared SendAddEditDialogComponent from @bitwarden/send-ui library

---------

Co-authored-by: William Martin <contact@willmartian.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
2026-01-14 10:09:38 -07:00
Vijay Oommen
7fef972f1d PM-29166 updated cards to use dynamic styles (#18340) 2026-01-14 08:16:29 -06:00
Jason Ng
149b3578b4 [PM-30734] hide the trash icon on the new item modal (#18342) 2026-01-13 15:40:39 -05:00
Vijay Oommen
4ea32e7a93 [PM-25228] Remove unknown elements from spec files (#18325) 2026-01-13 14:28:06 -06:00
SmithThe4th
f018ce36a1 Revert "[PM-28455] Fix vault breaking when collection name decryption fails (…" (#18343)
This reverts commit 20974f8195.
2026-01-13 19:38:56 +00:00
Daniel Riera
66819c0689 [PM-29512] Remove ts strict ignore in popup fido 2 cipher row component ts (#18064)
* last is dead code, remove completely

* pass required true so that angular enforces at runtime and run apply a definitive assignment assertion since angulars input binding is running before use
2026-01-13 14:36:52 -05:00
SmithThe4th
20974f8195 [PM-28455] Fix vault breaking when collection name decryption fails (#18331)
* Set error cannot decrypt when collection name cannot be decrypted

* Put back previous comment
2026-01-13 12:38:28 -05:00
olfek
67f6f82842 [PM-30443][FIX] Pass more inclusive user verification Boolean to setAbortTimeout (#15027)
* [FIX] Pass more inclusive user verification Boolean to `setAbortTimeout`

* Update `setAbortTimeout` user verification parameter type

* Fix lint issue

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-01-13 11:01:05 -06:00
Daniel Riera
5ee702093c make types optional to mitigate the design inconsistency (#18072) 2026-01-13 10:14:17 -05:00
renovate[bot]
622df1deaf [deps] Platform: Update electron-store to v11 (#16846)
* [deps] Platform: Update electron-store to v11

* wip-fix: all imports failing due to nodenext switch

* fix: desktop tsconfig not working properly

Renderer tsConfigPath was wrong so it defaulted to the base `tsconfig.json` which
included every single sourcefile into the angular artifact. This caused errors
with ESM modules which behave differently on node and needed a separate `tsconfig.json`
configuration.

* fix: revert some of the changes made to tools code

* fix: ESM import in tests

* chore: use consistent path

* feat: actually use custom tsconfig for preload

* fix: use correct entry point in tsconfig.main.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
2026-01-13 08:04:40 -07:00
Jason Ng
36433642b6 [PM-30705] Show Trash Icon in View Modal (#18329) 2026-01-13 09:51:55 -05:00
Oscar Hinton
5fe01323bb Improve routing during account switching to ensure feature flags are triggered (#18037)
When account switching from the old layout it's not bringing you into the new design. This resolves it by ensuring the route guard for vault is triggered after account switching.
2026-01-13 10:23:29 +00:00
renovate[bot]
bea6fb26f8 [deps] KM: Update Rust crate rsa to v0.9.10 [SECURITY] (#18220)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2026-01-13 10:42:32 +01:00
Bryan Cunningham
067bfa698d [CL-822] fix popover initial position (#18107)
* ensure trigger is fully rendered before placement

* do not skip popover screenshots

* try to stabalize popover screenshots

* try to stabalize popover screenshots

* add play function to remaining stories

* add screenshot diff threshold

* increase diff threshold

* revert story changes

* add comment about double requestAnimationFrame

* empty commit to trigger claude review

* address Claude feedback. Move init and cleanup

* add comment about rafIds are assigned

* add destroyed flag to prevent any potential race conditions

* use different rafIds for explicit cleanup

* check for ref to prevent duplicate creation

* prevent clicks during destroy lifecycle

* add spec for popover trigger directive

* ensure popover closes if clicked during initial delay
2026-01-12 17:04:46 -05:00
Jordan Aasen
89eb547c2d fix vault item dialog new item (#18330) 2026-01-12 11:59:51 -08:00
Isaiah Inuwa
314a5baada Sign Appx in CI (#17975)
Changes the publisher to match the Bitwarden signing certificate, and allows
signing of .appx files.

Also removes unused certificateSubjectName parameters from package.json
2026-01-12 14:19:46 -05:00
bmbitwarden
27d43c500f PM-28183 implemented new sends filter and search design (#17901)
* PM-28183 implemented new sends filter and search design

* PM-28183 resolved table issue fallout from merge conflict

* PM-28183 resolved browser paste url issue

* PM-28183 put new feature behind feature flag

* PM-28183 resolved feature flag

* PM-28183 resolved type-safe approach pr comment

* PM-28183 resolved DesktopSendUIRefresh feature flag is enabled. pr comment

* PM-28183 restored SendUIRefresh

* PM-28183 resolved query parameter subscription pr comment

* PM-28183 resolved pr comment re enum like objects

* PM-28183 resolved remove enum like objects  pr comment

* PM-28183 resolved pr comment re defining filteredSends member variable

* PM-28183 resolved pr comment re Code Duplication in syncCompleted Handler

* PM-28183 resolved pr comment re Floating Promise

* PM-28183 restored feature flag

* PM-28183 resolved pr comment re Dual Binding Pattern

* PM28183 resolved options cell button pr comment

* PM 28183 resolved pr comment re Incorrect CSS Class - Breaking Layout

* PM 28183 resolved pr comment re uery Param Update Causes Redundant Filter Application

* PM-28183 resolved lint issues

* PM 28183 resolved lint issues

* PM-28183 resolved type issue with import

* PM-28183 resolved import in failling test

* chore: rerun web build

* PM-28183 resolved build issues

* PM-28183 resolved build issues

* PM-28183 resolved lint issues
2026-01-12 13:26:50 -05:00
Jordan Aasen
0aac4cae35 allow deleting of failed decrypted cipher (#18279) 2026-01-12 09:05:20 -08:00
Nick Krantz
1ac6d3b2aa add missing translation keys (#18232) 2026-01-12 10:45:35 -06:00
Alex Morask
b1dcf34e9a [PM-29604] [PM-29605] [PM-29606] Premium subscription page redesign (#18300)
* refactor(subscription-card): Correctly name card action

* feat(storage-card): Switch 'callsToActionDisabled' into 1 input per CTA

* refactor(additional-options-card): Switch 'callsToActionDisabled' into 1 input per CTA

* feat(contract-alignment): Remove 'active' property from Discount

* feat(contract-alignment): Rename 'name' to 'translationKey' in Cart model

* feat(response-models): Add DiscountResponse

* feat(response-models): Add StorageResponse

* feat(response-models): Add CartResponse

* feat(response-models): Add BitwardenSubscriptionResponse

* feat(clients): Add new endpoint invocations

* feat(redesign): Add feature flags

* feat(redesign): Add AdjustAccountSubscriptionStorageDialogComponent

* feat(redesign): Add AccountSubscriptionComponent

* feat(redesign): Pivot subscription component on FF

* docs: Note FF removal POIs

* fix(subscription-card): Resolve compilation error in stories

* fix(upgrade-payment.service): Fix failing tests
2026-01-12 10:45:12 -06:00
Stephon Brown
3707a6fc84 billing(fix): add initial focus to upgrade button (#18184) 2026-01-12 10:44:19 -06:00
Nick Krantz
8cda097b3c do not show archive option in bulk menu for collections (#18267) 2026-01-12 10:07:38 -06:00
cyprain-okeke
f2bc147492 Resolve the space issue (#17921) 2026-01-12 16:48:42 +01:00