1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-21 20:04:02 +00:00
Commit Graph

20842 Commits

Author SHA1 Message Date
Isaiah Inuwa
c1eff8bbe9 Optimize allocations for writing u16 ComBuffers 2026-02-20 11:10:06 -06:00
Isaiah Inuwa
ca9ba5ca35 Remove extra allocation when copying to ComBuffer from &[u8] 2026-02-20 11:10:05 -06:00
Isaiah Inuwa
7bfa9a05fe Add Drop implementation for ComBuffer 2026-02-20 11:10:04 -06:00
Isaiah Inuwa
c4bb6283f1 Fix missing #[repr(C)] annotations 2026-02-20 11:10:03 -06:00
Isaiah Inuwa
075a9521f6 Use correct BOOL type instead of bool. 2026-02-20 11:10:02 -06:00
Isaiah Inuwa
fffa343f2f Address feedback 2026-02-20 11:10:01 -06:00
Isaiah Inuwa
e93c9e2542 Remove unused public methods 2026-02-20 11:10:00 -06:00
Isaiah Inuwa
b58912459b Clarify that Windows returns UTF-8 2026-02-20 11:09:59 -06:00
Isaiah Inuwa
beb27951d7 Use standard drop instead of mem::forget during attestation response struct conversion. 2026-02-20 11:09:58 -06:00
Isaiah Inuwa
713110f20a Fix comment typos 2026-02-20 11:09:57 -06:00
Isaiah Inuwa
0aaf399e78 Skip drop impl for VerifyingKey in tests 2026-02-20 11:09:55 -06:00
Isaiah Inuwa
a4f5b07f9a Reorganize unsafe blocks 2026-02-20 11:09:54 -06:00
Isaiah Inuwa
00d56bccf2 Apply lints 2026-02-20 11:09:53 -06:00
Isaiah Inuwa
9702ca8a02 Clarify key blob data structure. 2026-02-20 11:09:52 -06:00
Isaiah Inuwa
351d574247 Allow trailing commas in webauthn fn definition macro 2026-02-20 11:09:50 -06:00
Isaiah Inuwa
d5f3dfc887 Run cargo fmt 2026-02-20 11:09:47 -06:00
Isaiah Inuwa
51e0c41dba Reorganize unsafe blocks 2026-02-20 07:55:39 -06:00
Isaiah Inuwa
110a053df3 Add newtypes for request hash and signature 2026-02-20 07:55:37 -06:00
Isaiah Inuwa
9b237b489d Add test for P-256 2026-02-20 07:55:36 -06:00
Isaiah Inuwa
65dc28147c Add test for P-384 2026-02-20 07:55:35 -06:00
Isaiah Inuwa
0a3ebb2377 Switch from NCrypt to BCrypt API
The initial implementation was based on the Window sample, which uses NCrypt for RSA keys.
However, we were not using NCrypt for key storage (just using ephemeral key handles),
and we needed to specify the curves for the ECDSA algorithms anyway.
Because of that, we did not have any advantage using NCrypt, so this switches to BCrypt
for a slightly simpler API and ECDSA support.
2026-02-20 07:55:34 -06:00
Isaiah Inuwa
b5191032b1 Add SHA-256 and RSA tests 2026-02-20 07:55:32 -06:00
Isaiah Inuwa
75c1485974 Reorganize unsafe code blocks 2026-02-20 07:55:31 -06:00
Isaiah Inuwa
f4efe1fa3c Clarify public key type 2026-02-20 07:55:30 -06:00
Isaiah Inuwa
07b551fd39 Add documentation to webauthn.dll functions 2026-02-20 07:55:29 -06:00
Isaiah Inuwa
eaa955a87b Capture doc comments for webauthn.dll function definitions 2026-02-20 07:55:27 -06:00
Isaiah Inuwa
b8564facab Reduce unsafe scope 2026-02-20 07:55:24 -06:00
Isaiah Inuwa
f8a9b5781c Run cargo sort 2026-02-13 11:22:35 -06:00
Isaiah Inuwa
350df6e355 Remove copied headers and reference in README instead 2026-02-13 11:14:11 -06:00
Isaiah Inuwa
904517f1de Assign platform as owner of ciborium dependency 2026-02-13 11:14:09 -06:00
Isaiah Inuwa
09d71ea4b8 Address review feedback 2026-02-13 11:14:08 -06:00
Isaiah Inuwa
f53d74b4d7 Refactor SHA26 code 2026-02-13 11:14:07 -06:00
Isaiah Inuwa
2578b71489 Satisfy clippy lints with MaybeUninit 2026-02-13 11:14:05 -06:00
Isaiah Inuwa
41377e4f75 Address Clippy lints 2026-02-13 11:14:04 -06:00
Isaiah Inuwa
61fb7c3acd Gate dev-dependencies behind windows OS target 2026-02-13 11:14:03 -06:00
Isaiah Inuwa
c4af075e63 Always check signature 2026-02-13 11:14:02 -06:00
Isaiah Inuwa
30d9707727 Run rustfmt 2026-02-13 11:14:00 -06:00
Isaiah Inuwa
be70a18a2d Document safety for user_information 2026-02-13 11:13:59 -06:00
Isaiah Inuwa
bc4458b88c Remove wrapping Result, return slice directly based on safety constraints 2026-02-13 11:13:58 -06:00
Isaiah Inuwa
8677a8f6bd Complete MakeCredential struct fields 2026-02-13 11:13:56 -06:00
Isaiah Inuwa
ddc2c057ad Add win_webauthn lib 2026-02-13 11:13:54 -06:00
Isaiah Inuwa
ab702e3a1a Don't sync invalid password ciphers to autofill (#18783) 2026-02-13 11:01:42 -06:00
Isaiah Inuwa
fa40de92b1 Remove unneeded workaround to get credential ID from request (#18784) 2026-02-13 11:01:27 -06:00
Jared
b567fea7e7 [PM-29506] Rid of old feature flag for members feature flag (#18884)
* [PM-31750] Refactor members routing and user confirmation logic

* Simplified user confirmation process by removing feature flag checks.
* Updated routing to directly use the new members component without feature flagging.
* Removed deprecated members component references from routing modules.
* Cleaned up feature flag enum by removing unused entries.

* trigger claude

* [PM-31750] Refactor members component and remove deprecated files

* Renamed vNextMembersComponent to MembersComponent for consistency.
* Removed deprecated_members.component.ts and associated HTML files.
* Updated routing and references to use the new MembersComponent.
* Cleaned up related tests to reflect the component name change.

* Refactor import statements in security-tasks.service.ts for improved readability

* Update apps/web/src/app/admin-console/organizations/manage/user-confirm.component.ts

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Remove BaseMembersComponent and related imports from the admin console, streamlining member management functionality.

* Remove unused ConfigService import from UserConfirmComponent to clean up code.

* Implement feature flag logic for user restoration in MemberDialogComponent, allowing conditional restoration based on DefaultUserCollectionRestore flag.

---------

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-02-13 11:38:35 -05:00
Brandon Treston
011f250684 [PM-32075] Fix self host bug due to type mismatch (#18919)
* fix self host bug with data model

* fix type issues

* fix types, make successful required
2026-02-13 10:02:36 -05:00
Daniel James Smith
69264c8841 [PM-32212] Migrate platform font icons to bit-icon (#18970)
* Changes on browser

* Changes on desktop

* Changes on web

* Fix chromatic story

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-13 09:43:42 -05:00
bw-ghapp[bot]
412d1b541d Autosync the updated translations (#18963)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-13 12:11:17 +01:00
bw-ghapp[bot]
7c6512c78f Autosync the updated translations (#18962)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-13 10:27:35 +01:00
bw-ghapp[bot]
c9a125b338 Autosync the updated translations (#18961)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-13 10:24:50 +01:00
Brad
8d3cbd3da6 [PM-31801] Fix: Allow admins/owners to edit all ciphers in reports when Org setting is enabled#18856
This PR fixes an issue where admins couldn't edit ciphers in organization reports when the "Allow Admin Access to All Collection Items" setting was enabled.

The fix adds a check for organization.allowAdminAccessToAllCollectionItems in the canManage() method across all organization report components. When this setting is enabled, admins/owners can now properly edit all ciphers regardless of collection membership.
2026-02-12 13:59:27 -08:00