1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-08 04:33:38 +00:00
Commit Graph

6334 Commits

Author SHA1 Message Date
Jared
f34ccf21d8 Fix highlight in left sidebar menu (#18781) 2026-02-05 12:03:01 -05:00
Jared
5c7bba00f3 [PM-16694] ac integration page background fill missing (#18508)
* Fixing some tech debt before implementing actual fix of implementation

* Adding new components to handle the different routes for the integrations page to make use of bit-tab-nav-bar to follow background-fill UI spec

* Implement organization integrations page with routing and state management

- Added routing for organization integrations including device management, event management, single sign-on, and user provisioning.
- Created OrganizationIntegrationsState to manage integrations and organization data.
- Introduced OrganizationIntegrationsResolver for preloading organization and integration data.
- Updated components to utilize the new state management and resolver.
- Refactored integration routes to follow updated naming conventions.

* Refactor organization integrations components to use signals and observables; enhance async handling in templates and add debug logging

* Enhance organization integrations module with routing updates and state management improvements

- Added OrganizationIntegrationsState for better state management.
- Updated routing to redirect to single sign-on by default.
- Integrated OrganizationIntegrationsResolver for preloading data.
- Refactored components to utilize new state management and improved async handling.

* Refactor SingleSignOnComponent to remove OnInit lifecycle and debug logging

- Simplified SingleSignOnComponent by removing the OnInit implementation.
- Eliminated debug logging for integrations in ngOnInit.
- Cleaned up imports for better readability.

* Refactor WebHeaderComponent to simplify background handling

- Removed the useAltBackground input signal from WebHeaderComponent.
- Updated the HTML template to conditionally apply styles based solely on the child element count of the tabs container.

* Refactor organization integrations components for improved readability and performance

- Updated HTML templates to remove optional chaining for organization properties.
- Removed unnecessary debug logging and comments in the OrganizationIntegrationsResolver.
- Simplified DeviceManagementComponent by eliminating the OnInit lifecycle hook.

* Refactor organization integrations components to use direct state properties

- Updated components to access organization and integrations directly from state instead of using observables.
- Simplified HTML templates by removing async pipes and using direct function calls for better readability.
- Ensured consistent naming conventions for organization and integrations variables across components.

* Enhance WebHeaderComponent by adding bitTypography attribute to the title element for improved styling consistency

* Refactor organization state to use 'undefined' instead of 'null' for organization signal and remove OnInit lifecycle hook from UserProvisioningComponent for cleaner code.

* Refactor EventManagementComponent to remove OnInit lifecycle hook for cleaner code and improved readability.

* Update organization state to set organization value to 'undefined' when null is provided, enhancing state management consistency.

* Update WebHeaderComponent to allow optional title and icon inputs, enhancing flexibility in header configuration.

* Update WebHeaderComponent to allow account property to be nullable, improving type safety and handling of user data.
2026-02-05 10:58:42 -05:00
John Harrington
d88cb89618 PM-23851 False requirement to pop out extension when using send files (#17950)
* follow existing popout guard pattern to force popout on firefox when filepicker is exposed

* move firefox guard to tools ownership & revert changes to auth owned file

* initial refactor to consolidate logic  using file-picker-popout.guard

* remove safari from guard & disable forced popout in vault import

* enforce popout on Safari with test coverage

* use userAgent and consistent detection for platform detection

* refactor guard tests involving routes

* replace imports lost during merge

* remove text sends from popout requirement and update tests

* add tooltip and screen-reader text describing popout behavior
2026-02-05 08:41:03 -07:00
Jared
479273a883 Fix optional chaining for collectionId in vault navigation query parameters (#18652) 2026-02-05 10:39:33 -05:00
Jared
2d8f74bf70 Disable native icon for datetime-local field and use our own icons for stylizing (#18633) 2026-02-05 10:37:35 -05:00
Jared
35773ae9a0 [PM-29771] Make invitation non-plural if only 1 member selected (#18684)
* Make invitation non-plural if only 1 member selected

* Add isSingleInvite as per Jimmy's suggestion
2026-02-05 10:36:44 -05:00
Jared
61763204ea Update bulk restore/revoke component to conditionally display non-compliant members callout. Adjusted logic to set statuses based on entry errors and isRevoking state. (#18654) 2026-02-05 10:35:39 -05:00
adudek-bw
7c6d98b50e Remove feature flag check from password generation (#18003)
* Remove feature flag check from password generation
2026-02-05 09:46:31 -05:00
neuronull
34108d93e4 SSH Agent v2: Add ssh key primitive types (#18583)
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2026-02-04 14:01:18 -07:00
renovate[bot]
afc46cc50a [deps] Vault: Update @koa/router to v15 (#18086)
* [deps] Vault: Update @koa/router to v15

* update router imports from `@koa/router`

* remove `@types/koa__router` no longer needed with update to `@koa/router`

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
Co-authored-by: Nick Krantz <nick@livefront.com>
2026-02-04 14:40:50 -06:00
Jackson Engstrom
a686ea1640 [PM-26706] Update search results header for extension (#18676)
* dynamically changes the allItems title from 'All items' to 'Search results' based on search text length

* updates logic and copy for changing the allItems header text

* changes how ciphers are displayed when a user has a search term and/or filters applied

* Update apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html

Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>

* refactors tests

---------

Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
2026-02-04 11:21:20 -08:00
Bryan Cunningham
a07c9ebf6b [CL-637] icon api buttons links (#18388)
* update button api to accept icons

* use template outlet in button

* add link component

* create link component to handle anchors and buttons

* remove unnecessary let variables

* fix link focus state styling

* update link underline style

* fix broken skip link focus

* add focus method to link component

* fix typo

* fix off center loading state

* move flex styles to template to fix some minor style overrides

* remove unnecessary variables

* fix interaction states and add styles for test class to work properly

* refactor classes and make variable sreadonly

* fix classes not being applied correctly

* fix bad merge conflict resolution

* simplified button template
2026-02-04 14:20:44 -05:00
renovate[bot]
2b06f6ace3 [deps] AC: Update core-js to v3.48.0 (#18709)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jared <TheWolfBadger@gmail.com>
2026-02-04 17:34:20 +00:00
Jordan Aasen
2876ef15ae [PM-31606] - Clone should not be an option for archived item for non-premium user (#18726)
* do not allow cloning of archived items for non-premium users

* add tests
2026-02-04 09:31:23 -08:00
Vijay Oommen
a2916084ee [PM-30547] Table empty state message (#18752) 2026-02-04 10:42:13 -06:00
Jackson Engstrom
9fc52cb46e [PM-21607] Adds bwi-plus-circle and bwi-minus-circle to Link SSO and Unlink SSO menu buttons (#18328)
* adds bwi-plus-circle and bwi-minus-circle to Link SSO and Unlink SSO menu buttons

* fixes spacing for Leave organization option

---------

Co-authored-by: capenapplebw <capple@bitwarden.com>
2026-02-04 08:19:06 -08:00
Jonathan Prusik
b044427f41 [PM-31281] Add teardown of listeners/observers (#18593)
* add teardown of listeners/observers

* add tests
2026-02-04 11:12:25 -05:00
Jason Ng
febb64605a [PM-31400] skip MP reprompt when archive/unarchive in footer (#18678) 2026-02-04 10:31:02 -05:00
Vicki League
97c65b3c72 [PM-31384] Prevent dialog header from stealing focus from autofocus inputs (#18657) 2026-02-04 10:26:38 -05:00
Oscar Hinton
c3d0a2d858 Add a way to add folders in the desktop ui migration milestone 1 (#18632) 2026-02-04 10:03:43 -05:00
neuronull
e5c9f9398d Enhancements to EncryptedMemoryStore (#18484) 2026-02-03 15:04:18 -07:00
Jason Ng
f3686c657b [PM-31476] Desktop Archive Empty State Vault-V3 (#18695)
* add empty state for archive desktop
2026-02-03 15:29:11 -05:00
Mike Amirault
51a99fecd8 [PM-31429] Add missing helper text for password protected Sends, remove unused one (#18694)
* [PM-31429] Add missing helper text for password protected Sends, remove unused one

* Put one UI change behind feature flag, add back required translations

* Reorder translation

* Add spaces

* Come full circle, remove last couple of committed changes
2026-02-03 15:18:23 -05:00
Daniel Riera
557d417ed1 - Clear pending auth requests for both HTTP and HTTPS (#18661)
- Add null-safe checks before returning auth credentials
- Align callback typing and optional arguments
2026-02-03 14:10:05 -06:00
Jason Ng
50063c7f71 [PM-31477] Align Desktop V3 with Archive Premium Banner (#18696)
* adding showPremiumCallout to vault-v3 for non premium banner
2026-02-03 14:21:40 -05:00
rr-bw
489308fd75 refactor(input-password-flows): [Auth/PM-27086] Use new KM Data Types in InputPasswordComponent flows - Emergency Access (#18425)
Update the Emergency Access Takeover flow to use new KM data types from `master-password.types.ts` / `MasterPasswordService`:
- `MasterPasswordAuthenticationData`
- `MasterPasswordUnlockData`

This allows us to move away from the deprecated `makeMasterKey()` method (which takes email as salt) as we seek to eventually separate the email from the salt.

Changes are behind feature flag: `pm-27086-update-authentication-apis-for-input-password`
2026-02-03 10:41:25 -08:00
Stephon Brown
38465c059c [PM-29602] Update Cart Summary for Upgrade Flow (#18605)
* feat(billing): update cart-summary logic

 Add functionality to hide breakdown and allow translation params

* tests(cart-summary): update tests and stories

* feat(pricing): Add quantity support to discount labels

* feat(pricing): discount quantity story

* Revert "feat(pricing): discount quantity story"

This reverts commit 2c00891f1f.

* Revert "feat(pricing): Add quantity support to discount labels"

This reverts commit 8350fdd90f.

* fix(cart-summary): Adjust discount text styling

* feat(pricing): adds support for hidden discount amounts

Allows hiding the formatted amount for discounts in the cart summary.

This is useful for scenarios where the discount amount is displayed
elsewhere or is not relevant to the user.

Updates the storybook to include a story demonstrating this feature.

* feat(pricing): conditionally format currency amounts to show or hide decimals

* Revert "feat(pricing): adds support for hidden discount amounts"

This reverts commit 076724276c.

* Revert "fix(cart-summary): Adjust discount text styling"

This reverts commit d02c12fc2a.

* Revert "discount translation"

* feat(pricing): add credit type to cart summary

* feat(pricing-card): Add i18n and icon component infrastructure

* feat(pricing-card): Apply i18n pipe to pricing card template

* refactor(pricing-card): Replace `<i>` tags with `<bit-icon>` in template

* test(pricing-card): Update tests for i18n and icon component changes

* docs(pricing-card): Enhance Storybook and documentation for new features

* feat(pricing-card): Adds "per user" translation key

* refactor(pricing-card): use property binding for bit-icon name

* docs(pricing-card): expand price cadence options in MDX

* fix(icon): update exports for icon types

* feat(billing): Use strongly typed BitwardenIcon for pricing card buttons

* refactor(pricing): Remove unused I18nService from PricingCardComponent

* fix(pricing): Improve pricing card button icon template null-safety

* fix(pricing-card): format update

Clarifies the description of the `price` property within the PricingCard component documentation.

No functional code changes are included.

* refactor: Update discount label typography in cart summary

* refactor(stories): Rename account credit translation key to premium subscription credit

* feat(pricing-card): update spacing for card without button
2026-02-03 17:47:58 +00:00
neuronull
11e6b434e3 Fix bytes crate vuln RUSTSEC-2026-0007 (#18737) 2026-02-03 09:59:55 -07:00
Mike Amirault
1e0b64a55b [PM-31430] Add specific messages for creating password and email protected Sends (#18692)
* [PM-31430] Add specific messages for creating password and email protected Sends

* [PM-31430] Fix tests, one bug in Send success drawer component
2026-02-03 11:15:46 -05:00
Stephon Brown
86907d68c2 [PM-29600] Rename Tax Client and Add Endpoints for Upgrade and Proration (#18462)
* BREAKING CHANGE: rename tax-client and add proration endpoint

update

* fix(billing)!: rename tax-client in components

* feat(billing): Add upgrade endpoint

* fix(billing): update preview client error

* fix(billing): add billing address to clients

* fix(billing): add additional prorated amount of months

* fix(billing): update client call parameter

* feat(billing): Enhance ProrationPreviewResponse with new plan details
2026-02-03 11:11:00 -05:00
Jonathan Prusik
fe0d7df538 when only password and new password fields have values and do not match any vault ciphers, trigger a new cipher notification (#18729) 2026-02-03 11:05:02 -05:00
tbmc
8fb84a4670 Fix layout of download Bitwarden link in settings popup (#18309)
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
2026-02-03 09:01:10 -07:00
Jared
3333e5696d Update collection dialog to conditionally display "view" or "edit" title based on dialog state; add "viewCollection" translation to messages.json (#18724) 2026-02-03 10:19:30 -05:00
Daniel James Smith
c595767688 [PM-29239] Create proxy cookie redirect connector (#18476)
* Create a subfolder for platform-owned connectors and ensure it's included in the web builds

* Add platform as codeowner of apps/web/src/connectors/platform

* Create proxy-cookie-redirect connector

* Create section within CODEOWNERS for Web connectors

* Swap order of codeowners

* Use kebap-style route

* Update url to redirect to

* Add override to test locally

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-03 07:08:44 -05:00
Jackson Engstrom
4141b864da [PM-24187] Improve labeling of owner filter in vault table 2026-02-02 16:18:30 -08:00
Jason Ng
971f264c39 [PM-31387] Desktop Footer update archive/trash btn values (#18640)
* update footer component when action changes for desktop
2026-02-02 18:43:46 -05:00
Andy Pixley
9db65f8895 [BRE-1531] Adding ability to build web with custom SDK branch (#18677) 2026-02-02 17:13:56 -05:00
Jordan Aasen
50b8dde031 [PM-31240[ - [Defect] Toast message archiving an item in Edit/View item modal is in plural form (#18578)
* fix archive toast

* fix bulk share in vault

* Revert "fix bulk share in vault"

This reverts commit dfb309c8c5.
2026-02-02 13:23:13 -08:00
Jordan Aasen
a048827c0e don't allow unarchiving in AC (#18637) 2026-02-02 13:21:18 -08:00
Alex
8ceb28f2b9 default weakness sort to descending order (PM-31164) (#18719) 2026-02-02 15:49:11 -05:00
Jonathan Prusik
5a397fb44e [PM-29236] Refactor of post-submit notification triggering logic (#18395)
* refactor triggerChangedPasswordNotification logic

* improve triggerChangedPasswordNotification and test coverage to handle scenarios more comprehensively

* restore triggerChangedPasswordNotification logic and move new logic and testing to triggerCipherNotification

* add branching qualification logic for cipher notifications

* add and implement undetermined-cipher-scenario-logic feature flag

* add optional chaining to username comparison of existing login ciphers

* cleanup

* update tests

* prefer explicit length comparisons
2026-02-02 15:01:24 -05:00
Jackson Engstrom
47edae1c21 [PM 21939] Use family icon for free and family orgs
* adds check for a free/family org and updates the icon
2026-02-02 11:56:53 -08:00
Isaiah Inuwa
fd90efabe4 Split NAPI modules [PM-31598] (#18722) 2026-02-02 14:13:17 -05:00
Jordan Aasen
5d17d9ee71 Revert "[PM-26703]- Browser - Update autofill Behavior (#18467)" (#18723)
This reverts commit 7b583aa0ec.
2026-02-02 09:37:02 -08:00
rr-bw
27c6aa8121 refactor(input-password-flows): [Auth/PM-27086] Use new KM Data Types in InputPasswordComponent flows - Account Recovery (#18423)
Update Account Recovery flow to use new KM data types from `master-password.types.ts` / `MasterPasswordService`:
- `MasterPasswordAuthenticationData`
- `MasterPasswordUnlockData`

This allows us to move away from the deprecated `makeMasterKey()` method (which takes email as salt) as we seek to eventually separate the email from the salt.

Changes are behind feature flag: `pm-27086-update-authentication-apis-for-input-password`
2026-02-02 09:06:04 -08:00
Vijay Oommen
2c30fb72ba [PM-30544] Added Critical app badge to Access Intelligence (#18658) 2026-02-02 10:05:02 -06:00
Bernd Schoolmann
590bec2166 Fix rsa signing and add unit tests (#18702)
* Fix rsa signing and add unit tests

* Fix sorting

* Fix sorting
2026-02-02 14:35:49 +01:00
Bernd Schoolmann
b5c3735808 Revert "[deps] KM: Update Rust crate rsa to v0.9.10 [SECURITY] (#18220)" (#18693)
This reverts commit bea6fb26f8.
2026-02-01 16:06:10 +01:00
rr-bw
1f0e0ca098 refactor(input-password-flows): [Auth/PM-27086] JIT MP org user flow - remove masterKey generation from InputPasswordComponent (#18006)
- Updates `InputPasswordComponent` to emit raw data instead of generating cryptographic properties (`newMasterKey`, `newServerMasterKeyHash`, `newLocalMasterKeyHash`).
  - This helps us in moving away from using the deprecated `makeMasterKey()` method in the component (which takes email as salt) as we seek to eventually separate the email from the salt.
- Updates the `JIT_PROVISIONED_MP_ORG_USER` case of the switch to handle the flow when the `PM27086_UpdateAuthenticationApisForInputPassword` flag is on.

Feature Flag: `PM27086_UpdateAuthenticationApisForInputPassword`
2026-01-30 15:11:59 -08:00
Ike
4a45414f4a [PM-30563] Improve Send Access enumeration protection (#18620)
* feat: sync changes with SDK and server

* Update libs/common/src/auth/send-access/types/invalid-request-errors.type.ts

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* feat: sync changes with SDK and Server projects
sync: sdk version

* chore: update sdk

* chore: update sdk

* chore: prettier

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-01-30 17:16:32 -05:00