1
0
mirror of https://github.com/bitwarden/jslib synced 2025-12-06 00:03:29 +00:00
Commit Graph

1597 Commits

Author SHA1 Message Date
addison
ffdd9507ff [bug] Null check lists when changing the vault filter
Sometimes when changing an organization fault filter the system can end up in a postion where the filter modifier selected isn't valid for the newly selected organization.
The clearest example of this are collections, since changing any org filter with a collection already selected will make that collection selection invalid.

Because of this, when an organization filter is selected we check to make sure modifiers are still valid. If they aren't we clear them.
This isn't working if a list is checked and this list is null. An error throws and the filter doesn't change. This commit adds a null check to keep things moving.
2022-04-14 12:41:43 -04:00
addison
e021b2817f Merge branch 'feature/endUserVaultRefresh' into endUserVaultRefresh/organizationFilters 2022-04-11 14:57:55 -04:00
addison
9df0f8758c [refactor] Move DisplayMode to a dedicated file 2022-04-07 16:32:01 -05:00
addison
8e01081de2 [refactor] Dont directly change activeFilter in VaultFilterComponent 2022-03-31 11:59:52 -04:00
addison
629542b90c [bug] Add missing events for folder add/edit 2022-03-24 14:18:55 -04:00
addison
1dc9e5ff9a [refactor] Break down vault filter into several components
These changes rename and rewrite the GroupingsComponent into a VaultFiltersModule. The module follows typical angular patterns for structure and purpose, and contain components for each filter type. The mostly communicate via Input and Output, and depend on a VaultFilterService for sending and recieving data from other parts of the product.
2022-03-24 13:03:57 -04:00
addison
93b5a155bd [feature] Add organization filters
This is an MVP implementation of the changes needed for the vault refresh. This includes collapsable top level groupings, and organization based filters that dynamically adjust folders and collections.
2022-03-24 13:03:00 -04:00
addison
574cf8e7ee [refactor] Add optional folders param to folderService.getAllNested()
This will be used later for use cases where the vault filters service needs to build a list of nested folders that have been filtered by organization
2022-03-24 13:02:06 -04:00
Robyn MacCallum
e17ada83fb Add ellipsis pipe (#728)
* add ellipsis pipe

* run prettier

* Account for ellipsis length in returned string

* Fix complete words case

* Fix another complete words issue

* fix for if there are not spaces in long value

* extract length check to beginning of method

* condense if statements

* remove log
2022-03-24 12:59:37 -04:00
Thomas Rittson
83a8c366ef [JslibModule] Add JslibModule (#733) 2022-03-24 12:59:37 -04:00
Matt Gibson
57cd329186 Remove error Response type check (#731)
* Remove error Response type check

Minimization is impacting type checking in a non-consistent way.
The previous type check works locally,
but not from build artifacts 🤷. We only set `captchaRequired` on
our errors when we want a resubmit with captcha included, so we're safe
keying off that

* linter
2022-03-24 12:59:37 -04:00
Chad Scharf
4061c19c98 Update SECURITY.md (#725)
* Update SECURITY.md

Add link to our HackerOne program for submitting potential security issues.

* Revise language on SECURITY.md
2022-03-24 12:59:37 -04:00
Oscar Hinton
707064ffea Add Chromatic (#719) 2022-03-24 12:59:37 -04:00
Matt Gibson
3f0551e4f8 Check runtime name vs mangled name (#724) 2022-03-24 12:59:37 -04:00
Oscar Hinton
bb51485fbb Tweak component library slightly (#715) 2022-03-24 12:59:36 -04:00
Thomas Rittson
e32a772d77 Avoid duplicate fullSync api calls (#716) 2022-03-24 12:59:36 -04:00
addison
a3a88d4b8f [dependency] Update icons 2022-03-24 12:48:08 -04:00
Thomas Rittson
65efc948ad Merge branch 'master' into Feature/EndUserVaultRefresh 2022-03-22 08:33:23 +10:00
Robyn MacCallum
5409525ea2 Add ellipsis pipe (#728)
* add ellipsis pipe

* run prettier

* Account for ellipsis length in returned string

* Fix complete words case

* Fix another complete words issue

* fix for if there are not spaces in long value

* extract length check to beginning of method

* condense if statements

* remove log
2022-03-21 15:46:54 -04:00
Thomas Rittson
eafe87646a [EndUserVaultRefresh] Add base routing guard (#732)
* Add a base class for Angular routing guards

* Update Guard naming convention
2022-03-21 20:39:12 +10:00
Thomas Rittson
9950fb42a1 [JslibModule] Add JslibModule (#733) 2022-03-21 19:32:55 +10:00
Thomas Rittson
6dc1d65abc [End User Vault Refresh] Refactor route permission checking (#727)
* Update admin access logic

* Centralize route permission handling

* Add permission check for disabled orgs
2022-03-18 17:28:37 +10:00
Matt Gibson
f88515745c Remove error Response type check (#731)
* Remove error Response type check

Minimization is impacting type checking in a non-consistent way.
The previous type check works locally,
but not from build artifacts 🤷. We only set `captchaRequired` on
our errors when we want a resubmit with captcha included, so we're safe
keying off that

* linter
2022-03-18 12:24:22 +10:00
Chad Scharf
e2d95741b0 Update SECURITY.md (#725)
* Update SECURITY.md

Add link to our HackerOne program for submitting potential security issues.

* Revise language on SECURITY.md
2022-03-15 15:55:55 -04:00
Oscar Hinton
15ad2ca3ea Add Chromatic (#719) 2022-03-15 13:50:42 +01:00
Matt Gibson
3ec0f6977a Check runtime name vs mangled name (#724) 2022-03-14 20:12:31 -05:00
Oscar Hinton
41b199ab83 Tweak component library slightly (#715) 2022-03-11 21:00:24 +01:00
Thomas Rittson
3f20122e5b Avoid duplicate fullSync api calls (#716) 2022-03-11 07:16:50 +10:00
Addison Beck
284cd196ab [feature] Allow for top level groupings to be collapsed (#712) 2022-03-09 09:14:12 -05:00
Thomas Rittson
601e0a4956 Merge branch 'master' into Feature/EndUserVaultRefresh 2022-03-09 12:57:10 +10:00
Thomas Rittson
23bdc0b410 Move access logic to org model (#713) 2022-03-09 12:50:55 +10:00
Oscar Hinton
f7375e9064 Add premium and unless-premium directives (#710) 2022-03-08 15:21:49 +01:00
Daniel James Smith
744649573a Fixes for format change of 1pux files (#714)
* Remove unneeded ItemCollection type

* Mark item.trashed as optional property

* Adjust format of test files to be identical to current exports
2022-03-08 13:42:35 +01:00
Oscar Hinton
67a4fc8591 Component Library scaffolding (#625) 2022-03-08 11:50:34 +01:00
Daniel James Smith
fa3a95fed0 Fixes and improvements to MykiCsvImporter (#707)
* Add test suite for existing importer

* Fix 2fa-seed not copied on login records

* Fix secure note title not being set

* Add support for importing 2FA file

* Fixed casing on import of MykiCsvImporter

* Import all unmapped fields as customFields

* WIP: Add import of UserIdCard

* Add support for IdCards
2022-03-07 17:20:50 -05:00
Daniel James Smith
18b954614c Remove Dashlane json importer from the featured list (#711) 2022-03-08 08:11:23 +10:00
Daniel James Smith
6e345bc4cc Dashlane Csv-Importer (#708)
* Move existing dashlane importer into dashlaneImporters

* Add testData for Dashlane CSV importer

* Add dashlane Csv importer and unit tests

* Fixed linting issues

* Moved dashlaneCsv types to own file

* Register DashlaneCsv importer

* Removed temp private method and use base impl

* rename spec imports

* Move scope of mapped columns

* Migrate folders into collection if imported via org
2022-03-07 19:21:23 +01:00
Addison Beck
6aae3beb76 [bug] Set proper default for autoConfirmFingerprint (#704) 2022-03-03 19:57:50 +01:00
Addison Beck
4d94f7a631 [bug] Delete stored keys if the value is null (#705) 2022-03-03 19:57:08 +01:00
Oscar Hinton
813457c348 Expose logger in lock component (#703) 2022-03-03 17:19:52 +01:00
Daniel James Smith
8e112a1c33 Add importer for 1Password's new export format (.1pux) (#594)
* Initial commit

* Refactor the 1pux types

* Add test data

* 1Pux importer and tests

* Fixed a typo in the 1Pux types

* Make the linter happy

* Register and instantiate importer

* Fix adding secure notes

* Add missing placeholder property to types

* Test for existance of TOTP seed

* Add more test data

* Move processFullName into BaseImporter

* Add categoryEnum for easier mapping

* Refactoring of the importer and add support for different item types

* Make linter happy

* Modified some test data

* Fix linting issues

* Remove fieldvalue references comment

* Remove commented mapping use during tests
2022-03-03 15:22:05 +01:00
Vincent Salucci
48a4c27fe7 [Captcha] Failed login attempts (#698)
* [Captcha] Failed login attempts

* Fix logIn.strategy test

* Updated with the stark majority of requested changes

* Fix typo

* Unused import
2022-03-02 19:47:57 -06:00
Thomas Rittson
adfc2f234d Remove unused SSO Form code (#701)
* Remove unused SAML Artifact Binding properties

* Remove unused validators
2022-03-03 07:52:11 +10:00
Robyn MacCallum
8f5f694a1e Roll back organizationId and collectionId's if ciphers fail to be moved (#699) 2022-03-02 08:11:34 -05:00
Thomas Rittson
e47eb5e74f Fix linting (#700) 2022-03-01 23:11:12 +01:00
Thomas Rittson
c1a37eab13 Fix storage keys in v1 migration (#696) 2022-03-02 07:44:14 +10:00
Thomas Rittson
d81eb7ddae Improve SSO Config validation (#572)
* Extract SsoConfig enums to own file

* Add ChangeStripSpaces directive

* Move custom validators to jslib

* Add a11y-invalid directive

* Add and implement dirtyValidators

* Create ssoConfigView model and factory methods

* Add interface for select options

* Don't build SsoConfigData if null

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-03-02 07:31:00 +10:00
Thomas Rittson
d919346517 Fix autoFillOnPageLoadDefault default value (#697) 2022-03-01 13:13:19 +10:00
Daniel James Smith
a69135ce06 Add missing localeNames (#695) 2022-02-25 18:54:27 +01:00
Addison Beck
65219f5705 [bug] Store collapsedGroupings in accountSettings (#694) 2022-02-25 13:03:13 +01:00