mirror of
https://github.com/bitwarden/jslib
synced 2025-12-06 00:03:29 +00:00
ffdd9507ff
Sometimes when changing an organization fault filter the system can end up in a postion where the filter modifier selected isn't valid for the newly selected organization. The clearest example of this are collections, since changing any org filter with a collection already selected will make that collection selection invalid. Because of this, when an organization filter is selected we check to make sure modifiers are still valid. If they aren't we clear them. This isn't working if a list is checked and this list is null. An error throws and the filter doesn't change. This commit adds a null check to keep things moving.
Bitwarden JavaScript Library
Common code referenced across Bitwarden JavaScript projects.
Requirements
- Node.js v16.13.1 or greater
- NPM v8
- Git
- node-gyp
Windows
- Microsoft Build Tools 2015 in Visual Studio Installer
- Windows 10 SDK 17134 either by downloading it seperately or through the Visual Studio Installer.
We're Hiring!
Interested in contributing in a big way? Consider joining our team! We're hiring for many positions. Please take a look at our Careers page to see what opportunities are currently open as well as what it's like to work at Bitwarden.
Prettier
We recently migrated to using Prettier as code formatter. All previous branches will need to updated to avoid large merge conflicts using the following steps:
- Check out your local Branch
- Run
git merge 8b2dfc6cdcb8ff5b604364c2ea6d343473aee7cd - Resolve any merge conflicts, commit.
- Run
npm run prettier - Commit
- Run
git merge -Xours 193434461dbd9c48fe5dcbad95693470aec422ac - Push
Git blame
We also recommend that you configure git to ignore the prettier revision using:
git config blame.ignoreRevsFile .git-blame-ignore-revs